spot-gps 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4cefc691cf3adc7c13929ac4ad0aad2e03657b7e
-  data.tar.gz: 930728e3875f407014521e9f60bdbf3c9305076f
+  metadata.gz: 13e4a0abb43ad3882974975b75c91103d6d0be42
+  data.tar.gz: 164e08de3895f9d0f2dc8b666e6ba769f34941be
 SHA512:
-  metadata.gz: ee497615830b2294640d2752a7d8ca11100ba4f4b0e3fe1eb4d8002610343807fefb3841b3ac799253e28a250aeb5918aa8967149133eed8580714be79336172
-  data.tar.gz: 8f01ed30a2fa1e5c73cd911d36ec558266043396b9f0f21ab1021de1364f444af0b41665a53e0997564b480e16c96ba50a978b9d54240e11bb75c6d6b84314a1
+  metadata.gz: be02344cbfec73c32678b5d16b1829179ee9be435acdf5aa5957e1616152298fd69260f14783089b1b967f6b397af0ef2c528273854fba5d5068e421f049c7ac
+  data.tar.gz: 5c0207c3806fb992c1e7ba0a046442539c906674c886d704d829b4dd2196fa8e82b9b89ea06310dfd378d37ba1065be92ea2f9101a9cc92cf860493903578a0c

data/.gitignore

@@ -1,2 +1,3 @@
 .bundle
 Gemfile.lock
+*.gem

data/.travis.yml

@@ -0,0 +1,14 @@
+language: ruby
+
+matrix:
+  allow_failures:
+    - rvm: jruby
+    - rvm: rbx-2
+
+rvm:
+  - '2.3.1'
+  - jruby
+  - rbx-2
+
+script:
+  - bundle exec rspec spec

data/CHANGELOG.md

@@ -0,0 +1,12 @@
+## v0.0.2, 10 July 2016
+
+- Wrap responses in SPOT::Resources::Message objects, making them easier to work
+  with (allows date/time parsing, etc.).
+- Drop support for all Ruby versions prior to 2.3 (would be easy to
+  re-introduce, but I imagine anyone using this gem is building a new app).
+- Rename Spot::API to Spot::Client
+- Remove logger configuation, and move to Faraday
+
+## v0.0.1, 10 July 2016
+
+- Initial release

data/README.md

@@ -1,6 +1,9 @@
 # SPOT GPS
 
-A thin wrapper for SPOT's [API](http://www.findmespot.com/en/index.php?cid=1700).
+An API client library for SPOT's [API](http://faq.findmespot.com/index.php?action=showEntry&data=69).
+
+[![Gem Version](https://badge.fury.io/rb/spot-gps.svg)](http://badge.fury.io/rb/spot-gps)
+[![Build Status](https://travis-ci.org/greysteil/spot-gps.svg?branch=master)](https://travis-ci.org/greysteil/spot-gps)
 
 ## Installation
 
@@ -16,7 +19,6 @@ There are 3 configuration options:
 
 ```ruby
 SPOT.configure do |config|
-  config.logger = Logger.new(STDOUT)
   config.open_timeout = 30
   config.read_timeout = 80
 end
@@ -24,10 +26,10 @@ end
 
 ## Usage
 
-You can make API calls by using an instance of the `API` class:
+API calls are made using an instance of the `API` class:
 
 ```ruby
-api = SPOT::API.new(feed_id: 'FEED_GIID', feed_password: 'OPTIONAL_PASSWORD')
+api = SPOT::Client.new(feed_id: 'FEED_GIID', feed_password: 'OPTIONAL_PASSWORD')
 ```
 
 ### Resources
@@ -39,8 +41,8 @@ Currently, the SPOT API only supports a single `messages` resource.
 Messages are communications sent from a SPOT device.
 
 ```ruby
-api.applicant.all     # => Returns a (paginated) list of all messages for a feed
-api.applicant.latest  # => Returns the most recent message for a feed
+api.messages.all     # => Returns a (paginated) list of all messages for a feed
+api.messages.latest  # => Returns the most recent message for a feed
 ```
 
 ### Pagination
@@ -50,7 +52,7 @@ the first page of 50 records are fetched. To fetch subsequent pages (each of 50
 records), specify a `page`.
 
 ```ruby
-api.message.all(page: 2)
+api.messages.all(page: 2)
 ```
 
 ### Filtering
@@ -58,12 +60,13 @@ api.message.all(page: 2)
 The SPOT API supports filtering by date.
 
 ```ruby
-api.message.all(start_at: '2014-06-01T00:00:00', end_at: '2015-06-01T00:00:00')
+api.messages.all(start_at: '2014-06-01T00:00:00', end_at: '2015-06-01T00:00:00')
 ```
 
 ### Error Handling
 
-TODO: Currently the gem will just raise RestClient errors.
+TODO: Currently the gem will just raise Faraday errors if anything goes wrong
+with a request.
 
 ## Contributing
 

data/lib/spot-gps/api_response.rb

@@ -0,0 +1,43 @@
+module SPOT
+  class ApiResponse
+    extend Forwardable
+
+    def_delegator :@response, :headers
+    def_delegator :@response, :status
+    def_delegator :@response, :status_code
+
+    def initialize(response)
+      @response = response
+    end
+
+    # Return the body of the API response
+    def body
+      json? ? handle_json : handle_raw
+    end
+
+    # Returns true if the response is JSON
+    def json?
+      content_type = @response.headers[:content_type] || ''
+      content_type.include?('application/json')
+    end
+
+    private
+
+    def raw_body
+      @response.body
+    end
+
+    def handle_json
+      @json_body ||= JSON.parse(@response.body)
+    end
+
+    def handle_raw
+      non_json_msg = "Received non-JSON response:\n\n" \
+        "status: #{@response.status}\n" \
+        "headers: #{@response.headers}\n" \
+        "body: #{@response.body}"
+
+      raise non_json_msg
+    end
+  end
+end

data/lib/spot-gps/api_service.rb

@@ -6,32 +6,40 @@ module SPOT
     def initialize(feed_id:, feed_password: nil)
       @feed_id = feed_id
       @feed_password = feed_password
+
+      connection_options = {
+        request: {
+          timeout: SPOT.read_timeout,
+          open_timeout: SPOT.open_timeout
+        }
+      }
+
+      @connection = Faraday.new(base_uri, connection_options)
     end
 
     # Make a GET request to the SPOT API
     def get(path:, params: {})
+      params ||= {}
       params = params.merge(feedPassword: feed_password) if feed_password
 
-      uri = URI.join(base_uri, path)
-      uri.query = URI.encode_www_form(params) if params.any?
-
-      request_options = {
-        url: uri.to_s,
-        method: :get,
-        headers: headers,
-        open_timeout: SPOT.open_timeout,
-        timeout: SPOT.read_timeout
-      }
-
-      response = RestClient::Request.execute(request_options)
+      response = make_request(:get, path, params)
 
-      JSON.parse(response.body.to_s)
+      SPOT::ApiResponse.new(response)
     end
 
     private
 
     attr_reader :feed_id, :feed_password
 
+    def make_request(method, path, params = {})
+      @connection.send(method.to_sym) do |request|
+        request.url path
+        request.body = @request_body
+        request.params = params
+        request.headers = headers
+      end
+    end
+
     def base_uri
       URI.join(SPOT.endpoint, feed_id + '/')
     end

data/lib/spot-gps/{api.rb → client.rb}

@@ -1,8 +1,10 @@
 module SPOT
-  class API
+  class Client
     attr_reader :feed_id, :feed_password
 
-    def initialize(feed_id:, feed_password: nil)
+    def initialize(feed_id: nil, feed_password: nil)
+      raise ArgumentError, "feed_id is required" unless feed_id
+
       @api_service = ApiService.new(feed_id: feed_id, feed_password: feed_password)
     end
 

data/lib/spot-gps/configuration.rb

@@ -13,19 +13,6 @@ module SPOT
     def reset
       self.open_timeout = 30
       self.read_timeout = 80
-      RestClient.log = nil
-    end
-
-    def logger=(log)
-      if log.respond_to?(:<<)
-        RestClient.log = log
-      else
-        raise "#{log.class} doesn't seem to behave like a logger!"
-      end
-    end
-
-    def logger
-      RestClient.log ||= NullLogger.new
     end
 
     def endpoint

data/lib/spot-gps/list_response.rb

@@ -0,0 +1,20 @@
+module SPOT
+  class ListResponse
+    attr_reader :records
+
+    def initialize(response:, resource_class:, unenveloped_body:)
+      @response = response
+      @resource_class = resource_class
+      @unenveloped_body = unenveloped_body
+
+      # SPOT returns a Hash, rather than an array of hashes, if there is only
+      # a single record.
+      @unenveloped_body = [@unenveloped_body] if @unenveloped_body.is_a?(Hash)
+      @unenveloped_body = [] if @unenveloped_body.nil?
+
+      @records = @unenveloped_body.map do |item|
+        @resource_class.new(item)
+      end
+    end
+  end
+end

data/lib/spot-gps/resources/message.rb

@@ -0,0 +1,46 @@
+module SPOT
+  module Resources
+    class Message
+      attr_reader :id
+      attr_reader :created_at
+      attr_reader :type
+      attr_reader :latitude
+      attr_reader :longitude
+      attr_reader :battery_state
+      attr_reader :hidden
+      attr_reader :show_custom_message
+      attr_reader :content
+      attr_reader :messenger_id
+      attr_reader :messenger_name
+      attr_reader :messenger_model
+
+      def initialize(object, response = nil)
+        @object = object
+
+        @id = object.fetch('id')
+        @created_at = Time.at(object.fetch('unixTime'))
+        @type = object.fetch('messageType')
+        @latitude = object.fetch('latitude')
+        @longitude = object.fetch('longitude')
+        @battery_state = object.fetch('batteryState')
+
+        @hidden = object['hidden'] == 1
+        @show_custom_message = object['showCustomMsg'] == "Y"
+        @content = object['messageContent']
+        @messenger_id = object['messengerId']
+        @messenger_name = object['messengerName']
+        @messenger_model = object['modelId']
+
+        @response = response
+      end
+
+      def response
+        @response
+      end
+
+      def to_h
+        @object
+      end
+    end
+  end
+end

data/lib/spot-gps/services/messages.rb

@@ -7,17 +7,27 @@ module SPOT
         query_params[:startDate] = spot_formatted_time(start_at) if start_at
         query_params[:endDate] = spot_formatted_time(end_at) if end_at
 
-        get(path: "message.json", params: query_params)
+        response = get(path: "message.json", params: query_params)
+
+        SPOT::ListResponse.new(
+          response: response,
+          resource_class: SPOT::Resources::Message,
+          unenveloped_body: unenvelope_body(response.body)
+        )
       end
 
       def latest
-        get(path: "latest.json")
+        response = get(path: "latest.json")
+        Resources::Message.new(unenvelope_body(response.body), response)
       end
 
       private
 
+      def unenvelope_body(body)
+        body.dig("response", "feedMessageResponse", "messages", "message")
+      end
+
       def spot_formatted_time(time)
-        return nil unless time
         time = Time.parse(time) if time.is_a?(String)
         time = time.to_time if time.is_a?(Date) || time.is_a?(DateTime)
 
@@ -25,9 +35,8 @@ module SPOT
       end
 
       def start(page)
-        return nil unless page
         raise ArgumentError, "page must be an integer" unless page.is_a?(Integer)
-        raise ArgumentError, "page must be non-negative" if page < 0
+        raise ArgumentError, "page must be positive" unless page > 0
 
         # SPOT start param is zero-indexed
         (page - 1) * 50

data/lib/spot-gps/version.rb

@@ -1,3 +1,3 @@
 module SPOT
-  VERSION = '0.0.1'.freeze
+  VERSION = '0.0.2'.freeze
 end

data/lib/spot.rb

@@ -1,11 +1,13 @@
 require 'json'
-require 'rest-client'
+require 'faraday'
 
 require 'spot-gps/version'
 require 'spot-gps/configuration'
-require 'spot-gps/null_logger'
-require 'spot-gps/api'
+require 'spot-gps/client'
+require 'spot-gps/api_response'
 require 'spot-gps/api_service'
+require 'spot-gps/list_response'
+require 'spot-gps/resources/message'
 require 'spot-gps/services/base'
 require 'spot-gps/services/messages'
 

data/spec/api_response_spec.rb

@@ -0,0 +1,43 @@
+require 'spec_helper'
+
+describe SPOT::ApiResponse do
+  subject(:response) { described_class.new(raw_response) }
+
+  let(:raw_response) do
+    stub_url = SPOT.endpoint + 'EXAMPLE_ID/message.json'
+    stub_request(:get, /#{Regexp.escape(stub_url)}.*/).to_return(
+      body: load_fixture('message.json'),
+      headers: { 'Content-Type' => 'application/json' }
+    )
+
+    SPOT::ApiService.new(feed_id: 'EXAMPLE_ID').
+      send(:make_request, :get, stub_url)
+  end
+
+  its(:status) { is_expected.to eq(200) }
+
+  describe "#body" do
+    context "when the response is JSON" do
+      it 'returns the body parsed into a hash' do
+        expect(response.body).to be_a(Hash)
+      end
+    end
+
+    context "when the response isn't JSON" do
+      let(:raw_response) do
+        stub_url = SPOT.endpoint + 'EXAMPLE_ID/message.json'
+        stub_request(:get, /#{Regexp.escape(stub_url)}.*/).to_return(
+          body: 'Bad body',
+          headers: { 'Content-Type' => 'application/xml' }
+        )
+
+        SPOT::ApiService.new(feed_id: 'EXAMPLE_ID').
+          send(:make_request, :get, stub_url)
+      end
+
+      it 'raises an error' do
+        expect { response.body }.to raise_error(RuntimeError)
+      end
+    end
+  end
+end

data/spec/api_service_spec.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+
+describe SPOT::ApiService do
+  subject(:service) do
+    described_class.new(feed_id: 'EXAMPLE_ID', feed_password: password)
+  end
+  let(:password) { nil }
+
+  before do
+    allow(SPOT).to receive(:endpoint).and_return('https://example.com/')
+    stub_request(:get, /https:\/\/example\.com/).
+      to_return(body: '{}', status: 200)
+  end
+
+  describe 'making a get request without any parameters' do
+    it 'is expected to make a GET request to the correct URL' do
+      service.get(path: 'messages.json')
+      expect(WebMock).
+        to have_requested(:get, 'https://example.com/EXAMPLE_ID/messages.json').
+        with(query: {})
+    end
+
+    context 'with a password' do
+      let(:password) { 'password' }
+
+      it 'is expected to include the password in the querystring' do
+        service.get(path: 'messages.json')
+        expect(WebMock).
+          to have_requested(:get, 'https://example.com/EXAMPLE_ID/messages.json').
+          with(query: { feedPassword: 'password' })
+      end
+    end
+  end
+
+  describe 'making a get request with parameters' do
+    it 'is expected to make a GET request to the correct URL' do
+      service.get(path: 'messages.json', params: { example: 'param' })
+      expect(WebMock).
+        to have_requested(:get, 'https://example.com/EXAMPLE_ID/messages.json').
+        with(query: { example: 'param' })
+    end
+
+    context 'with a password' do
+      let(:password) { 'password' }
+
+      it 'is expected to include the password in the querystring' do
+        service.get(path: 'messages.json', params: { example: 'param' })
+        expect(WebMock).
+          to have_requested(:get, 'https://example.com/EXAMPLE_ID/messages.json').
+          with(query: { feedPassword: 'password', example: 'param' })
+      end
+    end
+  end
+end

data/spec/api_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+describe SPOT::Client do
+  subject(:api) { described_class.new(options) }
+  let(:options) { { feed_id: feed_id, feed_password: password } }
+  let(:feed_id) { "EXAMPLE_ID" }
+  let(:password) { nil }
+
+  describe ".new" do
+    subject { -> { described_class.new(options) } }
+
+    context 'when initialised without a feed ID' do
+      let(:feed_id) { nil }
+      it { is_expected.to raise_error('feed_id is required') }
+    end
+
+    context 'when initialised without a password' do
+      let(:password) { nil }
+      it { is_expected.to_not raise_error }
+    end
+  end
+
+  describe "#messages" do
+    subject { api.messages }
+
+    it { is_expected.to be_an_instance_of(SPOT::Services::Messages) }
+  end
+end

data/spec/fixtures/latest.json

@@ -0,0 +1,36 @@
+{
+    "response": {
+        "feedMessageResponse": {
+            "count": 1,
+            "feed": {
+                "id": "FEED_ID",
+                "name": "Testing",
+                "description": "Testing",
+                "status": "ACTIVE",
+                "usage": 0,
+                "daysRange": 7,
+                "detailedMessageShown": true
+            },
+            "totalCount": 1,
+            "activityCount": 0,
+            "messages": {
+                "message": {
+                    "@clientUnixTime": "0",
+                    "id": 585079373,
+                    "messengerId": "0-1234567",
+                    "messengerName": "My SPOT",
+                    "unixTime": 1468164566,
+                    "messageType": "OK",
+                    "latitude": 61.54875,
+                    "longitude": -3.0697,
+                    "modelId": "SPOT3",
+                    "showCustomMsg": "Y",
+                    "dateTime": "2016-07-10T15:29:26+0000",
+                    "batteryState": "GOOD",
+                    "hidden": 0,
+                    "messageContent": "This is the default SPOT Check In/OK message. Please update."
+                }
+            }
+        }
+    }
+}

data/spec/fixtures/message.json

@@ -0,0 +1,54 @@
+{
+    "response": {
+        "feedMessageResponse": {
+            "count": 2,
+            "feed": {
+                "id": "1HXUWlonx0AInTM7LAnBoAFEBQ9GWLJ5e",
+                "name": "Testing",
+                "description": "Testing",
+                "status": "ACTIVE",
+                "usage": 0,
+                "daysRange": 7,
+                "detailedMessageShown": true
+            },
+            "totalCount": 2,
+            "activityCount": 0,
+            "messages": {
+                "message": [
+                    {
+                        "@clientUnixTime": "0",
+                        "id": 585079373,
+                        "messengerId": "0-2855693",
+                        "messengerName": "Grey's SPOT",
+                        "unixTime": 1468164566,
+                        "messageType": "OK",
+                        "latitude": 51.54875,
+                        "longitude": -0.0697,
+                        "modelId": "SPOT3",
+                        "showCustomMsg": "Y",
+                        "dateTime": "2016-07-10T15:29:26+0000",
+                        "batteryState": "GOOD",
+                        "hidden": 0,
+                        "messageContent": "This is the default SPOT Check In/OK message. Please update."
+                    },
+                    {
+                        "@clientUnixTime": "0",
+                        "id": 584982167,
+                        "messengerId": "0-2855693",
+                        "messengerName": "Grey's SPOT",
+                        "unixTime": 1468149143,
+                        "messageType": "OK",
+                        "latitude": 51.5489,
+                        "longitude": -0.06988,
+                        "modelId": "SPOT3",
+                        "showCustomMsg": "Y",
+                        "dateTime": "2016-07-10T11:12:23+0000",
+                        "batteryState": "GOOD",
+                        "hidden": 0,
+                        "messageContent": "This is the default SPOT Check In/OK message. Please update."
+                    }
+                ]
+            }
+        }
+    }
+}

data/spec/fixtures/no_messages.json

@@ -0,0 +1,11 @@
+{
+    "response": {
+        "errors": {
+            "error": {
+                "code": "E-0195",
+                "text": "No Messages to display",
+                "description": "No displayable messages found found for feed: 1HXUWlonx0AInTM7LAnBoAFEBQ9GWLJ5e"
+            }
+        }
+    }
+}

data/spec/resources/message_spec.rb

@@ -0,0 +1,52 @@
+require 'spec_helper'
+
+describe SPOT::Resources::Message do
+  describe 'initialising' do
+    let(:data) do
+      {
+        '@clientUnixTime' => '0',
+        'id' => 585079373,
+        'messengerId' => '0-1234567',
+        'messengerName' => 'My SPOT',
+        'unixTime' => 1468164566,
+        'messageType' => 'OK',
+        'latitude' => 61.54875,
+        'longitude' => -3.0697,
+        'modelId' => 'SPOT3',
+        'showCustomMsg' => 'Y',
+        'dateTime' => '2016-07-10T15:29:26+0000',
+        'batteryState' => 'GOOD',
+        'hidden' => 0,
+        'messageContent' => 'Example SPOT message.'
+      }
+    end
+
+    it 'can be initialized from an unenveloped response' do
+      resource = described_class.new(data)
+
+      expect(resource.id).to eq(585079373)
+      expect(resource.created_at).to eq(Time.at(1468164566))
+      expect(resource.type).to eq('OK')
+      expect(resource.latitude).to eq(61.54875)
+      expect(resource.longitude).to eq(-3.0697)
+      expect(resource.battery_state).to eq('GOOD')
+      expect(resource.hidden).to eq(false)
+      expect(resource.show_custom_message).to eq(true)
+      expect(resource.content).to eq('Example SPOT message.')
+      expect(resource.messenger_id).to eq('0-1234567')
+      expect(resource.messenger_name).to eq('My SPOT')
+      expect(resource.messenger_model).to eq('SPOT3')
+    end
+
+    it 'can handle new attributes without erroring' do
+      data['foo'] = 'bar'
+      expect { described_class.new(data) }.to_not raise_error
+    end
+
+    describe '#to_h' do
+      it 'returns a hash representing the resource' do
+        expect(described_class.new(data).to_h).to eq(data)
+      end
+    end
+  end
+end

data/spec/services/messages_spec.rb

@@ -0,0 +1,172 @@
+require 'spec_helper'
+
+describe SPOT::Services::Messages do
+  let(:messages) { SPOT::Client.new(feed_id: 'EXAMPLE_ID').messages }
+
+  describe "#all" do
+    subject(:all) { messages.all(args) }
+
+    before do
+      stub_url = SPOT.endpoint + 'EXAMPLE_ID/message.json'
+      stub_request(:get, /#{Regexp.escape(stub_url)}.*/).to_return(
+        body: load_fixture('message.json'),
+        headers: { 'Content-Type' => 'application/json' }
+      )
+    end
+
+
+    context "without any arguments" do
+      let(:args) { {} }
+
+      it "makes a request without any querystring params" do
+        expect_any_instance_of(SPOT::ApiService).
+          to receive(:get).
+          with(path: 'message.json', params: {}).
+          and_call_original
+
+        messages.all
+      end
+
+      it { is_expected.to be_a(SPOT::ListResponse) }
+      its("records.first") { is_expected.to be_a(SPOT::Resources::Message) }
+
+      context "when there are no displayable messages" do
+        before do
+          stub_url = SPOT.endpoint + 'EXAMPLE_ID/message.json'
+          stub_request(:get, /#{Regexp.escape(stub_url)}.*/).to_return(
+            body: load_fixture('no_messages.json'),
+            headers: { 'Content-Type' => 'application/json' }
+          )
+        end
+
+        it { is_expected.to be_a(SPOT::ListResponse) }
+        its(:records) { is_expected.to eq([]) }
+      end
+    end
+
+    context "with a page parameter" do
+      context "that is invalid" do
+        let(:args) { { page: "invalid" } }
+        specify { expect { all }.to raise_error(ArgumentError) }
+      end
+
+      context "that is zero" do
+        let(:args) { { page: 0 } }
+        specify { expect { all }.to raise_error(ArgumentError) }
+      end
+
+      context "that is greater than zero" do
+        let(:args) { { page: 1 } }
+
+        it "makes a request with a start param" do
+          expect_any_instance_of(SPOT::ApiService).
+            to receive(:get).
+            with(path: 'message.json', params: { start: 0 }).
+            and_call_original
+
+          all
+        end
+
+        context "and greater than 1" do
+          let(:args) { { page: 2 } }
+
+          it "increases the start param by multiples of 50" do
+            expect_any_instance_of(SPOT::ApiService).
+              to receive(:get).
+              with(path: 'message.json', params: { start: 50 }).
+              and_call_original
+
+            all
+          end
+        end
+      end
+    end
+
+    context "with a start_at or end_at parameter" do
+      context "that is invalid" do
+        let(:args) { { start_at: "invalid" } }
+        specify { expect { all }.to raise_error(ArgumentError) }
+      end
+
+      context "that is a valid string" do
+        let(:args) { { start_at: "2016-01-01", end_at: "2016-02-01" } }
+
+        it "makes a request with a startDate param" do
+          expect_any_instance_of(SPOT::ApiService).
+            to receive(:get).
+            with(path: 'message.json',
+                 params: { startDate: '2016-01-01T00:00:00-0000',
+                           endDate: '2016-02-01T00:00:00-0000' }).
+            and_call_original
+
+          all
+        end
+      end
+
+      context "that is a Date" do
+        let(:args) { { start_at: Date.parse('2016-01-01') } }
+
+        it "makes a request with a startDate param" do
+          expect_any_instance_of(SPOT::ApiService).
+            to receive(:get).
+            with(path: 'message.json',
+                 params: { startDate: '2016-01-01T00:00:00-0000' }).
+            and_call_original
+
+          all
+        end
+      end
+
+      context "that is a DateTime" do
+        let(:args) { { start_at: DateTime.parse('2016-01-01') } }
+
+        it "makes a request with a startDate param" do
+          expect_any_instance_of(SPOT::ApiService).
+            to receive(:get).
+            with(path: 'message.json',
+                 params: { startDate: '2016-01-01T00:00:00-0000' }).
+            and_call_original
+
+          all
+        end
+      end
+
+      context "that is a Time" do
+        let(:args) { { start_at: Time.parse('2016-01-01') } }
+
+        it "makes a request with a startDate param" do
+          expect_any_instance_of(SPOT::ApiService).
+            to receive(:get).
+            with(path: 'message.json',
+                 params: { startDate: '2016-01-01T00:00:00-0000' }).
+            and_call_original
+
+          all
+        end
+      end
+    end
+  end
+
+  describe "#latest" do
+    before do
+      stub_url = SPOT.endpoint + 'EXAMPLE_ID/latest.json'
+      stub_request(:get, stub_url).to_return(
+        body: load_fixture('latest.json'),
+        headers: { 'Content-Type' => 'application/json' }
+      )
+    end
+
+    it "makes a request for the `latest.json` path, without params" do
+      expect_any_instance_of(SPOT::ApiService).
+        to receive(:get).
+        with(path: 'latest.json').
+        and_call_original
+
+      messages.latest
+    end
+
+    it 'wraps the response in a resource' do
+      expect(messages.latest).to be_a(SPOT::Resources::Message)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,18 @@
+require 'spot'
+require 'rspec/its'
+require 'webmock/rspec'
+
+WebMock.disable_net_connect!
+
+RSpec.configure do |config|
+  config.mock_with(:rspec) { |mocks| mocks.verify_partial_doubles = true }
+  config.raise_errors_for_deprecations!
+end
+
+def fixture_path(filename)
+  File.join(File.dirname(__FILE__), "fixtures", filename)
+end
+
+def load_fixture(filename)
+  File.read(fixture_path(filename))
+end

data/spot-gps.gemspec

@@ -18,13 +18,9 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.7'
-  spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'webmock', '~> 1.22'
-  spec.add_development_dependency 'rubocop', '~> 0.37.0'
-  spec.add_development_dependency 'rspec', '~> 3.1'
-  spec.add_development_dependency 'rspec-its', '~> 1.2'
-  spec.add_development_dependency 'sinatra', '~> 1.4'
+  spec.add_development_dependency 'rspec', '~> 3.5'
+  spec.add_development_dependency 'rspec-its'
 
-  spec.add_dependency 'rest-client', '~> 1.8.0'
+  spec.add_dependency 'faraday', ['>= 0.8.9', '< 0.10']
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spot-gps
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Grey Baker
@@ -10,34 +10,6 @@ bindir: bin
 cert_chain: []
 date: 2016-07-10 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.7'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.7'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -52,76 +24,54 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.22'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.37.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.37.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.5'
 - !ruby/object:Gem::Dependency
   name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: sinatra
+  name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.4'
-- !ruby/object:Gem::Dependency
-  name: rest-client
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
+        version: 0.8.9
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: '0.10'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.8.9
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: '0.10'
 description: A wrapper for the SPOT API
 email:
 - greysteil@gmail.com
@@ -130,16 +80,29 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - README.md
-- lib/spot-gps/api.rb
+- lib/spot-gps/api_response.rb
 - lib/spot-gps/api_service.rb
+- lib/spot-gps/client.rb
 - lib/spot-gps/configuration.rb
-- lib/spot-gps/null_logger.rb
+- lib/spot-gps/list_response.rb
+- lib/spot-gps/resources/message.rb
 - lib/spot-gps/services/base.rb
 - lib/spot-gps/services/messages.rb
 - lib/spot-gps/version.rb
 - lib/spot.rb
+- spec/api_response_spec.rb
+- spec/api_service_spec.rb
+- spec/api_spec.rb
+- spec/fixtures/latest.json
+- spec/fixtures/message.json
+- spec/fixtures/no_messages.json
+- spec/resources/message_spec.rb
+- spec/services/messages_spec.rb
+- spec/spec_helper.rb
 - spot-gps.gemspec
 homepage: http://github.com/greysteil/spot-gps
 licenses:
@@ -165,4 +128,13 @@ rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: A wrapper for the SPOT API
-test_files: []
+test_files:
+- spec/api_response_spec.rb
+- spec/api_service_spec.rb
+- spec/api_spec.rb
+- spec/fixtures/latest.json
+- spec/fixtures/message.json
+- spec/fixtures/no_messages.json
+- spec/resources/message_spec.rb
+- spec/services/messages_spec.rb
+- spec/spec_helper.rb

data/lib/spot-gps/null_logger.rb

@@ -1,6 +0,0 @@
-module SPOT
-  class NullLogger
-    def <<(*args)
-    end
-  end
-end