sports-odds-api 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ed23b744aefd6897f1ffe2c1b8b6ec7d2017a5c38f9f61407e9036a64c4b539c
-  data.tar.gz: 330d785ea83722954b4a1861bce87df552f61bf5640cd43d28a19b24ce39699b
+  metadata.gz: 0b2d3224b7a512959a77bc026bb7db55363c95d3f3b1ff6b595b3de3da3582fe
+  data.tar.gz: 984de9885de8b49aa3f1abffd1e1eef409db256dd171c6d9dde16cc60fa8cab2
 SHA512:
-  metadata.gz: a294de700247d92d72620d6ecd464313dc711d36bcccba1c848dbe1ce8a7da399559a4dcb59bfe3fcaf70982c6a86423af8d45ef3cb6bc0fbcf02bdedc20337b
-  data.tar.gz: b482d8805041a5b6d2efd02090c05f598b3b998619ba553502633be7406285304e8608f88f4c6d548b0b27d7c2a8c333639638d9faf8770757eb44fc21be5e2d
+  metadata.gz: 14bf0836a12cc6de42b06f89cd54ca7b5a9fcc13673f7da6e0a8f28f6426e76742e4e8598be9ec9712d3a5a770df0d63f190d1d2ef9435b8c66de2c3d3b3e768
+  data.tar.gz: 3d89ccf0592090be52aeb320ba0cd7a29b67d685950c8bbf6efc49aa5319354cbce9cac394802d8c9f5eb3e342f04eee1314a01d657ece0f339668429f0ec618

data/CHANGELOG.md

@@ -1,5 +1,22 @@
 # Changelog
 
+## 1.0.1 (2025-10-01)
+
+Full Changelog: [v1.0.0...v1.0.1](https://github.com/SportsGameOdds/sports-odds-api-ruby/compare/v1.0.0...v1.0.1)
+
+### Bug Fixes
+
+* always send `filename=...` for multipart requests where a file is expected ([28e1cb8](https://github.com/SportsGameOdds/sports-odds-api-ruby/commit/28e1cb8e5af175c4c0afa49da5596c939dcd9758))
+* coroutine leaks from connection pool ([6c9b16e](https://github.com/SportsGameOdds/sports-odds-api-ruby/commit/6c9b16e9c830d664af77e6a25bf3110b32e60091))
+* shorten multipart boundary sep to less than RFC specificed max length ([cda53c9](https://github.com/SportsGameOdds/sports-odds-api-ruby/commit/cda53c9aa624162299230dccbd47838f3e6e4e30))
+
+
+### Chores
+
+* allow fast-format to use bsd sed as well ([de4c0f0](https://github.com/SportsGameOdds/sports-odds-api-ruby/commit/de4c0f0a2e46a2f8c1e04540a31ac7a17202d467))
+* **internal:** codegen related update ([8101617](https://github.com/SportsGameOdds/sports-odds-api-ruby/commit/81016173ee5cadb07e1ea09785adbc79fa8ccf5b))
+* **internal:** codegen related update ([b1186c6](https://github.com/SportsGameOdds/sports-odds-api-ruby/commit/b1186c6bee86fe8b82456612407a78f33c6a655e))
+
 ## 1.0.0 (2025-09-23)
 
 Full Changelog: [v0.0.1...v1.0.0](https://github.com/SportsGameOdds/sports-odds-api-ruby/compare/v0.0.1...v1.0.0)

data/README.md

@@ -26,7 +26,7 @@ The REST API documentation can be found on [sportsgameodds.com](https://sportsga
 Add to your application's `Gemfile`:
 
 ```ruby
-gem "sports-odds-api", "~> 1.0.0"
+gem "sports-odds-api", "~> 1.0.1"
 ```
 
 Or install manually:

data/lib/sports_odds_api/file_part.rb

@@ -38,18 +38,21 @@ module SportsOddsAPI
     def to_yaml(*a) = read.to_yaml(*a)
 
     # @param content [Pathname, StringIO, IO, String]
-    # @param filename [String, nil]
+    # @param filename [Pathname, String, nil]
     # @param content_type [String, nil]
     def initialize(content, filename: nil, content_type: nil)
-      @content = content
+      @content_type = content_type
       @filename =
-        case content
-        in Pathname
-          filename.nil? ? content.basename.to_path : ::File.basename(filename)
+        case [filename, (@content = content)]
+        in [String | Pathname, _]
+          ::File.basename(filename)
+        in [nil, Pathname]
+          content.basename.to_path
+        in [nil, IO]
+          content.to_path
         else
-          filename.nil? ? nil : ::File.basename(filename)
+          filename
         end
-      @content_type = content_type
     end
   end
 end

data/lib/sports_odds_api/internal/transport/pooled_net_requester.rb

@@ -134,9 +134,9 @@ module SportsOddsAPI
 
           # rubocop:disable Metrics/BlockLength
           enum = Enumerator.new do |y|
-            with_pool(url, deadline: deadline) do |conn|
-              next if finished
+            next if finished
 
+            with_pool(url, deadline: deadline) do |conn|
               req, closing = self.class.build_request(request) do
                 self.class.calibrate_socket_timeout(conn, deadline)
               end
@@ -149,7 +149,7 @@ module SportsOddsAPI
 
               self.class.calibrate_socket_timeout(conn, deadline)
               conn.request(req) do |rsp|
-                y << [conn, req, rsp]
+                y << [req, rsp]
                 break if finished
 
                 rsp.read_body do |bytes|
@@ -160,6 +160,8 @@ module SportsOddsAPI
                 end
                 eof = true
               end
+            ensure
+              conn.finish if !eof && conn&.started?
             end
           rescue Timeout::Error
             raise SportsOddsAPI::Errors::APITimeoutError.new(url: url, request: req)
@@ -168,16 +170,11 @@ module SportsOddsAPI
           end
           # rubocop:enable Metrics/BlockLength
 
-          conn, _, response = enum.next
+          _, response = enum.next
           body = SportsOddsAPI::Internal::Util.fused_enum(enum, external: true) do
             finished = true
-            tap do
-              enum.next
-            rescue StopIteration
-              nil
-            end
+            loop { enum.next }
           ensure
-            conn.finish if !eof && conn&.started?
             closing&.call
           end
           [Integer(response.code), response, body]

data/lib/sports_odds_api/internal/type/file_input.rb

@@ -82,17 +82,20 @@ module SportsOddsAPI
           #
           # @return [Pathname, StringIO, IO, String, Object]
           def dump(value, state:)
-            # rubocop:disable Lint/DuplicateBranch
             case value
+            in StringIO | String
+              # https://datatracker.ietf.org/doc/html/rfc7578#section-4.2
+              # while not required, a filename is recommended, and in practice many servers do expect this
+              SportsOddsAPI::FilePart.new(value, filename: "upload")
             in IO
               state[:can_retry] = false
+              value.to_path.nil? ? SportsOddsAPI::FilePart.new(value, filename: "upload") : value
             in SportsOddsAPI::FilePart if value.content.is_a?(IO)
               state[:can_retry] = false
+              value
             else
+              value
             end
-            # rubocop:enable Lint/DuplicateBranch
-
-            value
           end
 
           # @api private

data/lib/sports_odds_api/internal/util.rb

@@ -566,7 +566,8 @@ module SportsOddsAPI
         #
         # @return [Array(String, Enumerable<String>)]
         private def encode_multipart_streaming(body)
-          boundary = SecureRandom.urlsafe_base64(60)
+          # RFC 1521 Section 7.2.1 says we should have 70 char maximum for boundary length
+          boundary = SecureRandom.urlsafe_base64(46)
 
           closing = []
           strio = writable_enum do |y|

data/lib/sports_odds_api/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SportsOddsAPI
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/rbi/sports_odds_api/file_part.rbi

@@ -27,7 +27,7 @@ module SportsOddsAPI
     sig do
       params(
         content: T.any(Pathname, StringIO, IO, String),
-        filename: T.nilable(String),
+        filename: T.nilable(T.any(Pathname, String)),
         content_type: T.nilable(String)
       ).returns(T.attached_class)
     end

data/sig/sports_odds_api/file_part.rbs

@@ -14,7 +14,7 @@ module SportsOddsAPI
 
     def initialize: (
       Pathname | StringIO | IO | String content,
-      ?filename: String?,
+      ?filename: (Pathname | String)?,
       ?content_type: String?
     ) -> void
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sports-odds-api
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Sports Game Odds
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-09-23 00:00:00.000000000 Z
+date: 2025-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: connection_pool