sportdb-formats 1.0.5 → 1.1.3

data/lib/sportdb/formats/structs/team.rb

@@ -11,10 +11,9 @@ class Team
   ##  todo: use just names for alt_names - why? why not?
   attr_accessor :key, :name, :alt_names,
                 :code,    ## code == abbreviation e.g. ARS etc.
-                :year, :year_end,   ## todo/fix: change year_end to end_year (like in season)!!!
+                :year, :year_end,   ## todo/fix: change year to start_year and year_end to end_year (like in season)!!!
                 :country
 
-  alias_method :title, :name  ## add alias/compat - why? why not
 
   def names
     ## todo/check: add alt_names_auto too? - why? why not?
@@ -66,6 +65,13 @@ class Team
   end
 
 
+  ## add convenience lookup helper / method for name by season for now
+  ##   use clubs history - for now kept separate from struct - why? why not?
+  def name_by_season( season )
+    ## note: returns / fallback to "regular" name if no records found in history
+    SportDb::Import.catalog.clubs_history.find_name_by( name: name, season: season ) || name
+  end
+
   ## helper methods for import only
   ## check for duplicates
   include NameHelper

data/lib/sportdb/formats/team/club_index.rb

@@ -54,6 +54,7 @@ class ClubIndex
   ##       normalize( name )
 
   def strip_wiki( name )     # todo/check: rename to strip_wikipedia_en - why? why not?
+    ##  change/rename to strip_wiki_qualifier or such - why? why not?
     ## note: strip disambiguationn qualifier from wikipedia page name if present
     ##        note: only remove year and foot... for now
     ## e.g. FC Wacker Innsbruck (2002) => FC Wacker Innsbruck
@@ -178,22 +179,24 @@ class ClubIndex
   ## todo/fix/check: use rename to find_canon  or find_canonical() or something??
   ##  remove (getting used?) - why? why not?
   def []( name )    ## lookup by canoncial name only;  todo/fix: add find alias why? why not?
+    puts "WARN!! do not use ClubIndex#[] for lookup >#{name}< - will get removed!!!"
     @clubs[ name ]
   end
 
 
-  ## todo/fix/check: return empty array if no match!!!
-  ##     and NOT nil (add || []) - why? why not?
   def match( name )
+    # note: returns empty array (e.g. []) if no match and NOT nil
     name = normalize( name )
-    m = @clubs_by_name[ name ]
+    m = @clubs_by_name[ name ] || []
 
     ## no match - retry with unaccented variant if different
     ##    e.g. example is Preussen Münster  (with mixed accent and unaccented letters) that would go unmatched for now
     ##      Preussen Münster => preussenmünster (norm) => preussenmunster (norm+unaccent)
-    if m.nil?
+    if m.empty?
       name2 = unaccent( name )
-      m = @clubs_by_name[ name2 ]    if name2 != name
+      if name2 != name
+        m = @clubs_by_name[ name2 ] || []
+      end
     end
     m
   end
@@ -227,10 +230,8 @@ class ClubIndex
       country = country( country )
 
       ## note: match must for now always  include name
-      if m    ## filter by country
-        m = m.select { |club| club.country.key == country.key }
-        m = nil   if m.empty?     ## note: reset to nil if no more matches
-      end
+      ## filter by country
+      m = m.select { |club| club.country.key == country.key }
     end
     m
   end
@@ -263,7 +264,7 @@ class ClubIndex
 
       m = match_by( name: name, country: country )
 
-      if m.nil?
+      if m.empty?
         ## (re)try with second country - quick hacks for known leagues
         ##  todo/fix: add league flag to activate!!!  - why? why not
         m = match_by( name: name, country: 'wal' )  if country.key == 'eng'
@@ -272,6 +273,7 @@ class ClubIndex
         m = match_by( name: name, country: 'mc' )   if country.key == 'fr'
         m = match_by( name: name, country: 'li' )   if country.key == 'ch'
         m = match_by( name: name, country: 'ca' )   if country.key == 'us'
+        m = match_by( name: name, country: 'nz' )   if country.key == 'au'
       end
     else  ## try "global" search - no country passed in
       m = match( name )
@@ -279,7 +281,7 @@ class ClubIndex
 
 
     club = nil
-    if m.nil?
+    if m.empty?
       ## puts "** !!! WARN !!! no match for club >#{name}<"
     elsif m.size > 1
       puts "** !!! ERROR - too many matches (#{m.size}) for club >#{name}<:"

data/lib/sportdb/formats/team/club_index_history.rb

@@ -0,0 +1,138 @@
+# encoding: utf-8
+
+module SportDb
+  module Import
+
+
+class ClubHistoryIndex
+
+  def self.build( path )
+    pack = Package.new( path )   ## lets us use direcotry or zip archive
+
+    recs = []
+    pack.each_clubs_history do |entry|
+      recs += ClubHistoryReader.parse( entry.read )
+    end
+    recs
+
+    index = new
+    index.add( recs )
+    index
+  end
+
+
+
+  def catalog() Import.catalog; end
+
+  ## note: keep name history for now separate from
+  ##          from club struct - why? why not?
+  ##       later yes, yes, yes, merge name history into club struct!!!!!
+  ##
+  ## for now the name history is experimental
+
+
+  def initialize
+    @clubs          = {}   ## clubs (indexed) by canonical name
+    @errors         = []
+  end
+
+  attr_reader :errors
+  def errors?() @errors.empty? == false; end
+
+  def mappings() @clubs; end   ## todo/check: rename to records or histories or something - why? why not?
+
+
+  def add_history( club_rec, keyword, season, args )
+    ## note use season obj for now (and NOT key) - why? why not?
+    rec = @clubs[ club_rec.name ] ||= []
+
+    rec << [season, [keyword, args]]
+
+    ## note: always keep records sorted by season_key for now
+    ##   check if 2010 and 2010/11 is in order using alpha sort?? (see argentina)
+    rec.sort! { |l,r| r[0] <=> l[0] }
+  end
+
+
+  def add( rec_or_recs )   ## add club record / alt_names
+    recs = rec_or_recs.is_a?( Array ) ? rec_or_recs : [rec_or_recs]      ## wrap (single) rec in array
+
+    recs.each do |rec|
+
+      keyword    = rec[0]
+      season_key = rec[1]
+      args       = rec[2..-1]   ## get rest of args e.g. one, two or more
+
+      ## note: for now only add (re)name history season records,
+      ##          that is, skip MERGE and BANKRUPT for now
+      ##           and incl. only RENAME, REFORM, MOVE for now
+      next if ['MERGE', 'BANKRUPT'].include?( keyword )
+
+
+      name_old = strip_geo( args[0][0] )  ## note: strip optional geo part from name
+      name_new = strip_geo( args[1][0] )
+
+      country_old = args[0][1]
+      country_new = args[1][1]
+
+      club_old = catalog.clubs.find_by!( name: name_old, country: country_old )
+      club_new = catalog.clubs.find_by!( name: name_new, country: country_new )
+
+      ## note use season obj for now (and NOT key) - why? why not?
+      season = Season.new( season_key )
+
+      ## todo/check:
+      ##   check if  club_old and club_new reference different club record!!
+      ##    examples - RB II            -> Liefering ??  or
+      ##               FC Pasching      -> OOE Juniors ??
+      ##               Austria Salzburg -> RB Salburg ??
+      ##   for now always add name history to both - why? why not?
+
+      add_history( club_old, keyword, season, args )
+      ## note: allow for now different club references
+      ##    but maybe warn later - why? why not?
+      ## add history to both for now
+      add_history( club_new, keyword, season, args )  if club_old != club_new
+    end # each rec
+  end # method add
+
+
+  #### todo/check: move as method to club struct later - to always use club reference
+  ##  returns (simply) name as string for now or nil - why? why not?
+  #
+  #  history entry example
+  # Arsenal FC"=>
+  # [[1927/28, ["RENAME", [["The Arsenal FC, London", "eng"], ["Arsenal FC", "eng"]]]],
+  #  [1914/15, ["RENAME", [["Woolwich Arsenal FC, London", "eng"], ["The Arsenal FC", "eng"]]]],
+  #  [1892/93, ["RENAME", [["Royal Arsenal FC, London", "eng"], ["Woolwich Arsenal FC", "eng"]]]]],
+  def find_name_by( name:, season: )
+    recs = @clubs[ name ]
+    if recs
+      season = season( season )   ## make sure season is a season obj (and NOT a string)
+      ## check season records for name; use linear search (assume only few records)
+      recs.each do |rec|
+        if season >= rec[0]
+           return strip_geo( rec[1][1][1][0] )  # use second arg
+        end
+      end
+      ## if we get here use last name
+      strip_geo( recs[-1][1][1][0][0] )   # use first arg
+    else
+      nil
+    end
+  end
+
+  ##################
+  ## helpers
+  def season( season )
+    season.is_a?( Season ) ? season : Season.new( season )
+  end
+
+  def strip_geo( name )
+    ## e.g. Arsenal, London   =>   Arsenal
+    name.split(',')[0].strip
+  end
+end # class ClubHistoryIndex
+
+end   # module Import
+end   # module SportDb

data/lib/sportdb/formats/team/club_reader_history.rb

@@ -0,0 +1,203 @@
+# encoding: utf-8
+
+
+module SportDb
+module Import
+
+
+class ClubHistoryReader
+
+  def catalog() Import.catalog; end
+
+
+
+def self.read( path )   ## use - rename to read_file or from_file etc. - why? why not?
+  txt = File.open( path, 'r:utf-8' ) { |f| f.read }
+  parse( txt )
+end
+
+def self.parse( txt )
+  new( txt ).parse
+end
+
+def initialize( txt )
+  @txt = txt
+end
+
+
+###
+## RENAME/RENAMED
+## MOVE/MOVED
+## BANKRUPT/BANKRUPTED
+## REFORM/REFORMED
+## MERGE/MERGED    - allow + or ++ or +++ or ; for "inline" - why? why not?
+
+
+KEYWORD_LINE_RE = %r{ ^(?<keyword>RENAMED?|
+                               MOVED?|
+                               BANKRUPT(?:ED)?|
+                               REFORM(?:ED)?|
+                               MERGED?
+                    )
+                      [ ]+
+                     (?<text>.*)    # rest of text
+                    $
+                  }x
+
+
+def parse
+  recs = []
+  last_rec  = nil
+
+  last_country = nil
+  last_season  = nil
+  last_keyword = nil
+  last_teams   = []
+
+  OutlineReader.parse( @txt ).each do |node|
+    if [:h1,:h2,:h3,:h4,:h5,:h6].include?( node[0] )
+      heading_level  = node[0][1].to_i
+      heading        = node[1]
+
+      puts "heading #{heading_level} >#{heading}<"
+
+
+        if heading_level == 1
+            ## assume country in heading; allow all "formats" supported by parse e.g.
+            ##   Österreich • Austria (at)
+            ##   Österreich • Austria
+            ##   Austria
+            ##   Deutschland (de) • Germany
+            country = catalog.countries.parse( heading )
+            ## check country code - MUST exist for now!!!!
+            if country.nil?
+              puts "!!! error [club history reader] - unknown country >#{heading}< - sorry - add country to config to fix"
+              exit 1
+            end
+            puts "  country >#{heading}< => #{country.name}, #{country.key}"
+            last_country = country
+            last_season  = nil  ## reset "lower levels" - season & keyword
+            last_keyword = nil
+         elsif heading_level == 2
+            ## assume season
+            season = Season.new( heading )
+            puts "  season >#{heading}< => #{season.key}"
+            last_season  = season  ## reset "lowwer levels" - keyword
+            last_keyword = nil
+         else
+            puts "!!! ERROR [club history reader] - for now only heading 1 & 2 supported; sorry"
+            exit 1
+         end
+
+    elsif node[0] == :p   ## paragraph with (text) lines
+      if last_country.nil?
+        puts "!!! ERROR [club history reader] - country heading 1 required, sorry"
+        exit 1
+      end
+      if last_season.nil?
+        puts "!!! ERROR [club history reader] - season heading 2 required, sorry"
+        exit 1
+      end
+
+      lines = node[1]
+      lines.each do |line|
+        if m=line.match(KEYWORD_LINE_RE)   ## extract keyword and continue
+          keyword = m[:keyword]
+          line    = m[:text].strip
+
+          puts "    keyword #{keyword}"
+          last_keyword = case keyword   ## "normalize" keywords
+                         when 'BANKRUPT', 'BANKRUPTED'
+                           'BANKRUPT'
+                         when 'RENAME', 'RENAMED'
+                           'RENAME'
+                         when 'REFORM', 'REFORMED'
+                           'REFORM'
+                         when 'MOVE',   'MOVED'
+                           'MOVE'
+                         when 'MERGE',  'MERGED'
+                           'MERGE'
+                         else
+                           puts "!!! ERROR [club history reader] - unexpected keyword >#{keyword}<; sorry - don't know how to normalize"
+                           exit 1
+                         end
+
+          last_teams   = []
+        end
+
+        if last_keyword.nil?
+          puts "!!! ERROR [club history reader] - line with keyword expected - got:"
+          puts line
+          exit 1
+        end
+
+        if    last_keyword == 'BANKRUPT'
+           ## requires / expects one team in one line
+           recs << [ last_keyword, last_season.key,
+                     [ squish(line), last_country.key ]
+                   ]
+        elsif last_keyword == 'RENAME' ||
+              last_keyword == 'REFORM' ||
+              last_keyword == 'MOVE'
+           ## requires / expects two teams in one line (separated by ⇒ or such)
+           teams = line.split( '⇒' )
+           if teams.size != 2
+            puts "!!! ERROR [club history reader] - expected two teams - got:"
+            pp teams
+            exit 1
+           end
+           teams = teams.map {|team| squish(team.strip) }  ## remove whitespaces
+           recs << [ last_keyword, last_season.key,
+                     [ teams[0], last_country.key ],
+                     [ teams[1], last_country.key ]
+                   ]
+        elsif last_keyword == 'MERGE'
+            ## check if line starts with separator
+            ## otherwise collect to be merged teams
+            if line.start_with?( '⇒' )
+              if last_teams.size < 2
+                puts "!!! ERROR [club history reader] - expected two or more teams for MERGE - got:"
+                pp last_teams
+                exit 1
+              end
+              ## auto-add country to all teams
+              teams = last_teams.map {|team| [team, last_country.key]}
+              recs << [ last_keyword, last_season.key,
+                        teams,
+                        [ squish(line.sub('⇒','').strip), last_country.key ]
+                      ]
+
+              last_teams = []
+            else
+              last_teams << squish(line)
+            end
+        else
+          puts "!!! ERROR [club history reader] - unknown keyword >#{last_keyword}<; cannot process; sorry"
+          exit 1
+        end
+      end  # each line (in paragraph)
+    else
+      puts "** !!! ERROR [club history reader] - unknown line type:"
+      pp node
+      exit 1
+    end
+  end
+
+  recs
+end  # method read
+
+
+###############
+## helper
+
+def squish( str )
+  ## colapse all whitespace to one
+  str.gsub( /[ ]+/,' ' )
+end
+
+
+end  # class ClubHistoryReader
+
+
+end ## module Import
+end ## module SportDb

data/lib/sportdb/formats/team/club_reader_props.rb

@@ -36,17 +36,16 @@ class ClubPropsReader
 
       ## find / match club by (canocial) name
       m = catalog.clubs.match( name )
-      if m && m.size > 1
+      if m.size > 1
         puts "** !!! WARN !!! ambigious (multiple) club matches (#{m.size}) for name >#{name}< in props row:"
         pp rec
         pp m
 
         ## todo/fix:  try filter by canonical name if more than one match
         m = m.select { |club| club.name == name }
-        m = nil    if m.empty?     ## note: reset to nil if no more matches
       end
 
-      if m.nil?
+      if m.empty?
         puts "** !!! ERROR !!! no club match for (canonical) name >#{name}< in props row:"
         pp rec
         exit 1