sportdb-formats 1.0.2 → 1.1.0

data/lib/sportdb/formats/structs/team.rb

@@ -11,10 +11,9 @@ class Team
   ##  todo: use just names for alt_names - why? why not?
   attr_accessor :key, :name, :alt_names,
                 :code,    ## code == abbreviation e.g. ARS etc.
-                :year, :year_end,   ## todo/fix: change year_end to end_year (like in season)!!!
+                :year, :year_end,   ## todo/fix: change year to start_year and year_end to end_year (like in season)!!!
                 :country
 
-  alias_method :title, :name  ## add alias/compat - why? why not
 
   def names
     ## todo/check: add alt_names_auto too? - why? why not?

data/lib/sportdb/formats/team/club_reader_props.rb

@@ -27,7 +27,7 @@ class ClubPropsReader
   def parse
     recs = parse_csv( @txt )
     recs.each do |rec|
-      name = rec[:name]
+      name = rec['Name']
       if name.nil?
         puts "** !!! ERROR !!! Name column required / missing / NOT found in row:"
         pp rec
@@ -62,8 +62,8 @@ class ClubPropsReader
         ## todo/fix:   only updated "on-demand" from in-memory struct/records!!!!
 
         ##  update attributes
-        club_rec.key  = rec[:key]      if rec[:key]
-        club_rec.code = rec[:code]     if rec[:code]
+        club_rec.key  = rec['Key']      if rec['Key']
+        club_rec.code = rec['Code']     if rec['Code']
         ## todo/fix: add (some) more props e.g. address, web, etc.
       end
     end

data/lib/sportdb/formats/version.rb

@@ -2,11 +2,12 @@
 
 
 module SportDb
+  module Module
 module Formats
 
   MAJOR = 1    ## todo: namespace inside version or something - why? why not??
-  MINOR = 0
-  PATCH = 2
+  MINOR = 1
+  PATCH = 0
   VERSION = [MAJOR,MINOR,PATCH].join('.')
 
   def self.version
@@ -22,4 +23,5 @@ module Formats
   end
 
 end # module Formats
+end # module Module
 end # module SportDb

data/test/helper.rb

@@ -1,5 +1,6 @@
 ## note: use the local version of gems
 $LOAD_PATH.unshift( File.expand_path( '../date-formats/lib' ))
+$LOAD_PATH.unshift( File.expand_path( '../sportdb-langs/lib' ))
 
 
 ## minitest setup
@@ -147,7 +148,7 @@ def parse_json( str )
 end
 
 def read_test( path )
-  blocks = read_blocks( "../football.txt/#{path}" )
+  blocks = read_blocks( "#{SportDb::Test.data_dir}/football.txt/#{path}" )
 
   if blocks.size == 2
     [blocks[0], parse_json( blocks[1] )]

data/test/test_club_reader_props.rb

@@ -29,8 +29,8 @@ TXT
     recs = parse_csv( ENG_CLUBS_PROPS_TXT )
     pp recs
 
-    assert_equal [{ key: 'chelsea', name: 'Chelsea FC', code: 'CHE' },
-                  { key: 'arsenal', name: 'Arsenal FC', code: 'ARS' }], recs[0..1]
+    assert_equal [{ 'Key' => 'chelsea', 'Name' => 'Chelsea FC', 'Code' => 'CHE' },
+                  { 'Key' => 'arsenal', 'Name' => 'Arsenal FC', 'Code' => 'ARS' }], recs[0..1]
   end
 
   CLUBS = SportDb::Import.catalog.clubs

data/test/test_country_index.rb

@@ -16,12 +16,12 @@ class TestCountryIndex < MiniTest::Test
     eng = countries[:eng]
     assert_equal 'eng',      eng.key
     assert_equal 'England',  eng.name
-    assert_equal 'ENG',      eng.fifa
+    assert_equal 'ENG',      eng.code
 
     at  = countries[:at]
     assert_equal 'at',                at.key
     assert_equal 'Austria',           at.name
-    assert_equal 'AUT',               at.fifa
+    assert_equal 'AUT',               at.code
     assert_equal ['Österreich [de]'], at.alt_names
 
     assert at == countries['AT']
@@ -48,13 +48,13 @@ class TestCountryIndex < MiniTest::Test
     assert at == countries.parse( 'Österreich • Austria' )
     assert at == countries.parse( 'Austria' )
     assert at == countries.parse( 'at' )    ## (iso alpha2) country code
-    assert at == countries.parse( 'AUT' )   ## fifa code
+    assert at == countries.parse( 'AUT' )   ## (fifa) country code
 
 
     de  = countries[:de]
     assert_equal 'de',                 de.key
     assert_equal 'Germany',            de.name
-    assert_equal 'GER',                de.fifa
+    assert_equal 'GER',                de.code
     assert_equal ['Deutschland [de]'], de.alt_names
 
     assert de == countries.parse( 'Deutschland (de) • Germany' )

data/test/test_country_reader.rb

@@ -16,12 +16,12 @@ class TestCountryReader < MiniTest::Test
     assert_equal 232, recs.size
 
     assert_equal 'Albania',        recs[0].name
-    assert_equal 'ALB',            recs[0].fifa
+    assert_equal 'ALB',            recs[0].code
     assert_equal 'al',             recs[0].key
     assert_equal ['fifa', 'uefa'], recs[0].tags
 
     assert_equal 'Andorra',        recs[1].name
-    assert_equal 'AND',            recs[1].fifa
+    assert_equal 'AND',            recs[1].code
     assert_equal 'ad',             recs[1].key
     assert_equal ['fifa', 'uefa'], recs[1].tags
   end
@@ -44,16 +44,46 @@ TXT
 
     assert_equal 4, recs.size
     assert_equal 'Afghanistan',    recs[0].name
-    assert_equal 'AFG',            recs[0].fifa
+    assert_equal 'AFG',            recs[0].code
     assert_equal 'af',             recs[0].key
     assert_equal [],               recs[0].alt_names
     assert_equal ['fifa', 'afc'],  recs[0].tags
 
     assert_equal 'American Samoa', recs[3].name
-    assert_equal 'ASA',            recs[3].fifa
+    assert_equal 'ASA',            recs[3].code
     assert_equal 'as',             recs[3].key
     assert_equal ['Am. Samoa'],    recs[3].alt_names
     assert_equal [],               recs[3].tags
   end
 
+  def test_parse_historic
+    recs = SportDb::Import::CountryReader.parse( <<TXT )
+###########################################
+# Former national teams
+#   with former FIFA country codes etc.
+-1992   Czechoslovakia, TCH      ⇒  Czech Republic
+
+-1991   Soviet Union,   URS      ⇒  Russia
+
+-1989   West Germany,   FRG      =>  Germany
+-1989   East Germany,   GDR      =>  Germany
+TXT
+
+    pp recs
+
+    assert_equal 4, recs.size
+    assert_equal 'Czechoslovakia (-1992)', recs[0].name
+    assert_equal 'TCH',                    recs[0].code
+    assert_equal 'czechoslovakia',         recs[0].key
+    assert_equal [],                       recs[0].alt_names
+    assert_equal [],                       recs[0].tags
+
+    assert_equal 'East Germany (-1989)',   recs[3].name
+    assert_equal 'GDR',                    recs[3].code
+    assert_equal 'eastgermany',            recs[3].key
+    assert_equal [],                       recs[3].alt_names
+    assert_equal [],                       recs[3].tags
+  end
+
+
 end # class TestCountryReader

data/test/test_csv_match_parser.rb

@@ -0,0 +1,114 @@
+# encoding: utf-8
+
+###
+#  to run use
+#     ruby -I ./lib -I ./test test/test_csv_match_parser.rb
+
+
+require 'helper'
+
+
+class TestCsvMatchParser < MiniTest::Test
+
+##
+# Div,Date,HomeTeam,AwayTeam,FTHG,FTAG,FTR,HTHG,HTAG,HTR,
+#   Referee,HS,AS,HST,AST,HF,AF,HC,AC,HY,AY,HR,AR,
+#    B365H,B365D,B365A,BWH,BWD,BWA,IWH,IWD,IWA,LBH,LBD,LBA,PSH,PSD,PSA,
+#    WHH,WHD,WHA,VCH,VCD,VCA,
+#    Bb1X2,BbMxH,BbAvH,BbMxD,BbAvD,BbMxA,BbAvA,BbOU,BbMx>2.5,BbAv>2.5,BbMx<2.5,BbAv<2.5,
+#    BbAH,BbAHh,BbMxAHH,BbAvAHH,BbMxAHA,BbAvAHA,PSCH,PSCD,PSCA
+  def test_eng_filters
+    path = "#{SportDb::Test.data_dir}/england/2017-18/E0.csv"
+
+    matches = SportDb::CsvMatchParser.read( path,
+                                            filters: { 'HomeTeam' => 'Arsenal' } )
+
+    pp path
+    pp matches[0..2]
+
+    m=matches[0]
+    assert_equal '2017-08-11', m.date
+    assert_equal 4, m.score1
+    assert_equal 3, m.score2
+    assert_equal 2, m.score1i
+    assert_equal 2, m.score2i
+    assert_equal 'Arsenal',    m.team1
+    assert_equal 'Leicester',  m.team2
+
+    m=matches[1]
+    assert_equal '2017-09-09', m.date
+    assert_equal 3, m.score1
+    assert_equal 0, m.score2
+    assert_equal 2, m.score1i
+    assert_equal 0, m.score2i
+    assert_equal 'Arsenal',     m.team1
+    assert_equal 'Bournemouth', m.team2
+  end
+
+
+  def test_eng_headers
+    path = "#{SportDb::Test.data_dir}/england/2017-18/E0.csv"
+
+    headers = { team1:  'HomeTeam',
+                team2:  'AwayTeam',
+                date:   'Date',
+                score1: 'FTHG',
+                score2: 'FTAG' }
+
+    matches = SportDb::CsvMatchParser.read( path, headers: headers )
+
+    pp path
+    pp matches[0..2]
+
+    m=matches[0]
+    assert_equal '2017-08-11', m.date
+    assert_equal 4, m.score1
+    assert_equal 3, m.score2
+    assert_nil   m.score1i      ## todo/fix: missing half time (ht) score !!!!
+    assert_nil   m.score2i      ## todo/fix: missing half time (ht) score !!!!
+    assert_equal 'Arsenal',   m.team1
+    assert_equal 'Leicester', m.team2
+
+    m=matches[1]
+    assert_equal '2017-08-12', m.date
+    assert_equal 0, m.score1
+    assert_equal 2, m.score2
+    assert_nil   m.score1i      ## todo/fix: missing half time (ht) score !!!!
+    assert_nil   m.score2i      ## todo/fix: missing half time (ht) score !!!!
+    assert_equal 'Brighton', m.team1
+    assert_equal 'Man City', m.team2
+  end
+
+
+###
+# Country,League,Season,Date,Time,Home,Away,HG,AG,
+#  Res,PH,PD,PA,MaxH,MaxD,MaxA,AvgH,AvgD,AvgA
+  def test_at
+    path = "#{SportDb::Test.data_dir}/austria/AUT.csv"
+
+    matches = SportDb::CsvMatchParser.read( path, filters: { 'Season' => '2017/2018' } )
+
+    pp matches[0..2]
+    pp path
+
+    m=matches[0]
+    assert_equal '2017-07-22', m.date
+    assert_equal 2, m.score1
+    assert_equal 2, m.score2
+    assert_nil      m.score1i  ## todo/fix: missing half time (ht) score !!!!
+    assert_nil      m.score2i  ## todo/fix: missing half time (ht) score !!!!
+    assert_equal 'Rapid Vienna', m.team1
+    assert_equal 'Mattersburg',  m.team2
+
+    m=matches[1]
+    assert_equal '2017-07-22', m.date
+    assert_equal 0, m.score1
+    assert_equal 2, m.score2
+    assert_nil   m.score1i    ## todo/fix: missing half time (ht) score !!!!
+    assert_nil   m.score2i    ## todo/fix: missing half time (ht) score !!!!
+    assert_equal 'AC Wolfsberger', m.team1
+    assert_equal 'Salzburg',       m.team2
+  end
+
+
+end # class TestCsvMatchParser

data/test/test_csv_match_parser_utils.rb

@@ -0,0 +1,20 @@
+# encoding: utf-8
+
+###
+#  to run use
+#     ruby -I ./lib -I ./test test/test_csv_match_parser_utils.rb
+
+
+require 'helper'
+
+class TestCsvMatchParserUtils < MiniTest::Test
+
+  def test_find_seasons
+     pp = SportDb::CsvMatchParser.find_seasons( "#{SportDb::Test.data_dir}/dl/AUT.csv" )  ## defaults to col: 'Season', col_sep: ','
+     pp = SportDb::CsvMatchParser.find_seasons( "#{SportDb::Test.data_dir}/dl/Bundesliga_1963_2014.csv", col: 'Saison', sep: ';'  )
+     assert true
+  end
+
+end # class TestCsvMatchParserUtils
+
+

data/test/test_csv_reader.rb

@@ -13,7 +13,7 @@ class TestCsvReader < MiniTest::Test
     recs = parse_csv( <<TXT )
 ### World Countries
 
-key, fifa, name
+Key, Code, Name
 af,  AFG,  Afghanistan
 al,  ALB,  Albania
 dz,  ALG,  Algeria
@@ -21,10 +21,10 @@ as,  ASA,  American Samoa (US)
 TXT
 
    pp recs
-   assert_equal  [{ key:'af', fifa:'AFG', name:'Afghanistan'},
-                  { key:'al', fifa:'ALB', name:'Albania'},
-                  { key:'dz', fifa:'ALG', name:'Algeria'},
-                  { key:'as', fifa:'ASA', name:'American Samoa (US)'},
+   assert_equal  [{ 'Key' => 'af', 'Code' => 'AFG', 'Name' => 'Afghanistan'},
+                  { 'Key' => 'al', 'Code' => 'ALB', 'Name' => 'Albania'},
+                  { 'Key' => 'dz', 'Code' => 'ALG', 'Name' => 'Algeria'},
+                  { 'Key' => 'as', 'Code' => 'ASA', 'Name' => 'American Samoa (US)'},
                  ], recs[0..3]
   end
 

data/test/test_datafile.rb

@@ -27,36 +27,4 @@ class TestDatafile < MiniTest::Test
     assert Datafile::Package.match_exclude?( '/.build/leagues.txt' )
     assert Datafile::Package.match_exclude?( '/.git/leagues.txt' )
   end
-
-
-  CLUBS_DIR   = '../../../openfootball/clubs'    ## source repo directory path
-  LEAGUES_DIR = '../../../openfootball/leagues'
-
-  def test_bundle
-    datafiles = SportDb::Package.find_clubs( CLUBS_DIR )
-    pp datafiles
-
-    ## todo/fix: turn into Datafile::Bundle.new  and Bundle#write/save -why? why not?
-    bundle = Datafile::Bundle.new( './tmp/clubs.txt' )
-    bundle.write <<TXT
-##########################################
-# auto-generated all-in-one single datafile clubs.txt bundle
-#    on #{Time.now} from #{datafiles.size} datafile(s)
-TXT
-    bundle.write datafiles
-    bundle.close
-  end
-
-  def test_bundle_old
-    datafiles = SportDb::Package.find_leagues( LEAGUES_DIR )
-    pp datafiles
-
-    Datafile.write_bundle( './tmp/leagues.txt',
-                           datafiles: datafiles,
-                           header: <<TXT )
-##########################################
-# auto-generated all-in-one single datafile leagues.txt bundle
-#    on #{Time.now} from #{datafiles.size} datafile(s)
-TXT
-  end
 end   # class TestDatafile

data/test/test_datafile_package.rb

@@ -0,0 +1,46 @@
+# encoding: utf-8
+
+###
+#  to run use
+#     ruby -I ./lib -I ./test test/test_datafile_package.rb
+
+
+require 'helper'
+
+
+class TestDatafilePackage < MiniTest::Test
+
+  def test_read
+    [Datafile::DirPackage.new( '../../../openfootball/england' ),
+     Datafile::ZipPackage.new( 'tmp/england-master.zip' )
+    ].each do |eng|
+       assert eng.find( '2015-16/.conf.txt' ).read.start_with?( '= English Premier League 2015/16' )
+       assert eng.find( '2017-18/.conf.txt' ).read.start_with?( '= English Premier League 2017/18' )
+       assert eng.find( '2015-16/1-premierleague-i.txt' ).read.start_with?( '= English Premier League 2015/16' )
+    end
+
+    [Datafile::DirPackage.new( '../../../openfootball/austria' ),
+     Datafile::ZipPackage.new( 'tmp/austria-master.zip' )
+    ].each do |at|
+       assert at.find( '2018-19/.conf.txt' ).read.start_with?( '= Österr. Bundesliga 2018/19' )
+    end
+
+    puts "DirPackage:"
+    pack = Datafile::DirPackage.new( '../../../openfootball/austria' )
+    puts pack.name
+    puts "  entries:"
+    pack.each( pattern: /\.txt$/ ) do |entry|
+      puts entry.name
+    end
+
+    puts "ZipPackage:"
+    pack = Datafile::ZipPackage.new( 'tmp/austria-master.zip' )
+    puts pack.name
+    puts "  entries:"
+    pack.each( pattern: /\.txt$/ ) do |entry|
+      puts entry.name
+    end
+
+  end  # method test_read
+
+end  # class TestDatafilePackage

data/test/test_match_auto_relegation.rb

@@ -0,0 +1,41 @@
+# encoding: utf-8
+
+###
+#  to run use
+#     ruby -I ./lib -I ./test test/test_match_auto_relegation.rb
+
+
+require 'helper'
+
+
+class TestMatchAutoRelegation < MiniTest::Test
+
+  def test_rel
+    txt = <<TXT
+Hinspiel
+[31.5.]
+  SC Wiener Neustadt     0-2  SKN St. Pölten
+
+Rückspiel
+[3.6.]
+  SKN St. Pölten         1-1  SC Wiener Neustadt
+TXT
+
+    start =  Date.new( 2017, 7, 1 )
+    SportDb::Import.config.lang = 'de'
+
+    teams, rounds, groups, round_defs, group_defs = SportDb::AutoConfParser.parse( txt, start: start )
+
+    puts "teams:"
+    pp teams
+    puts "rounds:"
+    pp rounds
+    puts "groups:"
+    pp groups
+    puts "round defs:"
+    pp round_defs
+    puts "group defs:"
+    pp group_defs
+  end
+
+end   # class TestMatchAutoRelegation