spoom 1.0.4 → 1.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d851bf66dbfb8e1d316b27466fde8ee205e55e68b9b489c3f8f234c03e1763d2
-  data.tar.gz: '068972f0ebb9393400dcbf68837be0a58114cc55560438fd329be3b54acfcaaf'
+  metadata.gz: 55531f68ca5416d234dc35cff63a0213a0f27ba0cf6fa840e183b90896661c3b
+  data.tar.gz: 2963d8788e5914ac38e00d30720d44a83691ef8c9165918cd2b7270b71775a3b
 SHA512:
-  metadata.gz: 8315d9c7de9beaf2aa9a5d6963cde78ec6e9e7949659bac85a0ff719080755808fb5a854c2a03f6dcab8134c17bc8d90d145d53d32a3f1632d83a2c6a21ebfaa
-  data.tar.gz: 88fee999fa79caf40dd776ce5253a1337a5acc2507653a2c09adfb3e4723b6a8a06033d34c8f299b3a7a663ef01c2fa4a8243d98fd9f104e9c77ad69f9836ff7
+  metadata.gz: 3b243083cf4ecae47f51bbfa6283e3272099c35ea28a7c471f731237eba01d5ce1f3634b9326ff3c19b7c36c58d38f97065e021e41070fd583efde13acfa2588
+  data.tar.gz: f0f2b0c272f46214a8d7bc21a9efc1e74f7646515a023a234612c96aaeb26c917c79a2db80169b275879c8da28cc57e49adf6e2f2a57c2f5e77abf0a018a6955

data/Gemfile

@@ -8,6 +8,5 @@ gemspec
 group(:development) do
   gem('rubocop-shopify', require: false)
   gem('rubocop-sorbet', require: false)
-  gem('byebug')
   gem('pry-byebug')
 end

data/README.md

@@ -20,7 +20,261 @@ Or install it yourself as:
 
 ## Usage
 
-### Parsing Sorbet config
+`spoom` provides both a CLI and an API to interact with Sorbet.
+
+### Generate a typing coverage report
+
+Spoom can create a typing coverage report from Sorbet and Git data:
+
+![Coverage Report](docs/report.png)
+
+After installing the `spoom` gem, run the `timeline` command to collect the history data:
+
+```
+$ spoom coverage timeline --save
+```
+
+Then create the HTML page with `report`:
+
+```
+$ spoom coverage report
+```
+
+Your report will be generated under `spoom_report.html`.
+
+See all the [Typing Coverage](#typing-coverage) CLI commands for more details.
+
+### Command Line Interface
+
+#### Sorbet configuration commands
+
+Spoom works with your `sorbet/config` file. No additional configuration is needed.
+
+Show Sorbet config options:
+
+```
+$ spoom config
+```
+
+#### Listing files
+
+List the files (and related strictness) that will be typchecked with the current Sorbet config options:
+
+```
+$ spoom files
+```
+
+#### Errors sorting and filtering
+
+List all typechecking errors sorted by location:
+
+```
+$ spoom tc -s loc
+```
+
+List all typechecking errors sorted by error code first:
+
+```
+$ spoom tc -s code
+```
+
+List only typechecking errors from a specific error code:
+
+```
+$ spoom tc -c 7004
+```
+
+List only the first 10 typechecking errors
+
+```
+$ spoom tc -l 10
+```
+
+These options can be combined:
+
+```
+$ spoom tc -s -c 7004 -l 10
+```
+
+Remove duplicated error lines:
+
+```
+$ spoom tc -u
+```
+
+Format each error line:
+
+```
+$ spoom tc -f '%C - %F:%L: %M'
+```
+
+Where:
+
+* `%C` is the error code
+* `%F` is the file the error is from
+* `%L` is the line the error is from
+* `%M` is the error message
+
+Hide the `Errors: X` at the end of the list:
+
+```
+$ spoom tc --no-count
+```
+
+#### Typing coverage
+
+Show metrics about the project contents and the typing coverage:
+
+```
+$ spoom coverage
+```
+
+Save coverage data under `spoom_data/`:
+
+```
+$ spoom coverage --save
+```
+
+Save coverage data under a specific directory:
+
+```
+$ spoom coverage --save my_data/
+```
+
+Show typing coverage evolution based on the commits history:
+
+```
+$ spoom coverage timeline
+```
+
+Show typing coverage evolution based on the commits history between specific dates:
+
+```
+$ spoom coverage timeline --from YYYY-MM-DD --to YYYY-MM-DD
+```
+
+Save the typing coverage evolution as JSON under `spoom_data/`:
+
+```
+$ spoom coverage timeline --save
+```
+
+Save the typing coverage evolution as JSON in a specific directory:
+
+```
+$ spoom coverage timeline --save my_data/
+```
+
+Run `bundle install` for each commit of the timeline (may solve errors due to different Sorbet versions):
+
+```
+$ spoom coverage timeline --bundle-install
+```
+
+Generate an HTML typing coverage report:
+
+```
+$ spoom coverage report
+```
+
+Change the colors used for strictnesses (useful for colorblind folks):
+
+```
+$ spoom coverage report \
+  --color-true "#648ffe" \
+  --color-false "#fe6002" \
+  --color-ignore "#feb000" \
+  --color-strict "#795ef0" \
+  --color-strong "#6444f1"
+```
+
+Open the HTML typing coverage report:
+
+```
+$ spoom coverage open
+```
+
+#### Change the sigil used in files
+
+Bump the strictness from all files currently at `typed: false` to `typed: true` where it does not create typechecking errors:
+
+```
+$ spoom bump --from false --to true
+```
+
+Bump the strictness from all files currently at `typed: false` to `typed: true` even if it creates typechecking errors:
+
+```
+$ spoom bump --from false --to true -f
+```
+
+Bump the strictness from a list of files (one file by line):
+
+```
+$ spoom bump --from false --to true -o list.txt
+```
+
+Check if files can be bumped without applying any change:
+
+```
+$ spoom bump --from false --to true --dry
+```
+
+Bump files using a custom instance of Sorbet:
+
+```
+$ spoom bump --from false --to true --sorbet /path/to/sorbet/bin
+```
+
+#### Interact with Sorbet LSP mode
+
+**Experimental**
+
+Find all definitions for `Foo`:
+
+```
+$ spoom lsp find Foo
+```
+
+List all symbols in a file:
+
+```
+$ spoom lsp symbols <file.rb>
+```
+
+List all definitions for a specific code location:
+
+```
+$ spoom lsp defs <file.rb> <line> <column>
+```
+
+List all references for a specific code location:
+
+```
+$ spoom lsp refs <file.rb> <line> <column>
+```
+
+Show hover information for a specific code location:
+
+```
+$ spoom lsp hover <file.rb> <line> <column>
+```
+
+Show signature information for a specific code location:
+
+```
+$ spoom lsp sig <file.rb> <line> <column>
+```
+
+Show type information for a specific code location:
+
+```
+$ spoom lsp sig <file.rb> <line> <column>
+```
+
+### API
+
+#### Parsing Sorbet config
 
 Parses a Sorbet config file:
 
@@ -41,6 +295,47 @@ puts config.paths   # "a", "b"
 puts config.ignore  # "c"
 ```
 
+List all files typchecked by Sorbet:
+
+```ruby
+config = Spoom::Sorbet::Config.parse_file("sorbet/config")
+puts Spoom::Sorbet.srb_files(config)
+```
+
+#### Parsing Sorbet metrics
+
+Display metrics collected during typechecking:
+
+```ruby
+puts Spoom::Sorbet.srb_metrics(capture_err: false)
+```
+
+#### Interacting with LSP
+
+Create an LSP client:
+
+```rb
+client = Spoom::LSP::Client.new(
+  Spoom::Sorbet::BIN_PATH,
+  "--lsp",
+  "--enable-all-experimental-lsp-features",
+  "--disable-watchman",
+)
+client.open(".")
+```
+
+Find all the symbols matching a string:
+
+```rb
+puts client.symbols("Foo")
+```
+
+Find all the symbols for a file:
+
+```rb
+puts client.document_symbols("file://path/to/my/file.rb")
+```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `bin/test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment. Don't forget to run `bin/sanity` before pushing your changes.

data/Rakefile

@@ -6,6 +6,7 @@ require "rake/testtask"
 Rake::TestTask.new(:test) do |t|
   t.libs << "test"
   t.libs << "lib"
+  t.warning = false
   t.test_files = FileList["test/**/*_test.rb"]
 end
 

data/lib/spoom.rb

@@ -1,13 +1,32 @@
 # typed: true
 # frozen_string_literal: true
 
+require "colorize"
 require "sorbet-runtime"
 
 module Spoom
+  extend T::Sig
+
+  SPOOM_PATH = (Pathname.new(__FILE__) / ".." / "..").to_s
+
   class Error < StandardError; end
+
+  sig do
+    params(
+      cmd: String,
+      arg: String,
+      path: String,
+      capture_err: T::Boolean
+    ).returns([String, T::Boolean])
+  end
+  def self.exec(cmd, *arg, path: '.', capture_err: false)
+    method = capture_err ? "popen2e" : "popen2"
+    Open3.send(method, [cmd, *arg].join(" "), chdir: path) do |_, o, t|
+      [o.read, T.cast(t.value, Process::Status).success?]
+    end
+  end
 end
 
-require "spoom/cli"
-require "spoom/config"
 require "spoom/sorbet"
+require "spoom/cli"
 require "spoom/version"

data/lib/spoom/cli.rb

@@ -3,25 +3,71 @@
 
 require "thor"
 
-require_relative "cli/commands/config"
-require_relative "cli/commands/lsp"
-require_relative "cli/commands/run"
+require_relative 'cli/helper'
+
+require_relative "cli/bump"
+require_relative "cli/config"
+require_relative "cli/lsp"
+require_relative "cli/coverage"
+require_relative "cli/run"
 
 module Spoom
   module Cli
     class Main < Thor
       extend T::Sig
+      include Helper
+
+      class_option :color, type: :boolean, default: true, desc: "Use colors"
+      class_option :path, type: :string, default: ".", aliases: :p, desc: "Run spoom in a specific path"
+
+      map T.unsafe(%w[--version -v] => :__print_version)
+
+      desc "bump", "Bump Sorbet sigils from `false` to `true` when no errors"
+      subcommand "bump", Spoom::Cli::Bump
+
+      desc "config", "Manage Sorbet config"
+      subcommand "config", Spoom::Cli::Config
+
+      desc "coverage", "Collect metrics related to Sorbet coverage"
+      subcommand "coverage", Spoom::Cli::Coverage
 
-      class_option :no_color, desc: "Don't use colors", type: :boolean
+      desc "lsp", "Send LSP requests to Sorbet"
+      subcommand "lsp", Spoom::Cli::LSP
 
-      desc "config", "manage Sorbet config"
-      subcommand "config", Spoom::Cli::Commands::Config
+      desc "tc", "Run Sorbet and parses its output"
+      subcommand "tc", Spoom::Cli::Run
 
-      desc "lsp", "send LSP requests to Sorbet"
-      subcommand "lsp", Spoom::Cli::Commands::LSP
+      desc "files", "List all the files typechecked by Sorbet"
+      option :tree, type: :boolean, default: true, desc: "Display list as an indented tree"
+      option :rbi, type: :boolean, default: true, desc: "Show RBI files"
+      def files
+        in_sorbet_project!
 
-      desc "tc", "run Sorbet and parses its output"
-      subcommand "tc", Spoom::Cli::Commands::Run
+        path = exec_path
+        config = sorbet_config
+        files = Spoom::Sorbet.srb_files(config, path: path)
+
+        unless options[:rbi]
+          files = files.reject { |file| file.end_with?(".rbi") }
+        end
+
+        if files.empty?
+          say_error("No file matching `#{sorbet_config_file}`")
+          exit(1)
+        end
+
+        if options[:tree]
+          tree = FileTree.new(files, strip_prefix: path)
+          tree.print(colors: options[:color], indent_level: 0)
+        else
+          puts files
+        end
+      end
+
+      desc "--version", "Show version"
+      def __print_version
+        puts "Spoom v#{Spoom::VERSION}"
+      end
 
       # Utils