spoom 1.0.2 → 1.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5c89940fbd779667ff48027cb2c60a2a67752c23bd65b47935d44d69f451065d
-  data.tar.gz: 12235dfb24ae6578e2fe5299d92311be7bfe424ae810748a70cf32e7235517ea
+  metadata.gz: f16907e7c4ce2a3d368bcac828ae7cfb43f0dde8f857bbfa364c4a3a16e0e433
+  data.tar.gz: b6d2a532d34b0cd5e8e4964d2edc5e279e5481de511a4e61ea764e120e4bae33
 SHA512:
-  metadata.gz: e72516c64841d1395a30ccffcb5ecabe7003ed9277f75e39929cba65bd49174cd0e05e310804dbbe465aa6ab234e1d0c64677a69e4e3f2aa5dfc4eeb323726eb
-  data.tar.gz: 2da79d80442024d88844ceec77394376fdd71f59fece8c1dff557b2707474794a830101775edf7820370d4a8df9f766e08012c8ed36b6e11f13625cf55f3deb1
+  metadata.gz: ad2f822b0c34fdb51ae8002bdc2c3f35202e219e334723716b141afe9ab00b18c65f74c3129cff6e4a9cb992d3c673ccb8afa522114cf2759af5cdd888df5100
+  data.tar.gz: f077abc8f9be4b2768776214601dd1c8d8c5709649536202a0ab9765058de9dc8590712b9a6fb96c30a0ac5ed46e7c21d84ab9bff190e48d99d5e0bddab1d44e

data/Gemfile

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 source "https://rubygems.org"
@@ -6,4 +7,7 @@ gemspec
 
 group(:development) do
   gem('rubocop-shopify', require: false)
+  gem('rubocop-sorbet', require: false)
+  gem('byebug')
+  gem('pry-byebug')
 end

data/README.md

@@ -20,7 +20,218 @@ Or install it yourself as:
 
 ## Usage
 
-### Parsing Sorbet config
+`spoom` provides both a CLI and an API to interact with Sorbet.
+
+### Generate a typing coverage report
+
+Spoom can create a typing coverage report from Sorbet and Git data:
+
+![Coverage Report](docs/report.png)
+
+After installing the `spoom` gem, run the `timeline` command to collect the history data:
+
+```
+$ spoom coverage timeline --save
+```
+
+Then create the HTML page with `report`:
+
+```
+$ spoom coverage report
+```
+
+Your report will be generated under `spoom_report.html`.
+
+See all the [Typing Coverage](#typing-coverage) CLI commands for more details.
+
+### Command Line Interface
+
+#### Sorbet configuration commands
+
+Spoom works with your `sorbet/config` file. No additional configuration is needed.
+
+Show Sorbet config options:
+
+```
+$ spoom config
+```
+
+#### Listing files
+
+List the files (and related strictness) that will be typchecked with the current Sorbet config options:
+
+```
+$ spoom files
+```
+
+#### Errors sorting and filtering
+
+List all typechecking errors sorted by location:
+
+```
+$ spoom tc -s
+```
+
+List all typechecking errors sorted by error code first:
+
+```
+$ spoom tc -s code
+```
+
+List only typechecking errors from a specific error code:
+
+```
+$ spoom tc -c 7004
+```
+
+List only the first 10 typechecking errors
+
+```
+$ spoom tc -l 10
+```
+
+These options can be combined:
+
+```
+$ spoom tc -s -c 7004 -l 10
+```
+
+#### Typing coverage
+
+Show metrics about the project contents and the typing coverage:
+
+```
+$ spoom coverage
+```
+
+Save coverage data under `spoom_data/`:
+
+```
+$ spoom coverage --save
+```
+
+Save coverage data under a specific directory:
+
+```
+$ spoom coverage --save my_data/
+```
+
+Show typing coverage evolution based on the commits history:
+
+```
+$ spoom coverage timeline
+```
+
+Show typing coverage evolution based on the commits history between specific dates:
+
+```
+$ spoom coverage timeline --from YYYY-MM-DD --to YYYY-MM-DD
+```
+
+Save the typing coverage evolution as JSON under `spoom_data/`:
+
+```
+$ spoom coverage timeline --save
+```
+
+Save the typing coverage evolution as JSON in a specific directory:
+
+```
+$ spoom coverage timeline --save my_data/
+```
+
+Run `bundle install` for each commit of the timeline (may solve errors due to different Sorbet versions):
+
+```
+$ spoom coverage timeline --bundle-install
+```
+
+Generate an HTML typing coverage report:
+
+```
+$ spoom coverage report
+```
+
+Change the colors used for strictnesses (useful for colorblind folks):
+
+```
+$ spoom coverage report \
+  --color-true "#648ffe" \
+  --color-false "#fe6002" \
+  --color-ignore "#feb000" \
+  --color-strict "#795ef0" \
+  --color-strong "#6444f1"
+```
+
+Open the HTML typing coverage report:
+
+```
+$ spoom coverage open
+```
+
+#### Change the sigil used in files
+
+Bump the strictness from all files currently at `typed: false` to `typed: true` where it does not create typechecking errors:
+
+```
+$ spoom bump --from false --to true
+```
+
+Bump the strictness from all files currently at `typed: false` to `typed: true` even if it creates typechecking errors:
+
+```
+$ spoom bump --from false --to true -f
+```
+
+#### Interact with Sorbet LSP mode
+
+**Experimental**
+
+Find all definitions for `Foo`:
+
+```
+$ spoom lsp find Foo
+```
+
+List all symbols in a file:
+
+```
+$ spoom lsp symbols <file.rb>
+```
+
+List all definitions for a specific code location:
+
+```
+$ spoom lsp defs <file.rb> <line> <column>
+```
+
+List all references for a specific code location:
+
+```
+$ spoom lsp refs <file.rb> <line> <column>
+```
+
+Show hover information for a specific code location:
+
+```
+$ spoom lsp hover <file.rb> <line> <column>
+```
+
+Show signature information for a specific code location:
+
+```
+$ spoom lsp sig <file.rb> <line> <column>
+```
+
+Show type information for a specific code location:
+
+```
+$ spoom lsp sig <file.rb> <line> <column>
+```
+
+### API
+
+#### Parsing Sorbet config
 
 Parses a Sorbet config file:
 
@@ -41,6 +252,47 @@ puts config.paths   # "a", "b"
 puts config.ignore  # "c"
 ```
 
+List all files typchecked by Sorbet:
+
+```ruby
+config = Spoom::Sorbet::Config.parse_file("sorbet/config")
+puts Spoom::Sorbet.srb_files(config)
+```
+
+#### Parsing Sorbet metrics
+
+Display metrics collected during typechecking:
+
+```ruby
+puts Spoom::Sorbet.srb_metrics(capture_err: false)
+```
+
+#### Interacting with LSP
+
+Create an LSP client:
+
+```rb
+client = Spoom::LSP::Client.new(
+  Spoom::Config::SORBET_PATH,
+  "--lsp",
+  "--enable-all-experimental-lsp-features",
+  "--disable-watchman",
+)
+client.open(".")
+```
+
+Find all the symbols matching a string:
+
+```rb
+puts client.symbols("Foo")
+```
+
+Find all the symbols for a file:
+
+```rb
+puts client.document_symbols("file://path/to/my/file.rb")
+```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `bin/test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment. Don't forget to run `bin/sanity` before pushing your changes.

data/Rakefile

@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 require "bundler/gem_tasks"
 require "rake/testtask"
@@ -5,6 +6,7 @@ require "rake/testtask"
 Rake::TestTask.new(:test) do |t|
   t.libs << "test"
   t.libs << "lib"
+  t.warning = false
   t.test_files = FileList["test/**/*_test.rb"]
 end
 

data/exe/spoom

@@ -0,0 +1,7 @@
+#! /usr/bin/env ruby
+# typed: true
+# frozen_string_literal: true
+
+require_relative "../lib/spoom"
+
+Spoom::Cli::Main.start(ARGV)

data/lib/spoom.rb

@@ -1,6 +1,14 @@
+# typed: true
 # frozen_string_literal: true
 
 require "sorbet-runtime"
 
+module Spoom
+  class Error < StandardError; end
+end
+
+require "spoom/config"
+
+require "spoom/sorbet"
+require "spoom/cli"
 require "spoom/version"
-require "spoom/sorbet/config"

data/lib/spoom/cli.rb

@@ -0,0 +1,68 @@
+# typed: true
+# frozen_string_literal: true
+
+require "thor"
+
+require_relative 'cli/helper'
+
+require_relative "cli/bump"
+require_relative "cli/config"
+require_relative "cli/lsp"
+require_relative "cli/coverage"
+require_relative "cli/run"
+
+module Spoom
+  module Cli
+    class Main < Thor
+      extend T::Sig
+      include Helper
+
+      class_option :color, desc: "Use colors", type: :boolean, default: true
+      class_option :path, desc: "Run spoom in a specific path", type: :string, default: ".", aliases: :p
+      map T.unsafe(%w[--version -v] => :__print_version)
+
+      desc "bump", "bump Sorbet sigils from `false` to `true` when no errors"
+      subcommand "bump", Spoom::Cli::Bump
+
+      desc "config", "manage Sorbet config"
+      subcommand "config", Spoom::Cli::Config
+
+      desc "coverage", "collect metrics related to Sorbet coverage"
+      subcommand "coverage", Spoom::Cli::Coverage
+
+      desc "lsp", "send LSP requests to Sorbet"
+      subcommand "lsp", Spoom::Cli::LSP
+
+      desc "tc", "run Sorbet and parses its output"
+      subcommand "tc", Spoom::Cli::Run
+
+      desc "files", "list all the files typechecked by Sorbet"
+      def files
+        in_sorbet_project!
+
+        path = exec_path
+        config = Spoom::Sorbet::Config.parse_file(sorbet_config)
+        files = Spoom::Sorbet.srb_files(config, path: path)
+
+        say("Files matching `#{sorbet_config}`:")
+        if files.empty?
+          say(" NONE")
+        else
+          tree = FileTree.new(files, strip_prefix: path)
+          tree.print(colors: options[:color], indent_level: 2)
+        end
+      end
+
+      desc "--version", "show version"
+      def __print_version
+        puts "Spoom v#{Spoom::VERSION}"
+      end
+
+      # Utils
+
+      def self.exit_on_failure?
+        true
+      end
+    end
+  end
+end

data/lib/spoom/cli/bump.rb

@@ -0,0 +1,60 @@
+# typed: strict
+# frozen_string_literal: true
+
+require 'find'
+require 'open3'
+
+module Spoom
+  module Cli
+    class Bump < Thor
+      extend T::Sig
+      include Helper
+
+      default_task :bump
+
+      desc "bump DIRECTORY", "change Sorbet sigils from one strictness to another when no errors"
+      option :from, type: :string, default: Spoom::Sorbet::Sigils::STRICTNESS_FALSE
+      option :to, type: :string, default: Spoom::Sorbet::Sigils::STRICTNESS_TRUE
+      option :force, desc: "change strictness without type checking", type: :boolean, default: false, aliases: :f
+      sig { params(directory: String).void }
+      def bump(directory = ".")
+        in_sorbet_project!
+
+        from = options[:from]
+        to = options[:to]
+        force = options[:force]
+
+        unless Sorbet::Sigils.valid_strictness?(from)
+          say_error("Invalid strictness #{from} for option --from")
+          exit(1)
+        end
+
+        unless Sorbet::Sigils.valid_strictness?(to)
+          say_error("Invalid strictness #{to} for option --to")
+          exit(1)
+        end
+
+        directory = File.expand_path(directory)
+        files_to_bump = Sorbet::Sigils.files_with_sigil_strictness(directory, from)
+        Sorbet::Sigils.change_sigil_in_files(files_to_bump, to)
+
+        return if force
+
+        output, no_errors = Sorbet.srb_tc(path: exec_path, capture_err: true)
+
+        return if no_errors
+
+        errors = Sorbet::Errors::Parser.parse_string(output)
+
+        files_with_errors = errors.map do |err|
+          path = File.expand_path(err.file)
+          next unless path.start_with?(directory)
+          next unless File.file?(path)
+          path
+        end.compact.uniq
+
+        Sorbet::Sigils.change_sigil_in_files(files_with_errors, from)
+      end
+    end
+  end
+end