splittable 0.0.8 → 0.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 37c4759b10b00ca1cf91aabb5e0b7611a6557f4a626e45b6ba8849b4756d6085
-  data.tar.gz: 1afade43018d247600cbb00b360b2f0e5e859358eb84fb0a00da9d2a6bf109a3
+  metadata.gz: f009747d17be3ef04b3f0837101ded2552e7e519b46fa4e82d518c7291493f5e
+  data.tar.gz: aad637f4ff361343bf795f138c1f700b5bd375fc70aeff0494827bd9f0140fc1
 SHA512:
-  metadata.gz: 6c7a5a283d57fc378864f8aa22236a6b58c590cb4218a6ff62783248e8052817a27ffd4d81d0812d0ec64699f6ddbb0addeda1fdbba82ecb8f1e1684786a1ac7
-  data.tar.gz: 0f10c22baa3d728be34ccd1a01b91901cae23ff32857255d4f66c7ed3ed3bf50988ca2ecb807b7c3f6d9a93c92e5e550ede3017a94e0e7365578ea11a7de8f04
+  metadata.gz: 0ade5a87b48dfd30170126e3358df344b521367c00c117f6f89b5795a6aef69fb48f903fc452b79c2f8f8df7920fb9503f182179adacb7149908e4ba7eb5d87a
+  data.tar.gz: 68a1f19ea3bd5af29569344ea0fc3ccd7078a67a1dd2dbea950da832e6a76ca98f8c9825ae9caf6b32a439c0ed99a08612e1ba7f0749113e5c0734b0032785cd

data/.github/workflows/publish_release.yml

@@ -4,8 +4,6 @@ on:
   push:
     branches:
       - master
-    tags:
-      - v*
 
 jobs:
   publish:
@@ -13,9 +11,22 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
+
+      - name: Decide whether this version is unpublished
+        id: release
+        run: |
+          version=$(ruby -r ./lib/splittable/version.rb -e 'puts Splittable::VERSION')
+          if git ls-remote --exit-code --tags origin "refs/tags/v${version}"; then
+            echo "Version v${version} is already tagged. Skipping publish."
+            echo "publish=false" >> "$GITHUB_OUTPUT"
+          else
+            echo "Version v${version} has no tag yet."
+            echo "publish=true" >> "$GITHUB_OUTPUT"
+          fi
 
       - name: Release Gem
+        if: steps.release.outputs.publish == 'true'
         uses: m4rcelotoledo/publish-rubygems-action@master
         env:
           RUBYGEMS_API_KEY: ${{secrets.RUBYGEMS_RELEASE}}

data/CHANGELOG.md

@@ -1,4 +1,33 @@
-# splittable 0.0.8 (Oct 14, 2025)
+# splittable 0.0.10 (Sep 25, 2026)
+
+* **Bump Versions**
+  * Fixed a vulnerability in libs
+
+* **Bug Fixes**
+  * Fixed incorrect examples in README.md with mathematically accurate values
+  * Corrected division examples to show proper cent adjustment behavior
+  * Fixed normalize examples to demonstrate actual gem behavior
+
+* **Error Handling Improvements**
+  * Added proper validation for empty installments array in normalize method
+  * Added validation for nil installments parameter
+  * Improved error messages with clear ArgumentError exceptions
+  * Enhanced error handling documentation with accurate examples
+
+* **Test Coverage**
+  * Added comprehensive tests for error handling scenarios
+  * Added tests for empty and nil installments arrays
+  * Maintained 100% test coverage (38 examples, 0 failures)
+  * Improved test readability with better formatting
+
+* **Code Quality**
+  * Enhanced input validation in Splittable::Normalize class
+  * Improved error messages for better developer experience
+  * All existing functionality preserved and thoroughly tested
+
+  *Marcelo Toledo*
+
+## splittable 0.0.8 (Oct 14, 2025)
 
 * **Documentation Improvements**
   * Complete README.md rewrite with better examples and real-world use cases

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    splittable (0.0.8)
+    splittable (0.0.10)
       bigdecimal (~> 3.0)
 
 GEM
@@ -13,7 +13,7 @@ GEM
     coderay (1.1.3)
     diff-lcs (1.6.2)
     docile (1.4.1)
-    json (2.15.1)
+    json (2.19.9)
     language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
     method_source (1.1.0)

data/README.md

@@ -52,7 +52,7 @@ Split a total value into equal installments:
 ```ruby
 # Basic usage - split $0.12 into 3 equal parts
 Splittable.division(value: 0.12, quantity: 3)
-# => [0.05, 0.03, 0.03]  # Sum: 0.11 (truncated from 0.12)
+# => [0.04, 0.04, 0.04]  # Sum: 0.12
 
 # Custom precision - 3 decimal places
 Splittable.division(value: 10, quantity: 3, precision: 3)
@@ -79,7 +79,7 @@ Splittable.normalize(value: 100, installments: [33.333, 33.333, 33.333], precisi
 ```ruby
 # Split a $99.99 order into 3 monthly payments
 payments = Splittable.division(value: 99.99, quantity: 3)
-# => [33.34, 33.33, 33.33]
+# => [33.33, 33.33, 33.33]
 # Total: $99.99 ✅
 ```
 
@@ -89,17 +89,17 @@ payments = Splittable.division(value: 99.99, quantity: 3)
 departments = ['Sales', 'Marketing', 'Support']
 amounts = [400.00, 350.00, 250.00]
 
-normalized = Splittable.normalize(value: 1000.00, installments: amounts)
+normalized = Splittable.normalize(value: 1000.01, installments: amounts)
 # => [400.01, 350.00, 250.00]
-# Total: $1,000.00 ✅
+# Total: $1,000.01 ✅
 ```
 
 ### Subscription Billing
 ```ruby
 # Annual subscription split into monthly payments
-monthly_payment = Splittable.division(value: 120.00, quantity: 12)
+monthly_payment = Splittable.division(value: 120.01, quantity: 12)
 # => [10.01, 10.00, 10.00, 10.00, 10.00, 10.00, 10.00, 10.00, 10.00, 10.00, 10.00, 10.00]
-# Total: $120.00 ✅
+# Total: $120.01 ✅
 ```
 
 ## ⚠️ Error Handling
@@ -111,7 +111,11 @@ Splittable.division(value: 100, quantity: 0)
 
 # Empty installments array
 Splittable.normalize(value: 100, installments: [])
-# => NoMethodError: undefined method `[]' for nil:NilClass
+# => ArgumentError: installments should be a non-empty array
+
+# Nil installments
+Splittable.normalize(value: 100, installments: nil)
+# => ArgumentError: installments should be a non-empty array
 ```
 
 ## 🛠️ Development

data/lib/splittable/normalize.rb

@@ -2,6 +2,7 @@
 
 class Splittable::Normalize
   def initialize(value:, installments:, precision: 2)
+    check_installments_validity!(installments)
     @value = BigDecimal(value, 15).truncate(precision)
     @installments = installments.map { |installment| BigDecimal(installment.round(precision), 15) }
   end
@@ -17,4 +18,10 @@ class Splittable::Normalize
 
   attr_reader :value
   attr_accessor :installments
+
+  def check_installments_validity!(installments)
+    return if installments.is_a?(Array) && !installments.empty?
+
+    raise ArgumentError, 'installments should be a non-empty array'
+  end
 end

data/lib/splittable/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Splittable
-  VERSION = '0.0.8'
+  VERSION = '0.0.10'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: splittable
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.10
 platform: ruby
 authors:
 - Arthur Brandão