splittable 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 833ea6cdda26baeca68d106309a33f14b4d74e65455c3435325c38763b192634
-  data.tar.gz: e9b7541a8c607ef61391d0df865153fa2ed7e5096a8d7a549f27203c34a5c67e
+  metadata.gz: 9f9785e87a5381e8601e2c63b84d374222701bbfafeec4ba879a671fca0d9334
+  data.tar.gz: e5c9df2e54ff33850e2efec6dcd766dc611509f5a5db5be1fbe2d40ddefb34d0
 SHA512:
-  metadata.gz: b34f0da34a89af96d72927ae40e0c12dc35bd11de7b8f5ca9003973bfb557e23ec29b6b6b0cdcd7f349c708730440205df816500431de81fd1fddeb0240a3fe0
-  data.tar.gz: 3353de9bba0f637aede703abe8cceacb597632f661430ba337a8fad541293b821567bce9c34a313dd99dc8e43afbd9f9ef5243c51e13f4c3ddde0a6034cb8a66
+  metadata.gz: c8b7795e1266f819dd59b10532b0c981f04568a7bac3162a48e5d43384ef083d84322ab2639aa704eb26f7687d472f5d47489de15a2c550a8a5cf2405542184e
+  data.tar.gz: c6f575e57453fcf85d2b2c98accd8a3f4bfc969f73c8f0e19dbbef950e134f658c8904b413f65c37489c6ecdcda8cb234008db5ed24ba822090d385fc2d2a634

data/.github/workflows/publish_release.yml

@@ -0,0 +1,22 @@
+name: Publish Gem
+
+on:
+  push:
+    branches:
+      - master
+    tags:
+      - v*
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v1
+
+      - name: Release Gem
+        if: contains(github.ref, 'refs/tags/v')
+        uses: cadwallion/publish-rubygems-action@master
+        env:
+          GITHUB_TOKEN: ${{secrets.BUNDLE_GITHUB__COM}}
+          RUBYGEMS_API_KEY: ${{secrets.RUBYGEMS_RELEASE}}
+          RELEASE_COMMAND: bundle exec rake release

data/.github/workflows/ruby.yml

@@ -10,24 +10,27 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [ '2.5', '2.6', '2.7', '3.0' ]
 
     steps:
     - uses: actions/checkout@v2
 
     - name: Set up Ruby version specified in `.ruby-version`
       with:
-          ruby-version: 2.6.6
+          ruby-version: ${{ matrix.ruby }}
       uses: eregon/use-ruby-action@master
 
     - name: Install dependencies
       run:  bundle install --jobs 4 --retry 3
 
-    - name: Run Rubocop
+    - name: Run tests with RSpec
       env:
         RAILS_ENV: test
-      run: bundle exec rubocop --config .rubocop.yml
+      run: bundle exec rspec
 
-    - name: Run tests with RSpec
+    - name: Run Rubocop
       env:
         RAILS_ENV: test
-      run: bundle exec rspec
+      run: bundle exec rubocop --config .rubocop.yml

data/.ruby-version

@@ -1 +1 @@
-2.6.6
+3.0.0

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## splittable 0.0.3 (Jan 29, 2021)
+
+* Separate Division code
+* Separate Normalize code
+* Update actions to use ruby versions 2.5, 2.6 and 3.0
+* Add badge to README.md
+* Updated some gems versions
+
+  *Eduardo Fiorezi, Marcelo Toledo*
+
 ## splittable 0.0.2 (Jan 25, 2021)
 
 * Update description for rubygems.org

data/Gemfile

@@ -2,10 +2,9 @@
 
 source 'https://rubygems.org'
 
-ruby '2.6.6'
-
 gemspec
 
+gem 'bigdecimal', '~> 3.0'
 gem 'pry-byebug', '~> 3.9'
 gem 'rake', '~> 13.0.3'
 gem 'rspec', '~> 3.10'

data/Gemfile.lock

@@ -1,12 +1,13 @@
 PATH
   remote: .
   specs:
-    splittable (0.0.2)
+    splittable (0.0.3)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    ast (2.4.1)
+    ast (2.4.2)
+    bigdecimal (3.0.0)
     byebug (11.1.3)
     coderay (1.1.3)
     diff-lcs (1.4.4)
@@ -34,11 +35,11 @@ GEM
     rspec-expectations (3.10.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
-    rspec-mocks (3.10.1)
+    rspec-mocks (3.10.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
-    rspec-support (3.10.1)
-    rubocop (1.8.1)
+    rspec-support (3.10.2)
+    rubocop (1.9.0)
       parallel (~> 1.10)
       parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
@@ -47,7 +48,7 @@ GEM
       rubocop-ast (>= 1.2.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.4.0)
+    rubocop-ast (1.4.1)
       parser (>= 2.7.1.5)
     rubocop-performance (1.9.2)
       rubocop (>= 0.90.0, < 2.0)
@@ -70,6 +71,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  bigdecimal (~> 3.0)
   pry-byebug (~> 3.9)
   rake (~> 13.0.3)
   rspec (~> 3.10)
@@ -80,8 +82,5 @@ DEPENDENCIES
   simplecov
   splittable!
 
-RUBY VERSION
-   ruby 2.6.6p146
-
 BUNDLED WITH
-   2.2.5
+   2.2.7

data/README.md

@@ -1,6 +1,7 @@
 # Splittable
 
 [![Gem Version](https://badge.fury.io/rb/splittable.svg)](https://badge.fury.io/rb/splittable)
+[![Ruby](https://github.com/Pagnet/splittable/workflows/Ruby/badge.svg?branch=master)](https://github.com/Pagnet/splittable/actions?query=workflow%3ARuby)
 
 ## Goal
 

data/lib/splittable.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 require 'splittable/version'
+require 'splittable/division'
+require 'splittable/normalize'
 require 'bigdecimal/util'
 
 module Splittable
@@ -8,40 +10,13 @@ module Splittable
     # receive total value and to quantity installments are required to equal division
     # just the first installment will receive the difference cents
     def division(value:, quantity:)
-      convert_params!(value: value, quantity: quantity)
-      params_validation!(@quantity)
-      partial_value = (@value / @quantity).truncate(2)
-      decimal_difference = @value - (@quantity * partial_value)
-      installments = [partial_value] * @quantity
-      installments[0] += decimal_difference
-
-      installments
+      Splittable::Division.new(value: value, quantity: quantity).call
     end
 
     # receive total value and specific value of installments are required to specific division
     # just the first installment will receive the difference cents
     def normalize(value:, installments:)
-      convert_params!(value: value, installments: installments)
-      decimal_difference = @value - @installments.sum
-      @installments[0] += decimal_difference
-
-      @installments
-    end
-
-    private
-
-    attr_accessor :value, :quantity, :installments
-
-    def params_validation!(quantity)
-      return if quantity.positive?
-
-      raise ArgumentError, 'quantity should be positive'
-    end
-
-    def convert_params!(value: nil, quantity: nil, installments: nil)
-      @value = BigDecimal(value.truncate(2), 15) unless value.nil?
-      @quantity = BigDecimal(quantity.to_i, 15) unless quantity.nil?
-      @installments = installments.map { |installment| BigDecimal(installment.round(2), 15) } unless installments.nil?
+      Splittable::Normalize.new(value: value, installments: installments).call
     end
   end
 end

data/lib/splittable/division.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+class Splittable::Division
+  def initialize(value:, quantity:)
+    @value = BigDecimal(value, 15).truncate(2)
+    @quantity = BigDecimal(quantity.to_i, 15)
+
+    check_quantity_as_positive_value!
+  end
+
+  def call
+    partial_value = (value / quantity).truncate(2)
+    installments = [partial_value] * quantity
+    installments[0] += value - installments.sum.to_d
+
+    installments
+  end
+
+  private
+
+  attr_reader :value, :quantity
+
+  def check_quantity_as_positive_value!
+    return if quantity.positive?
+
+    raise ArgumentError, 'quantity should be positive'
+  end
+end

data/lib/splittable/normalize.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+class Splittable::Normalize
+  def initialize(value:, installments:)
+    @value = BigDecimal(value, 15).truncate(2)
+    @installments = installments.map { |installment| BigDecimal(installment.round(2), 15) }
+  end
+
+  def call
+    decimal_difference = value - installments.sum
+    installments[0] += decimal_difference
+
+    installments
+  end
+
+  private
+
+  attr_reader :value
+  attr_accessor :installments
+end

data/lib/splittable/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Splittable
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: splittable
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Arthur Brandão
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-01-25 00:00:00.000000000 Z
+date: 2021-01-29 00:00:00.000000000 Z
 dependencies: []
 description: |-
   This gem solves the problem of several decimal places in divisions
@@ -27,6 +27,7 @@ files:
 - ".github/ISSUE_TEMPLATE/feature_request.md"
 - ".github/ISSUE_TEMPLATE/security_vulnerability.md"
 - ".github/PULL_REQUEST_TEMPLATE.md"
+- ".github/workflows/publish_release.yml"
 - ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".rspec"
@@ -43,6 +44,8 @@ files:
 - bin/console
 - bin/setup
 - lib/splittable.rb
+- lib/splittable/division.rb
+- lib/splittable/normalize.rb
 - lib/splittable/version.rb
 - sonar-project.properties
 - splittable.gemspec
@@ -68,7 +71,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.2.3
 signing_key:
 specification_version: 4
 summary: Calculate division and normalize parcels to use just cents.