splitclient-rb 8.1.0 → 8.1.1.pre.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e304e437ef6cbdc7601d4ac6cd5742703c1baf015a86b3d7ef5b6958d3a3e867
-  data.tar.gz: 13f206da6a357e65c6cbaefca0b90fb6a23fe813a80c64a6c4eef17f5cd1591b
+  metadata.gz: cb58331fe788f44a387c77cd0afce468c915879e55c5920d4bf20b11273b41bd
+  data.tar.gz: a5b310fe842ad026159aa6c8a16688cac72e73bb69188599da619e17d1a0a183
 SHA512:
-  metadata.gz: 8864034ff26d345e5d0714a4d105ecd85c08d177d0d0c6bd44ecf888676aa392e760790e7d4ec6d2e88d41090c42ff30655263d75f32325923a77256e7e9dc46
-  data.tar.gz: 1656f587c406c3828712e0eebc56a80892e57ba26ded821e0184ee532246c44e494af600d0234d2ecfb209e8517a24f2a73eb4c8c2be0f94425fd2420a18b7ff
+  metadata.gz: 41b224700eea9145c2510771edb30d8db6c75c1591b5095ee6c7636d4342b9600d63bd4435aab90c350ed899eda2f3865ac9965dd738c8dbca8fb70731a45e14
+  data.tar.gz: 984ee7cc0b3d3994ae6b050c837717d40d6c1d2fc7587f22ee28b9f6ef09947427ab6b1e4e588dfe14a62c4eea2c940d74ae7a7d4f2191bba1ada5c3718e4bfa

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright © 2022 Split Software, Inc.
+Copyright © 2023 Split Software, Inc.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

data/lib/splitclient-rb/cache/adapters/redis_adapter.rb

@@ -99,7 +99,7 @@ module SplitIoClient
         alias find_sets_by_prefix find_strings_by_prefix
 
         def add_to_set(key, val)
-          @redis.sadd(key, val)
+          @redis.sadd?(key, val)
         end
 
         def delete_from_set(key, val)

data/lib/splitclient-rb/cache/senders/impressions_adapter/redis_sender.rb

@@ -14,12 +14,13 @@ module SplitIoClient
         def record_uniques_key(uniques)
           return if uniques.nil? || uniques == {}
 
-          formatted = uniques_formatter(uniques).to_json
-
-          unless formatted.nil?
-            size = @adapter.add_to_queue(unique_keys_key, formatted)
-            @adapter.expire(unique_keys_key, EXPIRE_SECONDS) if formatted.size == size
+          size = @adapter.redis.pipelined do |pipeline|
+            uniques.each do |key, value|
+              pipeline.rpush(unique_keys_key, { f: key, ks: value.to_a }.to_json)
+            end
           end
+
+          @adapter.expire(unique_keys_key, EXPIRE_SECONDS) if uniques.length == size.last
         rescue StandardError => e
           @config.log_found_exception(__method__.to_s, e)
         end
@@ -54,23 +55,6 @@ module SplitIoClient
         def unique_keys_key
           "#{@config.redis_namespace}.uniquekeys"
         end
-
-        def uniques_formatter(uniques)
-          return if uniques.nil? || uniques.empty?
-
-          to_return = []
-          uniques.each do |key, value|
-            to_return << {
-              f: key,
-              k: value.to_a
-            }
-          end
-
-          to_return
-        rescue StandardError => e
-          @config.log_found_exception(__method__.to_s, e)
-          nil
-        end
       end
     end
   end

data/lib/splitclient-rb/engine/auth_api_client.rb

@@ -59,11 +59,7 @@ module SplitIoClient
 
       def process_success(response, start)
         @config.logger.debug("Success connection to: #{@config.auth_service_url}") if @config.debug_enabled
-
-        bucket = BinarySearchLatencyTracker.get_bucket((Time.now - start) * 1000.0)
-        @telemetry_runtime_producer.record_sync_latency(Telemetry::Domain::Constants::TOKEN_SYNC, bucket)
-        timestamp = (Time.now.to_f * 1000.0).to_i
-        @telemetry_runtime_producer.record_successful_sync(Telemetry::Domain::Constants::TOKEN_SYNC, timestamp)
+        record_telemetry(start)
 
         body_json = JSON.parse(response.body, symbolize_names: true)
         push_enabled = body_json[:pushEnabled]
@@ -77,7 +73,7 @@ module SplitIoClient
           @telemetry_runtime_producer.record_token_refreshes
         end
 
-        { push_enabled: push_enabled, token: token, channels: channels, exp: exp, retry: false }
+        { push_enabled: push_enabled, token: token, channels: channels, exp: exp, retry: true }
       end
 
       def control_channels(channels_string)
@@ -88,6 +84,13 @@ module SplitIoClient
 
         channels_string.gsub(control_sec, "#{prefix}#{control_sec}")
       end
+
+      def record_telemetry(start)
+        bucket = BinarySearchLatencyTracker.get_bucket((Time.now - start) * 1000.0)
+        @telemetry_runtime_producer.record_sync_latency(Telemetry::Domain::Constants::TOKEN_SYNC, bucket)
+        timestamp = (Time.now.to_f * 1000.0).to_i
+        @telemetry_runtime_producer.record_successful_sync(Telemetry::Domain::Constants::TOKEN_SYNC, timestamp)
+      end
     end
   end
 end

data/lib/splitclient-rb/engine/back_off.rb

@@ -2,7 +2,7 @@
 
 module SplitIoClient
   module Engine
-    BACKOFF_MAX_ALLOWED = 1.8
+    BACKOFF_MAX_ALLOWED = 1800
     class BackOff
       def initialize(back_off_base, attempt = 0, max_allowed = BACKOFF_MAX_ALLOWED)
         @attempt = attempt

data/lib/splitclient-rb/engine/push_manager.rb

@@ -14,7 +14,6 @@ module SplitIoClient
 
       def start_sse
         response = @auth_api_client.authenticate(@api_key)
-
         @config.logger.debug("Auth service response push_enabled: #{response[:push_enabled]}") if @config.debug_enabled
 
         if response[:push_enabled] && @sse_handler.start(response[:token], response[:channels])
@@ -26,7 +25,6 @@ module SplitIoClient
         end
 
         stop_sse
-
         schedule_next_token_refresh(@back_off.interval) if response[:retry]
         false
       rescue StandardError => e
@@ -35,7 +33,8 @@ module SplitIoClient
 
       def stop_sse
         @sse_handler.stop
-        SplitIoClient::Helpers::ThreadHelper.stop(:schedule_next_token_refresh, @config)
+      rescue StandardError => e
+        @config.logger.error(e.inspect)
       end
 
       private

data/lib/splitclient-rb/engine/synchronizer.rb

@@ -6,8 +6,6 @@ module SplitIoClient
       include SplitIoClient::Cache::Fetchers
       include SplitIoClient::Cache::Senders
 
-      ON_DEMAND_FETCH_BACKOFF_BASE_SECONDS = 10
-      ON_DEMAND_FETCH_BACKOFF_MAX_WAIT_SECONDS = 60
       ON_DEMAND_FETCH_BACKOFF_MAX_RETRIES = 10
 
       def initialize(
@@ -27,6 +25,9 @@ module SplitIoClient
         @telemetry_synchronizer = params[:telemetry_synchronizer]
         @impressions_sender_adapter = params[:impressions_sender_adapter]
         @unique_keys_tracker = params[:unique_keys_tracker]
+
+        @splits_sync_backoff = Engine::BackOff.new(10, 0, 60)
+        @segments_sync_backoff = Engine::BackOff.new(10, 0, 60)
       end
 
       def sync_all(asynchronous = true)
@@ -140,7 +141,7 @@ module SplitIoClient
 
       def attempt_segment_sync(name, target_cn, fetch_options, max_retries, retry_delay_seconds, with_backoff)
         remaining_attempts = max_retries
-        backoff = Engine::BackOff.new(ON_DEMAND_FETCH_BACKOFF_BASE_SECONDS, 0, ON_DEMAND_FETCH_BACKOFF_MAX_WAIT_SECONDS) if with_backoff
+        @segments_sync_backoff.reset
 
         loop do
           remaining_attempts -= 1
@@ -150,14 +151,14 @@ module SplitIoClient
           return sync_result(true, remaining_attempts) if target_cn <= @segments_repository.get_change_number(name).to_i
           return sync_result(false, remaining_attempts) if remaining_attempts <= 0
 
-          delay = with_backoff ? backoff.interval : retry_delay_seconds
+          delay = with_backoff ? @segments_sync_backoff.interval : retry_delay_seconds
           sleep(delay)
         end
       end
 
       def attempt_splits_sync(target_cn, fetch_options, max_retries, retry_delay_seconds, with_backoff)
         remaining_attempts = max_retries
-        backoff = Engine::BackOff.new(ON_DEMAND_FETCH_BACKOFF_BASE_SECONDS, 0, ON_DEMAND_FETCH_BACKOFF_MAX_WAIT_SECONDS) if with_backoff
+        @splits_sync_backoff.reset
 
         loop do
           remaining_attempts -= 1
@@ -167,7 +168,7 @@ module SplitIoClient
           return sync_result(true, remaining_attempts, result[:segment_names]) if target_cn <= @splits_repository.get_change_number
           return sync_result(false, remaining_attempts, result[:segment_names]) if remaining_attempts <= 0
 
-          delay = with_backoff ? backoff.interval : retry_delay_seconds
+          delay = with_backoff ? @splits_sync_backoff.interval : retry_delay_seconds
           sleep(delay)
         end
       end

data/lib/splitclient-rb/split_config.rb

@@ -117,7 +117,7 @@ module SplitIoClient
 
       @counter_refresh_rate = SplitConfig.default_counter_refresh_rate(@cache_adapter)
 
-      @sdk_start_time = Time.now
+      @sdk_start_time = Time.now.to_f
 
       @on_demand_fetch_retry_delay_seconds = SplitConfig.default_on_demand_fetch_retry_delay_seconds
       @on_demand_fetch_max_retries = SplitConfig.default_on_demand_fetch_max_retries

data/lib/splitclient-rb/telemetry/domain/structs.rb

@@ -13,9 +13,10 @@ module SplitIoClient
     # s: sdkUrl, e: eventsUrl, a: authUrl, st: streamUrl, t: telemetryUrl
     UrlOverrides = Struct.new(:s, :e, :a, :st, :t)
 
-    # om: operationMode, se: streamingEnabled, st: storage, rr: refreshRate, uo: urlOverrides, iq: impressionsQueueSize,
-    # eq: eventsQueueSize, im: impressionsMode, il: impressionListenerEnabled, hp: httpProxyDetected, af: activeFactories,
-    # rf: redundantActiveFactories, tr: timeUntilSdkReady, bt: burTimeouts, nr: sdkNotReadyUsage, t: tags, i: integrations
+    # om: operationMode, st: storage, af: activeFactories, rf: redundantActiveFactories, t: tags, se: streamingEnabled,
+    # rr: refreshRate, uo: urlOverrides, iq: impressionsQueueSize, eq: eventsQueueSize, im: impressionsMode,
+    # il: impressionListenerEnabled, hp: httpProxyDetected, tr: timeUntilSdkReady, bt: burTimeouts,
+    # nr: sdkNotReadyUsage, i: integrations
     ConfigInit = Struct.new(:om, :st, :af, :rf, :t, :se, :rr, :uo, :iq, :eq, :im, :il, :hp, :tr, :bt, :nr, :i)
 
     # ls: lastSynchronization, ml: clientMethodLatencies, me: clientMethodExceptions, he: httpErros, hl: httpLatencies,

data/lib/splitclient-rb/telemetry/memory/memory_synchronizer.rb

@@ -56,6 +56,7 @@ module SplitIoClient
 
         active_factories ||= SplitIoClient.split_factory_registry.active_factories
         redundant_active_factories ||= SplitIoClient.split_factory_registry.redundant_active_factories
+        time_until_ready ||= ((Time.now.to_f - @config.sdk_start_time) * 1000.0).to_i
 
         init_config = ConfigInit.new(mode,
                                      'memory',
@@ -70,7 +71,7 @@ module SplitIoClient
                                      impressions_mode,
                                      !@config.impression_listener.nil?,
                                      http_proxy_detected?,
-                                     time_until_ready || Time.now.to_i - @config.sdk_start_time.to_i,
+                                     time_until_ready,
                                      @telemetry_init_consumer.bur_timeouts,
                                      @telemetry_init_consumer.non_ready_usages)
 

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '8.1.0'
+  VERSION = '8.1.1.pre.rc2'
 end

data/splitclient-rb.gemspec

@@ -57,7 +57,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'jwt', '>= 1.0.0', '< 3.0'
   spec.add_runtime_dependency 'lru_redux', '~> 1.1'
   spec.add_runtime_dependency 'net-http-persistent', '>= 2.9', '< 5.0'
-  spec.add_runtime_dependency 'redis', '>= 4.0.0', '< 5.0'
+  spec.add_runtime_dependency 'redis', '>= 4.0.0', '< 6.0'
   spec.add_runtime_dependency 'socketry', '>= 0.4', '< 1.0'
   spec.add_runtime_dependency 'thread_safe', '~> 0.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 8.1.0
+  version: 8.1.1.pre.rc2
 platform: ruby
 authors:
 - Split Software
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-10-05 00:00:00.000000000 Z
+date: 2023-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: allocation_stats
@@ -343,7 +343,7 @@ dependencies:
         version: 4.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -353,7 +353,7 @@ dependencies:
         version: 4.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: socketry
   requirement: !ruby/object:Gem::Requirement
@@ -561,9 +561,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.2.3
 signing_key: