splitclient-rb 8.1.0.pre.rc1 → 8.1.1.pre.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 58cff247108a6b989b2a1b480223be0daf64fc6886fbc2a1b59268ab7442eba2
-  data.tar.gz: 18f3b5ecd93a6bfe6434364227a8ef0133d3a3ca45f1b4c996ddc3f528a40a25
+  metadata.gz: 42286a4f760882d4e4e282fb73e5f91e334170496a0a520dc66b74fc09cc865a
+  data.tar.gz: af0cf2df37ed010480a6afa9347771c5171aab05a72862beaaeb828420f21cf7
 SHA512:
-  metadata.gz: f8021b8b3b2198e19f2d42844ee7b562db985875847d6c9cc50f31d10f19492f445c47b8ead7adfaf670897ec35cc1dbc9c2eb2529f896d4cdecd448de84f23a
-  data.tar.gz: 46544185b5e88d767f2683087e37002ca431544ab04e4fa93caac3b877f92f401fa594ae2609da94f00c725c2c8bb100ba795fe793538c1504eff50cc56d58b4
+  metadata.gz: d8c881603f01063b3348f3a0aefd1c8c4c1c969368b7a01efd0963f2b75c282c30b360572f0994b980b7388a0e12707dcf260725b1547134c900c94a33cad796
+  data.tar.gz: 249b86bc974f7633148986c3b160e2fcc69ce81eaa073a0aaa7d79ae2e3fa48a27e74bbef99aff334084357fc5d1ffd8d15a8828674dcb0f13c4891405a07f9b

data/CHANGES.txt

@@ -1,6 +1,6 @@
 CHANGES
 
-8.1.0 (Oct 3, 2022)
+8.1.0 (Oct 5, 2022)
 - Added a new impressions mode for the SDK called NONE , to be used in factory when there is no desire to capture impressions on an SDK factory to feed Split's analytics engine. Running NONE mode, the SDK will only capture unique keys evaluated for a particular feature flag instead of full blown impressions.
 
 8.0.1 (Jul 20, 2022)

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright © 2022 Split Software, Inc.
+Copyright © 2023 Split Software, Inc.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

data/lib/splitclient-rb/cache/senders/impressions_adapter/redis_sender.rb

@@ -14,12 +14,12 @@ module SplitIoClient
         def record_uniques_key(uniques)
           return if uniques.nil? || uniques == {}
 
-          formatted = uniques_formatter(uniques).to_json
-
-          unless formatted.nil?
-            size = @adapter.add_to_queue(unique_keys_key, formatted)
-            @adapter.expire(unique_keys_key, EXPIRE_SECONDS) if formatted.size == size
+          size = 0
+          uniques.each do |key, value|
+            size = @adapter.add_to_queue(unique_keys_key, { f: key, ks: value.to_a }.to_json)
           end
+
+          @adapter.expire(unique_keys_key, EXPIRE_SECONDS) if uniques.length == size
         rescue StandardError => e
           @config.log_found_exception(__method__.to_s, e)
         end
@@ -54,23 +54,6 @@ module SplitIoClient
         def unique_keys_key
           "#{@config.redis_namespace}.uniquekeys"
         end
-
-        def uniques_formatter(uniques)
-          return if uniques.nil? || uniques.empty?
-
-          to_return = []
-          uniques.each do |key, value|
-            to_return << {
-              f: key,
-              k: value.to_a
-            }
-          end
-
-          to_return
-        rescue StandardError => e
-          @config.log_found_exception(__method__.to_s, e)
-          nil
-        end
       end
     end
   end

data/lib/splitclient-rb/engine/auth_api_client.rb

@@ -59,11 +59,7 @@ module SplitIoClient
 
       def process_success(response, start)
         @config.logger.debug("Success connection to: #{@config.auth_service_url}") if @config.debug_enabled
-
-        bucket = BinarySearchLatencyTracker.get_bucket((Time.now - start) * 1000.0)
-        @telemetry_runtime_producer.record_sync_latency(Telemetry::Domain::Constants::TOKEN_SYNC, bucket)
-        timestamp = (Time.now.to_f * 1000.0).to_i
-        @telemetry_runtime_producer.record_successful_sync(Telemetry::Domain::Constants::TOKEN_SYNC, timestamp)
+        record_telemetry(start)
 
         body_json = JSON.parse(response.body, symbolize_names: true)
         push_enabled = body_json[:pushEnabled]
@@ -77,7 +73,7 @@ module SplitIoClient
           @telemetry_runtime_producer.record_token_refreshes
         end
 
-        { push_enabled: push_enabled, token: token, channels: channels, exp: exp, retry: false }
+        { push_enabled: push_enabled, token: token, channels: channels, exp: exp, retry: true }
       end
 
       def control_channels(channels_string)
@@ -88,6 +84,13 @@ module SplitIoClient
 
         channels_string.gsub(control_sec, "#{prefix}#{control_sec}")
       end
+
+      def record_telemetry(start)
+        bucket = BinarySearchLatencyTracker.get_bucket((Time.now - start) * 1000.0)
+        @telemetry_runtime_producer.record_sync_latency(Telemetry::Domain::Constants::TOKEN_SYNC, bucket)
+        timestamp = (Time.now.to_f * 1000.0).to_i
+        @telemetry_runtime_producer.record_successful_sync(Telemetry::Domain::Constants::TOKEN_SYNC, timestamp)
+      end
     end
   end
 end

data/lib/splitclient-rb/engine/back_off.rb

@@ -2,7 +2,7 @@
 
 module SplitIoClient
   module Engine
-    BACKOFF_MAX_ALLOWED = 1.8
+    BACKOFF_MAX_ALLOWED = 1800
     class BackOff
       def initialize(back_off_base, attempt = 0, max_allowed = BACKOFF_MAX_ALLOWED)
         @attempt = attempt

data/lib/splitclient-rb/engine/push_manager.rb

@@ -14,7 +14,6 @@ module SplitIoClient
 
       def start_sse
         response = @auth_api_client.authenticate(@api_key)
-
         @config.logger.debug("Auth service response push_enabled: #{response[:push_enabled]}") if @config.debug_enabled
 
         if response[:push_enabled] && @sse_handler.start(response[:token], response[:channels])
@@ -26,7 +25,6 @@ module SplitIoClient
         end
 
         stop_sse
-
         schedule_next_token_refresh(@back_off.interval) if response[:retry]
         false
       rescue StandardError => e
@@ -35,7 +33,8 @@ module SplitIoClient
 
       def stop_sse
         @sse_handler.stop
-        SplitIoClient::Helpers::ThreadHelper.stop(:schedule_next_token_refresh, @config)
+      rescue StandardError => e
+        @config.logger.error(e.inspect)
       end
 
       private

data/lib/splitclient-rb/engine/synchronizer.rb

@@ -6,8 +6,6 @@ module SplitIoClient
       include SplitIoClient::Cache::Fetchers
       include SplitIoClient::Cache::Senders
 
-      ON_DEMAND_FETCH_BACKOFF_BASE_SECONDS = 10
-      ON_DEMAND_FETCH_BACKOFF_MAX_WAIT_SECONDS = 60
       ON_DEMAND_FETCH_BACKOFF_MAX_RETRIES = 10
 
       def initialize(
@@ -27,6 +25,9 @@ module SplitIoClient
         @telemetry_synchronizer = params[:telemetry_synchronizer]
         @impressions_sender_adapter = params[:impressions_sender_adapter]
         @unique_keys_tracker = params[:unique_keys_tracker]
+
+        @splits_sync_backoff = Engine::BackOff.new(10, 0, 60)
+        @segments_sync_backoff = Engine::BackOff.new(10, 0, 60)
       end
 
       def sync_all(asynchronous = true)
@@ -140,7 +141,7 @@ module SplitIoClient
 
       def attempt_segment_sync(name, target_cn, fetch_options, max_retries, retry_delay_seconds, with_backoff)
         remaining_attempts = max_retries
-        backoff = Engine::BackOff.new(ON_DEMAND_FETCH_BACKOFF_BASE_SECONDS, 0, ON_DEMAND_FETCH_BACKOFF_MAX_WAIT_SECONDS) if with_backoff
+        @segments_sync_backoff.reset
 
         loop do
           remaining_attempts -= 1
@@ -150,14 +151,14 @@ module SplitIoClient
           return sync_result(true, remaining_attempts) if target_cn <= @segments_repository.get_change_number(name).to_i
           return sync_result(false, remaining_attempts) if remaining_attempts <= 0
 
-          delay = with_backoff ? backoff.interval : retry_delay_seconds
+          delay = with_backoff ? @segments_sync_backoff.interval : retry_delay_seconds
           sleep(delay)
         end
       end
 
       def attempt_splits_sync(target_cn, fetch_options, max_retries, retry_delay_seconds, with_backoff)
         remaining_attempts = max_retries
-        backoff = Engine::BackOff.new(ON_DEMAND_FETCH_BACKOFF_BASE_SECONDS, 0, ON_DEMAND_FETCH_BACKOFF_MAX_WAIT_SECONDS) if with_backoff
+        @splits_sync_backoff.reset
 
         loop do
           remaining_attempts -= 1
@@ -167,7 +168,7 @@ module SplitIoClient
           return sync_result(true, remaining_attempts, result[:segment_names]) if target_cn <= @splits_repository.get_change_number
           return sync_result(false, remaining_attempts, result[:segment_names]) if remaining_attempts <= 0
 
-          delay = with_backoff ? backoff.interval : retry_delay_seconds
+          delay = with_backoff ? @splits_sync_backoff.interval : retry_delay_seconds
           sleep(delay)
         end
       end

data/lib/splitclient-rb/split_config.rb

@@ -311,31 +311,17 @@ module SplitIoClient
     end
 
     def init_impressions_mode(impressions_mode, adapter)
-      if adapter == :redis
-        impressions_mode ||= :debug
-
-        case impressions_mode
-        when :optimized
-          return :optimized
-        when :none
-         return :none
-        else
-          @logger.error('You passed an invalid impressions_mode, impressions_mode should be one of the following values: :debug or :optimized. Defaulting to :optimized mode') unless impressions_mode == :optimized
-          return :debug
-        end
-      end
-
-      return :debug if adapter == :redis
-
-      impressions_mode ||= :optimized
       case impressions_mode
-      when :debug
-        return :debug
+      when :optimized
+        return :optimized
       when :none
        return :none
+      when :debug
+        return :debug
       else
-        @logger.error('You passed an invalid impressions_mode, impressions_mode should be one of the following values: :debug or :optimized. Defaulting to :optimized mode') unless impressions_mode == :optimized
-        return :optimized
+        default = adapter == :redis ? :debug : :optimized
+        @logger.error("You passed an invalid impressions_mode, impressions_mode should be one of the following values: :debug, :optimized or :none. Defaulting to #{default} mode")
+        return default
       end
     end
 
@@ -464,7 +450,7 @@ module SplitIoClient
     end
 
     def self.default_features_refresh_rate
-      5
+      60
     end
 
     def self.default_segments_refresh_rate

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '8.1.0.pre.rc1'
+  VERSION = '8.1.1.pre.rc1'
 end

data/splitclient-rb.gemspec

@@ -57,7 +57,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'jwt', '>= 1.0.0', '< 3.0'
   spec.add_runtime_dependency 'lru_redux', '~> 1.1'
   spec.add_runtime_dependency 'net-http-persistent', '>= 2.9', '< 5.0'
-  spec.add_runtime_dependency 'redis', '>= 4.0.0', '< 5.0'
+  spec.add_runtime_dependency 'redis', '>= 4.0.0', '< 6.0'
   spec.add_runtime_dependency 'socketry', '>= 0.4', '< 1.0'
   spec.add_runtime_dependency 'thread_safe', '~> 0.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 8.1.0.pre.rc1
+  version: 8.1.1.pre.rc1
 platform: ruby
 authors:
 - Split Software
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-10-04 00:00:00.000000000 Z
+date: 2023-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: allocation_stats
@@ -343,7 +343,7 @@ dependencies:
         version: 4.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -353,7 +353,7 @@ dependencies:
         version: 4.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: socketry
   requirement: !ruby/object:Gem::Requirement