splitclient-rb 8.0.1-java → 8.1.0.pre.rc1-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a32ab3387865509e36920b5fdad6628b801d6022
-  data.tar.gz: 03171c8afda405b04f367c0933be63ecb83ee4d2
+  metadata.gz: 94b56b28dcd6009d9449f37727d5f1d04f4a7383
+  data.tar.gz: ece8b59ec6f9a453ce6cdd613e9b7a9d6653ce51
 SHA512:
-  metadata.gz: 1f1500e87cd4200c7ee7afa7375bb8879116f65a79f1414dc5009f63e12c2f4ff6792bdbb706b4a82dc184e83ecfab2dc3b0fef58fd7184fbed8cafb4d26817a
-  data.tar.gz: bd8805f46629a25eca16ba1c7d66be129d4649687a4a4248b75735f807dd1af4069bf18be9fafaa58817693ab246b64b4d20c788525432d3496524c53cb1e805
+  metadata.gz: eb5efc14d860c845eb3a40d3717b2abfa138f2a1cd9163c6bb91e27fdfdb03cd4435957a2740d2941f836f579d58d119c27da6cce91272207859d17f15560904
+  data.tar.gz: d449a63d948099d3cafb182cd848da73b1178972aa837721fdfaa03f376d9d1bd34ecedd04973838808edbd580df42bb0d82af83424b4b544cdbe73bd179b43e

data/CHANGES.txt

@@ -1,5 +1,8 @@
 CHANGES
 
+8.1.0 (Oct 3, 2022)
+- Added a new impressions mode for the SDK called NONE , to be used in factory when there is no desire to capture impressions on an SDK factory to feed Split's analytics engine. Running NONE mode, the SDK will only capture unique keys evaluated for a particular feature flag instead of full blown impressions.
+
 8.0.1 (Jul 20, 2022)
 - Updated dependencies to support faraday > 2.0
 
@@ -49,9 +52,10 @@ CHANGES
 - Updated ably error handling. 
 
 7.2.0 (Sep 25, 2020)
-- Added deduplication logic for impressions data.
-  - Now there are two modes for Impressions when the SDK is in standalone mode, OPTIMIZED (default) that only ships unique impressions and DEBUG for times where you need to send ALL impressions to debug an integration.
-  - Impression listener remains unchanged and will still get all impressions.
+- Added impressions dedupe logic to avoid sending duplicated impressions:  
+  - Added `OPTIMIZED` and `DEBUG` modes in order to enabling/disabling how impressions are going to be sent into Split servers,
+    - `OPTIMIZED`: will send unique impressions in a timeframe in order to reduce how many times impressions are posted to Split.
+    - `DEBUG`: will send every impression generated to Split.
 
 7.1.3 (Jul 31, 2020)
 - Updated rake development dependency to ~> 12.3.3.

data/lib/splitclient-rb/cache/senders/impressions_adapter/redis_sender.rb

@@ -12,7 +12,9 @@ module SplitIoClient
         end
 
         def record_uniques_key(uniques)
-          formatted = uniques_formatter(uniques)
+          return if uniques.nil? || uniques == {}
+
+          formatted = uniques_formatter(uniques).to_json
 
           unless formatted.nil?
             size = @adapter.add_to_queue(unique_keys_key, formatted)

data/lib/splitclient-rb/engine/common/impressions_manager.rb

@@ -30,7 +30,8 @@ module SplitIoClient
               @unique_keys_tracker.track(split_name, matching_key)
             else # In OPTIMIZED mode we should track the total amount of evaluations and deduplicate the impressions.
               impression_data[:pt] = @impression_observer.test_and_set(impression_data)
-              @impression_counter.inc(split_name, impression_data[:m])
+
+              @impression_counter.inc(split_name, impression_data[:m]) unless impression_data[:pt].nil?
             end
           rescue StandardError => e
             @config.log_found_exception(__method__.to_s, e)

data/lib/splitclient-rb/split_config.rb

@@ -310,20 +310,29 @@ module SplitIoClient
       10
     end
 
-    def self.default_impressions_mode
-      :optimized
-    end
-
     def init_impressions_mode(impressions_mode, adapter)
-      impressions_mode ||= SplitConfig.default_impressions_mode
+      if adapter == :redis
+        impressions_mode ||= :debug
+
+        case impressions_mode
+        when :optimized
+          return :optimized
+        when :none
+         return :none
+        else
+          @logger.error('You passed an invalid impressions_mode, impressions_mode should be one of the following values: :debug or :optimized. Defaulting to :optimized mode') unless impressions_mode == :optimized
+          return :debug
+        end
+      end
 
       return :debug if adapter == :redis
 
+      impressions_mode ||= :optimized
       case impressions_mode
       when :debug
         return :debug
-      # when :none  // we not support :none impression mode yet. Defaulting to :optimized mode
-      #  return :none
+      when :none
+       return :none
       else
         @logger.error('You passed an invalid impressions_mode, impressions_mode should be one of the following values: :debug or :optimized. Defaulting to :optimized mode') unless impressions_mode == :optimized
         return :optimized

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '8.0.1'
+  VERSION = '8.1.0.pre.rc1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 8.0.1
+  version: 8.1.0.pre.rc1
 platform: java
 authors:
 - Split Software
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-07-20 00:00:00.000000000 Z
+date: 2022-10-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -556,9 +556,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project:
 rubygems_version: 2.6.14