splitclient-rb 7.3.5.pre.rc2-java → 7.3.5.pre.rc5-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4057a9d01946967eb3b35a624eb4456c72c67c4b
-  data.tar.gz: 28ab3e1971b46453a94392bb5c1b2230a9b1c226
+  metadata.gz: 977dd4ad2b5e91d089796e2cc452f18dd1865465
+  data.tar.gz: dba8da2b6f8e25bd670f40588a6c8ce004ac2719
 SHA512:
-  metadata.gz: 1e90fe6953a748f65a96c38b96924821aef9403c52ba525bc5157c4840047c82213c8cb184dae31f2f206841bf028f6d058ab0254df5e7fef0bc9fc0b589a248
-  data.tar.gz: 1b43e98f1e5a400988d2d87e29c5a37075720469b71187f0760019cd9f76850bd2a54fcf084de25ad9c15093a95f7d8e908593051989cc89092c5de03feefcce
+  metadata.gz: 5b874e277d8ed4f803591238f130b1f16b885909f480f97aaf4f007f189d6699ddef901105a622784c9d6a17f18b418db1f284834d4c4367b28e133bc73b1fb3
+  data.tar.gz: 9e955a69fa2d695d65a3b8131c84e413e87ffffb66e927573a85954691f953c36eb6f0149fe772174ec7d0944c35271198d3c3d627b3173fcae0adab32c652f4

data/.github/workflows/ci.yml

@@ -1,10 +1,10 @@
 on:
   push:
     branches:
-      - master
+      - do-not-send-impressions
   pull_request:
     branches:
-      - master
+      - do-not-send-impressions
 
 jobs:
   test:
@@ -21,7 +21,7 @@ jobs:
           fetch-depth: 0
 
       - name: Set up Ruby
-        uses: ruby/setup-ruby@477b21f02be01bcb8030d50f37cfec92bfa615b6
+        uses: ruby/setup-ruby@v1
         with:
           ruby-version: 2.5
 

data/lib/splitclient-rb/cache/senders/impressions_count_sender.rb

@@ -24,7 +24,7 @@ module SplitIoClient
                 sleep(@config.counter_refresh_rate)
                 post_impressions_count                
               end
-            rescue SplitIoClient::SDKShutdownException              
+            rescue SplitIoClient::SDKShutdownException
               post_impressions_count
 
               @config.logger.info('Posting impressions count due to shutdown')

data/lib/splitclient-rb/engine/common/impressions_manager.rb

@@ -9,15 +9,13 @@ module SplitIoClient
                        impression_counter,
                        telemetry_runtime_producer,
                        impression_observer,
-                       unique_keys_tracker,
-                       impression_router)
+                       unique_keys_tracker)
           @config = config
           @impressions_repository = impressions_repository
           @impression_counter = impression_counter
           @impression_observer = impression_observer
           @telemetry_runtime_producer = telemetry_runtime_producer
           @unique_keys_tracker = unique_keys_tracker
-          @impression_router = impression_router
         end
 
         def build_impression(matching_key, bucketing_key, split_name, treatment, params = {})
@@ -58,12 +56,18 @@ module SplitIoClient
             @config.log_found_exception(__method__.to_s, e)
           ensure
             record_stats(stats)
-            @impression_router.add_bulk(impressions)
+            impression_router.add_bulk(impressions)
           end
         end
 
         private
 
+        def impression_router
+          @impression_router ||= SplitIoClient::ImpressionRouter.new(@config)
+        rescue StandardError => error
+          @config.log_found_exception(__method__.to_s, error)
+        end
+
         def record_stats(stats)
           return if redis?
 

data/lib/splitclient-rb/split_config.rb

@@ -51,7 +51,7 @@ module SplitIoClient
 
       @segments_refresh_rate = opts[:segments_refresh_rate] || SplitConfig.default_segments_refresh_rate
 
-      @impressions_mode = init_impressions_mode(opts[:impressions_mode])
+      @impressions_mode = init_impressions_mode(opts[:impressions_mode], opts[:cache_adapter])
 
       @impressions_refresh_rate = SplitConfig.init_impressions_refresh_rate(@impressions_mode, opts[:impressions_refresh_rate], SplitConfig.default_impressions_refresh_rate)
       @impressions_queue_size = opts[:impressions_queue_size] || SplitConfig.default_impressions_queue_size
@@ -314,14 +314,16 @@ module SplitIoClient
       :optimized
     end
 
-    def init_impressions_mode(impressions_mode)
+    def init_impressions_mode(impressions_mode, adapter)
       impressions_mode ||= SplitConfig.default_impressions_mode
 
+      return :debug if adapter == :redis
+
       case impressions_mode
       when :debug
         return :debug
-      when :none
-        return :none
+      # when :none  // we not support :none impression mode yet. Defaulting to :optimized mode
+      #  return :none
       else
         @logger.error('You passed an invalid impressions_mode, impressions_mode should be one of the following values: :debug or :optimized. Defaulting to :optimized mode') unless impressions_mode == :optimized
         return :optimized

data/lib/splitclient-rb/split_factory.rb

@@ -249,8 +249,7 @@ module SplitIoClient
       build_impressions_observer
       build_impression_counter
 
-      impression_router = ImpressionRouter.new(@config)
-      @impressions_manager = Engine::Common::ImpressionManager.new(@config, @impressions_repository, @impression_counter, @runtime_producer, @impression_observer, @unique_keys_tracker, impression_router)
+      @impressions_manager = Engine::Common::ImpressionManager.new(@config, @impressions_repository, @impression_counter, @runtime_producer, @impression_observer, @unique_keys_tracker)
     end
   end
 end

data/lib/splitclient-rb/telemetry/redis/redis_init_producer.rb

@@ -11,12 +11,12 @@ module SplitIoClient
       def record_config(config_data)
         return if config_data.nil?
 
-        data = { m: { i: @config.machine_ip, n: @config.machine_name, s: "#{@config.language}-#{@config.version}" },
-                 t: { oM: config_data.om, st: config_data.st, aF: config_data.af, rF: config_data.rf, t: config_data.t } }
+        data = { t: { oM: config_data.om, st: config_data.st, aF: config_data.af, rF: config_data.rf, t: config_data.t } }
+        field = "#{@config.language}-#{@config.version}/#{@config.machine_name}/#{@config.machine_ip}"
 
-        @adapter.add_to_queue(config_key, data.to_json)
-      rescue StandardError => error
-        @config.log_found_exception(__method__.to_s, error)
+        @adapter.add_to_map(config_key, field, data.to_json)
+      rescue StandardError => e
+        @config.log_found_exception(__method__.to_s, e)
       end
 
       def record_bur_timeout

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '7.3.5.pre.rc2'
+  VERSION = '7.3.5.pre.rc5'
 end

data/splitclient-rb.gemspec

@@ -41,7 +41,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 2.2'
   spec.add_development_dependency 'pry', '~> 0.14'
   spec.add_development_dependency 'pry-nav', '~> 1.0'
-  spec.add_development_dependency 'rake', '~> 12.3'
+  spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rake-compiler', '~> 1.1'
   spec.add_development_dependency 'rspec', '~> 3.10'
   spec.add_development_dependency 'rubocop', '0.59.0'
@@ -49,6 +49,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'simplecov-json', '~> 0.2'
   spec.add_development_dependency 'timecop', '~> 0.9'
   spec.add_development_dependency 'webmock', '~> 3.14'
+  spec.add_development_dependency 'webrick', '~> 1.7'
 
   spec.add_runtime_dependency 'bitarray', '~> 1.3'
   spec.add_runtime_dependency 'concurrent-ruby', '~> 1.0'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 7.3.5.pre.rc2
+  version: 7.3.5.pre.rc5
 platform: java
 authors:
 - Split Software
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-04-07 00:00:00.000000000 Z
+date: 2022-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -85,7 +85,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
   name: rake
   prerelease: false
   type: :development
@@ -93,7 +93,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
@@ -192,6 +192,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.14'
+- !ruby/object:Gem::Dependency
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.7'
+  name: webrick
+  prerelease: false
+  type: :development
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.7'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements: