splitclient-rb 7.3.5.pre.rc1-java → 7.3.5.pre.rc4-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 52ee386fb2542467575c4f58ddfd25b3d33ff33e
-  data.tar.gz: 6a6d7cd53ca3d0c7ad30c8fa8d3621c43e9a63d2
+  metadata.gz: 056032ef5843a8944e848f07d7a75471a193bdba
+  data.tar.gz: 94812fea82d41a99a9537555e3b04f617215807d
 SHA512:
-  metadata.gz: fb3e3c3dac2de8df3994d40bb10ba3dddf1e1ca8ae382a144980ddb8ba61ff76fb4dad4f40ce4755ed0f81e63650f84ca238c9b4c1353db86dfa39891131be88
-  data.tar.gz: f68eb21afac8f031a56eecb358d1e79520f38036b44f20f0596e07163b1cf1c4b50263f419b9388d556d2e919f206bffa17bd4f16e7f25276ba6d592487b3268
+  metadata.gz: 0b792cec62ca90569dbed5bcc8b4bb1a8bd3774add314806c0dc4fa10a09e560fbacf3927453348812f53fffdf88016a60b22fb47c4bb7bbf74d3cbdffd4e27d
+  data.tar.gz: 5b1e2eecf0de9f94bb6248eb145dc206f5927c2a0e068f2c3aeea57894ec358e9afec70409f5f109e3ed67e8de71b89317bc71d5abafa63861d7195e8e9a5c3f

data/lib/splitclient-rb/cache/filter/bloom_filter.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+require 'bitarray'
+
+module SplitIoClient
+  module Cache
+    module Filter
+      class BloomFilter
+        def initialize(capacity, false_positive_probability = 0.001)
+          @capacity = capacity.round
+          m = best_m(capacity, false_positive_probability)
+          @ba = BitArray.new(m.round)
+          @k = best_k(capacity)
+        end
+
+        def add(string)
+          return false if contains?(string)
+
+          positions = hashes(string)
+          
+          positions.each { |position| @ba[position] = 1 }
+
+          true
+        end
+      
+        def contains?(string)
+          !hashes(string).any? { |ea| @ba[ea] == 0 }
+        end
+
+        def clear
+          @ba.size.times { |i| @ba[i] = 0 }
+        end
+      
+        private
+
+        # m is the required number of bits in the array
+        def best_m(capacity, false_positive_probability)
+          -(capacity * Math.log(false_positive_probability)) / (Math.log(2) ** 2)
+        end
+
+        # k is the number of hash functions that minimizes the probability of false positives
+        def best_k(capacity)
+          (Math.log(2) * (@ba.size / capacity)).round
+        end
+
+        def hashes(data)
+          m = @ba.size
+          h = Digest::MD5.hexdigest(data.to_s).to_i(16)
+          x = h % m
+          h /= m
+          y = h % m
+          h /= m
+          z = h % m
+          [x] + 1.upto(@k - 1).collect do |i|
+            x = (x + y) % m
+            y = (y + z) % m
+            x
+          end
+        end
+      end
+    end
+  end
+end

data/lib/splitclient-rb/cache/filter/filter_adapter.rb

@@ -10,13 +10,13 @@ module SplitIoClient
         end
 
         def add(feature_name, key)
-          @filter.insert("#{feature_name}#{key}")
+          @filter.add("#{feature_name}#{key}")
         rescue StandardError => e
           @config.log_found_exception(__method__.to_s, e)
         end
 
         def contains?(feature_name, key)
-          @filter.include?("#{feature_name}#{key}")
+          @filter.contains?("#{feature_name}#{key}")
         rescue StandardError => e
           @config.log_found_exception(__method__.to_s, e)
         end

data/lib/splitclient-rb/engine/common/impressions_manager.rb

@@ -9,15 +9,13 @@ module SplitIoClient
                        impression_counter,
                        telemetry_runtime_producer,
                        impression_observer,
-                       unique_keys_tracker,
-                       impression_router)
+                       unique_keys_tracker)
           @config = config
           @impressions_repository = impressions_repository
           @impression_counter = impression_counter
           @impression_observer = impression_observer
           @telemetry_runtime_producer = telemetry_runtime_producer
           @unique_keys_tracker = unique_keys_tracker
-          @impression_router = impression_router
         end
 
         def build_impression(matching_key, bucketing_key, split_name, treatment, params = {})
@@ -58,12 +56,18 @@ module SplitIoClient
             @config.log_found_exception(__method__.to_s, e)
           ensure
             record_stats(stats)
-            @impression_router.add_bulk(impressions)
+            impression_router.add_bulk(impressions)
           end
         end
 
         private
 
+        def impression_router
+          @impression_router ||= SplitIoClient::ImpressionRouter.new(@config)
+        rescue StandardError => error
+          @config.log_found_exception(__method__.to_s, error)
+        end
+
         def record_stats(stats)
           return if redis?
 

data/lib/splitclient-rb/split_factory.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'bloomfilter-rb'
-
 module SplitIoClient
   class SplitFactory
     ROOT_PROCESS_ID = Process.pid
@@ -218,7 +216,7 @@ module SplitIoClient
         return
       end
 
-      bf = BloomFilter::Native.new(size: 95_850_584, hashes: 2)
+      bf = Cache::Filter::BloomFilter.new(30_000_000)
       filter_adapter = Cache::Filter::FilterAdapter.new(@config, bf)
       cache = Concurrent::Hash.new
       @unique_keys_tracker = Engine::Impressions::UniqueKeysTracker.new(@config, filter_adapter, @impressions_sender_adapter, cache)
@@ -251,8 +249,7 @@ module SplitIoClient
       build_impressions_observer
       build_impression_counter
 
-      impression_router = ImpressionRouter.new(@config)
-      @impressions_manager = Engine::Common::ImpressionManager.new(@config, @impressions_repository, @impression_counter, @runtime_producer, @impression_observer, @unique_keys_tracker, impression_router)
+      @impressions_manager = Engine::Common::ImpressionManager.new(@config, @impressions_repository, @impression_counter, @runtime_producer, @impression_observer, @unique_keys_tracker)
     end
   end
 end

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '7.3.5.pre.rc1'
+  VERSION = '7.3.5.pre.rc4'
 end

data/lib/splitclient-rb.rb

@@ -12,6 +12,7 @@ require 'splitclient-rb/cache/adapters/memory_adapter'
 require 'splitclient-rb/cache/adapters/redis_adapter'
 require 'splitclient-rb/cache/fetchers/segment_fetcher'
 require 'splitclient-rb/cache/fetchers/split_fetcher'
+require 'splitclient-rb/cache/filter/bloom_filter'
 require 'splitclient-rb/cache/filter/filter_adapter'
 require 'splitclient-rb/cache/hashers/impression_hasher'
 require 'splitclient-rb/cache/observers/impression_observer'

data/splitclient-rb.gemspec

@@ -50,7 +50,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'timecop', '~> 0.9'
   spec.add_development_dependency 'webmock', '~> 3.14'
 
-  spec.add_runtime_dependency 'bloomfilter-rb', '~> 2.1'
+  spec.add_runtime_dependency 'bitarray', '~> 1.3'
   spec.add_runtime_dependency 'concurrent-ruby', '~> 1.0'
   spec.add_runtime_dependency 'faraday', '>= 0.8', '< 2.0'
   spec.add_runtime_dependency 'json', '>= 1.8', '< 3.0'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 7.3.5.pre.rc1
+  version: 7.3.5.pre.rc4
 platform: java
 authors:
 - Split Software
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-04-06 00:00:00.000000000 Z
+date: 2022-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -197,15 +197,15 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
-  name: bloomfilter-rb
+        version: '1.3'
+  name: bitarray
   prerelease: false
   type: :runtime
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
@@ -402,6 +402,7 @@ files:
 - lib/splitclient-rb/cache/adapters/redis_adapter.rb
 - lib/splitclient-rb/cache/fetchers/segment_fetcher.rb
 - lib/splitclient-rb/cache/fetchers/split_fetcher.rb
+- lib/splitclient-rb/cache/filter/bloom_filter.rb
 - lib/splitclient-rb/cache/filter/filter_adapter.rb
 - lib/splitclient-rb/cache/hashers/impression_hasher.rb
 - lib/splitclient-rb/cache/observers/impression_observer.rb