splitclient-rb 7.2.3.pre.rc1 → 7.3.0.pre.rc3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f35241d91acb957b2e666ca2598021b66f8214d4d12980484b063723576dc13c
-  data.tar.gz: 1a833d613162de2aa18a3c925de083ddc2013bfe85630d57b2e9483a8364c357
+  metadata.gz: 85d3602c1b6aa514393f464c6032b557de0419e6ba321d3bdf0c3835a55b1db0
+  data.tar.gz: 7ae53a7b87f13ce2a975d71be6dd4bb8a615395d2f2f66b04eb8058573ac10fd
 SHA512:
-  metadata.gz: 231f86643247585e51cbb136790d71011764645edb87383c5641730b4e36952c1013dde5c06fbb46002c05b1fa07579a0b8579a3a4e859cc42862d0d2849316c
-  data.tar.gz: faff2962445b587f133d703ce19fec646a8495fbef7f34d8dd27d38614643bd517acf99d859b613220a4144c4f56be61c1ae048b526ef8e63a92134dfdcbda79
+  metadata.gz: 803c1e761ff1c13a501f47b56641b854efc079ef8732c1a24793b03b691fb1bb9e5fb2a9eddedc819f1458e314dcd37991311f730c2aaf7751ffa7e4c3190141
+  data.tar.gz: 849bfd49993b52ddb222f9c85157088181182539235e6ce36eb74b3a2f3823bc1e4b4b7455d306d08b81678bb60112483e5813e7dd8879b19ca1a19548ac1d44

data/.rubocop.yml

@@ -3,16 +3,26 @@ Documentation:
 
 Metrics/AbcSize:
   Max: 26
+  Exclude:
+    - lib/splitclient-rb/telemetry/memory/memory_synchronizer.rb
 
 Metrics/MethodLength:
   Max: 20
+  Exclude:
+    - lib/splitclient-rb/telemetry/memory/memory_synchronizer.rb
 
 Metrics/ClassLength:
   Max: 150
+  Exclude:
+    - lib/splitclient-rb/telemetry/memory/memory_synchronizer.rb
 
 Metrics/CyclomaticComplexity:
   Max: 8
 
+Metrics/ParameterLists:
+  Exclude:
+    - lib/splitclient-rb/engine/sync_manager.rb
+
 Metrics/LineLength:
   Max: 130
   Exclude:
@@ -20,6 +30,7 @@ Metrics/LineLength:
     - spec/integrations/**/*
     - spec/engine/sync_manager_spec.rb
     - spec/engine/auth_api_client_spec.rb
+    - spec/telemetry/synchronizer_spec.rb
 
 Style/BracesAroundHashParameters:
   Exclude:
@@ -50,3 +61,4 @@ AllCops:
     - lib/splitclient-rb/engine/metrics/**/*
     - lib/splitclient-rb/engine/models/**/*
     - lib/splitclient-rb/engine/parser/**/*
+    - spec/telemetry/synchronizer_spec.rb

data/CHANGES.txt

@@ -1,5 +1,11 @@
 CHANGES
 
+7.2.3 (Feb 24, 2021)
+- Fixed missing segment fetch after an SPLIT_UPDATE.
+- Updated streaming logic to support multiregion.
+- Updated sse client connection logic to read confirmation event.
+- Updated naming of retryable erros.
+
 7.2.2 (Dec 18, 2020)
 - Fixed issue: undefined local variable or method post_impressions_count
 

data/lib/splitclient-rb.rb

@@ -23,12 +23,8 @@ require 'splitclient-rb/cache/repositories/events/memory_repository'
 require 'splitclient-rb/cache/repositories/events/redis_repository'
 require 'splitclient-rb/cache/repositories/impressions/memory_repository'
 require 'splitclient-rb/cache/repositories/impressions/redis_repository'
-require 'splitclient-rb/cache/repositories/metrics_repository'
-require 'splitclient-rb/cache/repositories/metrics/memory_repository'
-require 'splitclient-rb/cache/repositories/metrics/redis_repository'
 require 'splitclient-rb/cache/senders/impressions_formatter'
 require 'splitclient-rb/cache/senders/impressions_sender'
-require 'splitclient-rb/cache/senders/metrics_sender'
 require 'splitclient-rb/cache/senders/events_sender'
 require 'splitclient-rb/cache/senders/impressions_count_sender'
 require 'splitclient-rb/cache/senders/localhost_repo_cleaner'
@@ -51,10 +47,10 @@ require 'splitclient-rb/engine/api/faraday_middleware/gzip'
 require 'splitclient-rb/engine/api/faraday_adapter/patched_net_http_persistent'
 require 'splitclient-rb/engine/api/client'
 require 'splitclient-rb/engine/api/impressions'
-require 'splitclient-rb/engine/api/metrics'
 require 'splitclient-rb/engine/api/segments'
 require 'splitclient-rb/engine/api/splits'
 require 'splitclient-rb/engine/api/events'
+require 'splitclient-rb/engine/api/telemetry_api'
 require 'splitclient-rb/engine/common/impressions_counter'
 require 'splitclient-rb/engine/common/impressions_manager'
 require 'splitclient-rb/engine/parser/condition'
@@ -84,7 +80,6 @@ require 'splitclient-rb/engine/matchers/equal_to_boolean_matcher'
 require 'splitclient-rb/engine/matchers/equal_to_matcher'
 require 'splitclient-rb/engine/matchers/matches_string_matcher'
 require 'splitclient-rb/engine/evaluator/splitter'
-require 'splitclient-rb/engine/metrics/metrics'
 require 'splitclient-rb/engine/metrics/binary_search_latency_tracker'
 require 'splitclient-rb/engine/models/split'
 require 'splitclient-rb/engine/models/label'
@@ -95,9 +90,6 @@ require 'splitclient-rb/engine/sync_manager'
 require 'splitclient-rb/engine/synchronizer'
 require 'splitclient-rb/utilitites'
 
-# redis metrics fixer
-require 'splitclient-rb/redis_metrics_fixer'
-
 # SSE 
 require 'splitclient-rb/sse/event_source/back_off'
 require 'splitclient-rb/sse/event_source/client'
@@ -110,6 +102,29 @@ require 'splitclient-rb/sse/notification_manager_keeper'
 require 'splitclient-rb/sse/notification_processor'
 require 'splitclient-rb/sse/sse_handler'
 
+# Telemetry
+require 'splitclient-rb/telemetry/domain/constants'
+require 'splitclient-rb/telemetry/domain/structs'
+require 'splitclient-rb/telemetry/storages/memory'
+require 'splitclient-rb/telemetry/evaluation_consumer'
+require 'splitclient-rb/telemetry/evaluation_producer'
+require 'splitclient-rb/telemetry/init_consumer'
+require 'splitclient-rb/telemetry/init_producer'
+require 'splitclient-rb/telemetry/runtime_consumer'
+require 'splitclient-rb/telemetry/runtime_producer'
+require 'splitclient-rb/telemetry/sync_task'
+require 'splitclient-rb/telemetry/synchronizer'
+require 'splitclient-rb/telemetry/memory/memory_evaluation_consumer'
+require 'splitclient-rb/telemetry/memory/memory_evaluation_producer'
+require 'splitclient-rb/telemetry/memory/memory_init_consumer'
+require 'splitclient-rb/telemetry/memory/memory_init_producer'
+require 'splitclient-rb/telemetry/memory/memory_runtime_consumer'
+require 'splitclient-rb/telemetry/memory/memory_runtime_producer'
+require 'splitclient-rb/telemetry/memory/memory_synchronizer'
+require 'splitclient-rb/telemetry/redis/redis_evaluation_producer'
+require 'splitclient-rb/telemetry/redis/redis_init_producer'
+require 'splitclient-rb/telemetry/redis/redis_synchronizer'
+
 # C extension
 require 'murmurhash/murmurhash_mri'
 

data/lib/splitclient-rb/cache/adapters/redis_adapter.rb

@@ -17,6 +17,10 @@ module SplitIoClient
           @redis = Redis.new(connection)
         end
 
+        def hincrby(key, field, increment)
+          @redis.hincrby(key, field, increment)
+        end
+
         # Map
         def initialize_map(key)
           # No need to initialize hash/map in Redis

data/lib/splitclient-rb/cache/fetchers/segment_fetcher.rb

@@ -4,13 +4,13 @@ module SplitIoClient
       class SegmentFetcher
         attr_reader :segments_repository
 
-        def initialize(segments_repository, api_key, metrics, config, sdk_blocker = nil)
+        def initialize(segments_repository, api_key, config, sdk_blocker, telemetry_runtime_producer)
           @segments_repository = segments_repository
           @api_key = api_key
-          @metrics = metrics
           @config = config
           @sdk_blocker = sdk_blocker
           @semaphore = Mutex.new
+          @telemetry_runtime_producer = telemetry_runtime_producer
         end
 
         def call
@@ -27,14 +27,22 @@ module SplitIoClient
           end
         end
 
-        def fetch_segment(name)
+        def fetch_segments_if_not_exists(names, cache_control_headers = false)
+          names.each do |name|
+            change_number = @segments_repository.get_change_number(name)
+
+            fetch_segment(name, cache_control_headers) if change_number == -1
+          end
+        rescue StandardError => error
+          @config.log_found_exception(__method__.to_s, error)
+        end
+
+        def fetch_segment(name, cache_control_headers = false)
           @semaphore.synchronize do
-            segments_api.fetch_segments_by_names([name])
-            true
+            segments_api.fetch_segments_by_names([name], cache_control_headers)
           end
         rescue StandardError => error
           @config.log_found_exception(__method__.to_s, error)
-          false
         end
 
         def fetch_segments
@@ -42,6 +50,7 @@ module SplitIoClient
             segments_api.fetch_segments_by_names(@segments_repository.used_segment_names)
 
             @sdk_blocker.segments_ready!
+            @sdk_blocker.sdk_internal_ready
           end
         rescue StandardError => error
           @config.log_found_exception(__method__.to_s, error)
@@ -58,7 +67,10 @@ module SplitIoClient
             @config.logger.info('Starting segments fetcher service') if @config.debug_enabled
 
             loop do
-              next unless @sdk_blocker.splits_repository.ready?
+              unless @sdk_blocker.splits_repository.ready?
+                sleep 0.2
+                next
+              end
 
               fetch_segments
               @config.logger.debug("Segment names: #{@segments_repository.used_segment_names.to_a}") if @config.debug_enabled
@@ -68,10 +80,10 @@ module SplitIoClient
               sleep(sleep_for)
             end
           end
-        end        
+        end
 
         def segments_api
-          @segments_api ||= SplitIoClient::Api::Segments.new(@api_key, @metrics, @segments_repository, @config)
+          @segments_api ||= SplitIoClient::Api::Segments.new(@api_key, @segments_repository, @config, @telemetry_runtime_producer)
         end
       end
     end

data/lib/splitclient-rb/cache/fetchers/split_fetcher.rb

@@ -4,13 +4,13 @@ module SplitIoClient
       class SplitFetcher
         attr_reader :splits_repository
 
-        def initialize(splits_repository, api_key, metrics, config, sdk_blocker = nil)
+        def initialize(splits_repository, api_key, config, sdk_blocker, telemetry_runtime_producer)
           @splits_repository = splits_repository
           @api_key = api_key
-          @metrics = metrics
           @config = config
           @sdk_blocker = sdk_blocker
           @semaphore = Mutex.new
+          @telemetry_runtime_producer = telemetry_runtime_producer
         end
 
         def call
@@ -27,9 +27,9 @@ module SplitIoClient
           end
         end
 
-        def fetch_splits
+        def fetch_splits(cache_control_headers = false)
           @semaphore.synchronize do
-            data = splits_since(@splits_repository.get_change_number)
+            data = splits_since(@splits_repository.get_change_number, cache_control_headers)
 
             data[:splits] && data[:splits].each do |split|
               add_split_unless_archived(split)
@@ -41,11 +41,12 @@ module SplitIoClient
             @config.logger.debug("segments seen(#{data[:segment_names].length}): #{data[:segment_names].to_a}") if @config.debug_enabled
 
             @sdk_blocker.splits_ready!
-            true
+
+            data[:segment_names]
           end
         rescue StandardError => error
           @config.log_found_exception(__method__.to_s, error)
-          false
+          []
         end
 
         def stop_splits_thread
@@ -67,8 +68,8 @@ module SplitIoClient
           end
         end
 
-        def splits_since(since)
-          splits_api.since(since)
+        def splits_since(since, cache_control_headers = false)
+          splits_api.since(since, cache_control_headers)
         end
 
         def add_split_unless_archived(split)
@@ -94,7 +95,7 @@ module SplitIoClient
         end
 
         def splits_api
-          @splits_api ||= SplitIoClient::Api::Splits.new(@api_key, @metrics, @config)
+          @splits_api ||= SplitIoClient::Api::Splits.new(@api_key, @config, @telemetry_runtime_producer)
         end
       end
     end

data/lib/splitclient-rb/cache/repositories/events/memory_repository.rb

@@ -5,10 +5,11 @@ module SplitIoClient
         class MemoryRepository < EventsRepository
           EVENTS_MAX_SIZE_BYTES = 5242880
 
-          def initialize(config)
+          def initialize(config, telemetry_runtime_producer)
             @config = config
             @adapter = @config.events_adapter
             @size = 0
+            @telemetry_runtime_producer = telemetry_runtime_producer
           end
 
           def add(key, traffic_type, event_type, time, value, properties, event_size)
@@ -17,8 +18,10 @@ module SplitIoClient
 
             post_events if @size >= EVENTS_MAX_SIZE_BYTES || @adapter.length == @config.events_queue_size
 
-            rescue StandardError => error
-              @config.log_found_exception(__method__.to_s, error)
+            @telemetry_runtime_producer.record_events_stats(Telemetry::Domain::Constants::EVENTS_QUEUED, 1)
+          rescue StandardError => error
+            @config.log_found_exception(__method__.to_s, error)
+            @telemetry_runtime_producer.record_events_stats(Telemetry::Domain::Constants::EVENTS_DROPPED, 1)
           end
 
           def clear

data/lib/splitclient-rb/cache/repositories/events_repository.rb

@@ -6,16 +6,17 @@ module SplitIoClient
         extend Forwardable
         def_delegators :@repository, :add, :clear, :batch
 
-        def initialize(config, api_key)
+        def initialize(config, api_key, telemetry_runtime_producer)
           super(config)
           @repository = case @config.events_adapter.class.to_s
           when 'SplitIoClient::Cache::Adapters::MemoryAdapter'
-            Repositories::Events::MemoryRepository.new(@config)
+            Repositories::Events::MemoryRepository.new(@config, telemetry_runtime_producer)
           when 'SplitIoClient::Cache::Adapters::RedisAdapter'
             Repositories::Events::RedisRepository.new(@config)
           end
 
           @api_key = api_key
+          @telemetry_runtime_producer = telemetry_runtime_producer
         end
 
         def post_events
@@ -48,7 +49,7 @@ module SplitIoClient
         private
 
         def events_api
-          @events_api ||= SplitIoClient::Api::Events.new(@api_key, @config)
+          @events_api ||= SplitIoClient::Api::Events.new(@api_key, @config, @telemetry_runtime_producer)
         end
       end
     end

data/lib/splitclient-rb/cache/repositories/impressions/memory_repository.rb

@@ -11,15 +11,23 @@ module SplitIoClient
           end
 
           def add_bulk(impressions)
+            return 0 if impressions.nil?
+
+            count = 0
             impressions.each do |impression|
               @adapter.add_to_queue(impression)
+              count += 1
             end
+
+            0
           rescue ThreadError # queue is full
             if random_sampler.rand(1..1000) <= 2 # log only 0.2 % of the time
               @config.logger.warn("Dropping impressions. Current size is \
                 #{@config.impressions_queue_size}. " \
                 'Consider increasing impressions_queue_size')
             end
+
+            impressions.length - count
           end
 
           def batch

data/lib/splitclient-rb/cache/repositories/impressions/redis_repository.rb

@@ -21,8 +21,10 @@ module SplitIoClient
 
             # Synchronizer might not be running
             @adapter.expire(key, EXPIRE_SECONDS) if impressions_json.size == impressions_list_size
+            0
           rescue StandardError => e
             @config.logger.error("Exception while add_bulk: #{e}")
+            0
           end
 
           def get_impressions(number_of_impressions = 0)

data/lib/splitclient-rb/cache/repositories/repository.rb

@@ -19,10 +19,6 @@ module SplitIoClient
       def namespace_key(key = '')
         "#{@config.redis_namespace}#{key}"
       end
-
-      def impressions_metrics_key(key)
-        namespace_key("/#{@config.language}-#{@config.version}/#{@config.machine_ip}/#{key}")
-      end
     end
   end
 end

data/lib/splitclient-rb/cache/repositories/segments_repository.rb

@@ -63,6 +63,26 @@ module SplitIoClient
           @adapter.clear(namespace_key)
         end
 
+        def segments_count
+          used_segment_names.length
+        end
+
+        def segment_keys_count
+          names = used_segment_names
+
+          keys = 0
+
+          names.each do |name|
+            segment_keys = get_segment_keys(name)            
+            keys += segment_keys.length
+          end
+          
+          keys
+        rescue StandardError => error
+          @config.log_found_exception(__method__.to_s, error)
+          0
+        end
+
         private
 
         def segment_data(name)

data/lib/splitclient-rb/cache/repositories/splits_repository.rb

@@ -140,6 +140,10 @@ module SplitIoClient
           @adapter.set_string(namespace_key(".split.#{split_name}"), split.to_json)
         end
 
+        def splits_count
+          split_names.length
+        end
+
         private
 
         def increase_tt_name_count(tt_name)

data/lib/splitclient-rb/cache/senders/localhost_repo_cleaner.rb

@@ -4,9 +4,8 @@ module SplitIoClient
   module Cache
     module Senders
       class LocalhostRepoCleaner
-        def initialize(impressions_repository, metrics_repository, events_repository, config)
+        def initialize(impressions_repository, events_repository, config)
           @impressions_repository = impressions_repository
-          @metrics_repository = metrics_repository
           @events_repository = events_repository
           @config = config
         end
@@ -40,7 +39,6 @@ module SplitIoClient
 
         def clear_repositories
           @impressions_repository.clear
-          @metrics_repository.clear
           @events_repository.clear
         end
       end