splitclient-rb 7.1.4.pre.rc7 → 7.1.4.pre.rc8

data/lib/splitclient-rb/split_config.rb

@@ -53,7 +53,9 @@ module SplitIoClient
       @segments_refresh_rate = opts[:segments_refresh_rate] || SplitConfig.default_segments_refresh_rate
       @metrics_refresh_rate = opts[:metrics_refresh_rate] || SplitConfig.default_metrics_refresh_rate
 
-      @impressions_refresh_rate = opts[:impressions_refresh_rate] || SplitConfig.default_impressions_refresh_rate
+      @impressions_mode = init_impressions_mode(opts[:impressions_mode])
+
+      @impressions_refresh_rate = SplitConfig.init_impressions_refresh_rate(@impressions_mode, opts[:impressions_refresh_rate], SplitConfig.default_impressions_refresh_rate)
       @impressions_queue_size = opts[:impressions_queue_size] || SplitConfig.default_impressions_queue_size
       @impressions_adapter = SplitConfig.init_cache_adapter(
         opts[:cache_adapter] || SplitConfig.default_cache_adapter, :queue_adapter, @impressions_queue_size, @redis_url
@@ -270,6 +272,30 @@ module SplitIoClient
 
     attr_accessor :streaming_enabled
 
+    attr_accessor :impressions_mode
+
+    def self.default_impressions_mode
+      :optimized
+    end
+
+    def init_impressions_mode(impressions_mode)
+      impressions_mode ||= SplitConfig.default_impressions_mode
+
+      case impressions_mode
+      when :debug
+        return :debug
+      else
+        @logger.error('You passed an invalid impressions_mode, impressions_mode should be one of the following values: :debug or :optimized. Defaulting to :optimized mode') unless impressions_mode == :optimized
+        return :optimized
+      end
+    end
+
+    def self.init_impressions_refresh_rate(impressions_mode, refresh_rate, default_rate)      
+      return (refresh_rate.nil? || refresh_rate <= 0 ? default_rate : refresh_rate) if impressions_mode == :debug
+      
+      return refresh_rate.nil? || refresh_rate <= 0 ? SplitConfig.default_impressions_refresh_rate_optimized : [default_rate, refresh_rate].max
+    end
+
     def self.default_streaming_enabled
       true
     end
@@ -387,6 +413,10 @@ module SplitIoClient
       60
     end
 
+    def self.default_impressions_refresh_rate_optimized
+      300
+    end
+
     def self.default_impression_listener_refresh_rate
       0
     end

data/lib/splitclient-rb/split_factory.rb

@@ -34,10 +34,12 @@ module SplitIoClient
       @metrics_repository = MetricsRepository.new(@config)
       @sdk_blocker = SDKBlocker.new(@splits_repository, @segments_repository, @config)
       @metrics = Metrics.new(100, @metrics_repository)
+      @impression_counter = SplitIoClient::Engine::Common::ImpressionCounter.new
+      @impressions_manager = SplitIoClient::Engine::Common::ImpressionManager.new(@config, @impressions_repository, @impression_counter)
 
       start!
 
-      @client = SplitClient.new(@api_key, @metrics, @splits_repository, @segments_repository, @impressions_repository, @metrics_repository, @events_repository, @sdk_blocker, @config)
+      @client = SplitClient.new(@api_key, @metrics, @splits_repository, @segments_repository, @impressions_repository, @metrics_repository, @events_repository, @sdk_blocker, @config, @impressions_manager)
       @manager = SplitManager.new(@splits_repository, @sdk_blocker, @config)
 
       validate_api_key
@@ -51,7 +53,8 @@ module SplitIoClient
       if @config.localhost_mode
         start_localhost_components
       else
-        SplitIoClient::Engine::SyncManager.new(repositories, @api_key, @config, @sdk_blocker, @metrics).start
+        params = { sdk_blocker: @sdk_blocker, metrics: @metrics, impression_counter: @impression_counter }
+        SplitIoClient::Engine::SyncManager.new(repositories, @api_key, @config, params).start
       end
     end
 

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '7.1.4.pre.rc7'
+  VERSION = '7.1.4.pre.rc8'
 end

data/splitclient-rb.gemspec

@@ -26,7 +26,14 @@ Gem::Specification.new do |spec|
          lib/murmurhash/murmurhash.jar]
     )
   else
-    spec.add_runtime_dependency 'digest-murmurhash', '>= 1.1.1'
+    spec.files.concat(
+      %w[ext/murmurhash/3_x86_32.c
+         ext/murmurhash/3_x64_128.c
+         ext/murmurhash/extconf.rb
+         ext/murmurhash/murmurhash.c
+         ext/murmurhash/murmurhash.h]
+    )
+    spec.extensions = ['ext/murmurhash/extconf.rb']
   end
 
   spec.add_development_dependency 'allocation_stats'

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 7.1.4.pre.rc7
+  version: 7.1.4.pre.rc8
 platform: ruby
 authors:
 - Split Software
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-26 00:00:00.000000000 Z
+date: 2020-09-17 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: digest-murmurhash
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.1.1
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.1.1
 - !ruby/object:Gem::Dependency
   name: allocation_stats
   requirement: !ruby/object:Gem::Requirement
@@ -322,7 +308,8 @@ description: Ruby client for using split SDK.
 email:
 - pato@split.io
 executables: []
-extensions: []
+extensions:
+- ext/murmurhash/extconf.rb
 extra_rdoc_files: []
 files:
 - ".github/pull_request_template.md"
@@ -337,6 +324,11 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- ext/murmurhash/3_x64_128.c
+- ext/murmurhash/3_x86_32.c
+- ext/murmurhash/extconf.rb
+- ext/murmurhash/murmurhash.c
+- ext/murmurhash/murmurhash.h
 - gemfiles/faraday_after_0.13.gemfile
 - gemfiles/faraday_before_0.13.gemfile
 - lib/murmurhash/base.rb
@@ -350,6 +342,8 @@ files:
 - lib/splitclient-rb/cache/adapters/redis_adapter.rb
 - lib/splitclient-rb/cache/fetchers/segment_fetcher.rb
 - lib/splitclient-rb/cache/fetchers/split_fetcher.rb
+- lib/splitclient-rb/cache/hashers/impression_hasher.rb
+- lib/splitclient-rb/cache/observers/impression_observer.rb
 - lib/splitclient-rb/cache/repositories/events/memory_repository.rb
 - lib/splitclient-rb/cache/repositories/events/redis_repository.rb
 - lib/splitclient-rb/cache/repositories/events_repository.rb
@@ -364,6 +358,7 @@ files:
 - lib/splitclient-rb/cache/repositories/splits_repository.rb
 - lib/splitclient-rb/cache/routers/impression_router.rb
 - lib/splitclient-rb/cache/senders/events_sender.rb
+- lib/splitclient-rb/cache/senders/impressions_count_sender.rb
 - lib/splitclient-rb/cache/senders/impressions_formatter.rb
 - lib/splitclient-rb/cache/senders/impressions_sender.rb
 - lib/splitclient-rb/cache/senders/localhost_repo_cleaner.rb
@@ -383,6 +378,8 @@ files:
 - lib/splitclient-rb/engine/api/segments.rb
 - lib/splitclient-rb/engine/api/splits.rb
 - lib/splitclient-rb/engine/auth_api_client.rb
+- lib/splitclient-rb/engine/common/impressions_counter.rb
+- lib/splitclient-rb/engine/common/impressions_manager.rb
 - lib/splitclient-rb/engine/evaluator/splitter.rb
 - lib/splitclient-rb/engine/matchers/all_keys_matcher.rb
 - lib/splitclient-rb/engine/matchers/between_matcher.rb