splitclient-rb 7.1.4.pre.rc18 → 7.1.4.pre.rc19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 25c646772ba955ff0e6518fef1f89835ef4243af4e950ff215ea7ff0f41ccbc6
-  data.tar.gz: b4bc3d6dcd6f1cca0d1b8542b61538c2759d49baa02c9afc2c571e75a171e037
+  metadata.gz: 60c6946b200c0979eb6eedefce813c20b6e3db78424c35540efab92db20be6a7
+  data.tar.gz: 073435bf9df789975fcc78d6e0075314e377014722de8fd3eac296f261263499
 SHA512:
-  metadata.gz: 306aa83e80c33dbeb51c04cdbc4a2feccb8bea6d77006fc37545f315037d552cd4352074715e316ecc981cdcaa0cec31480c799d2308172e0ef75fc58d719042
-  data.tar.gz: 474204267fa780a89c4013fc7fbb83b8b273789571b050613d30841191f5c458261ce5495ce7bc40da2c03296d11a4220e4dc07b8523440633d372e9a2eddb0d
+  metadata.gz: 420e8e14d6225c92cbab6bc4cdda21314ad9482bae315d8ce0049d3b493caed3376da696c08a563b1bc2e588e9ab11133e7dc311772d0ac56485c0599a1c597f
+  data.tar.gz: 7b8c32b0fe198035538dc00564cad7aae10a7c1a66173c428f8c4004329e4c91255ddfd8cfc4c48aeb8a28b978b2904e35239d0f4cf944bf95b675cfd96a54ee

data/lib/splitclient-rb/cache/routers/impression_router.rb

@@ -18,8 +18,10 @@ module SplitIoClient
       end
     end
 
-    def add(impression)
-      enqueue(impression)
+    def add_bulk(impressions)
+      impressions.each do |impression|
+        enqueue(impression)
+      end
     end
 
     private

data/lib/splitclient-rb/engine/common/impressions_manager.rb

@@ -17,12 +17,9 @@ module SplitIoClient
 
           impression_data[:pt] = @impression_observer.test_and_set(impression_data) unless redis?
 
-          impression_debug = impression(impression_data, params[:attributes])
-          impression_router.add(impression_debug)
+          @impression_counter.inc(split_name, impression_data[:m]) if optimized? && !redis?
 
-          return impression_optimized(split_name, impression_data, params[:attributes]) if optimized? && !redis?
-
-          impression_debug
+          impression(impression_data, params[:attributes])
         rescue StandardError => error
           @config.log_found_exception(__method__.to_s, error)
         end
@@ -30,7 +27,14 @@ module SplitIoClient
         def track(impressions)
           return if impressions.empty?
 
-          @impressions_repository.add_bulk(impressions)
+          impression_router.add_bulk(impressions)
+
+          if optimized? && !redis?
+            optimized_impressions = impressions.select { |imp| should_queue_impression?(imp[:i]) }
+            @impressions_repository.add_bulk(optimized_impressions)
+          else
+            @impressions_repository.add_bulk(impressions)
+          end
         rescue StandardError => error
           @config.log_found_exception(__method__.to_s, error)
         end
@@ -67,12 +71,6 @@ module SplitIoClient
           @config.impressions_mode == :optimized
         end
 
-        def impression_optimized(split_name, impression_data, attributes)
-          @impression_counter.inc(split_name, impression_data[:m])
-
-          impression(impression_data, attributes) if should_queue_impression?(impression_data)
-        end
-
         def should_queue_impression?(impression)
           impression[:pt].nil? ||
             (ImpressionCounter.truncate_time_frame(impression[:pt]) != ImpressionCounter.truncate_time_frame(impression[:m]))
@@ -88,6 +86,8 @@ module SplitIoClient
 
         def impression_router
           @impression_router ||= SplitIoClient::ImpressionRouter.new(@config)
+        rescue StandardError => error
+          @config.log_found_exception(__method__.to_s, error)
         end
       end
     end

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '7.1.4.pre.rc18'
+  VERSION = '7.1.4.pre.rc19'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 7.1.4.pre.rc18
+  version: 7.1.4.pre.rc19
 platform: ruby
 authors:
 - Split Software
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-22 00:00:00.000000000 Z
+date: 2020-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: allocation_stats