splitclient-rb 7.1.4.pre.rc15 → 7.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 39c8f9ba8b6485789a6cabceb19f0d9ae838f66a30e5d24b1cdc7fc6fb48ae67
-  data.tar.gz: 3d156718308ad5c79ec904b12ee9d35620eb83cce1b207262412d7a29c8ef7f6
+  metadata.gz: d5a8bad0b7b72fba188bff72b10b5a0849bdadabdde484929b83071a51cfe715
+  data.tar.gz: 27b74c33b6fbe6c87141bf163f1dbd8d37eaa586d8c60eb73319cbcb7e3cc85e
 SHA512:
-  metadata.gz: faf6ea58b3c564fd6c625f2558006bd668be5feb672cc436860c9c6f273f7596910cd28aceff64888993997ab6357e7654c68e1bfc238759ba28fc33dd132cff
-  data.tar.gz: cbb6c2efa42812ca03dd069f25653ce939450db32533d279260cfca6d192fa80cd62fd96548f7b164c4ffab468558446706f4781e691649a69fd9af3d876d5b9
+  metadata.gz: 0db37fb36974d3b177b3b4b08d35199bf828b8c4ebc508731e1255c44c08f9be2953174e6dbb3b1a2d514f880845b0abefd300061ad9b77e72745a867b930dc4
+  data.tar.gz: 0d66fc9a82f117ed7ccc4e391aa59827ed024d34d3082472dab54d6c3cacd57357c01af6eb6becb69f8a0dabc12cc51258e0e7a852fbfc9c82d414eb1ad1d40b

data/CHANGES.txt

@@ -1,5 +1,10 @@
 CHANGES
 
+7.2.0 (Sep 25, 2020)
+- Added deduplication logic for impressions data.
+  - Now there are two modes for Impressions when the SDK is in standalone mode, OPTIMIZED (default) that only ships unique impressions and DEBUG for times where you need to send ALL impressions to debug an integration.
+  - Impression listener remains unchanged and will still get all impressions.
+
 7.1.3 (Jul 31, 2020)
 - Updated rake development dependency to ~> 12.3.3.
 

data/lib/splitclient-rb/cache/routers/impression_router.rb

@@ -19,33 +19,30 @@ module SplitIoClient
     end
 
     def add_bulk(impressions)
-      @config.logger.error("### ROUTER.IMPRESSIONS #{impressions.to_s}")
-      @config.logger.error("### LISTENER #{@listener.nil?}")
-      return unless @listener
-
       impressions.each do |impression|
-        enqueue(
-          split_name: impression[:i][:f],
-          matching_key: impression[:i][:k],
-          bucketing_key: impression[:i][:b],
-          time: impression[:i][:m],
-          treatment: {
-            label: impression[:i][:r],
-            treatment: impression[:i][:t],
-            change_number: impression[:i][:c]
-          },
-          previous_time: impression[:i][:pt],
-          attributes: impression[:attributes]
-        ) unless impression.nil?
+        enqueue(impression)
       end
-    rescue StandardError => error
-      @config.log_found_exception(__method__.to_s, error)
     end
 
     private
 
     def enqueue(impression)
-      @queue.push(impression) if @listener
+      imp = {
+        split_name: impression[:i][:f],
+        matching_key: impression[:i][:k],
+        bucketing_key: impression[:i][:b],
+        time: impression[:i][:m],
+        treatment: {
+          label: impression[:i][:r],
+          treatment: impression[:i][:t],
+          change_number: impression[:i][:c]
+        },
+        previous_time: impression[:i][:pt],
+        attributes: impression[:attributes]
+      }
+      @queue.push(imp) if @listener
+    rescue StandardError => error
+      @config.log_found_exception(__method__.to_s, error)
     end
 
     def router_thread

data/lib/splitclient-rb/engine/common/impressions_counter.rb

@@ -32,12 +32,12 @@ module SplitIoClient
           to_return
         end
 
-        def truncate_time_frame(timestamp_ms)
-          timestamp_ms - (timestamp_ms % TIME_INTERVAL_MS)
+        def make_key(split_name, time_frame)
+          "#{split_name}::#{ImpressionCounter.truncate_time_frame(time_frame)}"
         end
 
-        def make_key(split_name, time_frame)
-          "#{split_name}::#{truncate_time_frame(time_frame)}"
+        def self.truncate_time_frame(timestamp_ms)
+          timestamp_ms - (timestamp_ms % TIME_INTERVAL_MS)
         end
       end
     end

data/lib/splitclient-rb/engine/common/impressions_manager.rb

@@ -8,7 +8,6 @@ module SplitIoClient
           @config = config
           @impressions_repository = impressions_repository
           @impression_counter = impression_counter
-          @impression_router = SplitIoClient::ImpressionRouter.new(@config)
           @impression_observer = SplitIoClient::Observers::ImpressionObserver.new
         end
 
@@ -18,7 +17,7 @@ module SplitIoClient
 
           impression_data[:pt] = @impression_observer.test_and_set(impression_data) unless redis?
 
-          return impression_optimized(split_name, impression_data, params[:attributes]) if optimized? && !redis?
+          @impression_counter.inc(split_name, impression_data[:m]) if optimized? && !redis?
 
           impression(impression_data, params[:attributes])
         rescue StandardError => error
@@ -26,11 +25,16 @@ module SplitIoClient
         end
 
         def track(impressions)
-          @config.logger.error("### IMPRESSIONS #{impressions.to_s}")
           return if impressions.empty?
 
-          @impressions_repository.add_bulk(impressions)
-          @impression_router.add_bulk(impressions)
+          impression_router.add_bulk(impressions)
+
+          if optimized? && !redis?
+            optimized_impressions = impressions.select { |imp| should_queue_impression?(imp[:i]) }
+            @impressions_repository.add_bulk(optimized_impressions)
+          else
+            @impressions_repository.add_bulk(impressions)
+          end
         rescue StandardError => error
           @config.log_found_exception(__method__.to_s, error)
         end
@@ -67,14 +71,9 @@ module SplitIoClient
           @config.impressions_mode == :optimized
         end
 
-        def impression_optimized(split_name, impression_data, attributes)
-          @impression_counter.inc(split_name, impression_data[:m])
-
-          impression(impression_data, attributes) if should_queue_impression?(impression_data)
-        end
-
         def should_queue_impression?(impression)
-          impression[:pt].nil? || (impression[:pt] < ((Time.now.to_f * 1000.0).to_i - Common::TIME_INTERVAL_MS))
+          impression[:pt].nil? ||
+            (ImpressionCounter.truncate_time_frame(impression[:pt]) != ImpressionCounter.truncate_time_frame(impression[:m]))
         end
 
         def impression(impression_data, attributes)
@@ -84,6 +83,12 @@ module SplitIoClient
         def redis?
           @config.impressions_adapter.class.to_s == 'SplitIoClient::Cache::Adapters::RedisAdapter'
         end
+
+        def impression_router
+          @impression_router ||= SplitIoClient::ImpressionRouter.new(@config)
+        rescue StandardError => error
+          @config.log_found_exception(__method__.to_s, error)
+        end
       end
     end
   end

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '7.1.4.pre.rc15'
+  VERSION = '7.2.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 7.1.4.pre.rc15
+  version: 7.2.0
 platform: ruby
 authors:
 - Split Software
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-21 00:00:00.000000000 Z
+date: 2020-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: allocation_stats
@@ -454,9 +454,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.0.6
 signing_key: