splitclient-rb 7.1.4.pre.rc14 → 7.1.4.pre.rc19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2a839ca256b9e088f4629289e875cbfc3ecb0ae44414270b826175a24ba98ee3
-  data.tar.gz: 6a240e652288008873e6cbd24cbb0adbb3aa868f9db94307644f9c6704bf4db8
+  metadata.gz: 60c6946b200c0979eb6eedefce813c20b6e3db78424c35540efab92db20be6a7
+  data.tar.gz: 073435bf9df789975fcc78d6e0075314e377014722de8fd3eac296f261263499
 SHA512:
-  metadata.gz: d26eb8ac2ecef7df984891a410a300369492b87400e6f5281a36c9fa21fbdb3a4d23c524c5f45645478f42ccebe1579058bef327ec08725d2a3423cf395fd6ab
-  data.tar.gz: aad7ad57c77a6766d0e3df45ca8a8114ae9209b238768616ce46cce3a516c9d7cf5744a4a841c7f5aa5ff5cd06e4725a13c3c2e2af989810e269dbc86cc7e288
+  metadata.gz: 420e8e14d6225c92cbab6bc4cdda21314ad9482bae315d8ce0049d3b493caed3376da696c08a563b1bc2e588e9ab11133e7dc311772d0ac56485c0599a1c597f
+  data.tar.gz: 7b8c32b0fe198035538dc00564cad7aae10a7c1a66173c428f8c4004329e4c91255ddfd8cfc4c48aeb8a28b978b2904e35239d0f4cf944bf95b675cfd96a54ee

data/lib/splitclient-rb/cache/routers/impression_router.rb

@@ -19,28 +19,30 @@ module SplitIoClient
     end
 
     def add_bulk(impressions)
-      return unless @listener
       impressions.each do |impression|
-        enqueue(
-          split_name: impression[:i][:f],
-          matching_key: impression[:i][:k],
-          bucketing_key: impression[:i][:b],
-          time: impression[:i][:m],
-          treatment: {
-            label: impression[:i][:r],
-            treatment: impression[:i][:t],
-            change_number: impression[:i][:c]
-          },
-          previous_time: impression[:i][:pt],
-          attributes: impression[:attributes]
-        ) unless impression.nil?
+        enqueue(impression)
       end
     end
 
     private
 
     def enqueue(impression)
-      @queue.push(impression) if @listener
+      imp = {
+        split_name: impression[:i][:f],
+        matching_key: impression[:i][:k],
+        bucketing_key: impression[:i][:b],
+        time: impression[:i][:m],
+        treatment: {
+          label: impression[:i][:r],
+          treatment: impression[:i][:t],
+          change_number: impression[:i][:c]
+        },
+        previous_time: impression[:i][:pt],
+        attributes: impression[:attributes]
+      }
+      @queue.push(imp) if @listener
+    rescue StandardError => error
+      @config.log_found_exception(__method__.to_s, error)
     end
 
     def router_thread

data/lib/splitclient-rb/engine/common/impressions_counter.rb

@@ -32,12 +32,12 @@ module SplitIoClient
           to_return
         end
 
-        def truncate_time_frame(timestamp_ms)
-          timestamp_ms - (timestamp_ms % TIME_INTERVAL_MS)
+        def make_key(split_name, time_frame)
+          "#{split_name}::#{ImpressionCounter.truncate_time_frame(time_frame)}"
         end
 
-        def make_key(split_name, time_frame)
-          "#{split_name}::#{truncate_time_frame(time_frame)}"
+        def self.truncate_time_frame(timestamp_ms)
+          timestamp_ms - (timestamp_ms % TIME_INTERVAL_MS)
         end
       end
     end

data/lib/splitclient-rb/engine/common/impressions_manager.rb

@@ -8,7 +8,6 @@ module SplitIoClient
           @config = config
           @impressions_repository = impressions_repository
           @impression_counter = impression_counter
-          @impression_router = SplitIoClient::ImpressionRouter.new(@config)
           @impression_observer = SplitIoClient::Observers::ImpressionObserver.new
         end
 
@@ -18,7 +17,7 @@ module SplitIoClient
 
           impression_data[:pt] = @impression_observer.test_and_set(impression_data) unless redis?
 
-          return impression_optimized(split_name, impression_data, params[:attributes]) if optimized? && !redis?
+          @impression_counter.inc(split_name, impression_data[:m]) if optimized? && !redis?
 
           impression(impression_data, params[:attributes])
         rescue StandardError => error
@@ -28,8 +27,14 @@ module SplitIoClient
         def track(impressions)
           return if impressions.empty?
 
-          @impressions_repository.add_bulk(impressions)
-          @impression_router.add_bulk(impressions)
+          impression_router.add_bulk(impressions)
+
+          if optimized? && !redis?
+            optimized_impressions = impressions.select { |imp| should_queue_impression?(imp[:i]) }
+            @impressions_repository.add_bulk(optimized_impressions)
+          else
+            @impressions_repository.add_bulk(impressions)
+          end
         rescue StandardError => error
           @config.log_found_exception(__method__.to_s, error)
         end
@@ -66,14 +71,9 @@ module SplitIoClient
           @config.impressions_mode == :optimized
         end
 
-        def impression_optimized(split_name, impression_data, attributes)
-          @impression_counter.inc(split_name, impression_data[:m])
-
-          impression(impression_data, attributes) if should_queue_impression?(impression_data)
-        end
-
         def should_queue_impression?(impression)
-          impression[:pt].nil? || (impression[:pt] < ((Time.now.to_f * 1000.0).to_i - Common::TIME_INTERVAL_MS))
+          impression[:pt].nil? ||
+            (ImpressionCounter.truncate_time_frame(impression[:pt]) != ImpressionCounter.truncate_time_frame(impression[:m]))
         end
 
         def impression(impression_data, attributes)
@@ -83,6 +83,12 @@ module SplitIoClient
         def redis?
           @config.impressions_adapter.class.to_s == 'SplitIoClient::Cache::Adapters::RedisAdapter'
         end
+
+        def impression_router
+          @impression_router ||= SplitIoClient::ImpressionRouter.new(@config)
+        rescue StandardError => error
+          @config.log_found_exception(__method__.to_s, error)
+        end
       end
     end
   end

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '7.1.4.pre.rc14'
+  VERSION = '7.1.4.pre.rc19'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 7.1.4.pre.rc14
+  version: 7.1.4.pre.rc19
 platform: ruby
 authors:
 - Split Software
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-21 00:00:00.000000000 Z
+date: 2020-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: allocation_stats