splitclient-rb 7.0.2.pre.rc2-java → 7.0.3-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 99b07947540ac1971dc7ccf9b7b3cf3d44fc8b90
-  data.tar.gz: c8911b0348e73e1192ebb4ca041cd3f4164a08fb
+  metadata.gz: 13e8f0d13a64dd00ff1a4ba2e831c0c68898d07a
+  data.tar.gz: 3a723eb9cfd9c5844bb7f543b02f79b7f0501bfb
 SHA512:
-  metadata.gz: fe5dca7a09847b5b7688489d3a833274314774a8f4d9086ae3d09fddd41104a629d0d177bf43063708859fc4ebc2ded475ba0ac88e0b2ff9c1ed46d1fbdacfe1
-  data.tar.gz: 902c1067142dcc0eef6268910a9d4a3301e9ed133a1d82cc3d8552b21f932fb094b2f0386e4160dc27364df5286c13087985ae62d0afac5c69594d084c1bce10
+  metadata.gz: 160d1a974ef68db74d53495bd9a8cbd5040761dbf3a9076467f232e27746a974e9d9d0cd1261d9eec268c7b1adc5e06c910697ab90d567fe531fa2f1e9a0235d
+  data.tar.gz: 892f1d01a48bd179b123c2fce338dcab9024f34581e61ffcdc65840b04ee2ed6c0b502321eb825efd20941e0aebfe2c54ee97a80471d948316626aa2fdbd8d3a

data/CHANGES.txt

@@ -1,4 +1,9 @@
+7.0.3 (Jan 20, 2020)
+- Added integration tests.
+- Fixed impressions labels.
+
 7.0.2 (Nov 11, 2019)
+- Fixed an issue about empty logs.
 - Fixed an issue about reducing scan commands in redis.
 
 7.0.1 (Oct 31, 2019)
@@ -35,7 +40,7 @@
   define configurations for your treatments and also whitelisted keys. Read more in our docs!
 
 6.2.0 (Mar 7th, 2019)
-- Reworked SplitClient#destroy to ensure events, impressions and metrics are sent to Split backend when called
+- Reworked SplitClient#destroy to ensure events, impressions and metrics are sent to Split backend when called.
 - Ensured destroy is called when keyboard interrupts are sent to the application
 - Changed SDK blocker (and block_until_ready) to have no effect in consumer mode
 - Added support for applications tied to Faraday < 0.13 and net-http-persistent 3 using a patched Faraday adapter

data/lib/splitclient-rb/cache/repositories/events/memory_repository.rb

@@ -25,6 +25,12 @@ module SplitIoClient
             @size = 0
             @adapter.clear
           end
+
+          def batch
+            return [] if @config.events_queue_size.zero?
+
+            @adapter.get_batch(@config.events_queue_size)
+          end
         end
       end
     end

data/lib/splitclient-rb/cache/repositories/events/redis_repository.rb

@@ -24,6 +24,10 @@ module SplitIoClient
             @config.logger.error("Exception while clearing events cache: #{e}")
             []
           end
+
+          def batch
+            clear()
+          end
         end
       end
     end

data/lib/splitclient-rb/cache/repositories/events_repository.rb

@@ -4,7 +4,7 @@ module SplitIoClient
       # Repository which forwards events interface to the selected adapter
       class EventsRepository < Repository
         extend Forwardable
-        def_delegators :@repository, :add, :clear
+        def_delegators :@repository, :add, :clear, :batch
 
         def initialize(config, api_key)
           super(config)

data/lib/splitclient-rb/cache/repositories/metrics/memory_repository.rb

@@ -1,3 +1,5 @@
+require 'concurrent'
+
 module SplitIoClient
   module Cache
     module Repositories
@@ -6,9 +8,9 @@ module SplitIoClient
           OPERATIONS = %w(sdk.get_treatment sdk.get_treatments sdk.get_treatment_with_config sdk.get_treatments_with_config)
 
           def initialize(_ = nil, config)
-            @counts = []
-            @latencies = []
-            @gauges = []
+            @counts = Concurrent::Array.new
+            @latencies = Concurrent::Array.new
+            @gauges = Concurrent::Array.new
             @config = config
           end
 
@@ -64,15 +66,15 @@ module SplitIoClient
           end
 
           def clear_counts
-            @counts = []
+            @counts = Concurrent::Array.new
           end
 
           def clear_latencies
-            @latencies = []
+            @latencies = Concurrent::Array.new
           end
 
           def clear_gauges
-            @gauges = []
+            @gauges = Concurrent::Array.new
           end
 
           def clear
@@ -152,7 +154,7 @@ module SplitIoClient
           end
 
           def find_operation_latencies(operation)
-            @latencies.find { |l| l[:operation] == operation unless l.nil? }
+            @latencies.find { |l| l[:operation] == operation }
           end
         end
       end

data/lib/splitclient-rb/cache/repositories/metrics/redis_repository.rb

@@ -67,7 +67,8 @@ module SplitIoClient
 
           # introduced to fix incorrect latencies
           def fix_latencies
-            return if @adapter.exists?(impressions_metrics_key('lantencies.cleaned'))
+            latencies_cleaned_key =  namespace_key('/latencies.cleaned')
+            return if @adapter.exists?(latencies_cleaned_key)
 
             keys =[]
 
@@ -91,7 +92,7 @@ module SplitIoClient
               end
             end
 
-            @adapter.set_string(impressions_metrics_key('lantencies.cleaned'), '1')
+            @adapter.set_string(latencies_cleaned_key, '1')
           end
 
           def latencies_to_be_deleted_key_pattern_prefix(key)

data/lib/splitclient-rb/cache/routers/impression_router.rb

@@ -28,13 +28,14 @@ module SplitIoClient
           split_name: split_name.to_s,
           matching_key: impressions[:matching_key],
           bucketing_key: impressions[:bucketing_key],
+          time: impressions[:time],
           treatment: {
             label: impressions[:treatments_labels_change_numbers][split_name.to_sym][:label],
             treatment: impressions[:treatments_labels_change_numbers][split_name.to_sym][:treatment],
             change_number: impressions[:treatments_labels_change_numbers][split_name.to_sym][:change_number]
           },
           attributes: impressions[:attributes]
-        )
+        ) unless impressions[:treatments_labels_change_numbers][split_name.to_sym].nil?
       end
     end
 

data/lib/splitclient-rb/cache/senders/events_sender.rb

@@ -9,16 +9,12 @@ module SplitIoClient
           @config = config
         end
 
-        def call
-          if ENV['SPLITCLIENT_ENV'] == 'test'
-            post_events
-          else
-            events_thread
-
-            if defined?(PhusionPassenger)
-              PhusionPassenger.on_event(:starting_worker_process) do |forked|
-                events_thread if forked
-              end
+        def call          
+          events_thread
+
+          if defined?(PhusionPassenger)
+            PhusionPassenger.on_event(:starting_worker_process) do |forked|
+              events_thread if forked
             end
           end
         end

data/lib/splitclient-rb/cache/senders/impressions_sender.rb

@@ -11,15 +11,11 @@ module SplitIoClient
         end
 
         def call
-          if ENV['SPLITCLIENT_ENV'] == 'test'
-            post_impressions
-          else
-            impressions_thread
-
-            if defined?(PhusionPassenger)
-              PhusionPassenger.on_event(:starting_worker_process) do |forked|
-                impressions_thread if forked
-              end
+          impressions_thread
+
+          if defined?(PhusionPassenger)
+            PhusionPassenger.on_event(:starting_worker_process) do |forked|
+              impressions_thread if forked
             end
           end
         end

data/lib/splitclient-rb/cache/senders/metrics_sender.rb

@@ -11,8 +11,6 @@ module SplitIoClient
         end
 
         def call
-          return if ENV['SPLITCLIENT_ENV'] == 'test'
-
           metrics_thread
 
           if defined?(PhusionPassenger)

data/lib/splitclient-rb/clients/split_client.rb

@@ -97,7 +97,11 @@ module SplitIoClient
         matching_key: matching_key,
         bucketing_key: bucketing_key,
         time: time,
-        treatment: treatment,
+        treatment: {
+          label: treatment[:label],
+          treatment: treatment[:treatment],
+          change_number: treatment[:change_number]
+        },
         attributes: attributes
       )
     end
@@ -247,12 +251,14 @@ module SplitIoClient
       # Measure
       @adapter.metrics.time('sdk.' + calling_method, latency)
 
+      treatments_for_impressions = get_treatment_for_impressions(treatments_labels_change_numbers)
+
       time = (Time.now.to_f * 1000.0).to_i
       @impressions_repository.add_bulk(
-        matching_key, bucketing_key, treatments_labels_change_numbers, time
-      )
+        matching_key, bucketing_key, treatments_for_impressions, time
+      ) unless treatments_for_impressions == {}
 
-      route_impressions(sanitized_split_names, matching_key, bucketing_key, time, treatments_labels_change_numbers, attributes)
+      route_impressions(sanitized_split_names, matching_key, bucketing_key, time, treatments_for_impressions, attributes)
 
       split_names_keys = treatments_labels_change_numbers.keys
       treatments = treatments_labels_change_numbers.values.map do |v|
@@ -282,14 +288,11 @@ module SplitIoClient
       )
       control_treatment = { treatment: Engine::Models::Treatment::CONTROL }
 
-      parsed_control_exception = parsed_treatment(multiple,
-        control_treatment.merge({ label: Engine::Models::Label::EXCEPTION }))
-
       bucketing_key, matching_key = keys_from_key(key)
 
       attributes = parsed_attributes(attributes)
 
-      return parsed_control_exception unless valid_client && @config.split_validator.valid_get_treatment_parameters(calling_method, key, split_name, matching_key, bucketing_key, attributes)
+      return parsed_treatment(multiple, control_treatment) unless valid_client && @config.split_validator.valid_get_treatment_parameters(calling_method, key, split_name, matching_key, bucketing_key, attributes)
 
       bucketing_key = bucketing_key ? bucketing_key.to_s : nil
       matching_key = matching_key.to_s
@@ -336,7 +339,7 @@ module SplitIoClient
 
         store_impression(split_name, matching_key, bucketing_key, control_treatment, attributes) if store_impressions
 
-        return parsed_control_exception
+        return parsed_treatment(multiple, control_treatment.merge({ label: Engine::Models::Label::EXCEPTION }))
       end
 
       parsed_treatment(multiple, treatment_data)
@@ -354,5 +357,12 @@ module SplitIoClient
     def parsed_attributes(attributes)
       return attributes || attributes.to_h
     end
+
+    def get_treatment_for_impressions(treatments_labels_change_numbers)
+      return treatments_labels_change_numbers.select{|imp| 
+        treatments_labels_change_numbers[imp][:label] != Engine::Models::Label::NOT_FOUND && 
+        !treatments_labels_change_numbers[imp][:label].nil?
+      }
+    end
   end
 end

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '7.0.2.pre.rc2'
+  VERSION = '7.0.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 7.0.2.pre.rc2
+  version: 7.0.3
 platform: java
 authors:
 - Split Software
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-11-22 00:00:00.000000000 Z
+date: 2020-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -402,9 +402,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project:
 rubygems_version: 2.6.14