splitclient-rb 6.4.1.pre.rc1 → 6.4.1.pre.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f474b8941f870d494de1e1c5314b2b880c12672cf9d46b17ceb902e99e85050a
-  data.tar.gz: 27e00346829c95698a5e19acd95d392c9805a857cb5882ef0a94ff4011ea41d5
+  metadata.gz: 727fb19c1dbe097c79169ab3dceb79d3433f407e80c8fd5e2f6802dfb8f37690
+  data.tar.gz: 3b17876bc08c8d3e299dda5971331d44f1c157d3870775e1b965912f2669806c
 SHA512:
-  metadata.gz: 9463b792568144eeec07f22bd3550ad5e3b626de832752694e67c82792f884c3627e0f1b1774a3cff6168c860dbf0b248873df6848db39f1b43f487600361956
-  data.tar.gz: 8e2431113432f21f485ad67009c538bdfaba2902828e872099b2cf89e739bbbfae4c8114c20e49fa2e77357ed7cee9d0e524b341ca1d8667ba0607d6a5fd47f7
+  metadata.gz: 98d13f44e00258349853061336df8ccc775359c89ff95d3460a7f27e2a40027ba8e54d0b3a8f39a0f3cb1da38159ac49bda8d64e20c716b2604f269792a4ad5a
+  data.tar.gz: 9f47b928cbfd5eb6f6ce789f420b68bcc473e4668a6109428e7ad58faac8601b51adca9d5637a8a32411211067a28b6993c235dca684e39d2e59405798c2d450

data/lib/splitclient-rb.rb

@@ -84,6 +84,9 @@ require 'splitclient-rb/engine/models/treatment'
 require 'splitclient-rb/utilitites'
 require 'splitclient-rb/validators'
 
+# redis metrics fixer
+require 'splitclient-rb/redis_metrics_fixer'
+
 # C extension
 require 'murmurhash/murmurhash_mri'
 

data/lib/splitclient-rb/cache/adapters/redis_adapter.rb

@@ -56,10 +56,14 @@ module SplitIoClient
         end
 
         def find_strings_by_prefix(prefix)
+          find_strings_by_pattern("#{prefix}*")
+        end
+
+        def find_strings_by_pattern(pattern)
           memo = { items: [], cursor: 0 }
 
           loop do
-            memo[:cursor], items = @redis.scan(memo[:cursor], match: "#{prefix}*", count: SCAN_SLICE)
+            memo[:cursor], items = @redis.scan(memo[:cursor], match: "#{pattern}", count: SCAN_SLICE)
 
             memo[:items].push(*items)
 

data/lib/splitclient-rb/cache/repositories/metrics/memory_repository.rb

@@ -23,27 +23,14 @@ module SplitIoClient
           end
 
           def add_latency(operation, time_in_ms, binary_search)
-            operation_hash = @latencies.find { |l| l[:operation] == operation }
-            if operation_hash.nil?
-              latencies_for_op = (OPERATIONS.include?(operation)) ? build_latencies_for_op(operation, binary_search.add_latency_millis(time_in_ms, true)) : [time_in_ms]
-              @latencies << { operation: operation, latencies: latencies_for_op }
+            if (OPERATIONS.include?(operation))
+              index = binary_search.add_latency_millis(time_in_ms, true)
+              increase_latency_bucket(operation, index)
             else
-              (OPERATIONS.include?(operation)) ? increase_latencies_for_op(operation_hash[:latencies], binary_search.add_latency_millis(time_in_ms, true)) : operation_hash[:latencies].push(time_in_ms)
+              concatenate_latency(operation, time_in_ms)
             end
           end
 
-          def build_latencies_for_op(operation, index)
-            latencies_array = Array.new(BinarySearchLatencyTracker::BUCKETS.length, 0)
-
-            latencies_array[index] = 1
-
-            latencies_array
-          end
-
-          def increase_latencies_for_op(operation_latencies_array, index)
-            operation_latencies_array[index] += 1
-          end
-
           def add_gauge(gauge, value)
             gauge_hash = @gauges.find { |g| g[:name] == gauge }
             if gauge_hash.nil?
@@ -71,6 +58,10 @@ module SplitIoClient
             # TODO
           end
 
+          def fix_latencies
+            # NOOP
+          end
+
           def clear_counts
             @counts = []
           end
@@ -134,6 +125,34 @@ module SplitIoClient
               @value = 0
             end
           end
+
+          private
+          
+          def increase_latency_bucket(operation, index)
+            operation_latencies = find_operation_latencies(operation)
+
+            if (operation_latencies.nil?)
+              latencies_array = Array.new(BinarySearchLatencyTracker::BUCKETS.length, 0)
+              latencies_array[index] = 1
+              @latencies << { operation: operation, latencies: latencies_array }
+            else
+              operation_latencies[:latencies][index] += 1
+            end
+          end
+
+          def concatenate_latency(operation, time_in_ms)
+            operation_latencies = find_operation_latencies(operation)
+
+            if (operation_latencies.nil?)
+              @latencies << { operation: operation, latencies: [time_in_ms] }
+            else
+              operation_latencies[:latencies].push(time_in_ms)
+            end
+          end
+
+          def find_operation_latencies(operation)
+            @latencies.find { |l| l[:operation] == operation }
+          end
         end
       end
     end

data/lib/splitclient-rb/cache/repositories/metrics/redis_repository.rb

@@ -38,30 +38,16 @@ module SplitIoClient
             keys = @adapter.find_strings_by_prefix(impressions_metrics_key('latency'))
             return [] if keys.empty?
 
-            found_latencies = @adapter.multiple_strings(keys).map do |name, data|
-              [name.gsub(impressions_metrics_key('latency.'), ''), data]
-            end.to_h
-
-            collected_latencies = {}
-
-            found_latencies.each do |key, value|
-              operation, bucket = key.split('.bucket.')
-              collected_latencies[operation] = {} unless collected_latencies[operation]
-              collected_latencies[operation].merge!({bucket => value})
-            end
-
-            latencies = {}
+            collected_latencies = collect_latencies(keys)
 
-            collected_latencies.keys.each do |operation|
-              latencies_array = Array.new(BinarySearchLatencyTracker::BUCKETS.length, 0)
+            collected_latencies.keys.each_with_object({}) do |operation, latencies|
+              operation_latencies = Array.new(BinarySearchLatencyTracker::BUCKETS.length, 0)
               collected_latencies[operation].each do |bucket, value|
-                latencies_array[bucket.to_i] = value.to_i
+                operation_latencies[bucket.to_i] = value.to_i
               end
 
-              latencies[operation] = latencies_array
+              latencies[operation] = operation_latencies
             end
-
-            latencies
           end
 
           def gauges
@@ -78,6 +64,35 @@ module SplitIoClient
             @adapter.delete(keys)
           end
 
+          # introduced to fix incorrect latencies
+          def fix_latencies
+            keys =[]
+
+            23.times do |index|
+              keys.concat @adapter.find_strings_by_pattern(latencies_to_be_deleted_key_pattern_prefix("sdk.get_treatment.#{index}"))
+            end
+
+            keys.concat @adapter.find_strings_by_pattern(latencies_to_be_deleted_key_pattern_prefix('sdk.get_treatments'))
+            keys.concat @adapter.find_strings_by_pattern(latencies_to_be_deleted_key_pattern_prefix('sdk.get_treatment_with_config'))
+            keys.concat @adapter.find_strings_by_pattern(latencies_to_be_deleted_key_pattern_prefix('sdk.get_treatments_with_config'))
+
+            keys.concat @adapter.find_strings_by_pattern(latencies_to_be_deleted_key_pattern_prefix('*.time'))
+
+            SplitIoClient.configuration.logger.info("Found incorrect latency keys, deleting. Keys: #{keys}") unless keys.size == 0
+
+            keys.each_slice(500) do |chunk|
+              @adapter.pipelined do
+                chunk.each do |key|
+                  @adapter.delete key
+                end
+              end
+            end
+          end
+
+          def latencies_to_be_deleted_key_pattern_prefix(key)
+            "#{SplitIoClient.configuration.redis_namespace}/#{SplitIoClient.configuration.language}-*/latency.#{key}"
+          end
+
           def clear_gauges
             # TODO
           end
@@ -87,6 +102,22 @@ module SplitIoClient
             clear_latencies
             clear_gauges
           end
+
+          private
+
+          def find_latencies(keys)
+            @adapter.multiple_strings(keys).map do |name, data|
+              [name.gsub(impressions_metrics_key('latency.'), ''), data]
+            end.to_h
+          end
+
+          def collect_latencies(keys)
+            find_latencies(keys).each_with_object({}) do |(key, value), collected_latencies|
+              operation, bucket = key.split('.bucket.')
+              collected_latencies[operation] = {} unless collected_latencies[operation]
+              collected_latencies[operation].merge!({bucket => value})
+            end
+          end
         end
       end
     end

data/lib/splitclient-rb/cache/repositories/metrics_repository.rb

@@ -5,7 +5,7 @@ module SplitIoClient
       class MetricsRepository < Repository
         extend Forwardable
         def_delegators :@adapter, :add_count, :add_latency, :add_gauge, :counts, :latencies, :gauges,
-                       :clear_counts, :clear_latencies, :clear_gauges, :clear
+                       :clear_counts, :clear_latencies, :clear_gauges, :clear, :fix_latencies
 
         def initialize(adapter)
           @adapter = case adapter.class.to_s

data/lib/splitclient-rb/redis_metrics_fixer.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module SplitIoClient
+  class RedisMetricsFixer
+    def initialize(metrics_repository)
+      @metrics_repository = metrics_repository
+    end
+
+    def call
+      return if ENV['SPLITCLIENT_ENV'] == 'test' || SplitIoClient.configuration.mode == :standalone
+
+      fixer_thread
+
+      if defined?(PhusionPassenger)
+        PhusionPassenger.on_event(:starting_worker_process) do |forked|
+          fixer_thread if forked
+        end
+      end
+    end
+
+    private
+
+    def fixer_thread
+      Thread.new do
+        begin
+          SplitIoClient.configuration.logger.info('Starting redis metrics fixer')
+
+          @metrics_repository.fix_latencies
+        rescue StandardError => error
+          SplitIoClient.configuration.log_found_exception(__method__.to_s, error)
+        end
+      end
+    end
+  end
+end

data/lib/splitclient-rb/split_factory.rb

@@ -42,6 +42,8 @@ module SplitIoClient
 
       validate_api_key
 
+      RedisMetricsFixer.new(@metrics_repository).call
+
       @sdk_blocker.block if @sdk_blocker
     end
 

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '6.4.1.pre.rc1'
+  VERSION = '6.4.1.pre.rc2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 6.4.1.pre.rc1
+  version: 6.4.1.pre.rc2
 platform: ruby
 authors:
 - Split Software
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-24 00:00:00.000000000 Z
+date: 2019-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: allocation_stats
@@ -378,6 +378,7 @@ files:
 - lib/splitclient-rb/localhost_utils.rb
 - lib/splitclient-rb/managers/localhost_split_manager.rb
 - lib/splitclient-rb/managers/split_manager.rb
+- lib/splitclient-rb/redis_metrics_fixer.rb
 - lib/splitclient-rb/split_config.rb
 - lib/splitclient-rb/split_factory.rb
 - lib/splitclient-rb/split_factory_builder.rb