splitclient-rb 6.4.0 → 6.4.1.pre.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 86c89d8f5625455516d031b21565ae8c24c9a790b2cab13340aaf7f549cddb91
-  data.tar.gz: f055fb7c29be50dc802cf009473f52179c122eb9a4ff5e3fe71a4b5d9d4f454a
+  metadata.gz: f474b8941f870d494de1e1c5314b2b880c12672cf9d46b17ceb902e99e85050a
+  data.tar.gz: 27e00346829c95698a5e19acd95d392c9805a857cb5882ef0a94ff4011ea41d5
 SHA512:
-  metadata.gz: b89e8fb171fbb6ac3b6d4ab96f6a10196bad8962f3cec4913dad5e137ad54d4495434cf48bf3010f3ce1fab34fb36d8a7b03e5515a8a2252af5d8e78d6477e93
-  data.tar.gz: 65df4efc489b8fd6124e0e5018da58a87823e060fd2f6f94fc32a91ea94105f7b8c3d847ba132862f2bf874d092a91ed75816938a38eb38dccb8b5db0af382f0
+  metadata.gz: 9463b792568144eeec07f22bd3550ad5e3b626de832752694e67c82792f884c3627e0f1b1774a3cff6168c860dbf0b248873df6848db39f1b43f487600361956
+  data.tar.gz: 8e2431113432f21f485ad67009c538bdfaba2902828e872099b2cf89e739bbbfae4c8114c20e49fa2e77357ed7cee9d0e524b341ca1d8667ba0607d6a5fd47f7

data/CHANGES.txt

@@ -1,7 +1,5 @@
-6.4.0 (Jul 05, 2019)
- - Added properties to track method.
-
 6.3.0 (Apr 30, 2019)
+
 - Added Dynamic Configurations support through two new methods that mimick the regular ones, changing the type of what is returned.
   - get_treatment_with_config: Same as get_treatment but returning the treatment with it's config.
   - get_treatments_with_config: Same as get_treatments, but instead of a map of string it returns a map of treatments with config.

data/NEWS

@@ -1,6 +1,3 @@
-6.4.0 (Jul 05, 2019)
- - Added properties to track method.
-
 6.3.0 (Apr 30, 2019)
 
 - Added Dynamic Configurations support through two new methods that mimick the regular ones, changing the type of what is returned.

data/lib/splitclient-rb/cache/repositories/metrics/memory_repository.rb

@@ -3,6 +3,8 @@ module SplitIoClient
     module Repositories
       module Metrics
         class MemoryRepository
+          OPERATIONS = %w(sdk.get_treatment sdk.get_treatments sdk.get_treatment_with_config sdk.get_treatments_with_config)
+
           def initialize(_ = nil, adapter)
             @counts = []
             @latencies = []
@@ -23,13 +25,25 @@ module SplitIoClient
           def add_latency(operation, time_in_ms, binary_search)
             operation_hash = @latencies.find { |l| l[:operation] == operation }
             if operation_hash.nil?
-              latencies_for_op = (operation == 'sdk.get_treatment') ? binary_search.add_latency_millis(time_in_ms) : [time_in_ms]
+              latencies_for_op = (OPERATIONS.include?(operation)) ? build_latencies_for_op(operation, binary_search.add_latency_millis(time_in_ms, true)) : [time_in_ms]
               @latencies << { operation: operation, latencies: latencies_for_op }
             else
-              latencies_for_op = (operation == 'sdk.get_treatment') ? binary_search.add_latency_millis(time_in_ms) : operation_hash[:latencies].push(time_in_ms)
+              (OPERATIONS.include?(operation)) ? increase_latencies_for_op(operation_hash[:latencies], binary_search.add_latency_millis(time_in_ms, true)) : operation_hash[:latencies].push(time_in_ms)
             end
           end
 
+          def build_latencies_for_op(operation, index)
+            latencies_array = Array.new(BinarySearchLatencyTracker::BUCKETS.length, 0)
+
+            latencies_array[index] = 1
+
+            latencies_array
+          end
+
+          def increase_latencies_for_op(operation_latencies_array, index)
+            operation_latencies_array[index] += 1
+          end
+
           def add_gauge(gauge, value)
             gauge_hash = @gauges.find { |g| g[:name] == gauge }
             if gauge_hash.nil?

data/lib/splitclient-rb/cache/repositories/metrics/redis_repository.rb

@@ -17,12 +17,7 @@ module SplitIoClient
           def add_latency(operation, time_in_ms, binary_search)
             prefixed_name = impressions_metrics_key("latency.#{operation}")
 
-            if operation == 'sdk.get_treatment'
-              @adapter.inc("#{prefixed_name}.#{binary_search.add_latency_millis(time_in_ms, true)}")
-              return
-            end
-
-            @adapter.append_to_string(prefixed_name, "#{time_in_ms},")
+            @adapter.inc("#{prefixed_name}.bucket.#{binary_search.add_latency_millis(time_in_ms, true)}")
           end
 
           def add_gauge(gauge, value)
@@ -40,30 +35,33 @@ module SplitIoClient
           end
 
           def latencies
-            collected_latencies = {}
-            latencies_array = Array.new(BinarySearchLatencyTracker::BUCKETS.length, 0)
             keys = @adapter.find_strings_by_prefix(impressions_metrics_key('latency'))
-
             return [] if keys.empty?
 
             found_latencies = @adapter.multiple_strings(keys).map do |name, data|
               [name.gsub(impressions_metrics_key('latency.'), ''), data]
             end.to_h
 
+            collected_latencies = {}
+
             found_latencies.each do |key, value|
-              if key.start_with?('sdk.get_treatment')
-                index = key.gsub('sdk.get_treatment.', '').to_i
-                latencies_array[index] = value.to_i
+              operation, bucket = key.split('.bucket.')
+              collected_latencies[operation] = {} unless collected_latencies[operation]
+              collected_latencies[operation].merge!({bucket => value})
+            end
 
-                next
+            latencies = {}
+
+            collected_latencies.keys.each do |operation|
+              latencies_array = Array.new(BinarySearchLatencyTracker::BUCKETS.length, 0)
+              collected_latencies[operation].each do |bucket, value|
+                latencies_array[bucket.to_i] = value.to_i
               end
 
-              collected_latencies[key] = value.split(',').map(&:to_f)
+              latencies[operation] = latencies_array
             end
 
-            collected_latencies['sdk.get_treatment'] = latencies_array unless latencies_array.reduce(:+) == 0
-
-            collected_latencies
+            latencies
           end
 
           def gauges

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '6.4.0'
+  VERSION = '6.4.1.pre.rc1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 6.4.0
+  version: 6.4.1.pre.rc1
 platform: ruby
 authors:
 - Split Software
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-05 00:00:00.000000000 Z
+date: 2019-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: allocation_stats
@@ -403,12 +403,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.10
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Ruby client for split SDK.