split_cacheable 1.0.4 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 88bf6a45b6ca1479a616341ae2e5ac7ed63c2eee
-  data.tar.gz: c091304482e6a064c71c9759e615cf4eae60a157
+  metadata.gz: 368c9295e1d66cf2cc485447c8fceb6447e9513b
+  data.tar.gz: b57ff20ea387090b991be0568ed2e8c0fecc09c9
 SHA512:
-  metadata.gz: f989aae4a469c7aa4c5fc3a0f7503b7b6fdadfb27befef780c55cc3d2e88f4f14a78ab92de4f72fbb91b5487e33a9b3d89b204ede51eb438a959640a026104c5
-  data.tar.gz: f6248284e6c30814e336c7e0e8094ce499509d82f6b01fea398ac3338ffb4552c85a132e5bb45dad264703434edba625129366ac2721701254f4be63bf6491a7
+  metadata.gz: 87a3b5c312e756ab0b264d42c56fc49ad1b2285ca83791d5c27982b85a82c9098f374ffeae9eab8cc60bc28119b7aab4136371cbc6dd9abbd7f79a2da3a74b0c
+  data.tar.gz: 9c1e0dae6f69297ee86b14dee6426efa8614d650e7636dce974944161f65168790fc2be855ed76a9578e79b04d7607a620a791de64ab4d06f396f88afc77e100

data/.travis.yml

@@ -2,4 +2,15 @@ sudo: false
 language: ruby
 rvm:
   - 2.0.0
-script: bundle exec rspec spec
+  - 2.1.7
+  - 2.2.2
+script: bundle exec rspec spec
+gemfile:
+  - gemfiles/Gemfile.split-1.2-stable
+  - gemfiles/Gemfile.split-1.1-stable
+  - gemfiles/Gemfile.split-1.0-stable
+  - gemfiles/Gemfile.rails-4.2-stable
+  - gemfiles/Gemfile.rails-4.1-stable
+  - gemfiles/Gemfile.rails-4.0-stable
+  - gemfiles/Gemfile.rails-3.2-stable
+  - Gemfile

data/README.md

@@ -16,13 +16,23 @@ Then run:
 
     bundle install
 
+### Rails 4
+
+Because this gem uses action caching, a feature removed from Rails 4, you will also need to include the `actionpack-action_caching` gem in your Gemfile:
+
+    gem 'actionpack-action_caching'
+
+Then run:
+
+    bundle install
+
 ## Why?
 
-We use action caching in Rails 3 to cache both our standard and mobile site. We wanted to be able to quickly run Split tests without worrying about setting a custom cache_path each time as well as remembering to make the needed changes to our ActiveRecord models. 
+We use action caching in Rails 3 to cache both our standard and mobile site. We wanted to be able to quickly run Split tests without worrying about setting a custom cache_path each time as well as remembering to make the needed changes to our ActiveRecord models.
 
-## How? 
+## How?
 
-Under the hood, action caching uses `fragment_cache_key` in `ActionController::Base`. This gem patches this method to incldue our generated current tests and variations. 
+Under the hood, action caching uses `fragment_cache_key` in `ActionController::Base`. This gem patches this method to incldue our generated current tests and variations.
 
 If you already override `fragment_cache_key` in your project you can get the split partial cache key we generate by calling `current_tests_and_variations`
 
@@ -33,12 +43,12 @@ We've created an easy to remember DSL for adding active tests to specific method
 ```
 class ProductController < ApplicationController
     cacheable_ab_test :login_flow,
-        :only => [:index, :some_other_method], 
-        :except => [:index, :some_other_method], 
+        :only => [:index, :some_other_method],
+        :except => [:index, :some_other_method],
         :if => Proc.new { |controller| controller.mobile_device? }
-        
+
     def index
-    
+
     end
 end
 ```
@@ -75,7 +85,7 @@ Split::Cacheable::Adapter.new(ProductController.new, :index).get_all_possible_va
 }
 ```
 
-Note that we don't evaluate the `:if` option when you instantiate the controller manually. This is because we assume `Proc`s will usually be used to decide whether to show the test based on the current request. By not evaluating the `:if`s in this scenario we are able to return all possible cache keys regardless of request type. 
+Note that we don't evaluate the `:if` option when you instantiate the controller manually. This is because we assume `Proc`s will usually be used to decide whether to show the test based on the current request. By not evaluating the `:if`s in this scenario we are able to return all possible cache keys regardless of request type.
 
 ## Development
 

data/gemfiles/Gemfile.rails-3.2-stable

@@ -0,0 +1,5 @@
+source "https://rubygems.org"
+
+gemspec path: '..'
+
+gem 'activesupport', '~> 3.2.22'

data/gemfiles/Gemfile.rails-4.0-stable

@@ -0,0 +1,6 @@
+source "https://rubygems.org"
+
+gemspec path: '..'
+
+gem 'activesupport', '~> 4.0.13'
+gem 'actionpack-action_caching'

data/gemfiles/Gemfile.rails-4.1-stable

@@ -0,0 +1,6 @@
+source "https://rubygems.org"
+
+gemspec path: '..'
+
+gem 'activesupport', '~> 4.1.13'
+gem 'actionpack-action_caching'

data/gemfiles/Gemfile.rails-4.2-stable

@@ -0,0 +1,6 @@
+source "https://rubygems.org"
+
+gemspec path: '..'
+
+gem 'activesupport', '~> 4.2.4'
+gem 'actionpack-action_caching'

data/gemfiles/Gemfile.split-1.0-stable

@@ -0,0 +1,5 @@
+source "https://rubygems.org"
+
+gemspec path: '..'
+
+gem 'split', '~> 1.0.0'

data/gemfiles/Gemfile.split-1.1-stable

@@ -0,0 +1,5 @@
+source "https://rubygems.org"
+
+gemspec path: '..'
+
+gem 'split', '~> 1.1.0'

data/gemfiles/Gemfile.split-1.2-stable

@@ -0,0 +1,5 @@
+source "https://rubygems.org"
+
+gemspec path: '..'
+
+gem 'split', '~> 1.2.0'

data/lib/split_cacheable.rb

@@ -1,6 +1,8 @@
 require "split_cacheable/version"
 require 'split_cacheable/helper'
-require 'split_cacheable/engine' if defined?(Rails) && Rails::VERSION::MAJOR === 3
+if defined?(Rails) && [3, 4].include?(Rails::VERSION::MAJOR) && ActionController::Base.methods.include?(:caches_action)
+    require 'split_cacheable/engine'
+end
 require 'split'
 
 # This is the main Adapter instance. It expects:
@@ -57,7 +59,9 @@ module Split
                 if !defined?(@controller.request) || @controller.request.nil?
                     return DEFAULT_KEY
                 else
-                    return !active_tests.empty? ? active_tests.map{|test_obj| "#{test_obj[:test_name]}/#{@controller.ab_test(test_obj[:test_name])}"}.join('/') : DEFAULT_KEY
+                    return !active_tests.empty? ? active_tests.map{ |test_obj|
+                        "#{test_obj[:test_name]}/#{@controller.send(:ab_test, test_obj[:test_name])}"
+                    }.join('/') : DEFAULT_KEY
                 end
             end
 
@@ -72,7 +76,7 @@ module Split
                     if split_test
                         test_variations << split_test.alternatives.map { |alternative|
                             "#{split_test.name}/#{alternative.name}"
-                        } 
+                        }
                     end
                 }
 
@@ -95,4 +99,4 @@ module Split
             end
         end
     end
-end
+end

data/lib/split_cacheable/version.rb

@@ -1,5 +1,5 @@
 module Split
 	module Cacheable
-		VERSION = "1.0.4"
+		VERSION = "1.2.0"
 	end
 end

data/spec/spec_helper.rb

@@ -35,7 +35,7 @@ class TestControllerWithoutRequest
     cacheable_ab_test :test_1, :only => :index
     cacheable_ab_test :test_2, :except => :show
     def index
-            
+
     end
 
     def session
@@ -58,7 +58,7 @@ class TestControllerWithRequest < TestControllerWithoutRequest
     cacheable_ab_test :test_1, :only => :index
     cacheable_ab_test :test_2, :except => :show
     def index
-        
+
     end
 
     def request(ua = 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_6; de-de) AppleWebKit/533.20.25 (KHTML, like Gecko) Version/5.0.4 Safari/533.20.27')
@@ -72,9 +72,9 @@ end
 class TestControllerWithRequestAndProc < TestControllerWithRequest
     cacheable_ab_test :test_1, :only => :index, :if => Proc.new { |c| c.mobile_device? }
     cacheable_ab_test :test_2, :except => :show, :if => Proc.new { |c| c.mobile_device? }
-    
+
     def index
-        
+
     end
 
     def mobile_device?
@@ -85,4 +85,4 @@ end
 class TestControllerWithRequestAndMultiTestOnSameAction < TestControllerWithRequest
     cacheable_ab_test :test_1, :only => :index
     cacheable_ab_test :test_2, :only => :index
-end
+end

data/split_cacheable.gemspec

@@ -8,7 +8,7 @@ Gem::Specification.new do |spec|
   spec.version       = Split::Cacheable::VERSION
   spec.authors       = ["Daniel Schwartz"]
   spec.email         = ["dschwartz88@gmail.com"]
-  spec.summary       = %q{We use action caching in Rails 3 to cache both our standard and mobile site. We wanted to be able to quickly run Split tests without worrying about setting a custom cache_path each time as well as remembering to make the needed changes to our ActiveRecord models.}
+  spec.summary       = %q{We use action caching in Rails to cache both our standard and mobile site. We wanted to be able to quickly run Split tests without worrying about setting a custom cache_path each time as well as remembering to make the needed changes to our ActiveRecord models.}
   spec.description   = %q{An extension to Split to allow for automatic cache bucket creation accross Split tests.}
   spec.homepage      = "https://github.com/harrystech/split_cacheable"
   spec.license       = "MIT"
@@ -18,8 +18,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "split", "~> 1.0.0"
-  spec.add_dependency "activesupport", ">= 3.2.17"
+  spec.add_dependency "split", ">= 1.0.0", "< 1.4"
+  spec.add_dependency "activesupport", ">= 3.2.22"
 
   spec.add_development_dependency "rspec", ">= 2.14"
   spec.add_development_dependency "pry", ">= 0"

metadata

@@ -1,97 +1,103 @@
 --- !ruby/object:Gem::Specification
 name: split_cacheable
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.2.0
 platform: ruby
 authors:
 - Daniel Schwartz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-29 00:00:00.000000000 Z
+date: 2016-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: split
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1.4'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.17
+        version: 3.2.22
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.17
+        version: 3.2.22
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.14'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mock_redis
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.11.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.11.0
 description: An extension to Split to allow for automatic cache bucket creation accross
@@ -102,13 +108,20 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - LICENSE.txt
 - README.md
 - Rakefile
+- gemfiles/Gemfile.rails-3.2-stable
+- gemfiles/Gemfile.rails-4.0-stable
+- gemfiles/Gemfile.rails-4.1-stable
+- gemfiles/Gemfile.rails-4.2-stable
+- gemfiles/Gemfile.split-1.0-stable
+- gemfiles/Gemfile.split-1.1-stable
+- gemfiles/Gemfile.split-1.2-stable
 - lib/split_cacheable.rb
 - lib/split_cacheable/engine.rb
 - lib/split_cacheable/helper.rb
@@ -126,24 +139,23 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
-summary: We use action caching in Rails 3 to cache both our standard and mobile site.
+summary: We use action caching in Rails to cache both our standard and mobile site.
   We wanted to be able to quickly run Split tests without worrying about setting a
   custom cache_path each time as well as remembering to make the needed changes to
   our ActiveRecord models.
 test_files:
 - spec/cacheable_spec.rb
 - spec/spec_helper.rb
-has_rdoc: