split 3.4.0 → 3.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9a24a0e9549dc87669984c000cc285627233dec8824829897b39c2787925ca4d
-  data.tar.gz: be237da0ea36471894503a9eee2a2dbfba2fe6f9a4563b6071950f449760e069
+  metadata.gz: c51ebd6a368635471d5c3f820488065669ac7dc1ad7ed7eba61f2c4154ca42b7
+  data.tar.gz: 7fabe9a63a07037b144b91a11c89675d48a6ec9a5883e47bf8193584c461d003
 SHA512:
-  metadata.gz: 3b5218890aedc5ec4de12c4f5b03f25eb3857aadd337c188f8cb71608ba9bc8519e8f9b4040b638d1ce443220acb5535064a7815ba71bb1d802026d2c4798e13
-  data.tar.gz: efd41eb33dd434dfd6e0c961b4c3b37b9097a0e0b7e6677ac537a62527c0b5e9938d2e7b232a6ee3e6268946ca96e6f4e38fae60ace6341d77fa82ee88affaa3
+  metadata.gz: 49c32cc9c769184b79716956046604e8f63de0fba0a87036f6cf2809803e74c376887db47e3a472d9b5acfb5172eb5d0bcea1c700bf74f799a5d259e0cf3dd49
+  data.tar.gz: b930240fd33d85f594fef51f756100f925581fc1ead0dd910a1a51417362c68ab03aea6adbb1b50076db78114a1bc842fd2cd2d4a9462b9d50aa43c25b166df8

data/lib/split/engine.rb

@@ -4,10 +4,10 @@ module Split
     initializer "split" do |app|
       if Split.configuration.include_rails_helper
         ActiveSupport.on_load(:action_controller) do
-          include Split::Helper
-          helper Split::Helper
-          include Split::CombinedExperimentsHelper
-          helper Split::CombinedExperimentsHelper
+          ::ActionController::Base.send :include, Split::Helper
+          ::ActionController::Base.helper Split::Helper
+          ::ActionController::Base.send :include, Split::CombinedExperimentsHelper
+          ::ActionController::Base.helper Split::CombinedExperimentsHelper
         end
       end
     end

data/lib/split/experiment.rb

@@ -25,7 +25,7 @@ module Split
           alternatives: load_alternatives_from_configuration,
           goals: Split::GoalsCollection.new(@name).load_from_configuration,
           metadata: load_metadata_from_configuration,
-          resettable: exp_config.fetch(:resettable, true),
+          resettable: exp_config[:resettable],
           algorithm: exp_config[:algorithm]
         }
       else
@@ -62,7 +62,7 @@ module Split
           alts = load_alternatives_from_configuration
           options[:goals] = Split::GoalsCollection.new(@name).load_from_configuration
           options[:metadata] = load_metadata_from_configuration
-          options[:resettable] = exp_config.fetch(:resettable, true)
+          options[:resettable] = exp_config[:resettable]
           options[:algorithm] = exp_config[:algorithm]
         end
       end

data/lib/split/version.rb

@@ -2,6 +2,6 @@
 module Split
   MAJOR   = 3
   MINOR   = 4
-  PATCH   = 0
+  PATCH   = 1
   VERSION = [MAJOR, MINOR, PATCH].join('.')
 end

data/spec/experiment_spec.rb

@@ -35,12 +35,6 @@ describe Split::Experiment do
       expect(experiment.resettable).to be_truthy
     end
 
-    it "should be resettable when loading from configuration" do
-      allow(Split.configuration).to receive(:experiment_for).with('some_experiment') { { alternatives: %w(a b) } }
-
-      expect(Split::Experiment.new('some_experiment')).to be_resettable
-    end
-
     it "should save to redis" do
       experiment.save
       expect(Split.redis.exists('basket_text')).to be true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: split
 version: !ruby/object:Gem::Version
-  version: 3.4.0
+  version: 3.4.1
 platform: ruby
 authors:
 - Andrew Nesbitt
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-10 00:00:00.000000000 Z
+date: 2019-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis