split 3.3.2 → 4.0.5

data/spec/user_spec.rb

@@ -1,57 +1,73 @@
-require 'spec_helper'
-require 'split/experiment_catalog'
-require 'split/experiment'
-require 'split/user'
+# frozen_string_literal: true
+
+require "spec_helper"
+require "split/experiment_catalog"
+require "split/experiment"
+require "split/user"
 
 describe Split::User do
-  let(:user_keys) { { 'link_color' => 'blue' } }
-  let(:context) { double(:session => { split:  user_keys }) }
-  let(:experiment) { Split::Experiment.new('link_color') }
+  let(:user_keys) { { "link_color" => "blue" } }
+  let(:context) { double(session: { split:  user_keys }) }
+  let(:experiment) { Split::Experiment.new("link_color") }
 
   before(:each) do
     @subject = described_class.new(context)
   end
 
-  it 'delegates methods correctly' do
-    expect(@subject['link_color']).to eq(@subject.user['link_color'])
+  it "delegates methods correctly" do
+    expect(@subject["link_color"]).to eq(@subject.user["link_color"])
   end
 
-  context '#cleanup_old_versions!' do
-    let(:user_keys) { { 'link_color:1' => 'blue' } }
+  context "#cleanup_old_versions!" do
+    let(:experiment_version) { "#{experiment.name}:1" }
+    let(:second_experiment_version) { "#{experiment.name}_another:1" }
+    let(:third_experiment_version) { "variation_of_#{experiment.name}:1" }
+    let(:user_keys) do
+      {
+        experiment_version => "blue",
+        second_experiment_version => "red",
+        third_experiment_version => "yellow"
+      }
+    end
 
-    it 'removes key if old experiment is found' do
-      @subject.cleanup_old_versions!(experiment)
-      expect(@subject.keys).to be_empty
+    before(:each) { @subject.cleanup_old_versions!(experiment) }
+
+    it "removes key if old experiment is found" do
+      expect(@subject.keys).not_to include(experiment_version)
     end
-  end 
 
-  context '#cleanup_old_experiments!' do
-    it 'removes key if experiment is not found' do
+    it "does not remove other keys" do
+      expect(@subject.keys).to include(second_experiment_version, third_experiment_version)
+    end
+  end
+
+  context "#cleanup_old_experiments!" do
+    it "removes key if experiment is not found" do
       @subject.cleanup_old_experiments!
       expect(@subject.keys).to be_empty
     end
 
-    it 'removes key if experiment has a winner' do
-      allow(Split::ExperimentCatalog).to receive(:find).with('link_color').and_return(experiment)
+    it "removes key if experiment has a winner" do
+      allow(Split::ExperimentCatalog).to receive(:find).with("link_color").and_return(experiment)
       allow(experiment).to receive(:start_time).and_return(Date.today)
       allow(experiment).to receive(:has_winner?).and_return(true)
       @subject.cleanup_old_experiments!
       expect(@subject.keys).to be_empty
     end
 
-    it 'removes key if experiment has not started yet' do
-      allow(Split::ExperimentCatalog).to receive(:find).with('link_color').and_return(experiment)
+    it "removes key if experiment has not started yet" do
+      allow(Split::ExperimentCatalog).to receive(:find).with("link_color").and_return(experiment)
       allow(experiment).to receive(:has_winner?).and_return(false)
       @subject.cleanup_old_experiments!
       expect(@subject.keys).to be_empty
     end
 
-    context 'with finished key' do
-      let(:user_keys) { { 'link_color' => 'blue', 'link_color:finished' => true } }
+    context "with finished key" do
+      let(:user_keys) { { "link_color" => "blue", "link_color:finished" => true } }
 
-      it 'does not remove finished key for experiment without a winner' do
-        allow(Split::ExperimentCatalog).to receive(:find).with('link_color').and_return(experiment)
-        allow(Split::ExperimentCatalog).to receive(:find).with('link_color:finished').and_return(nil)
+      it "does not remove finished key for experiment without a winner" do
+        allow(Split::ExperimentCatalog).to receive(:find).with("link_color").and_return(experiment)
+        allow(Split::ExperimentCatalog).to receive(:find).with("link_color:finished").and_return(nil)
         allow(experiment).to receive(:start_time).and_return(Date.today)
         allow(experiment).to receive(:has_winner?).and_return(false)
         @subject.cleanup_old_experiments!
@@ -59,6 +75,33 @@ describe Split::User do
         expect(@subject.keys).to include("link_color:finished")
       end
     end
+
+    context "when already cleaned up" do
+      before do
+        @subject.cleanup_old_experiments!
+      end
+
+      it "does not clean up again" do
+        expect(@subject).to_not receive(:keys_without_finished)
+        @subject.cleanup_old_experiments!
+      end
+    end
+  end
+
+  context "allows user to be loaded from adapter" do
+    it "loads user from adapter (RedisAdapter)" do
+      user = Split::Persistence::RedisAdapter.new(nil, 112233)
+      user["foo"] = "bar"
+
+      ab_user = Split::User.find(112233, :redis)
+
+      expect(ab_user["foo"]).to eql("bar")
+    end
+
+    it "returns nil if adapter does not implement a finder method" do
+      ab_user = Split::User.find(112233, :dual_adapter)
+      expect(ab_user).to be_nil
+    end
   end
 
   context "instantiated with custom adapter" do
@@ -72,5 +115,4 @@ describe Split::User do
       expect(@subject.user).to eq(custom_adapter)
     end
   end
-
 end

data/split.gemspec

@@ -1,4 +1,6 @@
 # -*- encoding: utf-8 -*-
+# frozen_string_literal: true
+
 $:.push File.expand_path("../lib", __FILE__)
 require "split/version"
 
@@ -7,39 +9,40 @@ Gem::Specification.new do |s|
   s.version     = Split::VERSION
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Andrew Nesbitt"]
-  s.licenses    = ['MIT']
+  s.licenses    = ["MIT"]
   s.email       = ["andrewnez@gmail.com"]
   s.homepage    = "https://github.com/splitrb/split"
   s.summary     = "Rack based split testing framework"
 
   s.metadata    = {
-   "homepage_uri" => "https://github.com/splitrb/split",
-   "changelog_uri" => "https://github.com/splitrb/split/blob/master/CHANGELOG.md",
-   "source_code_uri" => "https://github.com/splitrb/split",
-   "bug_tracker_uri" => "https://github.com/splitrb/split/issues",
-   "wiki_uri" => "https://github.com/splitrb/split/wiki",
-   "mailing_list_uri" => "https://groups.google.com/d/forum/split-ruby"
- }
-
-  s.required_ruby_version = '>= 1.9.3'
-  s.required_rubygems_version = '>= 2.0.0'
+    "homepage_uri" => "https://github.com/splitrb/split",
+    "changelog_uri" => "https://github.com/splitrb/split/blob/main/CHANGELOG.md",
+    "source_code_uri" => "https://github.com/splitrb/split",
+    "bug_tracker_uri" => "https://github.com/splitrb/split/issues",
+    "wiki_uri" => "https://github.com/splitrb/split/wiki",
+    "mailing_list_uri" => "https://groups.google.com/d/forum/split-ruby",
+    "funding_uri" => "https://opencollective.com/split"
+  }
 
-  s.rubyforge_project = "split"
+  s.required_ruby_version = ">= 2.7.0"
+  s.required_rubygems_version = ">= 2.0.0"
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.require_paths = ["lib"]
 
-  s.add_dependency 'redis',           '>= 2.1'
-  s.add_dependency 'sinatra',         '>= 1.2.6'
-  s.add_dependency 'simple-random',   '>= 0.9.3'
+  s.add_dependency "redis",           ">= 4.2"
+  s.add_dependency "sinatra",         ">= 1.2.6"
+  s.add_dependency "rubystats",       ">= 0.3.0"
+  s.add_dependency "matrix"
+  s.add_dependency "bigdecimal"
+  s.add_dependency "cgi"
 
-  s.add_development_dependency 'bundler',     '>= 1.17'
-  s.add_development_dependency 'simplecov',   '~> 0.15'
-  s.add_development_dependency 'rack-test',   '~> 0.6'
-  s.add_development_dependency 'rake',        '~> 12'
-  s.add_development_dependency 'rspec',       '~> 3.7'
-  s.add_development_dependency 'pry',         '~> 0.10'
-  s.add_development_dependency 'fakeredis',   '~> 0.7'
-  s.add_development_dependency 'rails',       '>= 4.2'
+  s.add_development_dependency "bundler",     ">= 1.17"
+  s.add_development_dependency "simplecov",   "~> 0.15"
+  s.add_development_dependency "rack-test",   "~> 2.0"
+  s.add_development_dependency "rake",        "~> 13"
+  s.add_development_dependency "rspec",       "~> 3.7"
+  s.add_development_dependency "pry",         "~> 0.10"
+  s.add_development_dependency "rails",       ">= 5.0"
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: split
 version: !ruby/object:Gem::Version
-  version: 3.3.2
+  version: 4.0.5
 platform: ruby
 authors:
 - Andrew Nesbitt
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-12 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -16,14 +15,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
@@ -39,19 +38,61 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 1.2.6
 - !ruby/object:Gem::Dependency
-  name: simple-random
+  name: rubystats
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.3.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.3.0
+- !ruby/object:Gem::Dependency
+  name: matrix
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: bigdecimal
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.3
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.3
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: cgi
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -86,28 +127,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12'
+        version: '13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12'
+        version: '13'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -136,35 +177,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.10'
-- !ruby/object:Gem::Dependency
-  name: fakeredis
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.7'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
-description: 
+        version: '5.0'
 email:
 - andrewnez@gmail.com
 executables: []
@@ -175,10 +201,13 @@ files:
 - ".csslintrc"
 - ".eslintignore"
 - ".eslintrc"
+- ".github/FUNDING.yml"
+- ".github/ISSUE_TEMPLATE/bug_report.md"
+- ".github/dependabot.yml"
+- ".github/workflows/ci.yml"
 - ".gitignore"
+- ".rspec"
 - ".rubocop.yml"
-- ".travis.yml"
-- Appraisals
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
@@ -186,16 +215,13 @@ files:
 - LICENSE
 - README.md
 - Rakefile
-- gemfiles/4.2.gemfile
-- gemfiles/5.0.gemfile
-- gemfiles/5.1.gemfile
-- gemfiles/5.2.gemfile
-- gemfiles/6.0.gemfile
 - lib/split.rb
+- lib/split/algorithms.rb
 - lib/split/algorithms/block_randomization.rb
 - lib/split/algorithms/weighted_sample.rb
 - lib/split/algorithms/whiplash.rb
 - lib/split/alternative.rb
+- lib/split/cache.rb
 - lib/split/combined_experiments_helper.rb
 - lib/split/configuration.rb
 - lib/split/dashboard.rb
@@ -235,6 +261,7 @@ files:
 - spec/algorithms/weighted_sample_spec.rb
 - spec/algorithms/whiplash_spec.rb
 - spec/alternative_spec.rb
+- spec/cache_spec.rb
 - spec/combined_experiments_helper_spec.rb
 - spec/configuration_spec.rb
 - spec/dashboard/pagination_helpers_spec.rb
@@ -264,12 +291,12 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/splitrb/split
-  changelog_uri: https://github.com/splitrb/split/blob/master/CHANGELOG.md
+  changelog_uri: https://github.com/splitrb/split/blob/main/CHANGELOG.md
   source_code_uri: https://github.com/splitrb/split
   bug_tracker_uri: https://github.com/splitrb/split/issues
   wiki_uri: https://github.com/splitrb/split/wiki
   mailing_list_uri: https://groups.google.com/d/forum/split-ruby
-post_install_message: 
+  funding_uri: https://opencollective.com/split
 rdoc_options: []
 require_paths:
 - lib
@@ -277,16 +304,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: 2.0.0
 requirements: []
-rubyforge_project: split
-rubygems_version: 2.7.6
-signing_key: 
+rubygems_version: 3.7.0.dev
 specification_version: 4
 summary: Rack based split testing framework
 test_files:
@@ -294,6 +319,7 @@ test_files:
 - spec/algorithms/weighted_sample_spec.rb
 - spec/algorithms/whiplash_spec.rb
 - spec/alternative_spec.rb
+- spec/cache_spec.rb
 - spec/combined_experiments_helper_spec.rb
 - spec/configuration_spec.rb
 - spec/dashboard/pagination_helpers_spec.rb

data/.travis.yml

@@ -1,66 +0,0 @@
-language: ruby
-rvm:
-  - 1.9.3
-  - 2.0
-  - 2.1.10
-  - 2.2.0
-  - 2.2.2
-  - 2.4.5
-  - 2.5.3
-  - 2.6.0
-
-gemfile:
-  - gemfiles/4.2.gemfile
-  - gemfiles/5.0.gemfile
-  - gemfiles/5.1.gemfile
-  - gemfiles/5.2.gemfile
-  - gemfiles/6.0.gemfile
-
-
-matrix:
-  exclude:
-  - rvm: 1.9.3
-    gemfile: gemfiles/5.0.gemfile
-  - rvm: 1.9.3
-    gemfile: gemfiles/5.1.gemfile
-  - rvm: 1.9.3
-    gemfile: gemfiles/5.2.gemfile
-  - rvm: 1.9.3
-    gemfile: gemfiles/6.0.gemfile
-  - rvm: 2.0
-    gemfile: gemfiles/5.0.gemfile
-  - rvm: 2.0
-    gemfile: gemfiles/5.1.gemfile
-  - rvm: 2.0
-    gemfile: gemfiles/5.2.gemfile
-  - rvm: 2.0
-    gemfile: gemfiles/6.0.gemfile
-  - rvm: 2.1.10
-    gemfile: gemfiles/5.0.gemfile
-  - rvm: 2.1.10
-    gemfile: gemfiles/5.1.gemfile
-  - rvm: 2.1.10
-    gemfile: gemfiles/5.2.gemfile
-  - rvm: 2.1.10
-    gemfile: gemfiles/6.0.gemfile
-  - rvm: 2.2.0
-    gemfile: gemfiles/5.0.gemfile
-  - rvm: 2.2.0
-    gemfile: gemfiles/5.1.gemfile
-  - rvm: 2.2.0
-    gemfile: gemfiles/5.2.gemfile
-  - rvm: 2.2.0
-    gemfile: gemfiles/6.0.gemfile
-  - rvm: 2.2.2
-    gemfile: gemfiles/6.0.gemfile
-  - rvm: 2.4.5
-    gemfile: gemfiles/6.0.gemfile
-
-before_install:
-  - gem install bundler --version=1.17.3
-
-script:
-  - RAILS_ENV=test bundle exec rake spec && bundle exec codeclimate-test-reporter
-
-cache: bundler
-sudo: false

data/Appraisals

@@ -1,19 +0,0 @@
-appraise "4.2" do
-  gem "rails", "~> 4.2"
-end
-
-appraise "5.0" do
-  gem "rails", "~> 5.0"
-end
-
-appraise "5.1" do
-  gem "rails", "~> 5.1"
-end
-
-appraise "5.2" do
-  gem "rails", "~> 5.2"
-end
-
-appraise "6.0" do
-  gem 'rails', '~> 6.0.0.beta3'
-end

data/gemfiles/4.2.gemfile

@@ -1,9 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "appraisal"
-gem "codeclimate-test-reporter"
-gem "rails", "~> 4.2"
-
-gemspec path: "../"

data/gemfiles/5.0.gemfile

@@ -1,9 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "appraisal"
-gem "codeclimate-test-reporter"
-gem "rails", "~> 5.0"
-
-gemspec path: "../"

data/gemfiles/5.1.gemfile

@@ -1,9 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "appraisal"
-gem "codeclimate-test-reporter"
-gem "rails", "~> 5.1"
-
-gemspec path: "../"

data/gemfiles/5.2.gemfile

@@ -1,9 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "appraisal"
-gem "codeclimate-test-reporter"
-gem "rails", "~> 5.2"
-
-gemspec path: "../"

data/gemfiles/6.0.gemfile

@@ -1,9 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "appraisal"
-gem "codeclimate-test-reporter"
-gem "rails", "~> 6.0.0.beta3"
-
-gemspec path: "../"