split 3.3.1 → 3.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: b5af227a83e5e86e548a867ee1fd5b0f99a8f735
-  data.tar.gz: 187fa1e271f499f25d12fd2b212194f51443e53c
+SHA256:
+  metadata.gz: 1d316599c60ca79cff957c25c44d5901c0c2a86c3631e516b07aeac5afc720d3
+  data.tar.gz: 004f09975e36482ab4a56b7bd63fd9d703f067a26d9e9fd99e0a80b6cc2853b5
 SHA512:
-  metadata.gz: 808297b3e08a2fe1bd1bb0fabd81544f8c82d8e3c22f514f4966d2b8b4cf8c3d06f3a972d3e70461da3ee04c03f6e693a4d79a7710d884519ee45da524f43ca0
-  data.tar.gz: 3e5ecc4dfd26bd80750ee3ca268428d0e11a6497c3195d62ae4d067b3d227a9624e5d1d31b0c8b06305265f3b583b30c6221c65c692fe9d609b33eefe2f0859a
+  metadata.gz: 9001316e86f2e91289523c51097b67dac319ee1cd9a6b27e6f323496258824afe8921fcc306a7ecdc8787406b64f6c8eaa49febf06069afe9532f42218baf8f9
+  data.tar.gz: 51b13b3950580e2b446cf688f651632ed2135dec37168e9681e9cf46623ce9707ab8db2b947ca0d1711d0a49d64e1721d4d58ba09b9f5c3fab62ef6f747f5c8f

data/.travis.yml

@@ -14,6 +14,7 @@ gemfile:
   - gemfiles/5.0.gemfile
   - gemfiles/5.1.gemfile
   - gemfiles/5.2.gemfile
+  - gemfiles/6.0.gemfile
 
 
 matrix:
@@ -24,25 +25,36 @@ matrix:
     gemfile: gemfiles/5.1.gemfile
   - rvm: 1.9.3
     gemfile: gemfiles/5.2.gemfile
+  - rvm: 1.9.3
+    gemfile: gemfiles/6.0.gemfile
   - rvm: 2.0
     gemfile: gemfiles/5.0.gemfile
   - rvm: 2.0
     gemfile: gemfiles/5.1.gemfile
   - rvm: 2.0
     gemfile: gemfiles/5.2.gemfile
+  - rvm: 2.0
+    gemfile: gemfiles/6.0.gemfile
   - rvm: 2.1.10
     gemfile: gemfiles/5.0.gemfile
   - rvm: 2.1.10
     gemfile: gemfiles/5.1.gemfile
   - rvm: 2.1.10
     gemfile: gemfiles/5.2.gemfile
+  - rvm: 2.1.10
+    gemfile: gemfiles/6.0.gemfile
   - rvm: 2.2.0
     gemfile: gemfiles/5.0.gemfile
   - rvm: 2.2.0
     gemfile: gemfiles/5.1.gemfile
   - rvm: 2.2.0
     gemfile: gemfiles/5.2.gemfile
-
+  - rvm: 2.2.0
+    gemfile: gemfiles/6.0.gemfile
+  - rvm: 2.2.2
+    gemfile: gemfiles/6.0.gemfile
+  - rvm: 2.4.5
+    gemfile: gemfiles/6.0.gemfile
 
 before_install:
   - gem install bundler --version=1.17.3

data/Appraisals

@@ -13,3 +13,7 @@ end
 appraise "5.2" do
   gem "rails", "~> 5.2"
 end
+
+appraise "6.0" do
+  gem 'rails', '~> 6.0.0.beta3'
+end

data/CHANGELOG.md

@@ -1,11 +1,33 @@
+## 3.3.2 (April 12th, 2019)
+
+Features:
+- Added uptime robot to configuration.rb (@razel1982, #556)
+- Check to see if being run in Rails application and run in before_initialize (@husteadrobert, #555)
+
+Bugfixes:
+- Fix error message interpolation (@hanibash, #553)
+- Fix Bigdecimal warnings (@agraves, #551)
+- Avoid hitting up on redis for robots/excluded users. (@andrehjr, #544)
+- Checks for defined?(request) on Helper#exclude_visitor?. (@andrehjr)
+
+Misc:
+- Update travis to add Rails 6 (@edmilton, #559)
+- Fix broken specs in developement environment (@dougpetronilio, #557)
+
 ## 3.3.1 (January 11th, 2019)
+
+Features:
 - Filter some more bots (@janosch-x, #542)
+
+Bugfixes:
 - Fix Dashboard Pagination Helper typo (@cattekin, #541)
-- Tweak RSpec instructions (@eliotsykes, #540)
 - Do not storage alternative in cookie if experiment has a winner (@sadhu89, #539)
-- Improve README regarding rspec usage (@vermaxik, #538)
 - fix user participating alternative not found (@NaturalHokke, #536)
 
+Misc:
+- Tweak RSpec instructions (@eliotsykes, #540)
+- Improve README regarding rspec usage (@vermaxik, #538)
+
 ## 3.3.0 (August 13th, 2018)
 
 Features:

data/README.md

@@ -950,4 +950,4 @@ Please note that this project is released with a [Contributor Code of Conduct](C
 
 ## Copyright
 
-[MIT License](LICENSE) © 2018 [Andrew Nesbitt](https://github.com/andrew).
+[MIT License](LICENSE) © 2019 [Andrew Nesbitt](https://github.com/andrew).

data/gemfiles/6.0.gemfile

@@ -0,0 +1,9 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "appraisal"
+gem "codeclimate-test-reporter"
+gem "rails", "~> 6.0.0.beta3"
+
+gemspec path: "../"

data/lib/split.rb

@@ -66,4 +66,11 @@ module Split
   end
 end
 
-Split.configure {}
+# Check to see if being run in a Rails application.  If so, wait until before_initialize to run configuration so Gems that create ENV variables have the chance to initialize first.
+if defined?(::Rails)
+  class Railtie < Rails::Railtie
+    config.before_initialize { Split.configure {} }
+  end
+else
+  Split.configure {}
+end

data/lib/split/combined_experiments_helper.rb

@@ -3,7 +3,7 @@ module Split
   module CombinedExperimentsHelper
     def ab_combined_test(metric_descriptor, control = nil, *alternatives)
       return nil unless experiment = find_combined_experiment(metric_descriptor)
-      raise(Split::InvalidExperimentsFormatError, 'Unable to find experiment #{metric_descriptor} in configuration') if experiment[:combined_experiments].nil?
+      raise(Split::InvalidExperimentsFormatError, "Unable to find experiment #{metric_descriptor} in configuration") if experiment[:combined_experiments].nil?
 
       alternative = nil
       weighted_alternatives = nil

data/lib/split/configuration.rb

@@ -98,6 +98,7 @@ module Split
         'Panopta' => 'Monitoring service',
         'Pingdom' => 'Pingdom monitoring',
         'SiteUptime' => 'Site monitoring services',
+        'UptimeRobot' => 'Monitoring service',
 
         # ???
         'DigitalPersona Fingerprint Software' => 'HP Fingerprint scanner',

data/lib/split/dashboard/helpers.rb

@@ -19,9 +19,9 @@ module Split
 
     def round(number, precision = 2)
       begin
-        BigDecimal.new(number.to_s)
+        BigDecimal(number.to_s)
       rescue ArgumentError
-        BigDecimal.new(0)
+        BigDecimal(0)
       end.round(precision).to_f
     end
 

data/lib/split/helper.rb

@@ -8,7 +8,7 @@ module Split
     def ab_test(metric_descriptor, control = nil, *alternatives)
       begin
         experiment = ExperimentCatalog.find_or_initialize(metric_descriptor, control, *alternatives)
-        alternative = if Split.configuration.enabled
+        alternative = if Split.configuration.enabled && !exclude_visitor?
           experiment.save
           raise(Split::InvalidExperimentsFormatError) unless (Split.configuration.experiments || {}).fetch(experiment.name.to_sym, {})[:combined_experiments].nil?
           trial = Trial.new(:user => ab_user, :experiment => experiment,
@@ -122,7 +122,7 @@ module Split
     end
 
     def exclude_visitor?
-      instance_exec(request, &Split.configuration.ignore_filter) || is_ignored_ip_address? || is_robot? || is_preview?
+      defined?(request) && (instance_exec(request, &Split.configuration.ignore_filter) || is_ignored_ip_address? || is_robot? || is_preview?)
     end
 
     def is_robot?

data/lib/split/version.rb

@@ -2,6 +2,6 @@
 module Split
   MAJOR   = 3
   MINOR   = 3
-  PATCH   = 1
+  PATCH   = 2
   VERSION = [MAJOR, MINOR, PATCH].join('.')
 end

data/spec/helper_spec.rb

@@ -564,6 +564,11 @@ describe Split::Helper do
         expect(alternative).to eq experiment.control.name
       end
 
+      it 'should not create a experiment' do
+        ab_test('link_color', 'blue', 'red')
+        expect(Split::Experiment.new('link_color')).to be_a_new_record
+      end
+
       it "should not increment the participation count" do
 
         previous_red_count = Split::Alternative.new('red', 'link_color').participant_count

data/split.gemspec

@@ -41,4 +41,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rspec',       '~> 3.7'
   s.add_development_dependency 'pry',         '~> 0.10'
   s.add_development_dependency 'fakeredis',   '~> 0.7'
+  s.add_development_dependency 'rails',       '>= 4.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: split
 version: !ruby/object:Gem::Version
-  version: 3.3.1
+  version: 3.3.2
 platform: ruby
 authors:
 - Andrew Nesbitt
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-11 00:00:00.000000000 Z
+date: 2019-04-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -150,6 +150,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.7'
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '4.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '4.2'
 description: 
 email:
 - andrewnez@gmail.com
@@ -176,6 +190,7 @@ files:
 - gemfiles/5.0.gemfile
 - gemfiles/5.1.gemfile
 - gemfiles/5.2.gemfile
+- gemfiles/6.0.gemfile
 - lib/split.rb
 - lib/split/algorithms/block_randomization.rb
 - lib/split/algorithms/weighted_sample.rb
@@ -270,7 +285,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 2.0.0
 requirements: []
 rubyforge_project: split
-rubygems_version: 2.6.14.3
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Rack based split testing framework