split 2.1.0 → 2.2.0

data/spec/redis_interface_spec.rb

@@ -0,0 +1,111 @@
+require 'spec_helper'
+
+describe Split::RedisInterface do
+  let(:list_name) { 'list_name' }
+  let(:set_name) { 'set_name' }
+  let(:interface) { described_class.new }
+
+  describe '#persist_list' do
+    subject(:persist_list) do
+      interface.persist_list(list_name, %w(a b c d))
+    end
+
+    specify do
+      expect(persist_list).to eq %w(a b c d)
+      expect(Split.redis.lindex(list_name, 0)).to eq 'a'
+      expect(Split.redis.lindex(list_name, 1)).to eq 'b'
+      expect(Split.redis.lindex(list_name, 2)).to eq 'c'
+      expect(Split.redis.lindex(list_name, 3)).to eq 'd'
+      expect(Split.redis.llen(list_name)).to eq 4
+    end
+
+    context 'list is overwritten but not deleted' do
+      specify do
+        expect(persist_list).to eq %w(a b c d)
+        interface.persist_list(list_name, ['z'])
+        expect(Split.redis.lindex(list_name, 0)).to eq 'z'
+        expect(Split.redis.llen(list_name)).to eq 1
+      end
+    end
+  end
+
+  describe '#add_to_list' do
+    subject(:add_to_list) do
+      interface.add_to_list(list_name, 'y')
+      interface.add_to_list(list_name, 'z')
+    end
+
+    specify do
+      add_to_list
+      expect(Split.redis.lindex(list_name, 0)).to eq 'y'
+      expect(Split.redis.lindex(list_name, 1)).to eq 'z'
+      expect(Split.redis.llen(list_name)).to eq 2
+    end
+  end
+
+  describe '#set_list_index' do
+    subject(:set_list_index) do
+      interface.add_to_list(list_name, 'y')
+      interface.add_to_list(list_name, 'z')
+      interface.set_list_index(list_name, 0, 'a')
+    end
+
+    specify do
+      set_list_index
+      expect(Split.redis.lindex(list_name, 0)).to eq 'a'
+      expect(Split.redis.lindex(list_name, 1)).to eq 'z'
+      expect(Split.redis.llen(list_name)).to eq 2
+    end
+  end
+
+  describe '#list_length' do
+    subject(:list_length) do
+      interface.add_to_list(list_name, 'y')
+      interface.add_to_list(list_name, 'z')
+      interface.list_length(list_name)
+    end
+
+    specify do
+      expect(list_length).to eq 2
+    end
+  end
+
+  describe '#remove_last_item_from_list' do
+    subject(:remove_last_item_from_list) do
+      interface.add_to_list(list_name, 'y')
+      interface.add_to_list(list_name, 'z')
+      interface.remove_last_item_from_list(list_name)
+    end
+
+    specify do
+      remove_last_item_from_list
+      expect(Split.redis.lindex(list_name, 0)).to eq 'y'
+      expect(Split.redis.llen(list_name)).to eq 1
+    end
+  end
+
+  describe '#make_list_length' do
+    subject(:make_list_length) do
+      interface.add_to_list(list_name, 'y')
+      interface.add_to_list(list_name, 'z')
+      interface.make_list_length(list_name, 1)
+    end
+
+    specify do
+      make_list_length
+      expect(Split.redis.lindex(list_name, 0)).to eq 'y'
+      expect(Split.redis.llen(list_name)).to eq 1
+    end
+  end
+
+  describe '#add_to_set' do
+    subject(:add_to_set) do
+      interface.add_to_set(set_name, 'something')
+    end
+
+    specify do
+      add_to_set
+      expect(Split.redis.sismember(set_name, 'something')).to be true
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -4,33 +4,34 @@ ENV['RACK_ENV'] = "test"
 require 'rubygems'
 require 'bundler/setup'
 
-require 'coveralls'
-Coveralls.wear!
+require 'simplecov'
+SimpleCov.start
 
 require 'split'
 require 'ostruct'
 require 'yaml'
-require 'complex' if RUBY_VERSION.match(/1\.8/)
 
 Dir['./spec/support/*.rb'].each { |f| require f }
 
 require "fakeredis"
 
-fakeredis = Redis.new
+G_fakeredis = Redis.new
 
-RSpec.configure do |config|
-  config.order = 'random'
-  config.before(:each) do
+module GlobalSharedContext
+  extend RSpec::SharedContext
+  let(:mock_user){ Split::User.new(double(session: {})) }
+  before(:each) do
     Split.configuration = Split::Configuration.new
-    Split.redis = fakeredis
+    Split.redis = G_fakeredis
     Split.redis.flushall
     @ab_user = mock_user
     params = nil
   end
 end
 
-def mock_user
-  Split::User.new(double(session: {}))
+RSpec.configure do |config|
+  config.order = 'random'
+  config.include GlobalSharedContext
 end
 
 def session

data/spec/split_spec.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+require 'spec_helper'
+
+RSpec.describe Split do
+
+  around(:each) do |ex|
+    old_env, old_redis = [ENV.delete('REDIS_URL'), Split.redis]
+    ex.run
+    ENV['REDIS_URL'] = old_env
+    Split.redis = old_redis
+  end
+
+  describe '#redis=' do
+    it 'accepts a url string' do
+      Split.redis = 'redis://localhost:6379'
+      expect(Split.redis).to be_a(Redis)
+
+      client = Split.redis.client
+      expect(client.host).to eq("localhost")
+      expect(client.port).to eq(6379)
+    end
+
+    it 'accepts an options hash' do
+      Split.redis = {host: 'localhost', port: 6379, db: 12}
+      expect(Split.redis).to be_a(Redis)
+
+      client = Split.redis.client
+      expect(client.host).to eq("localhost")
+      expect(client.port).to eq(6379)
+      expect(client.db).to eq(12)
+    end
+
+    it 'accepts a valid Redis instance' do
+      other_redis = Redis.new(url: "redis://localhost:6379")
+      Split.redis = other_redis
+      expect(Split.redis).to eq(other_redis)
+    end
+
+    it 'raises an ArgumentError when server cannot be determined' do
+      expect { Split.redis = Object.new }.to raise_error(ArgumentError)
+    end
+  end
+end

data/split.gemspec

@@ -21,15 +21,14 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
 
   s.add_dependency 'redis',           '>= 2.1'
-  s.add_dependency 'redis-namespace', '>= 1.1.0'
   s.add_dependency 'sinatra',         '>= 1.2.6'
   s.add_dependency 'simple-random',   '>= 0.9.3'
 
   s.add_development_dependency 'bundler',     '~> 1.10'
-  s.add_development_dependency 'coveralls',   '~> 0.8'
+  s.add_development_dependency 'simplecov',   '~> 0.12'
   s.add_development_dependency 'rack-test',   '~> 0.6'
   s.add_development_dependency 'rake',        '~> 11.1'
   s.add_development_dependency 'rspec',       '~> 3.4'
   s.add_development_dependency 'pry',         '~> 0.10'
-  s.add_development_dependency 'fakeredis',   '~> 0.5.0'
+  s.add_development_dependency 'fakeredis',   '~> 0.6.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: split
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.0
 platform: ruby
 authors:
 - Andrew Nesbitt
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-08 00:00:00.000000000 Z
+date: 2016-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -24,20 +24,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '2.1'
-- !ruby/object:Gem::Dependency
-  name: redis-namespace
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.1.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
@@ -81,19 +67,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.10'
 - !ruby/object:Gem::Dependency
-  name: coveralls
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0.12'
 - !ruby/object:Gem::Dependency
   name: rack-test
   requirement: !ruby/object:Gem::Requirement
@@ -156,14 +142,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.6.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.6.0
 description: 
 email:
 - andrewnez@gmail.com
@@ -171,7 +157,12 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
+- ".csslintrc"
+- ".eslintignore"
+- ".eslintrc"
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - Appraisals
 - CHANGELOG.md
@@ -183,6 +174,7 @@ files:
 - Rakefile
 - gemfiles/4.1.gemfile
 - gemfiles/4.2.gemfile
+- gemfiles/5.0.gemfile
 - lib/split.rb
 - lib/split/algorithms.rb
 - lib/split/algorithms/weighted_sample.rb
@@ -207,7 +199,6 @@ files:
 - lib/split/experiment.rb
 - lib/split/experiment_catalog.rb
 - lib/split/extensions.rb
-- lib/split/extensions/array.rb
 - lib/split/extensions/string.rb
 - lib/split/goals_collection.rb
 - lib/split/helper.rb
@@ -217,6 +208,7 @@ files:
 - lib/split/persistence/dual_adapter.rb
 - lib/split/persistence/redis_adapter.rb
 - lib/split/persistence/session_adapter.rb
+- lib/split/redis_interface.rb
 - lib/split/trial.rb
 - lib/split/user.rb
 - lib/split/version.rb
@@ -234,10 +226,13 @@ files:
 - spec/helper_spec.rb
 - spec/metric_spec.rb
 - spec/persistence/cookie_adapter_spec.rb
+- spec/persistence/dual_adapter_spec.rb
 - spec/persistence/redis_adapter_spec.rb
 - spec/persistence/session_adapter_spec.rb
 - spec/persistence_spec.rb
+- spec/redis_interface_spec.rb
 - spec/spec_helper.rb
+- spec/split_spec.rb
 - spec/support/cookies_mock.rb
 - spec/trial_spec.rb
 - spec/user_spec.rb
@@ -280,11 +275,13 @@ test_files:
 - spec/helper_spec.rb
 - spec/metric_spec.rb
 - spec/persistence/cookie_adapter_spec.rb
+- spec/persistence/dual_adapter_spec.rb
 - spec/persistence/redis_adapter_spec.rb
 - spec/persistence/session_adapter_spec.rb
 - spec/persistence_spec.rb
+- spec/redis_interface_spec.rb
 - spec/spec_helper.rb
+- spec/split_spec.rb
 - spec/support/cookies_mock.rb
 - spec/trial_spec.rb
 - spec/user_spec.rb
-has_rdoc: 

data/lib/split/extensions/array.rb

@@ -1,5 +0,0 @@
-# frozen_string_literal: true
-class Array
-  # maintain backwards compatibility with 1.8.7
-  alias_method :sample, :choice unless method_defined?(:sample)
-end