split 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9fa1bd87e254e6e0bc2f244f3fd6e479d40e096f
-  data.tar.gz: c50789065bf80c9b850bdc0851d1b6dbcd330183
+  metadata.gz: c3be3075da830ca06ace5ff9a940376dd572ba01
+  data.tar.gz: 817bc46b6d8a5042523e347fcf4b6607edefe16f
 SHA512:
-  metadata.gz: d1ce3cc70e83f014d69136754658030b310aaff9450d6ad8750011202d071f44a0157c824e79a0a4dd7938e2534090949e6f138c913c799caec02ba01b2b277c
-  data.tar.gz: db2e2a14bdd4bfb3e8620c211e74cf649dbfe9c67a0555e1304f79ab2e8c9da707c5798816d90887c4f2d1f7ab2ad87d99157d00125801eb29afb8026033983b
+  metadata.gz: ca0a492e129fcf2a823950c47d5db418a56ba3841680cb9057958570bf1444d619c12bb095b46d2e816056bc94b058ad79e2dc6358f3514e24b63d011013fe7a
+  data.tar.gz: 5207f26da88b7eaf4a47ad73c340b238de9dc7ee1874d684501bf4ee9190cbc8333f7ea37070ca6734d97569c7733ed0a3d88b7d81665b7c8220563a20b0dcd9

data/.travis.yml

@@ -1,13 +1,14 @@
 language: ruby
 rvm:
-  - 2.2.0
+  - 2.2.4
 
 gemfile:
-  - gemfiles/3.2.gemfile
-  - gemfiles/4.0.gemfile
   - gemfiles/4.1.gemfile
   - gemfiles/4.2.gemfile
 
+before_install:
+  - gem install bundler
+
 services:
    - redis-server
 cache: bundler

data/Appraisals

@@ -1,15 +1,7 @@
-appraise "3.2" do
-  gem "rails", "~> 3.2.21"
-end
-
-appraise "4.0" do
-  gem "rails", "~> 4.0.13"
-end
-
 appraise "4.1" do
-  gem "rails", "~> 4.1.10"
+  gem "rails", "~> 4.1"
 end
 
 appraise "4.2" do
-  gem "rails", "~> 4.2.1"
+  gem "rails", "~> 4.2"
 end

data/CHANGELOG.md

@@ -1,6 +1,12 @@
+## 1.3.1 (January 1st, 2016)
+
+Bugfixes:
+
+- Fix the dashboard for experiments with ‘/‘ in the name. (@craigmcnamara, #349)
+
 ## 1.3.0 (October 20th, 2015)
 
-Features
+Features:
 
  - allow for custom redis_url different from ENV variable (@davidgrieser, #323)
  - add ability to change the length of the persistence cookie (@peterylai, #335)
@@ -18,7 +24,7 @@ Misc:
 
 ## 1.2.1 (May 17th, 2015)
 
-Features
+Features:
 
  - Handle redis DNS resolution failures gracefully (@fusion2004, #310)
  - Push metadata to ab_test block (@ekorneeff, #296)
@@ -38,7 +44,7 @@ Misc:
 
 ## 1.2.0 (January 24th, 2015)
 
-Features
+Features:
 
   - Configure redis using environment variables if available (@saratovsource , #293)
   - Store metadata on experiment configuration (@dekz, #291)
@@ -108,7 +114,7 @@ Features:
 
   - You can now reopen experiment from the dashboard (@mikezaby, #235)
 
-Misc
+Misc:
 
   - Internal code tidy up (@IanVaughan, #238)
 
@@ -123,7 +129,7 @@ Bugfixes:
 
   - Fixed start button not being displayed in some cases (@vigosan, #219)
 
-Misc
+Misc:
 
   - Experiment#initialize refactoring (@nberger, #224)
   - Extract ExperimentStore into a seperate class (@nberger, #225)

data/LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2015 Andrew Nesbitt
+Copyright (c) 2016 Andrew Nesbitt
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -125,7 +125,7 @@ ab_test(:homepage_design, {'Old' => 18}, {'New' => 2})
 
 ab_test(:homepage_design, 'Old', {'New' => 1.0/9})
 
-ab_test(:homepage_design', {'Old' => 9}, 'New')
+ab_test(:homepage_design, {'Old' => 9}, 'New')
 ```
 
 This will only show the new alternative to visitors 1 in 10 times, the default weight for an alternative is 1.
@@ -661,6 +661,7 @@ end
   - [Split::Mongoid](https://github.com/MongoHQ/split-mongoid) - store experiment data in mongoid (still uses redis)
   - [Split::Cacheable](https://github.com/harrystech/split_cacheable) - automatically create cache buckets per test
   - [Split::Counters](https://github.com/bernardkroes/split-counters) - add counters per experiment and alternative
+  - [Split::Cli](https://github.com/craigmcnamara/split-cli) - a CLI to trigger Split A/B tests
 
 ## Screencast
 
@@ -697,4 +698,4 @@ Tests can be ran with `rake spec`
 
 ## Copyright
 
-Copyright (c) 2015 Andrew Nesbitt. See [LICENSE](https://github.com/splitrb/split/blob/master/LICENSE) for details.
+Copyright (c) 2016 Andrew Nesbitt. See [LICENSE](https://github.com/splitrb/split/blob/master/LICENSE) for details.

data/gemfiles/4.1.gemfile

@@ -3,6 +3,6 @@
 source "https://rubygems.org"
 
 gem "appraisal"
-gem "rails", "~> 4.1.10"
+gem "rails", "~> 4.1"
 
 gemspec :path => "../"

data/gemfiles/4.2.gemfile

@@ -3,6 +3,6 @@
 source "https://rubygems.org"
 
 gem "appraisal"
-gem "rails", "~> 4.2.1"
+gem "rails", "~> 4.2"
 
 gemspec :path => "../"

data/lib/split/dashboard.rb

@@ -29,32 +29,32 @@ module Split
       erb :index
     end
 
-    post '/:experiment' do
+    post '/experiment' do
       @experiment = Split::ExperimentCatalog.find(params[:experiment])
       @alternative = Split::Alternative.new(params[:alternative], params[:experiment])
       @experiment.winner = @alternative.name
       redirect url('/')
     end
 
-    post '/start/:experiment' do
+    post '/start' do
       @experiment = Split::ExperimentCatalog.find(params[:experiment])
       @experiment.start
       redirect url('/')
     end
 
-    post '/reset/:experiment' do
+    post '/reset' do
       @experiment = Split::ExperimentCatalog.find(params[:experiment])
       @experiment.reset
       redirect url('/')
     end
 
-    post '/reopen/:experiment' do
+    post '/reopen' do
       @experiment = Split::ExperimentCatalog.find(params[:experiment])
       @experiment.reset_winner
       redirect url('/')
     end
 
-    delete '/:experiment' do
+    delete '/experiment' do
       @experiment = Split::ExperimentCatalog.find(params[:experiment])
       @experiment.delete
       redirect url('/')

data/lib/split/dashboard/views/_controls.erb

@@ -1,18 +1,18 @@
 <% if experiment.has_winner? %>
-  <form action="<%= url "/reopen/#{experiment.name}" %>" method='post' onclick="return confirmReopen()">
+  <form action="<%= url "/reopen?experiment=#{experiment.name}" %>" method='post' onclick="return confirmReopen()">
     <input type="submit" value="Reopen Experiment">
   </form>
 <% end %>
 <% if experiment.start_time %>
-  <form action="<%= url "/reset/#{experiment.name}" %>" method='post' onclick="return confirmReset()">
+  <form action="<%= url "/reset?experiment=#{experiment.name}" %>" method='post' onclick="return confirmReset()">
     <input type="submit" value="Reset Data">
   </form>
 <% else%>
-  <form action="<%= url "/start/#{experiment.name}" %>" method='post'>
+  <form action="<%= url "/start?experiment=#{experiment.name}" %>" method='post'>
     <input type="submit" value="Start">
   </form>
 <% end %>
-<form action="<%= url "/#{experiment.name}" %>" method='post' onclick="return confirmDelete()">
+<form action="<%= url "/?experiment=#{experiment.name}" %>" method='post' onclick="return confirmDelete()">
   <input type="hidden" name="_method" value="delete"/>
   <input type="submit" value="Delete" class="red">
 </form>

data/lib/split/dashboard/views/_experiment.erb

@@ -95,7 +95,7 @@
               Loser
             <% end %>
           <% else %>
-            <form action="<%= url experiment.name %>" method='post' onclick="return confirmWinner()">
+            <form action="<%= url('experiment') + '?experiment=' + experiment.name %>" method='post' onclick="return confirmWinner()">
               <input type='hidden' name='alternative' value='<%= h alternative.name %>'>
               <input type="submit" value="Use this" class="green">
             </form>

data/lib/split/experiment.rb

@@ -400,11 +400,12 @@ module Split
     end
 
     def jstring(goal = nil)
-      unless goal.nil?
-        jstring = name + "-" + goal
-      else
-        jstring = name
-      end
+      js_id = if goal.nil?
+                name
+              else
+                name + "-" + goal
+              end
+      js_id.gsub('/', '--')
     end
 
     protected

data/lib/split/version.rb

@@ -1,6 +1,6 @@
 module Split
   MAJOR   = 1
   MINOR   = 3
-  PATCH   = 0
+  PATCH   = 1
   VERSION = [MAJOR, MINOR, PATCH].join('.')
 end

data/spec/configuration_spec.rb

@@ -182,7 +182,7 @@ describe Split::Configuration do
           let(:input) { '' }
 
           it "should raise an error" do
-            expect { @config.experiments = yaml }.to raise_error
+            expect { @config.experiments = yaml }.to raise_error(Split::InvalidExperimentsFormatError)
           end
         end
 
@@ -190,7 +190,7 @@ describe Split::Configuration do
           let(:input) { '---' }
 
           it "should raise an error" do
-            expect { @config.experiments = yaml }.to raise_error
+            expect { @config.experiments = yaml }.to raise_error(Split::InvalidExperimentsFormatError)
           end
         end
       end

data/spec/dashboard_spec.rb

@@ -44,7 +44,7 @@ describe Split::Dashboard do
         get '/'
         expect(last_response.body).to include('Start')
 
-        post "/start/#{experiment.name}"
+        post "/start?experiment=#{experiment.name}"
         get '/'
         expect(last_response.body).to include('Reset Data')
         expect(last_response.body).not_to include('Metrics:')
@@ -65,7 +65,7 @@ describe Split::Dashboard do
         get '/'
         expect(last_response.body).to include('Start')
 
-        post "/start/#{experiment.name}"
+        post "/start?experiment=#{experiment.name}"
         get '/'
         expect(last_response.body).to include('Reset Data')
       end
@@ -96,13 +96,13 @@ describe Split::Dashboard do
     before { experiment.winner = 'red' }
 
     it 'redirects' do
-      post "/reopen/#{experiment.name}"
+      post "/reopen?experiment=#{experiment.name}"
 
       expect(last_response).to be_redirect
     end
 
     it "removes winner" do
-      post "/reopen/#{experiment.name}"
+      post "/reopen?experiment=#{experiment.name}"
 
       expect(experiment).to_not have_winner
     end
@@ -112,7 +112,7 @@ describe Split::Dashboard do
       blue_link.participant_count = 7
       experiment.winner = 'blue'
 
-      post "/reopen/#{experiment.name}"
+      post "/reopen?experiment=#{experiment.name}"
 
       expect(red_link.participant_count).to eq(5)
       expect(blue_link.participant_count).to eq(7)
@@ -124,7 +124,7 @@ describe Split::Dashboard do
     blue_link.participant_count = 7
     experiment.winner = 'blue'
 
-    post "/reset/#{experiment.name}"
+    post "/reset?experiment=#{experiment.name}"
 
     expect(last_response).to be_redirect
 
@@ -137,14 +137,14 @@ describe Split::Dashboard do
   end
 
   it "should delete an experiment" do
-    delete "/#{experiment.name}"
+    delete "/experiment?experiment=#{experiment.name}"
     expect(last_response).to be_redirect
     expect(Split::ExperimentCatalog.find(experiment.name)).to be_nil
   end
 
   it "should mark an alternative as the winner" do
     expect(experiment.winner).to be_nil
-    post "/#{experiment.name}", :alternative => 'red'
+    post "/experiment?experiment=#{experiment.name}", :alternative => 'red'
 
     expect(last_response).to be_redirect
     expect(experiment.winner.name).to eq('red')

data/spec/experiment_catalog_spec.rb

@@ -13,11 +13,11 @@ describe Split::ExperimentCatalog do
     end
 
     it "should raise the appropriate error when passed integers for alternatives" do
-      expect { subject.find_or_create('xyz', 1, 2, 3) }.to raise_error
+      expect { subject.find_or_create('xyz', 1, 2, 3) }.to raise_error(ArgumentError)
     end
 
     it "should raise the appropriate error when passed symbols for alternatives" do
-      expect { subject.find_or_create('xyz', :a, :b, :c) }.to raise_error
+      expect { subject.find_or_create('xyz', :a, :b, :c) }.to raise_error(ArgumentError)
     end
 
     it "should not raise error when passed an array for goals" do

data/spec/experiment_spec.rb

@@ -343,8 +343,8 @@ describe Split::Experiment do
 
   describe 'alternatives passed as non-strings' do
     it "should throw an exception if an alternative is passed that is not a string" do
-      expect(lambda { Split::ExperimentCatalog.find_or_create('link_color', :blue, :red) }).to raise_error
-      expect(lambda { Split::ExperimentCatalog.find_or_create('link_enabled', true, false) }).to raise_error
+      expect(lambda { Split::ExperimentCatalog.find_or_create('link_color', :blue, :red) }).to raise_error(ArgumentError)
+      expect(lambda { Split::ExperimentCatalog.find_or_create('link_enabled', true, false) }).to raise_error(ArgumentError)
     end
   end
 

data/spec/helper_spec.rb

@@ -19,11 +19,11 @@ describe Split::Helper do
     end
 
     it "should raise the appropriate error when passed integers for alternatives" do
-      expect(lambda { ab_test('xyz', 1, 2, 3) }).to raise_error
+      expect(lambda { ab_test('xyz', 1, 2, 3) }).to raise_error(ArgumentError)
     end
 
     it "should raise the appropriate error when passed symbols for alternatives" do
-      expect(lambda { ab_test('xyz', :a, :b, :c) }).to raise_error
+      expect(lambda { ab_test('xyz', :a, :b, :c) }).to raise_error(ArgumentError)
     end
 
     it "should not raise error when passed an array for goals" do
@@ -449,7 +449,7 @@ describe Split::Helper do
       expect(active_experiments.first[0]).to eq "def"
       expect(active_experiments.first[1]).to eq alternative
     end
-    
+
     it 'should show an active test when an experiment is on a later version' do
       experiment.reset
       expect(experiment.version).to eq(1)
@@ -696,13 +696,13 @@ describe Split::Helper do
 
       describe 'ab_test' do
         it 'should raise an exception' do
-          expect(lambda { ab_test('link_color', 'blue', 'red') }).to raise_error
+          expect(lambda { ab_test('link_color', 'blue', 'red') }).to raise_error(Errno::ECONNREFUSED)
         end
       end
 
       describe 'finished' do
         it 'should raise an exception' do
-          expect(lambda { finished('link_color') }).to raise_error
+          expect(lambda { finished('link_color') }).to raise_error(Errno::ECONNREFUSED)
         end
       end
 
@@ -907,11 +907,11 @@ describe Split::Helper do
 
     it "fails gracefully if config is missing experiment" do
       Split.configuration.experiments = { :other_experiment => { :foo => "Bar" } }
-      expect(lambda { ab_test :my_experiment }).to raise_error
+      expect(lambda { ab_test :my_experiment }).to raise_error(Split::ExperimentNotFound)
     end
 
     it "fails gracefully if config is missing" do
-      expect(lambda { Split.configuration.experiments = nil }).to raise_error
+      expect(lambda { Split.configuration.experiments = nil }).to raise_error(Split::InvalidExperimentsFormatError)
     end
 
     it "fails gracefully if config is missing alternatives" do

data/spec/persistence/redis_adapter_spec.rb

@@ -11,8 +11,7 @@ describe Split::Persistence::RedisAdapter do
 
     context 'default' do
       it 'should raise error with prompt to set lookup_by' do
-        expect{Split::Persistence::RedisAdapter.new(context)
-              }.to raise_error
+        expect{Split::Persistence::RedisAdapter.new(context)}.to raise_error(RuntimeError)
       end
     end
 

data/spec/persistence_spec.rb

@@ -18,7 +18,7 @@ describe Split::Persistence do
 
       it "should raise if the adapter cannot be found" do
         expect(Split.configuration).to receive(:persistence).twice.and_return(:something_weird)
-        expect { subject.adapter }.to raise_error
+        expect { subject.adapter }.to raise_error(Split::InvalidPersistenceAdapterError)
       end
     end
     context "when the persistence config is a class" do

data/split.gemspec

@@ -25,9 +25,9 @@ Gem::Specification.new do |s|
   s.add_dependency 'sinatra',         '>= 1.2.6'
   s.add_dependency 'simple-random'
 
-  s.add_development_dependency 'bundler',     '~> 1.7'
-  s.add_development_dependency 'coveralls'
-  s.add_development_dependency 'rack-test'
-  s.add_development_dependency 'rake'
-  s.add_development_dependency 'rspec',       '~> 3.1.0'
+  s.add_development_dependency 'bundler',     '~> 1.10'
+  s.add_development_dependency 'coveralls',   '~> 0.8'
+  s.add_development_dependency 'rack-test',   '~> 0.6'
+  s.add_development_dependency 'rake',        '~> 10.4'
+  s.add_development_dependency 'rspec',       '~> 3.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: split
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Andrew Nesbitt
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-20 00:00:00.000000000 Z
+date: 2016-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -72,70 +72,70 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '1.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '1.10'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
   name: rack-test
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.4'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '3.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '3.4'
 description: 
 email:
 - andrewnez@gmail.com
@@ -152,8 +152,6 @@ files:
 - LICENSE
 - README.md
 - Rakefile
-- gemfiles/3.2.gemfile
-- gemfiles/4.0.gemfile
 - gemfiles/4.1.gemfile
 - gemfiles/4.2.gemfile
 - lib/split.rb
@@ -229,7 +227,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: split
-rubygems_version: 2.4.8
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Rack based split testing framework
@@ -252,4 +250,3 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/cookies_mock.rb
 - spec/trial_spec.rb
-has_rdoc: 

data/gemfiles/3.2.gemfile

@@ -1,8 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "appraisal"
-gem "rails", "~> 3.2.21"
-
-gemspec :path => "../"

data/gemfiles/4.0.gemfile

@@ -1,8 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "appraisal"
-gem "rails", "~> 4.0.13"
-
-gemspec :path => "../"