split 0.8.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b45369489c7a861f224af9981f7636825c08164e
-  data.tar.gz: 5b494f25bbf014a457fe17e84525db6f4269b3a0
+  metadata.gz: a3b1309c8ead9c52a0d0d6fe52c9b7e14caf82ea
+  data.tar.gz: 79d96d59eb43b6ce77fd9822f4f324cf4cf8b1e7
 SHA512:
-  metadata.gz: d320a8d67b4bedb538a63a5268b35bc7b358a7e68ab8fbdf4a0970704d32f452c982192f70e74c9d34190088894063633cd3ca2ced6ccfc20e6696dad225ed63
-  data.tar.gz: 33e8beb7302afe08d0b266eabf315ea27091119f82317772551f18c10af349f3925be9f63162a4a15907b0858f495fd04750ca2981e0592443dbe1ad9a36af2b
+  metadata.gz: c206f354515025bfbb3acae7641c99216078493f0d3de1d4bcabee6224ce6b44fd920af04ded93c807c7a07d8167fe6fd6e4c3fe008b83e521d5332f62023c65
+  data.tar.gz: e7613adebd501d9a4caa5d1c68f41cbec9b6b363a4da61a086865e356ebd360761e39ec47bb6b8de567d1499b8d47ea39ba0015b67a120ef2e5fefacc1fe16c0

data/CONTRIBUTING.md

@@ -1,4 +1,7 @@
 ## Contributing
+
+*Note*: Split requires Ruby 1.9.2 or higher. 
+
 * Fork the project.
 * Make your feature addition or bug fix.
 * Add tests for it. This is important so I don't break it in a

data/README.mdown

@@ -14,6 +14,8 @@ Split is designed to be hacker friendly, allowing for maximum customisation and
 
 ## Requirements
 
+Split currently requires Ruby 1.9.2 or higher. If your project requires compatibility with Ruby 1.8.x and Rails 2.3, please use v0.8.0.
+
 Split uses redis as a datastore.
 
 Split only supports redis 2.0 or greater.
@@ -53,29 +55,10 @@ and require it in your project:
 require 'split'
 ```
 
-### SystemTimer
-
-If you are using Redis on Ruby 1.8.x then you will likely want to also use the SystemTimer gem if you want to make sure the Redis client will not hang.
-
-Put the following in your gemfile as well:
-
-```
-gem 'SystemTimer'
-```
-
 ### Rails 3
 
 Split is autoloaded when rails starts up, as long as you've configured redis it will 'just work'.
 
-### Rails 2.3
-
-To configure Rails 2.3 with Split you need to mix in the helper methods. Add the following lines to config/initializers.split.rb:
-
-```ruby
-ActionController::Base.send :include, Split::Helper
-ActionController::Base.helper Split::Helper
-```
-
 ### Sinatra
 
 To configure sinatra with Split you need to enable sessions and mix in the helper methods. Add the following lines at the top of your sinatra app:
@@ -163,8 +146,6 @@ ab_test('homepage design', 'Old', {'New' => 0.1})
 ab_test('homepage design', {'Old' => 10}, 'New')
 ```
 
-Note: If using ruby 1.8.x and weighted alternatives you should always pass the control alternative through as the second argument with any other alternatives as a third argument because the order of the hash is not preserved in ruby 1.8, ruby 1.9.1+ users are not affected by this bug.
-
 This will only show the new alternative to visitors 1 in 10 times, the default weight for an alternative is 1.
 
 ### Overriding alternatives
@@ -354,7 +335,7 @@ end
 
 You can even use Devise or any other Warden-based authentication method to authorize users. Just replace `mount Split::Dashboard, :at => 'split'` in `config/routes.rb` with the following:
 ```ruby
-match "/split" => Split::Dashboard, :anchor => false, :constraints => lambda { |request|
+match "/split" => Split::Dashboard, :anchor => false, :via => [:get, :post], :constraints => lambda { |request|
   request.env['warden'].authenticated? # are we authenticated?
   request.env['warden'].authenticate! # authenticate if not already
   # or even check any other condition such as request.env['warden'].user.is_admin?

data/lib/split.rb

@@ -15,7 +15,7 @@
   require "split/#{f}"
 end
 
-require 'split/engine' if defined?(Rails) && Rails::VERSION::MAJOR >= 3
+require 'split/engine' if defined?(Rails)
 require 'redis/namespace'
 
 module Split

data/lib/split/helper.rb

@@ -2,9 +2,6 @@ module Split
   module Helper
 
     def ab_test(metric_descriptor, control=nil, *alternatives)
-      if RUBY_VERSION.match(/1\.8/) && alternatives.length.zero? && ! control.nil?
-        puts 'WARNING: You should always pass the control alternative through as the second argument with any other alternatives as the third because the order of the hash is not preserved in ruby 1.8'
-      end
 
       # Check if array is passed to ab_test
       # e.g. ab_test('name', ['Alt 1', 'Alt 2', 'Alt 3'])

data/lib/split/version.rb

@@ -1,6 +1,6 @@
 module Split
-  MAJOR   = 0
-  MINOR   = 8
+  MAJOR   = 1
+  MINOR   = 0
   PATCH   = 0
   VERSION = [MAJOR, MINOR, PATCH].join('.')
 end

data/spec/experiment_spec.rb

@@ -397,7 +397,7 @@ describe Split::Experiment do
       experiment.alternatives.each do |alternative|
         alternative.participant_count = 50
         alternative.set_completed_count(10, goal1)
-        alternative.set_completed_count(10+rand(30), goal2)
+        alternative.set_completed_count(15+rand(30), goal2)
       end
       experiment.calc_winning_alternatives
       alt = experiment.alternatives[0]

data/split.gemspec

@@ -12,6 +12,8 @@ Gem::Specification.new do |s|
   s.homepage    = "https://github.com/andrew/split"
   s.summary     = %q{Rack based split testing framework}
 
+  s.required_ruby_version = '>= 1.9.2'
+
   s.rubyforge_project = "split"
 
   s.files         = `git ls-files`.split("\n")
@@ -23,11 +25,6 @@ Gem::Specification.new do |s|
   s.add_dependency 'sinatra',         '>= 1.2.6'
   s.add_dependency 'simple-random'
 
-  # Ruby 1.8 doesn't include JSON in the std lib
-  if RUBY_VERSION < "1.9"
-    s.add_dependency 'json',            '>= 1.7.7'
-  end
-
   s.add_development_dependency 'rake'
   s.add_development_dependency 'bundler',     '~> 1.6'
   s.add_development_dependency 'rspec',       '~> 3.0'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: split
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Andrew Nesbitt
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-25 00:00:00.000000000 Z
+date: 2014-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -143,7 +143,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".DS_Store"
 - ".gitignore"
 - ".travis.yml"
 - Appraisals
@@ -224,7 +223,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="