split 0.5.0 → 0.6.0

data/spec/persistence/cookie_adapter_spec.rb

@@ -28,4 +28,11 @@ describe Split::Persistence::CookieAdapter do
     end
   end
 
-end
+  it "handles invalid JSON" do
+    context.cookies[:split] = { :value => '{"foo":2,', :expires => Time.now }
+    subject["my_key"].should be_nil
+    subject["my_key"] = "my_value"
+    subject["my_key"].should eq("my_value")
+  end
+
+end

data/spec/spec_helper.rb

@@ -4,6 +4,7 @@ require 'rubygems'
 require 'bundler/setup'
 require 'split'
 require 'ostruct'
+require 'yaml'
 require 'complex' if RUBY_VERSION.match(/1\.8/)
 
 Dir['./spec/support/*.rb'].each { |f| require f }

data/spec/trial_spec.rb

@@ -4,7 +4,7 @@ require 'split/trial'
 describe Split::Trial do
   it "should be initializeable" do
     experiment  = mock('experiment')
-    alternative = mock('alternative')
+    alternative = mock('alternative', :kind_of? => Split::Alternative)
     trial = Split::Trial.new(:experiment => experiment, :alternative => alternative)
     trial.experiment.should == experiment
     trial.alternative.should == alternative
@@ -12,13 +12,14 @@ describe Split::Trial do
 
   describe "alternative" do
     it "should use the alternative if specified" do
-      trial = Split::Trial.new(:experiment => experiment = mock('experiment'), :alternative => alternative = mock('alternative'))
+      alternative = mock('alternative', :kind_of? => Split::Alternative)
+      trial = Split::Trial.new(:experiment => experiment = mock('experiment'), :alternative => alternative)
       trial.should_not_receive(:choose)
       trial.alternative.should == alternative
     end
 
     it "should populate alternative with a full alternative object after calling choose" do
-      experiment = Split::Experiment.new('basket_text', :alternative_names => ['basket', 'cart'])
+      experiment = Split::Experiment.new('basket_text', :alternatives => ['basket', 'cart'])
       experiment.save
       trial = Split::Trial.new(:experiment => experiment)
       trial.choose
@@ -27,7 +28,7 @@ describe Split::Trial do
     end
 
     it "should populate an alternative when only one option is offerred" do
-      experiment = Split::Experiment.new('basket_text', :alternative_names => ['basket'])
+      experiment = Split::Experiment.new('basket_text', :alternatives => ['basket'])
       experiment.save
       trial = Split::Trial.new(:experiment => experiment)
       trial.choose
@@ -38,9 +39,10 @@ describe Split::Trial do
 
     it "should choose from the available alternatives" do
       trial = Split::Trial.new(:experiment => experiment = mock('experiment'))
-      experiment.should_receive(:next_alternative).and_return(alternative = mock('alternative'))
+      alternative = mock('alternative', :kind_of? => Split::Alternative)
+      experiment.should_receive(:next_alternative).and_return(alternative)
       alternative.should_receive(:increment_participation)
-      experiment.should_receive(:winner).and_return nil
+      experiment.stub(:winner).and_return nil
       trial.choose!
 
       trial.alternative.should == alternative
@@ -49,10 +51,10 @@ describe Split::Trial do
 
   describe "alternative_name" do
     it "should load the alternative when the alternative name is set" do
-      experiment = Split::Experiment.new('basket_text', :alternative_names => ['basket', "cart"])
+      experiment = Split::Experiment.new('basket_text', :alternatives => ['basket', "cart"])
       experiment.save
 
-      trial = Split::Trial.new(:experiment => experiment, :alternative_name => 'basket')
+      trial = Split::Trial.new(:experiment => experiment, :alternative => 'basket')
       trial.alternative.name.should == 'basket'
     end
   end

data/split.gemspec

@@ -24,7 +24,7 @@ Gem::Specification.new do |s|
 
   # Ruby 1.8 doesn't include JSON in the std lib
   if RUBY_VERSION < "1.9"
-    s.add_dependency 'json',            '>= 1.7.5'
+    s.add_dependency 'json',            '>= 1.7.7'
   end
 
   s.add_development_dependency 'rake'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: split
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-28 00:00:00.000000000 Z
+date: 2013-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
-  requirement: &70342380332380 !ruby/object:Gem::Requirement
+  requirement: &70363788679740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '2.1'
   type: :runtime
   prerelease: false
-  version_requirements: *70342380332380
+  version_requirements: *70363788679740
 - !ruby/object:Gem::Dependency
   name: redis-namespace
-  requirement: &70342380331880 !ruby/object:Gem::Requirement
+  requirement: &70363788691860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: 1.1.0
   type: :runtime
   prerelease: false
-  version_requirements: *70342380331880
+  version_requirements: *70363788691860
 - !ruby/object:Gem::Dependency
   name: sinatra
-  requirement: &70342380331420 !ruby/object:Gem::Requirement
+  requirement: &70363788708940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: 1.2.6
   type: :runtime
   prerelease: false
-  version_requirements: *70342380331420
+  version_requirements: *70363788708940
 - !ruby/object:Gem::Dependency
   name: simple-random
-  requirement: &70342380331040 !ruby/object:Gem::Requirement
+  requirement: &70363788722360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70342380331040
+  version_requirements: *70363788722360
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70342380330560 !ruby/object:Gem::Requirement
+  requirement: &70363788720900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70342380330560
+  version_requirements: *70363788720900
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70342380330060 !ruby/object:Gem::Requirement
+  requirement: &70363788716120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -76,10 +76,10 @@ dependencies:
         version: '1.0'
   type: :development
   prerelease: false
-  version_requirements: *70342380330060
+  version_requirements: *70363788716120
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70342380329560 !ruby/object:Gem::Requirement
+  requirement: &70363788729360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -87,10 +87,10 @@ dependencies:
         version: '2.12'
   type: :development
   prerelease: false
-  version_requirements: *70342380329560
+  version_requirements: *70363788729360
 - !ruby/object:Gem::Dependency
   name: rack-test
-  requirement: &70342380329100 !ruby/object:Gem::Requirement
+  requirement: &70363788751640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -98,7 +98,7 @@ dependencies:
         version: '0.6'
   type: :development
   prerelease: false
-  version_requirements: *70342380329100
+  version_requirements: *70363788751640
 description: 
 email:
 - andrewnez@gmail.com
@@ -126,6 +126,7 @@ files:
 - lib/split/dashboard/public/reset.css
 - lib/split/dashboard/public/style.css
 - lib/split/dashboard/views/_experiment.erb
+- lib/split/dashboard/views/_experiment_with_goal_header.erb
 - lib/split/dashboard/views/index.erb
 - lib/split/dashboard/views/layout.erb
 - lib/split/engine.rb