split 0.4.6 → 0.5.0

data/spec/persistence/session_adapter_spec.rb

@@ -0,0 +1,31 @@
+require "spec_helper"
+
+describe Split::Persistence::SessionAdapter do
+
+  let(:context) { mock(:session => {}) }
+  subject { Split::Persistence::SessionAdapter.new(context) }
+
+  describe "#[] and #[]=" do
+    it "should set and return the value for given key" do
+      subject["my_key"] = "my_value"
+      subject["my_key"].should eq("my_value")
+    end
+  end
+
+  describe "#delete" do
+    it "should delete the given key" do
+      subject["my_key"] = "my_value"
+      subject.delete("my_key")
+      subject["my_key"].should be_nil
+    end
+  end
+
+  describe "#keys" do
+    it "should return an array of the session's stored keys" do
+      subject["my_key"] = "my_value"
+      subject["my_second_key"] = "my_second_value"
+      subject.keys.should =~ ["my_key", "my_second_key"]
+    end
+  end
+
+end

data/spec/persistence_spec.rb

@@ -0,0 +1,33 @@
+require "spec_helper"
+
+describe Split::Persistence do
+
+  subject { Split::Persistence }
+
+  describe ".adapter" do
+    context "when the persistence config is a symbol" do
+      it "should return the appropriate adapter for the symbol" do
+        Split.configuration.stub(:persistence).and_return(:cookie)
+        subject.adapter.should eq(Split::Persistence::CookieAdapter)
+      end
+
+      it "should return an adapter whose class is present in Split::Persistence::ADAPTERS" do
+        Split.configuration.stub(:persistence).and_return(:cookie)
+        Split::Persistence::ADAPTERS.values.should include(subject.adapter)
+      end
+
+      it "should raise if the adapter cannot be found" do
+        Split.configuration.stub(:persistence).and_return(:something_weird)
+        expect { subject.adapter }.to raise_error(Split::InvalidPersistenceAdapterError)
+      end
+    end
+    context "when the persistence config is a class" do
+      let(:custom_adapter_class) { MyCustomAdapterClass = Class.new }
+      it "should return that class" do
+        Split.configuration.stub(:persistence).and_return(custom_adapter_class)
+        subject.adapter.should eq(MyCustomAdapterClass)
+      end
+    end
+  end
+
+end

data/spec/spec_helper.rb

@@ -6,6 +6,18 @@ require 'split'
 require 'ostruct'
 require 'complex' if RUBY_VERSION.match(/1\.8/)
 
+Dir['./spec/support/*.rb'].each { |f| require f }
+
+RSpec.configure do |config|
+  config.order = 'random'
+  config.before(:each) do
+    Split.configuration = Split::Configuration.new
+    Split.redis.flushall
+    @ab_user = {}
+    params = nil
+  end
+end
+
 def session
   @session ||= {}
 end

data/spec/support/cookies_mock.rb

@@ -0,0 +1,19 @@
+class CookiesMock
+
+  def initialize
+    @cookies = {}
+  end
+
+  def []=(key, value)
+    @cookies[key] = value[:value]
+  end
+
+  def [](key)
+    @cookies[key]
+  end
+
+  def delete(key)
+    @cookies.delete(key)
+  end
+
+end

data/spec/trial_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+require 'split/trial'
+
+describe Split::Trial do
+  it "should be initializeable" do
+    experiment  = mock('experiment')
+    alternative = mock('alternative')
+    trial = Split::Trial.new(:experiment => experiment, :alternative => alternative)
+    trial.experiment.should == experiment
+    trial.alternative.should == alternative
+  end
+
+  describe "alternative" do
+    it "should use the alternative if specified" do
+      trial = Split::Trial.new(:experiment => experiment = mock('experiment'), :alternative => alternative = mock('alternative'))
+      trial.should_not_receive(:choose)
+      trial.alternative.should == alternative
+    end
+
+    it "should populate alternative with a full alternative object after calling choose" do
+      experiment = Split::Experiment.new('basket_text', :alternative_names => ['basket', 'cart'])
+      experiment.save
+      trial = Split::Trial.new(:experiment => experiment)
+      trial.choose
+      trial.alternative.class.should == Split::Alternative
+      ['basket', 'cart'].should include(trial.alternative.name)
+    end
+
+    it "should populate an alternative when only one option is offerred" do
+      experiment = Split::Experiment.new('basket_text', :alternative_names => ['basket'])
+      experiment.save
+      trial = Split::Trial.new(:experiment => experiment)
+      trial.choose
+      trial.alternative.class.should == Split::Alternative
+      trial.alternative.name.should == 'basket'
+    end
+
+
+    it "should choose from the available alternatives" do
+      trial = Split::Trial.new(:experiment => experiment = mock('experiment'))
+      experiment.should_receive(:next_alternative).and_return(alternative = mock('alternative'))
+      alternative.should_receive(:increment_participation)
+      experiment.should_receive(:winner).and_return nil
+      trial.choose!
+
+      trial.alternative.should == alternative
+    end
+  end
+
+  describe "alternative_name" do
+    it "should load the alternative when the alternative name is set" do
+      experiment = Split::Experiment.new('basket_text', :alternative_names => ['basket', "cart"])
+      experiment.save
+
+      trial = Split::Trial.new(:experiment => experiment, :alternative_name => 'basket')
+      trial.alternative.name.should == 'basket'
+    end
+  end
+end

data/split.gemspec

@@ -15,16 +15,20 @@ Gem::Specification.new do |s|
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
   s.add_dependency 'redis',           '>= 2.1'
   s.add_dependency 'redis-namespace', '>= 1.1.0'
   s.add_dependency 'sinatra',         '>= 1.2.6'
+  s.add_dependency 'simple-random'
+
+  # Ruby 1.8 doesn't include JSON in the std lib
+  if RUBY_VERSION < "1.9"
+    s.add_dependency 'json',            '>= 1.7.5'
+  end
 
   s.add_development_dependency 'rake'
   s.add_development_dependency 'bundler',     '~> 1.0'
-  s.add_development_dependency 'rspec',       '~> 2.6'
+  s.add_development_dependency 'rspec',       '~> 2.12'
   s.add_development_dependency 'rack-test',   '~> 0.6'
-  s.add_development_dependency 'guard-rspec', '~> 1.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: split
 version: !ruby/object:Gem::Version
-  version: 0.4.6
+  version: 0.5.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-28 00:00:00.000000000 Z
+date: 2013-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
-  requirement: &70093446916440 !ruby/object:Gem::Requirement
+  requirement: &70342380332380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '2.1'
   type: :runtime
   prerelease: false
-  version_requirements: *70093446916440
+  version_requirements: *70342380332380
 - !ruby/object:Gem::Dependency
   name: redis-namespace
-  requirement: &70093446931800 !ruby/object:Gem::Requirement
+  requirement: &70342380331880 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: 1.1.0
   type: :runtime
   prerelease: false
-  version_requirements: *70093446931800
+  version_requirements: *70342380331880
 - !ruby/object:Gem::Dependency
   name: sinatra
-  requirement: &70093446947900 !ruby/object:Gem::Requirement
+  requirement: &70342380331420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,21 @@ dependencies:
         version: 1.2.6
   type: :runtime
   prerelease: false
-  version_requirements: *70093446947900
+  version_requirements: *70342380331420
+- !ruby/object:Gem::Dependency
+  name: simple-random
+  requirement: &70342380331040 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: *70342380331040
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70093446950180 !ruby/object:Gem::Requirement
+  requirement: &70342380330560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70093446950180
+  version_requirements: *70342380330560
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70093447002840 !ruby/object:Gem::Requirement
+  requirement: &70342380330060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,21 +76,21 @@ dependencies:
         version: '1.0'
   type: :development
   prerelease: false
-  version_requirements: *70093447002840
+  version_requirements: *70342380330060
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70093447013900 !ruby/object:Gem::Requirement
+  requirement: &70342380329560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.6'
+        version: '2.12'
   type: :development
   prerelease: false
-  version_requirements: *70093447013900
+  version_requirements: *70342380329560
 - !ruby/object:Gem::Dependency
   name: rack-test
-  requirement: &70093447010320 !ruby/object:Gem::Requirement
+  requirement: &70342380329100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -87,18 +98,7 @@ dependencies:
         version: '0.6'
   type: :development
   prerelease: false
-  version_requirements: *70093447010320
-- !ruby/object:Gem::Dependency
-  name: guard-rspec
-  requirement: &70093447018620 !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '1.2'
-  type: :development
-  prerelease: false
-  version_requirements: *70093447018620
+  version_requirements: *70342380329100
 description: 
 email:
 - andrewnez@gmail.com
@@ -109,12 +109,15 @@ files:
 - .gitignore
 - .travis.yml
 - CHANGELOG.mdown
+- CONTRIBUTING.md
 - Gemfile
-- Guardfile
 - LICENSE
 - README.mdown
 - Rakefile
 - lib/split.rb
+- lib/split/algorithms.rb
+- lib/split/algorithms/weighted_sample.rb
+- lib/split/algorithms/whiplash.rb
 - lib/split/alternative.rb
 - lib/split/configuration.rb
 - lib/split/dashboard.rb
@@ -126,16 +129,33 @@ files:
 - lib/split/dashboard/views/index.erb
 - lib/split/dashboard/views/layout.erb
 - lib/split/engine.rb
+- lib/split/exceptions.rb
 - lib/split/experiment.rb
+- lib/split/extensions.rb
+- lib/split/extensions/array.rb
+- lib/split/extensions/string.rb
 - lib/split/helper.rb
+- lib/split/metric.rb
+- lib/split/persistence.rb
+- lib/split/persistence/cookie_adapter.rb
+- lib/split/persistence/session_adapter.rb
+- lib/split/trial.rb
 - lib/split/version.rb
+- spec/algorithms/weighted_sample_spec.rb
+- spec/algorithms/whiplash_spec.rb
 - spec/alternative_spec.rb
 - spec/configuration_spec.rb
 - spec/dashboard_helpers_spec.rb
 - spec/dashboard_spec.rb
 - spec/experiment_spec.rb
 - spec/helper_spec.rb
+- spec/metric_spec.rb
+- spec/persistence/cookie_adapter_spec.rb
+- spec/persistence/session_adapter_spec.rb
+- spec/persistence_spec.rb
 - spec/spec_helper.rb
+- spec/support/cookies_mock.rb
+- spec/trial_spec.rb
 - split.gemspec
 homepage: https://github.com/andrew/split
 licenses: []
@@ -162,10 +182,19 @@ signing_key:
 specification_version: 3
 summary: Rack based split testing framework
 test_files:
+- spec/algorithms/weighted_sample_spec.rb
+- spec/algorithms/whiplash_spec.rb
 - spec/alternative_spec.rb
 - spec/configuration_spec.rb
 - spec/dashboard_helpers_spec.rb
 - spec/dashboard_spec.rb
 - spec/experiment_spec.rb
 - spec/helper_spec.rb
+- spec/metric_spec.rb
+- spec/persistence/cookie_adapter_spec.rb
+- spec/persistence/session_adapter_spec.rb
+- spec/persistence_spec.rb
 - spec/spec_helper.rb
+- spec/support/cookies_mock.rb
+- spec/trial_spec.rb
+has_rdoc: 

data/Guardfile

@@ -1,5 +0,0 @@
-guard 'rspec', :version => 2 do
-  watch(%r{^spec/.+_spec\.rb$})
-  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
-  watch('spec/spec_helper.rb')  { "spec" }
-end