split-counters 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f3f6a298b34fbb6e817f9f200bcd4789a180a1d2
-  data.tar.gz: 4dead8b7639298a0795c6f3863065c205abe7876
+  metadata.gz: e9c81db5233d5b9f5c1f4f12c6dd0fc5ed070efe
+  data.tar.gz: 8156386a3041a17f2f71ae5bc3e75ab5ba47ceb7
 SHA512:
-  metadata.gz: 5e43a0776886cc1b5ef7a1e9182becd3a5dc4999eacc8a7b02ec957e3a58629961cec0657b7b71caedfe7393718f63078d286b59f9249844ce4d4e9f7c598188
-  data.tar.gz: 69f8f55e94dfc7d4ac8c6d0cf030cf33638c92de65d0f1b95d31bcab9555417c4ea08dad8a691547fce644d813b552100f31860f579266ddc2d9e162771675bf
+  metadata.gz: 8da2383690a10a6399c7f313460b4ad5993bd77b2ca2c4db10852fc76fd911645b57ff911028b812a1844a6fd2e4d6b5fcadb87eccc8795399d229a7a69527f7
+  data.tar.gz: bce9992dea9629b319082696307413db71c7f95b5f6a4341f1493ce659f137d75b9d072b0efec2a4d777a6dabb9b12bc1170a0739d0e804de645cdde22345cb6

data/Readme.mdown

@@ -45,15 +45,19 @@ A simple example in a Rails app could be:
 def index
   the_ab_test = ab_test("exp", "alt1", "alt2")
 
-  ab_counter_inc("IndexViews", "exp", the_ab_test)
-  ab_counter_inc("PageViews", "exp", ab_test("exp", "alt1", "alt2"))
+  if !exclude_visitor?
+    ab_counter_inc("IndexViews", "exp", the_ab_test)
+    ab_counter_inc("PageViews", "exp", ab_test("exp", "alt1", "alt2"))
+  end
 end
 
 def other
   the_ab_test = ab_test("exp", "alt1", "alt2")
 
-  ab_counter_inc("OtherViews", "exp", the_ab_test)
-  ab_counter_inc("PageViews", "exp", ab_test("exp", "alt1", "alt2"))
+  if !exclude_visitor?
+    ab_counter_inc("OtherViews", "exp", the_ab_test)
+    ab_counter_inc("PageViews", "exp", ab_test("exp", "alt1", "alt2"))
+  end
 end
 ```
 

data/lib/split/counters.rb

@@ -21,6 +21,7 @@ module Split
     end
 
     def self.inc(name, experiment, alternative)
+      Split.redis.sadd(:counters, name)
       Split.redis.hincrby(Split::Counters.hash_name_for_name(name), Split::Counters.keyname_for_experiment_and_alternative(experiment, alternative), 1)
     end
 
@@ -33,6 +34,7 @@ module Split
     end
 
     def self.delete(name)
+      Split.redis.srem(:counters, name)
       Split.redis.del(Split::Counters.hash_name_for_name(name))
     end
 
@@ -52,7 +54,7 @@ module Split
     end
 
     def self.all_counter_names
-      Split.redis.keys("co:*").collect { |k| k.gsub(/^.*:/,"") }
+      Split.redis.smembers(:counters)
     end
   end
 end

data/lib/split/counters/version.rb

@@ -1,5 +1,5 @@
 module Split
   module Counters
-    VERSION = "0.3.0"
+    VERSION = "0.3.1"
   end
 end

data/spec/counters_spec.rb

@@ -17,6 +17,7 @@ describe Split::Counters do
     it "should create a counter upon using it, if it does not exist" do
       Split::Counters.inc('co', 'exp1', 'alt1')
       Split::Counters.current_value('co', 'exp1', 'alt1').should eq("1")
+      Split::Counters.all_counter_names.should include('co')
     end
 
     it "should create a counter directly upon using it, if it does not exist" do
@@ -29,8 +30,10 @@ describe Split::Counters do
     it "should be possible to delete a counter" do
       Split::Counters.inc('co','exp1', 'alt1')
       Split::Counters.exists?('co').should eq(true)
+      Split::Counters.all_counter_names.should include('co')
       Split::Counters.delete('co')
       Split::Counters.exists?('co').should eq(false)
+      Split::Counters.all_counter_names.should_not include('co')
     end
 
     it "should be possible to reset a counter" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: split-counters
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Bernard Kroes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-29 00:00:00.000000000 Z
+date: 2015-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: split
@@ -83,7 +83,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.6
+rubygems_version: 2.1.11
 signing_key: 
 specification_version: 4
 summary: Split extension for counting things per experiment and alternative