splicer-dns_made_easy 2.2.7 → 2.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bf6f322a7d147d93167887385e53f1dc3b56d9b9
-  data.tar.gz: 47c9dcd718199ef4dd9048a582dfcc0550b84ddc
+  metadata.gz: 56bf8afdce6164b612bc0df414bc476b78f055af
+  data.tar.gz: 17eac9d8d8d2442b7a2d942bb90576c1c916f617
 SHA512:
-  metadata.gz: 30e0ff9d7123cc9cb579330ef6706b4efb253d436dfdd560294b128606a0939c6ca3481c64c08c687de1b98a58c1d0dcbf4c6208c663940fd7e35a016d50c086
-  data.tar.gz: 87fc82d2ee280b183ef4d87d66890a33f5b1a136c7dc7b0c20ef187faf3646256ee7bc91d1268576eaf69e4c46997b68ba0306724e97e8a992d57b05a3269baa
+  metadata.gz: 6ac08e2d5a935707378cd0aec0f21954c1199d1c9acd5bc985be67835c1309f6f31895407ec03014b1072a8350617f7931dffd19931edf68ae91d6fc66933d5c
+  data.tar.gz: 13c7a7e93fd4f2202283894e6b229d6d46ef642ceecb86cc9e2350167d5d8fc7518bc12fa23eb52adc40510a0de79791f886cedf00f246addf7f9212a78a9783

data/lib/splicer/dns_made_easy/client.rb

@@ -93,15 +93,11 @@ module Splicer
         Splicer.logger.debug "[SPLICER][DNSMADEEASY] method=#{args[:method]} url=#{args[:url]} headers=#{args[:headers]} payload=#{args[:payload]} response=#{response}"
         response
       rescue RestClient::Exception => error
+        request_params = { method: args[:method], url: args[:url], headers: args[:headers], payload: args[:payload] }
         if error.response
           Splicer.logger.debug "[SPLICER][DNSMADEEASY] method=#{args[:method]} url=#{args[:url]} request_headers=#{args[:headers]} payload=#{args[:payload]} response_headers=#{error.response.raw_headers}"
           raise Splicer::Errors::RequestError.new(error, {
-            request: {
-              method: args[:method],
-              url: args[:url],
-              headers: args[:headers],
-              payload: args[:payload]
-            },
+            request: request_params,
             response: {
               message: error.response,
               headers: error.response.raw_headers
@@ -109,14 +105,7 @@ module Splicer
           })
         else
           Splicer.logger.debug "[SPLICER][DNSMADEEASY] method=#{args[:method]} url=#{args[:url]} request_headers=#{args[:headers]} payload=#{args[:payload]}"
-          raise Splicer::Errors::RequestError.new(error, {
-            request: {
-              method: args[:method],
-              url: args[:url],
-              headers: args[:headers],
-              payload: args[:payload]
-            }
-          })
+          raise Splicer::Errors::RequestError.new(error, { request: request_params })
         end
       end
 

data/lib/splicer/dns_made_easy/provider.rb

@@ -93,9 +93,6 @@ module Splicer
           @records << new_record
         end
         @records
-      rescue => error
-        Splicer.logger.error "[SPLICER][DNSMADEEASY] #fetch_records domain_id=#{domain_id} #{error.message}"
-        []
       end
 
       # @param [Integer] domain_id
@@ -116,9 +113,6 @@ module Splicer
         else
           [Record.new(response['data'])]
         end
-      rescue Splicer::Errors::Error => error
-        Splicer.logger.error "[SPLICER][DNSMADEEASY] #find_records name=#{name} type=#{type} domain_id=#{domain_id} #{error.message}"
-        []
       end
 
       def create_domain(zone)
@@ -173,7 +167,7 @@ module Splicer
         response = JSON.parse(client.get("dns/managed/id/#{name}"))
         Domain.new(response)
       rescue Splicer::Errors::RequestError => error
-        Domain.new
+        Domain.new({error: error.data})
       end
 
       # Returns a hash for the record data
@@ -183,7 +177,7 @@ module Splicer
         payload = {
           type: record.type,
           gtdLocation: 'DEFAULT',
-          name: record.name ? record.name : '',
+          name: record.name || '',
           ttl: record.ttl
         }
         case record

data/lib/splicer/dns_made_easy/version.rb

@@ -1,5 +1,5 @@
 module Splicer
   module DnsMadeEasy
-    VERSION = '2.2.7'
+    VERSION = '2.2.8'
   end
 end

data/spec/splicer/dns_made_easy/client_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe Splicer::DnsMadeEasy::Client do
   let(:client) { Splicer::DnsMadeEasy::Client.new('key','secret') }
   describe '#initialize' do
-    it "should initialize" do
+    it 'should initialize' do
       expect(client).to be_a(Splicer::DnsMadeEasy::Client)
     end
   end
@@ -11,13 +11,13 @@ describe Splicer::DnsMadeEasy::Client do
   describe '#post' do
     subject { client.post('resource', { data: 'something' }) }
 
-    context 'when Dynect returns with success' do
+    context 'when DNS Made Easy returns with success' do
       before { client.stub(:execute).and_return({}) }
       it { should eq({})}
     end
 
-    context 'when Dynect returns with an error' do
-      before { client.stub(:execute).and_raise(Splicer::Errors::RequestError) }
+    context 'when DNS Made Easy returns with an error' do
+      before { client.stub(:execute).and_raise(Splicer::Errors::RequestError.new('error')) }
       it 'should raise a Splicer::Errors::RequestError' do
         expect { subject }.to raise_error(Splicer::Errors::RequestError)
       end
@@ -27,13 +27,13 @@ describe Splicer::DnsMadeEasy::Client do
   describe '#get' do
     subject { client.get('resource') }
 
-    context 'when Dynect returns with success' do
+    context 'when DNS Made Easy returns with success' do
       before { client.stub(:execute).and_return({}) }
       it { should eq({})}
     end
 
-    context 'when Dynect returns with an error' do
-      before { client.stub(:execute).and_raise(Splicer::Errors::RequestError) }
+    context 'when DNS Made Easy returns with an error' do
+      before { client.stub(:execute).and_raise(Splicer::Errors::RequestError.new('error')) }
       it 'should raise a Splicer::Errors::RequestError' do
         expect { subject }.to raise_error(Splicer::Errors::RequestError)
       end
@@ -43,13 +43,13 @@ describe Splicer::DnsMadeEasy::Client do
   describe '#put' do
     subject { client.put('resource', { data: 'something' }) }
 
-    context 'when Dynect returns with success' do
+    context 'when DNS Made Easy returns with success' do
       before { client.stub(:execute).and_return({}) }
       it { should eq({})}
     end
 
-    context 'when Dynect returns with an error' do
-      before { client.stub(:execute).and_raise(Splicer::Errors::RequestError) }
+    context 'when DNS Made Easy returns with an error' do
+      before { client.stub(:execute).and_raise(Splicer::Errors::RequestError.new('error')) }
       it 'should raise a Splicer::Errors::RequestError' do
         expect { subject }.to raise_error(Splicer::Errors::RequestError)
       end
@@ -59,13 +59,13 @@ describe Splicer::DnsMadeEasy::Client do
   describe '#delete' do
     subject { client.delete('resource') }
 
-    context 'when Dynect returns with success' do
+    context 'when DNS Made Easy returns with success' do
       before { client.stub(:execute).and_return({}) }
       it { should eq({})}
     end
 
-    context 'when Dynect returns with an error' do
-      before { client.stub(:execute).and_raise(Splicer::Errors::RequestError) }
+    context 'when DNS Made Easy returns with an error' do
+      before { client.stub(:execute).and_raise(Splicer::Errors::RequestError.new('error')) }
       it 'should raise a Splicer::Errors::RequestError' do
         expect { subject }.to raise_error(Splicer::Errors::RequestError)
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: splicer-dns_made_easy
 version: !ruby/object:Gem::Version
-  version: 2.2.7
+  version: 2.2.8
 platform: ruby
 authors:
 - Matthew Johnston
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-19 00:00:00.000000000 Z
+date: 2016-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: splicer