spine-transform 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b4ab6da369c4fb24c26a099255860a7704bd1348
-  data.tar.gz: 79ba8def7647c80be07de5a2ff669a1484d162c8
+  metadata.gz: 1da876872726df51848dd707401c993d6959ed50
+  data.tar.gz: bd59589e5afa4301c68e7acbf01acaaf325b4008
 SHA512:
-  metadata.gz: ffcc2c6f9ab1730526b8e00990f3318216bc88c15c6bbb0b854c823d0fa26c3ab603987887b1d1a368f760a02f16164de0cff2db32de678885db146601960c52
-  data.tar.gz: b18cd1a765d423585dfb9ac179607b48fc5259dca827452b6b2f731b2b8a13837c51a78b5ff8230d2cbb4c7d5a0d492d00e0a472817da58ae84b3c2879448cce
+  metadata.gz: 299c9bad0931358d89746f247400c371e4631b6a075acac75d51394657ee508eff97b666dfab7a817c31342d66cdb7454d64c293923308786e2853dee3eaddf3
+  data.tar.gz: 0836a9d5e4014f2f832968d94d8b551919abdf6a765c9572c2229ba732f9558bbd1793ee9206da57120563cf5ec8466d6ac0df94666dfb18f05166737fbbe34e

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 Changelog
 =========
 
+0.1.1
+-----
+-   Fixes return error in transformation when conversion is not needed
+
 0.1.0
 -----
 -   First public release

data/README.md

@@ -36,8 +36,8 @@ end
 transformations.transform(
   id: '1',
   name: 'Product',
-  price: 1.0,
-  is_available: true,
+  price: '1.0',
+  is_available: 'true',
   available: { from: '2014-01-01', until: '2015-01-01' }
 )
 ```

data/lib/spine/transform/commands/intercept.rb

@@ -9,8 +9,6 @@ module Spine
 
         def execute(destination, value)
           destination[@key] = @action.call(value)
-        #rescue
-        #  raise 'Uhuu'
         end
       end
     end

data/lib/spine/transform/syntax/date.rb

@@ -6,8 +6,7 @@ module Spine
           register(
             key,
             intercept(key, options) { |value|
-              return value if value.is_a?(Date)
-              DateTime.iso8601(value.to_s).to_date
+              value.is_a?(Date) ? value : DateTime.iso8601(value.to_s).to_date
             }
           )
         end

data/lib/spine/transform/syntax/decimal.rb

@@ -6,8 +6,7 @@ module Spine
           register(
             key,
             intercept(key, options) { |value|
-              return value if value.is_a?(Float)
-              Float(value.to_s)
+              value.is_a?(Float) ? value : Float(value.to_s)
             }
           )
         end

data/lib/spine/transform/syntax/integer.rb

@@ -6,8 +6,7 @@ module Spine
           register(
             key,
             intercept(key, options) { |value|
-              return value if value.is_a?(Integer)
-              Integer(value.to_s, 10)
+              value.is_a?(Integer) ? value : Integer(value.to_s, 10)
             }
           )
         end

data/lib/spine/transform/syntax/timestamp.rb

@@ -6,8 +6,7 @@ module Spine
           register(
             key,
             intercept(key, options) { |value|
-              return value if value.is_a?(DateTime)
-              DateTime.iso8601(value.to_s)
+              value.is_a?(DateTime) ? value : DateTime.iso8601(value.to_s)
             }
           )
         end

data/lib/spine/transform/version.rb

@@ -1,5 +1,5 @@
 module Spine
   module Transform
-    VERSION = '0.1.0'
+    VERSION = '0.1.1'
   end
 end

data/spec/spine/transform/transformer_spec.rb

@@ -106,6 +106,15 @@ module Spine
           expect(result[:identity]).to eql(1)
         end
 
+        it 'transforms value to integer without conversion' do
+          subject = Transformer.define do
+            integer :identity
+          end
+
+          result = subject.transform(identity: 1)
+          expect(result[:identity]).to eql(1)
+        end
+
         it 'transforms value to decimal' do
           subject = Transformer.define do
             decimal :price
@@ -115,6 +124,15 @@ module Spine
           expect(result[:price]).to eql(1.25)
         end
 
+        it 'transforms value to decimal without conversion' do
+          subject = Transformer.define do
+            decimal :price
+          end
+
+          result = subject.transform(price: 1.25)
+          expect(result[:price]).to eql(1.25)
+        end
+
         it 'transforms value to boolean' do
           subject = Transformer.define do
             boolean :active
@@ -158,6 +176,16 @@ module Spine
           expect(result[:starts_at]).to eql(date)
         end
 
+        it 'transforms value to date without conversion' do
+          subject = Transformer.define do
+            date :starts_at
+          end
+
+          date = Date.new(2014, 1, 1)
+          result = subject.transform(starts_at: date)
+          expect(result[:starts_at]).to eql(date)
+        end
+
         it 'transforms value to timestamp' do
           subject = Transformer.define do
             timestamp :starts_at
@@ -167,6 +195,16 @@ module Spine
           result = subject.transform(starts_at: date.iso8601)
           expect(result[:starts_at]).to eql(date)
         end
+
+        it 'transforms value to timestamp without conversion' do
+          subject = Transformer.define do
+            timestamp :starts_at
+          end
+
+          date = DateTime.new(2014, 1, 1, 12, 0, 0)
+          result = subject.transform(starts_at: date)
+          expect(result[:starts_at]).to eql(date)
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spine-transform
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - TOGGL LLC