spinach 0.5.2 → 0.6.0

data/lib/spinach/version.rb

@@ -1,4 +1,4 @@
 module Spinach
   # Spinach version.
-  VERSION = "0.5.2"
+  VERSION = "0.6.0"
 end

data/spinach.gemspec

@@ -14,11 +14,11 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'mocha'
   gem.add_development_dependency 'sinatra'
-  gem.add_development_dependency 'capybara'
+  gem.add_development_dependency 'capybara', '~> 1.1.3'
   gem.add_development_dependency 'pry'
   gem.add_development_dependency 'simplecov'
   gem.add_development_dependency 'rspec'
-  gem.add_development_dependency 'minitest'
+  gem.add_development_dependency 'minitest', "4.1.0"
   gem.add_development_dependency 'turn'
 
   gem.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }

data/test/spinach/cli_test.rb

@@ -3,17 +3,61 @@ require_relative '../test_helper'
 describe Spinach::Cli do
   describe '#options' do
     it 'sets the default options' do
+      config = Spinach::Config.new
+      Spinach.stubs(:config).returns(config)
       cli = Spinach::Cli.new([])
       options = cli.options
-      options[:reporter][:backtrace].must_equal false
+      config[:reporter_options].must_equal({})
+    end
+
+    it 'sets default tags' do
+      config = Spinach::Config.new
+      Spinach.stubs(:config).returns(config)
+      cli = Spinach::Cli.new([])
+      cli.options
+      config[:tags].must_equal [['~wip']]
+    end
+
+    it 'sets default tags some are defined in config file' do
+      in_current_dir do
+        config = Spinach::Config.new
+        config.config_path = "spinach.yml"
+        File.open(config.config_path, "w") do |f|
+          f.write <<-EOS
+---
+tags:
+  - v1
+  - - ~external
+    - js
+          EOS
+        end
+        Spinach.stubs(:config).returns(config)
+        cli = Spinach::Cli.new([])
+        cli.options
+        config[:tags].must_equal [['~wip'], 'v1', ['~external', 'js']]
+      end
     end
 
     describe 'backtrace' do
       %w{-b --backtrace}.each do |opt|
         it 'sets the backtrace if #{opt}' do
+          config = Spinach::Config.new
+          Spinach.stubs(:config).returns(config)
           cli = Spinach::Cli.new([opt])
           options = cli.options
-          options[:reporter][:backtrace].must_equal true
+          config[:reporter_options][:backtrace].must_equal true
+        end
+      end
+    end
+
+    describe 'reporter class' do
+      %w{-r --reporter}.each do |opt|
+        it 'sets the reporter class' do
+          config = Spinach::Config.new
+          Spinach.stubs(:config).returns(config)
+          cli = Spinach::Cli.new([opt, "String"])
+          options = cli.options
+          config.reporter_class.must_equal 'String'
         end
       end
     end
@@ -55,6 +99,24 @@ describe Spinach::Cli do
           cli.options
           config.tags.must_equal [['~wip', 'javascript']]
         end
+
+        it 'has precedence over tags specified in config file' do
+          in_current_dir do
+            config = Spinach::Config.new
+            config.config_path = "spinach.yml"
+            File.open(config.config_path, "w") do |f|
+              f.write <<-EOS
+---
+tags:
+  - v1
+              EOS
+            end
+            Spinach.stubs(:config).returns(config)
+            cli = Spinach::Cli.new([opt,'javascript'])
+            cli.options
+            config[:tags].must_equal [['~wip', 'javascript']]
+          end
+        end
       end
 
       it 'sets AND-ed tags' do
@@ -123,16 +185,6 @@ describe Spinach::Cli do
     end
   end
 
-  describe '#init_reporter' do
-    it 'inits the default reporter' do
-      cli = Spinach::Cli.new([])
-      reporter = stub
-      reporter.expects(:bind)
-      Spinach::Reporter::Stdout.stubs(new: reporter)
-      cli.init_reporter
-    end
-  end
-
   describe '#run' do
     describe 'when a particular feature list is passed' do
       it 'runs the feature' do
@@ -179,13 +231,13 @@ describe Spinach::Cli do
                   'path/to/features/domain/feature4.feature'])
 
         Spinach::Runner.expects(:new).with([
-                   'path/to/features/feature1.feature', 
-                   'path/to/features/feature2.feature',
-                   'path/to/features/feature3.feature',
-                   'path/to/features/domain/feature4.feature']).
-          returns(stub(:run))
+                                           'path/to/features/feature1.feature', 
+                                           'path/to/features/feature2.feature',
+                                           'path/to/features/feature3.feature',
+                                           'path/to/features/domain/feature4.feature']).
+                                           returns(stub(:run))
 
-        cli.run
+                                           cli.run
       end
     end
   end

data/test/spinach/config_test.rb

@@ -16,79 +16,90 @@ describe Spinach::Config do
    end
  end
 
-  describe '#step_definitions_path' do
-    it 'returns a default' do
-      subject[:step_definitions_path].must_be_kind_of String
-    end
-
-    it 'can be overwritten' do
-      subject[:step_definitions_path] = 'steps'
-      subject[:step_definitions_path].must_equal 'steps'
-    end
-  end
+ describe '#reporter_class' do
+   it 'returns a default' do
+     subject[:reporter_class].must_equal "Spinach::Reporter::Stdout"
+   end
 
-  describe '#support_path' do
-    it 'returns a default' do
-      subject[:support_path].must_be_kind_of String
-    end
+   it 'can be overwritten' do
+     subject[:reporter_class] = "MyOwnReporter"
+     subject[:reporter_class].must_equal "MyOwnReporter"
+   end
+ end
 
-    it 'can be overwritten' do
-      subject[:support_path] = 'support'
-      subject[:support_path].must_equal 'support'
-    end
-  end
+ describe '#step_definitions_path' do
+   it 'returns a default' do
+     subject[:step_definitions_path].must_be_kind_of String
+   end
 
-  describe '#failure_exceptions' do
-    it 'returns a default' do
-      subject[:failure_exceptions].must_be_kind_of Array
-    end
+   it 'can be overwritten' do
+     subject[:step_definitions_path] = 'steps'
+     subject[:step_definitions_path].must_equal 'steps'
+   end
+ end
 
-    it 'can be overwritten' do
-      subject[:failure_exceptions] = [1, 2, 3]
-      subject[:failure_exceptions].must_equal [1,2,3]
-    end
+ describe '#support_path' do
+   it 'returns a default' do
+     subject[:support_path].must_be_kind_of String
+   end
 
-    it 'allows adding elements' do
-      subject[:failure_exceptions] << RuntimeError
-      subject[:failure_exceptions].must_include RuntimeError
-    end
-  end
+   it 'can be overwritten' do
+     subject[:support_path] = 'support'
+     subject[:support_path].must_equal 'support'
+   end
+ end
 
-  describe '#config_path' do
-    it 'returns a default' do
-      subject[:config_path].must_equal 'config/spinach.yml'
-    end
+ describe '#failure_exceptions' do
+   it 'returns a default' do
+     subject[:failure_exceptions].must_be_kind_of Array
+   end
 
-    it 'can be overwritten' do
-      subject[:config_path] = 'my_config_file.yml'
-      subject[:config_path].must_equal 'my_config_file.yml'
-    end
-  end
+   it 'can be overwritten' do
+     subject[:failure_exceptions] = [1, 2, 3]
+     subject[:failure_exceptions].must_equal [1,2,3]
+   end
 
-  describe '#parse_from_file' do
-    before do
-      subject[:config_path] = 'a_path'
-      YAML.stubs(:load_file).returns({support_path: 'my_path', config_path: 'another_path'})
-      subject.parse_from_file
-    end
+   it 'allows adding elements' do
+     subject[:failure_exceptions] << RuntimeError
+     subject[:failure_exceptions].must_include RuntimeError
+   end
+ end
 
-    it 'sets the options' do
-      subject[:support_path].must_equal 'my_path'
-    end
+ describe '#config_path' do
+   it 'returns a default' do
+     subject[:config_path].must_equal 'config/spinach.yml'
+   end
 
-    it "doesn't set the config_path option" do
-      subject[:config_path].must_equal 'a_path'
-    end
-  end
+   it 'can be overwritten' do
+     subject[:config_path] = 'my_config_file.yml'
+     subject[:config_path].must_equal 'my_config_file.yml'
+   end
+ end
 
-  describe '#tags' do
-    it 'returns a default' do
-      subject[:tags].must_be_kind_of Array
-    end
+ describe '#parse_from_file' do
+   before do
+     subject[:config_path] = 'a_path'
+     YAML.stubs(:load_file).returns({support_path: 'my_path', config_path: 'another_path'})
+     subject.parse_from_file
+   end
 
-    it 'can be overwritten' do
-      subject[:tags] = ['wip']
-      subject[:tags].must_equal ['wip']
-    end
-  end
+   it 'sets the options' do
+     subject[:support_path].must_equal 'my_path'
+   end
+
+   it "doesn't set the config_path option" do
+     subject[:config_path].must_equal 'a_path'
+   end
+ end
+
+ describe '#tags' do
+   it 'returns a default' do
+     subject[:tags].must_be_kind_of Array
+   end
+
+   it 'can be overwritten' do
+     subject[:tags] = ['wip']
+     subject[:tags].must_equal ['wip']
+   end
+ end
 end

data/test/spinach/dsl_test.rb

@@ -28,6 +28,114 @@ describe Spinach::DSL do
       end
     end
 
+    describe "#after" do
+      let(:super_class) {
+        Class.new do
+          attr_reader :var1
+          def after_each
+            @var1 = 30
+            @var2 = 60
+          end
+        end
+      }
+
+      let(:feature) {
+        Class.new(super_class) do
+          attr_accessor :var2
+          include Spinach::DSL
+          after do
+            self.var2 = 40
+          end
+        end
+      }
+
+      let(:object) { feature.new }
+      
+      it "defines after_each method and calls the super first" do
+        object.after_each
+        object.var1.must_equal 30
+      end
+      
+      it "defines after_each method and runs the block second" do
+        object.after_each
+        object.var2.must_equal 40
+      end
+
+      describe "deep inheritance" do
+        let(:sub_feature) {
+          Class.new(feature) do
+            include Spinach::DSL
+            attr_reader :var3
+
+            after do
+              @var3 = 15
+            end
+          end
+        }
+
+        let(:sub_object) { sub_feature.new }
+
+        it "works with the 3rd layer of inheritance" do
+          sub_object.after_each
+          sub_object.var2.must_equal 40
+        end
+      end
+    end
+
+    describe "#before" do
+      let(:super_class) {
+        Class.new do
+          attr_reader :var1
+          def before_each
+            @var1 = 30
+            @var2 = 60
+          end
+        end
+      }
+
+      let(:feature) {
+        Class.new(super_class) do
+          attr_accessor :var2
+          include Spinach::DSL
+          before do
+            self.var2 = 40
+          end
+        end
+      }
+
+      let(:object) { feature.new }
+      
+      it "defines before_each method and calls the super first" do
+        object.before_each
+        object.var1.must_equal 30
+      end
+      
+      it "defines before_each method and runs the block second" do
+        object.before_each
+        object.var2.must_equal 40
+      end
+
+      describe "deep inheritance" do
+        let(:sub_feature) {
+          Class.new(feature) do
+            include Spinach::DSL
+            attr_reader :var3
+
+            before do
+              @var3 = 15
+            end
+          end
+        }
+
+        let(:sub_object) { sub_feature.new }
+
+        it "works with the 3rd layer of inheritance" do
+          sub_object.before_each
+          sub_object.var2.must_equal 40
+        end
+      end
+    end
+
     describe '#feature' do
       it 'sets the name for this feature' do
         @feature.feature('User salutes')

data/test/spinach/feature_steps_test.rb

@@ -31,6 +31,14 @@ describe Spinach::FeatureSteps do
       end.new
     end
 
+    it "responds to before_each" do
+      feature.must_respond_to(:before_each)
+    end
+
+    it "responds to after_each" do
+      feature.must_respond_to(:after_each)
+    end
+
     describe 'execute' do
       it 'runs defined step correctly' do
         feature.execute(stub(name: 'I go to the toilet'))

data/test/spinach/helpers_test.rb

@@ -0,0 +1,9 @@
+require_relative '../test_helper'
+
+describe Spinach::Helpers do
+  describe '.constantize' do
+    it "converts a string into a class" do
+      Spinach::Helpers.constantize("Spinach::FeatureSteps").must_equal Spinach::FeatureSteps
+    end
+  end
+end

data/test/spinach/runner/feature_runner_test.rb

@@ -1,7 +1,13 @@
 require_relative '../../test_helper'
 
 describe Spinach::Runner::FeatureRunner do
-  let(:feature) { stub('feature', name: 'Feature') }
+  let(:feature) { 
+    stub('feature', 
+         name: 'Feature',
+         scenarios: [],
+         background_steps: []
+        )
+  }
   subject{ Spinach::Runner::FeatureRunner.new(feature) }
 
   describe '#initialize' do
@@ -153,6 +159,18 @@ describe Spinach::Runner::FeatureRunner do
           @runner = Spinach::Runner::FeatureRunner.new(@feature)
           @runner.run
         end
+
+        it "doesn't accumulate tags from one scenario to the next" do
+          next_scenario = stub(line: 14, tags: [])
+          @feature.stubs(:scenarios).returns [@scenario, next_scenario]
+
+          Spinach::TagsMatcher.expects(:match).with(["feature_tag", "scenario_tag"]).returns true
+          Spinach::TagsMatcher.expects(:match).with(["feature_tag"]).returns false
+          Spinach::Runner::ScenarioRunner.expects(:new).with(@scenario).returns stub(run: true)
+
+          @runner = Spinach::Runner::FeatureRunner.new(@feature)
+          @runner.run
+        end
       end
     end
   end