spinach 0.10.0 → 0.10.1

data/test/spinach/reporter/failure_file_test.rb

@@ -0,0 +1,84 @@
+# encoding: utf-8
+
+require_relative '../../test_helper'
+
+describe Spinach::Reporter::FailureFile do
+  let(:feature) { stub_everything(filename: 'features/test.feature') }
+  let(:scenario) { stub_everything(lines: [1,2]) }
+
+  describe '#initialize' do
+    it 'generates a distinctive output filename if none is provided' do
+      @reporter = Spinach::Reporter::FailureFile.new
+      @reporter.filename.wont_be_nil
+      @reporter.filename.must_be_kind_of String
+    end
+
+    it 'uses a provided output filename option' do
+      @reporter = Spinach::Reporter::FailureFile.new(failure_filename: 'foo')
+      @reporter.filename.must_equal 'foo'
+    end
+
+    it 'uses a provided output filename environment variable' do
+      ENV['SPINACH_FAILURE_FILE'] = 'asdf'
+      @reporter = Spinach::Reporter::FailureFile.new
+      @reporter.filename.must_equal 'asdf'
+    end
+
+    it 'initializes the array of failing scenarios' do
+      @reporter = Spinach::Reporter::FailureFile.new
+      @reporter.failing_scenarios.wont_be_nil
+      @reporter.failing_scenarios.must_be_kind_of Array
+      @reporter.failing_scenarios.must_be_empty
+    end
+
+    after do
+      ENV.delete('SPINACH_FAILURE_FILE')
+    end
+  end
+
+  describe 'hooks' do
+    before do
+      @reporter = Spinach::Reporter::FailureFile.new(failure_filename: "tmp/test-failures_#{Time.now.strftime('%F_%H-%M-%S-%L')}.txt")
+      @reporter.set_current_feature(feature)
+      @reporter.set_current_scenario(scenario)
+    end
+
+    describe '#on_failed_step' do
+      it 'collects the feature and line number for outputting later' do
+        @reporter.failing_scenarios.must_be_empty
+        @reporter.on_failed_step(anything)
+        @reporter.failing_scenarios.must_include "#{feature.filename}:#{scenario.lines[0]}"
+      end
+    end
+
+    describe '#on_error_step' do
+      it 'collects the feature and line number for outputting later' do
+        @reporter.failing_scenarios.must_be_empty
+        @reporter.on_error_step(anything)      
+        @reporter.failing_scenarios.must_include "#{feature.filename}:#{scenario.lines[0]}"
+      end
+    end
+
+    describe '#after_run' do
+      describe 'when the run has succeeded' do
+        it 'no failure file is created' do
+          @reporter.after_run(true)
+          refute File.exist?(@reporter.filename), 'Output file should not exist when run is successful'
+        end
+      end
+
+      describe 'when the run has failed' do
+        it 'failure file is created and includes expected output' do
+          @reporter.on_failed_step(anything)
+          @reporter.after_run(false)
+          assert File.exist?(@reporter.filename)
+          f = File.open(@reporter.filename)
+          f.read.must_equal "#{feature.filename}:#{scenario.lines[0]}"
+          f.close
+          File.unlink(@reporter.filename)
+        end
+      end
+    end
+  end
+
+end

data/test/spinach/runner/feature_runner_test.rb

@@ -1,24 +1,19 @@
 require_relative '../../test_helper'
 
 describe Spinach::Runner::FeatureRunner do
-  let(:feature) { 
-    stub('feature', 
-         name: 'Feature',
-         scenarios: [],
-         background_steps: []
-        )
-  }
-  subject{ Spinach::Runner::FeatureRunner.new(feature) }
+  let(:feature) do
+    stub('feature',
+      name:             'Feature',
+      scenarios:        [],
+      background_steps: []
+    )
+  end
+  subject { Spinach::Runner::FeatureRunner.new(feature) }
 
   describe '#initialize' do
     it 'initializes the given filename' do
       subject.feature.must_equal feature
     end
-
-    it 'initalizes the given scenario line' do
-      @runner = Spinach::Runner::FeatureRunner.new(feature, '34')
-      @runner.instance_variable_get(:@line).must_equal 34
-    end
   end
 
   describe '#scenarios' do
@@ -29,24 +24,30 @@ describe Spinach::Runner::FeatureRunner do
   end
 
   describe '#run' do
-    it 'runs the hooks in order' do
-      hooks = sequence('hooks')
-      Spinach.hooks.expects(:run_before_feature).with(feature).in_sequence(hooks)
-      Spinach.expects(:find_step_definitions).returns(false).in_sequence(hooks)
-      Spinach.hooks.expects(:run_after_feature).with(feature).in_sequence(hooks)
-
-      subject.run
+    describe "when some steps don't exist" do
+      it 'runs the hooks in order' do
+        hooks = sequence('hooks')
+        Spinach.hooks.expects(:run_before_feature).with(feature).in_sequence(hooks)
+        Spinach.expects(:find_step_definitions).returns(false).in_sequence(hooks)
+        Spinach.hooks.expects(:run_after_feature).with(feature).in_sequence(hooks)
+
+        subject.run
+      end
     end
 
-    describe 'when the steps exist' do
+    describe 'when all the steps exist' do
       before do
-        @feature = stub('feature', name: 'Feature')
-        Spinach.stubs(:find_step_definitions).returns(true)
         @scenarios = [
           scenario         = stub(tags: []),
           another_scenario = stub(tags: [])
         ]
-        @feature.stubs(:scenarios).returns @scenarios
+        @feature = stub('feature',
+          name:                "Feature",
+          tags:                [],
+          scenarios:           @scenarios,
+          run_every_scenario?: true
+        )
+        Spinach.stubs(:find_step_definitions).returns(true)
         @runner = Spinach::Runner::FeatureRunner.new(@feature)
       end
 
@@ -62,13 +63,15 @@ describe Spinach::Runner::FeatureRunner do
       end
 
       describe 'and the scenarios fail' do
-        it 'runs the scenarios and returns false' do
-          @scenarios.each do |scenario|
-            runner = stub(run: false)
-            Spinach::Runner::ScenarioRunner.expects(:new).with(scenario).returns runner
-          end
+        describe "without config option fail_fast set" do
+          it 'runs the scenarios and returns false' do
+            @scenarios.each do |scenario|
+              runner = stub(run: false)
+              Spinach::Runner::ScenarioRunner.expects(:new).with(scenario).returns runner
+            end
 
-          @runner.run.must_equal false
+            @runner.run.must_equal false
+          end
         end
 
         describe "with config option fail_fast set" do
@@ -97,38 +100,46 @@ describe Spinach::Runner::FeatureRunner do
       end
     end
 
-    describe "when a line is given" do
+    describe "when only running specific lines" do
       before do
-        @feature = stub('feature', name: 'Feature')
-        Spinach.stubs(:find_step_definitions).returns(true)
         @scenarios = [
-          scenario         = stub(line: 4, tags: []),
-          another_scenario = stub(line: 12, tags: [])
+          stub(tags: [], lines: (4..8).to_a),
+          stub(tags: [], lines: (12..15).to_a),
         ]
-        @feature.stubs(:scenarios).returns @scenarios
+        @feature = stub('feature',
+          name:                'Feature',
+          tags:                [],
+          scenarios:           @scenarios,
+          run_every_scenario?: false,
+        )
+        Spinach.stubs(:find_step_definitions).returns(true)
       end
 
       it "runs exactly matching scenario" do
         Spinach::Runner::ScenarioRunner.expects(:new).with(@scenarios[1]).returns stub(run: true)
-        @runner = Spinach::Runner::FeatureRunner.new(@feature, "12")
+        @feature.stubs(:lines_to_run).returns([12])
+        @runner = Spinach::Runner::FeatureRunner.new(@feature)
         @runner.run
       end
 
       it "runs no scenario and returns false" do
         Spinach::Runner::ScenarioRunner.expects(:new).never
-        @runner = Spinach::Runner::FeatureRunner.new(@feature, "3")
+        @feature.stubs(:lines_to_run).returns([3])
+        @runner = Spinach::Runner::FeatureRunner.new(@feature)
         @runner.run
       end
 
       it "runs matching scenario" do
         Spinach::Runner::ScenarioRunner.expects(:new).with(@scenarios[0]).returns stub(run: true)
-        @runner = Spinach::Runner::FeatureRunner.new(@feature, "8")
+        @feature.stubs(:lines_to_run).returns([8])
+        @runner = Spinach::Runner::FeatureRunner.new(@feature)
         @runner.run
       end
 
       it "runs last scenario" do
         Spinach::Runner::ScenarioRunner.expects(:new).with(@scenarios[1]).returns stub(run: true)
-        @runner = Spinach::Runner::FeatureRunner.new(@feature, "15")
+        @feature.stubs(:lines_to_run).returns([15])
+        @runner = Spinach::Runner::FeatureRunner.new(@feature)
         @runner.run
       end
     end
@@ -137,10 +148,14 @@ describe Spinach::Runner::FeatureRunner do
 
       describe "with feature" do
         before do
-          @feature = stub('feature', name: 'Feature', tags: ["feature_tag"])
+          @scenario = stub(tags: [])
+          @feature = stub('feature',
+            name:                'Feature',
+            tags:                ["feature_tag"],
+            scenarios:           [@scenario],
+            run_every_scenario?: true,
+          )
           Spinach.stubs(:find_step_definitions).returns(true)
-          @scenario = stub(line: 4, tags: [])
-          @feature.stubs(:scenarios).returns [@scenario]
         end
 
         it "runs matching feature" do
@@ -154,10 +169,14 @@ describe Spinach::Runner::FeatureRunner do
 
       describe "with scenario" do
         before do
-          @feature = stub('feature', name: 'Feature', tags: ["feature_tag"])
+          @scenario = stub(tags: ["scenario_tag"])
+          @feature = stub('feature',
+            name:                'Feature',
+            tags:                ["feature_tag"],
+            scenarios:           [@scenario],
+            run_every_scenario?: true,
+          )
           Spinach.stubs(:find_step_definitions).returns(true)
-          @scenario = stub(line: 4, tags: ["scenario_tag"])
-          @feature.stubs(:scenarios).returns [@scenario]
         end
 
         it "runs matching scenario" do
@@ -177,7 +196,7 @@ describe Spinach::Runner::FeatureRunner do
         end
 
         it "doesn't accumulate tags from one scenario to the next" do
-          next_scenario = stub(line: 14, tags: [])
+          next_scenario = stub(tags: [])
           @feature.stubs(:scenarios).returns [@scenario, next_scenario]
 
           Spinach::TagsMatcher.expects(:match).with(["feature_tag", "scenario_tag"]).returns true

data/test/spinach/runner/scenario_runner_test.rb

@@ -37,6 +37,31 @@ module Spinach
       end
 
       describe '#run' do
+        describe 'hooks (no #run_step stub)' do
+          before(:each) do
+            subject.stubs(:step_definitions).returns step_definitions = stub
+            step_definitions.stubs(:before_each)
+            step_definitions.stubs(:after_each)
+            step_definitions.stubs(:step_location_for)
+          end
+
+          let(:scenario) { stub(feature: feature, steps: [steps.first], name: 'test' ) }
+
+          it 'runs hooks in order (no #run_step stub)' do
+            hooks = sequence('hooks')
+
+            Spinach.hooks.expects(:run_before_scenario).with(scenario, step_definitions).in_sequence(hooks)
+            Spinach.hooks.expects(:run_around_scenario).with(scenario, step_definitions).in_sequence(hooks).yields
+
+            Spinach.hooks.expects(:run_before_step).with(steps.first, step_definitions).in_sequence(hooks)
+            Spinach.hooks.expects(:run_around_step).with(steps.first, step_definitions).in_sequence(hooks).yields
+            Spinach.hooks.expects(:run_after_step).with(steps.first, step_definitions).in_sequence(hooks)
+
+            Spinach.hooks.expects(:run_after_scenario).with(scenario, step_definitions).in_sequence(hooks)
+            subject.run
+          end
+        end
+
         describe 'hooks' do
           before(:each) do
             subject.stubs(:step_definitions).returns step_definitions = stub
@@ -78,14 +103,26 @@ module Spinach
             subject.run
           end
 
-          it 'raises if around hook does not yield' do
+          it 'raises if around_scenario hook does not yield' do
             subject.stubs(:step_definitions).returns stub
 
             Spinach.hooks.stubs(:run_around_scenario).with(scenario, step_definitions)
 
-            proc do
+            e = proc do
+              subject.run
+            end.must_raise Spinach::HookNotYieldException
+            e.hook.must_match /around_scenario/
+          end
+
+          it 'raises if around_step hook does not yield' do
+            step_definitions.stubs(:step_location_for)
+
+            Spinach.hooks.stubs(:run_around_step).with(steps.first, step_definitions)
+
+            e = proc do
               subject.run
-            end.must_raise RuntimeError
+            end.must_raise Spinach::HookNotYieldException
+            e.hook.must_match /around_step/
           end
         end
       end

data/test/spinach/runner_test.rb

@@ -36,25 +36,25 @@ describe Spinach::Runner do
     end
   end
 
-  describe '#init_reporter' do
-    describe "when no reporter_class option is passed in" do
+  describe '#init_reporters' do
+    describe "when no reporter_classes option is passed in" do
       it 'inits the default reporter' do
         reporter = stub
         reporter.expects(:bind)
         Spinach::Reporter::Stdout.stubs(new: reporter)
-        runner.init_reporter
+        runner.init_reporters
       end
     end
 
-    describe "when reporter_class option is passed in" do
-      it "inits the reporter class" do
+    describe "when reporter_classes option is passed in" do
+      it "inits the reporter classes" do
         config = Spinach::Config.new
         Spinach.stubs(:config).returns(config)
-        config.reporter_class = "String"
+        config.reporter_classes = ["String"]
         reporter = stub
         reporter.expects(:bind)
         String.stubs(new: reporter)
-        runner.init_reporter
+        runner.init_reporters
       end
     end
 
@@ -66,7 +66,7 @@ describe Spinach::Runner do
         reporter = stub
         reporter.stubs(:bind)
         Spinach::Reporter::Stdout.expects(new: reporter).with(backtrace: true)
-        runner.init_reporter
+        runner.init_reporters
       end
     end
   end
@@ -86,8 +86,8 @@ describe Spinach::Runner do
       runner.stubs(required_files: [])
     end
 
-    it "inits reporter" do
-      runner.expects(:init_reporter)
+    it "inits reporters" do
+      runner.expects(:init_reporters)
       runner.run
     end
 
@@ -107,7 +107,7 @@ describe Spinach::Runner do
       let(:filenames) { ["#{filename}:#{line}"] }
       let(:runner) { Spinach::Runner.new(filenames) }
 
-      it 'sets filename and line on the feature' do
+      it 'sets filename and lines_to_run on the feature' do
         @feature_runner = stub
         Spinach::Parser.stubs(:open_file).with(filename).returns parser = stub
         parser.stubs(:parse).returns feature = Spinach::Feature.new
@@ -119,7 +119,7 @@ describe Spinach::Runner do
 
         runner.run.must_equal true
         feature.filename.must_equal filename
-        feature.lines.must_equal [line]
+        feature.lines_to_run.must_equal [line]
       end
     end
 
@@ -139,11 +139,11 @@ describe Spinach::Runner do
         runner.stubs(required_files: [])
       end
 
-      it "sets filename and lines on the feature" do
+      it "sets filename and lines_to_run on the feature" do
         @feature_runner.stubs(:run).returns(true)
         runner.run.must_equal true
         @feature.filename.must_equal filename
-        @feature.lines.must_equal line.split(":").map(&:to_i)
+        @feature.lines_to_run.must_equal line.split(":").map(&:to_i)
       end
 
       it "returns false if it fails" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spinach
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.10.1
 platform: ruby
 authors:
 - Josep Jaume Rey
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-16 00:00:00.000000000 Z
+date: 2018-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gherkin-ruby
@@ -220,6 +220,7 @@ files:
 - features/reporting/show_step_source_location.feature
 - features/reporting/undefined_feature_reporting.feature
 - features/rspec_compatibility.feature
+- features/running_specific_scenarios.feature
 - features/step_auditing.feature
 - features/steps/automatic_feature_generation.rb
 - features/steps/background.rb
@@ -236,6 +237,7 @@ files:
 - features/steps/reporting/undefined_feature_reporting.rb
 - features/steps/reporting/use_customized_reporter.rb
 - features/steps/rspec_compatibility.rb
+- features/steps/running_specific_scenarios.rb
 - features/steps/step_auditing.rb
 - features/support/env.rb
 - features/support/error_reporting.rb
@@ -264,9 +266,11 @@ files:
 - lib/spinach/parser.rb
 - lib/spinach/parser/visitor.rb
 - lib/spinach/reporter.rb
+- lib/spinach/reporter/failure_file.rb
 - lib/spinach/reporter/progress.rb
 - lib/spinach/reporter/reporting.rb
 - lib/spinach/reporter/stdout.rb
+- lib/spinach/rspec/mocks.rb
 - lib/spinach/runner.rb
 - lib/spinach/runner/feature_runner.rb
 - lib/spinach/runner/scenario_runner.rb
@@ -291,6 +295,7 @@ files:
 - test/spinach/hooks_test.rb
 - test/spinach/parser/visitor_test.rb
 - test/spinach/parser_test.rb
+- test/spinach/reporter/failure_file_test.rb
 - test/spinach/reporter/progress_test.rb
 - test/spinach/reporter/stdout/error_reporting_test.rb
 - test/spinach/reporter/stdout_test.rb
@@ -345,6 +350,7 @@ test_files:
 - features/reporting/show_step_source_location.feature
 - features/reporting/undefined_feature_reporting.feature
 - features/rspec_compatibility.feature
+- features/running_specific_scenarios.feature
 - features/step_auditing.feature
 - features/steps/automatic_feature_generation.rb
 - features/steps/background.rb
@@ -361,6 +367,7 @@ test_files:
 - features/steps/reporting/undefined_feature_reporting.rb
 - features/steps/reporting/use_customized_reporter.rb
 - features/steps/rspec_compatibility.rb
+- features/steps/running_specific_scenarios.rb
 - features/steps/step_auditing.rb
 - features/support/env.rb
 - features/support/error_reporting.rb
@@ -382,6 +389,7 @@ test_files:
 - test/spinach/hooks_test.rb
 - test/spinach/parser/visitor_test.rb
 - test/spinach/parser_test.rb
+- test/spinach/reporter/failure_file_test.rb
 - test/spinach/reporter/progress_test.rb
 - test/spinach/reporter/stdout/error_reporting_test.rb
 - test/spinach/reporter/stdout_test.rb