spinach 0.1.5.4 → 0.2.0.1

data/test/spinach/config_test.rb

@@ -5,6 +5,17 @@ describe Spinach::Config do
     Spinach::Config.new
   end
 
+ describe '#features_path' do
+   it 'returns a default' do
+     subject[:features_path].must_be_kind_of String
+   end
+   
+   it 'can be overwritten' do
+     subject[:features_path] = 'test'
+     subject[:features_path].must_equal 'test'
+   end
+ end
+
   describe '#step_definitions_path' do
     it 'returns a default' do
       subject[:step_definitions_path].must_be_kind_of String
@@ -42,4 +53,32 @@ describe Spinach::Config do
       subject[:failure_exceptions].must_include RuntimeError
     end
   end
+
+  describe '#config_path' do
+    it 'returns a default' do
+      subject[:config_path].must_equal 'config/spinach.yml'
+    end
+
+    it 'can be overwritten' do
+      subject[:config_path] = 'my_config_file.yml'
+      subject[:config_path].must_equal 'my_config_file.yml'
+    end
+  end
+
+  describe '#parse_from_file' do
+    before do
+      subject[:config_path] = 'a_path'
+      YAML.stubs(:load_file).returns({support_path: 'my_path', config_path: 'another_path'})
+      subject.parse_from_file
+    end
+
+    it 'sets the options' do
+      subject[:support_path].must_equal 'my_path'
+    end
+
+    it "doesn't set the config_path option" do
+      subject[:config_path].must_equal 'a_path'
+    end
+  end
+
 end

data/test/spinach/dsl_test.rb

@@ -15,18 +15,9 @@ describe Spinach::DSL do
           step_executed = true
         end
 
-        @feature.new.execute_step('I say goodbye')
+        @feature.new.execute(stub(name: 'I say goodbye'))
         step_executed.must_equal true
       end
-
-      it 'returns step source location' do
-        @feature.When('I say goodbye') do
-          'You say hello'
-        end
-
-        @feature.new.execute_step('I say goodbye').first.must_include '/dsl_test.rb'
-        @feature.new.execute_step('I say goodbye').last.must_be_kind_of Fixnum
-      end
     end
 
     describe '#When, #Then, #And, #But' do
@@ -50,5 +41,16 @@ describe Spinach::DSL do
         @feature.new.name.must_equal "A cool feature"
       end
     end
+
+    describe '#step_location_for' do
+      it 'returns step source location' do
+        @feature.When('I say goodbye') do
+          'You say hello'
+        end
+
+        @feature.new.step_location_for('I say goodbye').first.must_include '/dsl_test.rb'
+        @feature.new.step_location_for('I say goodbye').last.must_be_kind_of Fixnum
+      end
+    end
   end
 end

data/test/spinach/feature_steps_test.rb

@@ -31,16 +31,16 @@ describe Spinach::FeatureSteps do
       end.new
     end
 
-    describe 'execute_step' do
+    describe 'execute' do
       it 'runs defined step correctly' do
-        feature.execute_step('I go to the toilet')
+        feature.execute(stub(name: 'I go to the toilet'))
 
         feature.pee.must_equal true
       end
 
       it 'raises an exception if step is not defined' do
         proc {
-          feature.execute_step 'I am lost'
+          feature.execute(stub(name: 'I am lost'))
         }.must_raise Spinach::StepNotDefinedException
       end
     end

data/test/spinach/feature_test.rb

@@ -0,0 +1,6 @@
+require 'test_helper'
+
+module Spinach
+  describe Feature do
+  end
+end

data/test/spinach/{suites → frameworks}/minitest_test.rb

@@ -1,8 +1,8 @@
 require_relative '../../test_helper'
 
-describe "minitest suite" do
+describe "minitest framework" do
   before do
-    require_relative '../../../lib/spinach/suites/minitest'
+    require_relative '../../../lib/spinach/frameworks/minitest'
   end
 
   it "adds MiniTest::Assertion into the failure exceptions" do

data/test/spinach/generators/feature_generator_test.rb

@@ -4,81 +4,41 @@ require_relative '../../../lib/spinach/generators'
 module Spinach::Generators
   describe FeatureGenerator do
     subject do
-      FeatureGenerator.new(data)
+      FeatureGenerator.new(feature)
     end
 
-    let(:data) do
-      Spinach::Parser.new("
-        Feature: Cheezburger can I has
-          Scenario: Some Lulz
-            Given I haz a sad
-            When I get some lulz
-            Then I haz a happy
-          Scenario: Some sad
-            Given I haz a happy
-            When I get some lulz
-            Then I am OMG ROFLMAO").parse
+    let(:feature) do
+      Spinach::Parser.new("""
+Feature: Cheezburger can I has
+  Background:
+    Given I liek cheezburger
+  Scenario: Some Lulz
+    Given I haz a sad
+    When I get some lulz
+    Then I haz a happy
+  Scenario: Some sad
+    Given I haz a happy
+    When I get some lulz
+    Then I am OMG ROFLMAO""").parse
     end
 
     describe "#name" do
-      it "returns the scenario name" do
+      it "returns the feature name" do
         subject.name.must_equal 'Cheezburger can I has'
       end
-
-      it "returns nil if no name present" do
-        data['name'] = nil
-        subject.name.must_equal nil
-      end
     end
 
     describe "#steps" do
       it "returns a correct number different steps for this data" do
-        subject.steps.length.must_equal 4
-      end
-
-      describe "includes the correct steps" do
-        it "includes 'Given I haz a sad'" do
-          subject.steps.any?{ |step|
-            (step['keyword'] == 'Given') && (step['name'] == 'I haz a sad')
-          }.must_equal true
-        end
-
-        it "includes 'When I get some lulz'" do
-          subject.steps.any?{ |step|
-            (step['keyword'] == 'When') && (step['name'] == 'I get some lulz')
-          }.must_equal true
-        end
-
-        it "includes 'Then I has a happy'" do
-          subject.steps.any?{ |step|
-            (step['keyword'] == 'Then') && (step['name'] == 'I haz a happy')
-          }.must_equal true
-        end
-
-        it "does not include 'Given I haz a happy'" do
-          subject.steps.any?{ |step|
-            (step['keyword'] == 'Given') && (step['name'] == 'I haz a happy')
-          }.must_equal false
-        end
-
-        it "includes 'Then I am OMG ROFLMAO'" do
-          subject.steps.any?{ |step|
-            (step['keyword'] == 'Then') && (step['name'] == 'I am OMG ROFLMAO')
-          }.must_equal true
-        end
+        subject.steps.length.must_equal 5
       end
     end
 
     describe "#generate" do
       it "generates an entire feature_steps class definition" do
         result = subject.generate
-        klass = eval(result)
-        feature_runner = Spinach::Runner::FeatureRunner.new(stub_everything)
-        feature_runner.stubs(data: data)
-        error_count = 0
-        CheezburgerCanIHas.any_instance.
-          expects(:raise).with("step not implemented").times(6).returns(nil)
-        feature_runner.run.must_equal true
+        result.must_match /Given 'I haz a sad' do/
+        result.must_match /raise 'step not implemented'/
       end
     end
 

data/test/spinach/generators/step_generator_test.rb

@@ -4,11 +4,11 @@ require_relative '../../../lib/spinach/generators'
 module Spinach::Generators
   describe StepGenerator do
     subject do
-      StepGenerator.new(data)
+      StepGenerator.new(step)
     end
 
-    let(:data) do
-      {'keyword' => 'Given', 'name' => "I has a sad"}
+    let(:step) do
+      stub(keyword: 'Given', name: 'I has a sad')
     end
 
     describe "#generate" do

data/test/spinach/generators_test.rb

@@ -6,16 +6,18 @@ describe Spinach::Generators do
   end
 
   let(:data) do
-    Spinach::Parser.new("
-      Feature: Cheezburger can I has
-        Scenario: Some Lulz
-          Given I haz a sad
-          When I get some lulz
-          Then I haz a happy
-        Scenario: Some sad
-          Given I haz a happy
-          When I get some lulz
-          Then I am OMG ROFLMAO").parse
+    Spinach::Parser.new("""
+Feature: Cheezburger can I has
+  Background:
+    Given I liek cheezburger
+  Scenario: Some Lulz
+    Given I haz a sad
+    When I get some lulz
+    Then I haz a happy
+  Scenario: Some sad
+    Given I haz a happy
+    When I get some lulz
+    Then I am OMG ROFLMAO""").parse
   end
 
   describe "#bind" do

data/test/spinach/hookable_test.rb

@@ -48,6 +48,14 @@ describe Spinach::Hookable do
         subject.run_hook(:before_save, 1, 2)
         array.must_equal [1, 2]
       end
+
+      it "yields to hook block even if nothing is hooked" do
+        called = false
+        subject.run_hook(:before_save) do
+          called = true
+        end
+        called.must_equal true
+      end
     end
 
     describe "#reset_hooks" do

data/test/spinach/hooks_test.rb

@@ -7,7 +7,7 @@ describe Spinach::Hooks do
 
   describe "hooks" do
     %w{before_run after_run before_feature after_feature on_undefined_feature
-    before_scenario after_scenario before_step after_step on_successful_step
+    before_scenario around_scenario after_scenario before_step after_step on_successful_step
     on_failed_step on_error_step on_undefined_step on_skipped_step}.each do |callback|
       describe "#{callback}" do
         it "responds to #{callback}" do
@@ -26,11 +26,10 @@ describe Spinach::Hooks do
         end
       end
     end
+
     describe "#on_tag" do
-      let(:data) do
-        {
-          'tags' => [{'name' => '@javascript'}, {'name' => '@capture'}]
-        }
+      let(:scenario) do
+        stub(tags: ['javascript', 'capture'])
       end
 
       it "calls the block if the scenario includes the tag" do
@@ -38,7 +37,7 @@ describe Spinach::Hooks do
         subject.on_tag('javascript') do
           assertion = true
         end
-        subject.run_before_scenario(data)
+        subject.run_before_scenario(scenario)
         assertion.must_equal true
       end
 
@@ -47,7 +46,7 @@ describe Spinach::Hooks do
         subject.on_tag('screenshot') do
           assertion = true
         end
-        subject.run_before_scenario(data)
+        subject.run_before_scenario(scenario)
         assertion.wont_equal true
       end
     end

data/test/spinach/parser/visitor_test.rb

@@ -0,0 +1,173 @@
+require 'test_helper'
+
+module Spinach
+  class Parser
+    describe Visitor do
+      let(:feature) { Feature.new }
+      let(:visitor) { Visitor.new }
+
+      describe '#visit' do
+        it 'makes ast accept self' do
+          ast = stub('AST')
+          ast.expects(:accept).with(visitor)
+
+          visitor.visit(ast)
+        end
+
+        it 'returns the feature' do
+          ast = stub_everything
+          visitor.instance_variable_set(:@feature, feature)
+          visitor.visit(ast).must_equal feature
+        end
+      end
+
+      describe '#visit_Feature' do
+        before do
+          @background = stub_everything
+          @scenarios = [stub_everything, stub_everything, stub_everything]
+          @node  = stub(scenarios: @scenarios, name: 'Go shopping', background: @background)
+        end
+
+        it 'sets the name' do
+          visitor.visit_Feature(@node)
+          visitor.feature.name.must_equal 'Go shopping'
+        end
+
+        it 'iterates over its children' do
+          @scenarios.each do |scenario|
+            scenario.expects(:accept).with visitor
+          end
+
+          visitor.visit_Feature(@node)
+        end
+      end
+
+      describe '#visit_Scenario' do
+        before do
+          @steps = [stub_everything, stub_everything, stub_everything]
+          @tags  = [stub_everything, stub_everything, stub_everything]
+          @node  = stub(
+            tags:  @tags,
+            steps: @steps,
+            name:  'Go shopping on Saturday morning',
+            line: 3
+          )
+        end
+
+        it 'adds the scenario to the feature' do
+          visitor.visit_Scenario(@node)
+          visitor.feature.scenarios.length.must_equal 1
+        end
+
+        it 'sets the name' do
+          visitor.visit_Scenario(@node)
+          visitor.feature.scenarios.first.name.must_equal 'Go shopping on Saturday morning'
+        end
+
+        it 'sets the line' do
+          visitor.visit_Scenario(@node)
+          visitor.feature.scenarios.first.line.must_equal 3
+        end
+
+        it 'sets the tags' do
+          @tags.each do |step|
+            step.expects(:accept).with visitor
+          end
+          visitor.visit_Scenario(@node)
+        end
+
+        it 'iterates over its children' do
+          @steps.each do |step|
+            step.expects(:accept).with visitor
+          end
+          visitor.visit_Scenario(@node)
+        end
+
+      end
+
+      describe '#visit_Background' do
+        before do
+          @steps = [stub_everything, stub_everything, stub_everything]
+          @node  = stub(
+            steps: @steps,
+            line: 3
+          )
+        end
+
+        it 'adds the background to the feature' do
+          visitor.visit_Background(@node)
+          visitor.feature.background.must_be_kind_of Background
+        end
+
+        it 'sets the line' do
+          visitor.visit_Background(@node)
+          visitor.feature.background.line.must_equal 3
+        end
+
+        it 'iterates over its children' do
+          @steps.each do |step|
+            step.expects(:accept).with visitor
+          end
+          visitor.visit_Background(@node)
+        end
+
+        it 'visits the background' do
+          visitor.visit_Background(@node)
+        end
+      end
+
+      describe '#visit_Tag' do
+        it 'adds the tag to the current scenario' do
+          tags     = ['tag1', 'tag2', 'tag3']
+          scenario = stub(tags: tags)
+          visitor.instance_variable_set(:@current_scenario, scenario)
+
+          visitor.visit_Tag(stub(name: 'tag4'))
+          scenario.tags.must_equal ['tag1', 'tag2', 'tag3', 'tag4']
+        end
+      end
+
+      describe '#visit_Step' do
+        before do
+          @node  = stub(name: 'Baz', line: 3, keyword: 'Given')
+          @steps = [stub(name: 'Foo'), stub(name: 'Bar')]
+        end
+
+        it 'adds the step to the step set' do
+          step_set = stub(steps: @steps)
+          visitor.instance_variable_set(:@current_step_set, step_set)
+
+          visitor.visit_Step(@node)
+          step_set.steps.length.must_equal 3
+        end
+
+        it 'sets the name' do
+          step_set = stub(steps: [])
+          visitor.instance_variable_set(:@current_step_set, step_set)
+
+          visitor.visit_Step(@node)
+
+          step_set.steps.first.name.must_equal 'Baz'
+        end
+
+        it 'sets the keyword' do
+          step_set = stub(steps: [])
+          visitor.instance_variable_set(:@current_step_set, step_set)
+
+          visitor.visit_Step(@node)
+
+          step_set.steps.first.keyword.must_equal 'Given'
+        end
+
+        it 'sets the line' do
+          step_set = stub(steps: [])
+          visitor.instance_variable_set(:@current_step_set, step_set)
+
+          visitor.visit_Step(@node)
+
+          step_set.steps.first.line.must_equal 3
+        end
+      end
+    end
+  end
+end