spicycode-rcov 0.8.1.5.5 → 0.8.1.5.6

data/lib/rcov/rexml_extensions.rb

@@ -0,0 +1,44 @@
+require 'rexml/document'
+require 'rexml/formatters/pretty'
+
+module Rcov
+  module REXMLExtensions
+  
+    def self.fix_pretty_formatter_wrap
+      REXML::Formatters::Pretty.class_eval do
+        include PrettyFormatterWrapFix
+      end
+    end
+
+    # Fix for this bug: http://clint-hill.com/2008/10/02/a-bug-in-ruby-did-i-just-find-that/
+    # Also known from this fun exception:
+    #
+    #    /usr/local/ruby/lib/ruby/1.8/rexml/formatters/pretty.rb:131:in
+    #    `[]': no implicit conversion from nil to integer (TypeError)
+    #
+    # This bug was fixed in Ruby with this changeset http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=19487
+    # ...which should mean that this bug only affects Ruby 1.8.6.  The latest stable version of 1.8.7 (and up) should be fine.
+    module PrettyFormatterWrapFix
+
+      def self.included(base)
+        base.class_eval do
+          def wrap(string, width)
+            # Recursively wrap string at width.
+            return string if string.length <= width
+            place = string.rindex(' ', width) # Position in string with last ' ' before cutoff
+            return string if place.nil?
+            return string[0,place] + "\n" + wrap(string[place+1..-1], width)
+          end
+        end
+      end
+    
+    end
+  
+    def self.init!
+      if RUBY_VERSION == "1.8.6"
+        fix_pretty_formatter_wrap
+      end
+    end
+  end
+  
+end

data/lib/rcov/version.rb

@@ -4,7 +4,7 @@
 
 module Rcov
 
-VERSION = "0.8.1.5.5"
+VERSION = "0.8.1.5.6"
 RELEASE_DATE = "2008-10-29"
 RCOVRT_ABI = [2,0,0]
 UPSTREAM_URL = "http://github.com/spicycode/rcov"

data/test/rexml_test.rb

@@ -0,0 +1,23 @@
+require File.dirname(__FILE__) + '/test_helper'
+require 'rcov/rexml_extensions'
+
+class TestRexml < Test::Unit::TestCase
+
+  def test_wrap_with_long_lines_without_spaces_should_not_break_wrap
+    Rcov::REXMLExtensions.fix_pretty_formatter_wrap
+    pretty_formatter = ::REXML::Formatters::Pretty.new
+    long_string = "this-is-a-long-string-without-any-spaces-to-try-to-break-rexml-formatter-and-it-is-over-100-characters-long"
+    pretty_formatter.instance_eval { wrap(long_string, 100) } # avoid send, it can't bypass private methods in ruby19
+  end
+  
+  def test_wrap_original_behavior_should_be_preserved
+    pretty_formatter = REXML::Formatters::Pretty.new
+    str = "This string should be wrapped at 40 characters"
+    pretty_formatter.instance_eval do
+      str = wrap(str, 40)
+    end # avoid send, it can't bypass private methods in ruby19
+    assert_equal("This string should be wrapped at 40\ncharacters", str)
+    
+  end
+  
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: spicycode-rcov
 version: !ruby/object:Gem::Version 
-  version: 0.8.1.5.5
+  version: 0.8.1.5.6
 platform: ruby
 authors: 
 - Mauricio Fernandez
@@ -31,6 +31,7 @@ files:
 - lib/rcov/version.rb
 - lib/rcov/rant.rb
 - lib/rcov/report.rb
+- lib/rcov/rexml_extensions.rb
 - lib/rcov/rcovtask.rb
 - ext/rcovrt/extconf.rb
 - ext/rcovrt/rcovrt.c
@@ -56,6 +57,7 @@ files:
 - test/turn_off_rcovrt.rb
 - test/call_site_analyzer_test.rb
 - test/assets/sample_05.rb
+- test/rexml_test.rb
 - rcov.vim
 - rcov.el
 - setup.rb