spicerack-styleguide 0.27.2 → 0.29.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5096f26351efb29dfd3dc4574912f8b93d86b48def24538c0fd5a74a30156d03
-  data.tar.gz: 6af5bbb15351a94f505260c7933d4666bcabb078a7fb3b2bd6f62ee0bf6dc780
+  metadata.gz: 93976758d8cf4db8685472d8bb603178b5ccf7be2dcbd25e7d5d54f859c19d44
+  data.tar.gz: 7fd806960abe967ba5d07c6c4dd6bfadc8082ee5fe6c764ecff0fb370386c0ad
 SHA512:
-  metadata.gz: 1c0618e7dd6a3c9d1e6f617258dc77ce2faf90da5bcd54f8c7695ea69debd65c33b2561bc111fa2f74efc831ff27ca64159e451b81b374b53ea80fc44d16d741
-  data.tar.gz: 27e9aea35cfff644e99a12fd4e82ea0d42d693fb522ed911fda1859bbf29a7ddf482392e78d8b7a4c816ac019d62e6f5f0843f2cded1ec2e17f3a938cdc26ec5
+  metadata.gz: ef1f06474017ddccee17e59e553db6d5eb27c202a93475e6cd8d3751e2c9923b16d6cf4a0979a0ad9eeb533e4f2ecd38341db2fe60abbadcd1453747a40118cd
+  data.tar.gz: a3038f6e86bb36f9fc0ad508fc29631da6a92d391a93172ae0d63027c0e6d2542d44757c47f5265084bfc8dc6968a80a14c89e45a7888acf5cea06b897210ea7

data/README.md

@@ -64,7 +64,7 @@ This... is a yml. You don't develop it. Go home, boilerplate gem README text, yo
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/Freshly/spicerack.
+Bug reports and pull requests are welcome on GitHub at https://github.com/RubyAfterAll/spicerack.
 
 ## License
 

data/lib/spicerack/styleguide/version.rb

@@ -3,6 +3,6 @@
 module Spicerack
   module Styleguide
     # This constant is managed by spicerack
-    VERSION = "0.27.2"
+    VERSION = "0.29.1"
   end
 end

data/rubocop.yml

@@ -4,7 +4,8 @@ require:
   - rubocop-rails
 
 AllCops:
-  TargetRubyVersion: 2.6
+  TargetRubyVersion: 2.7
+  NewCops: enable
   Exclude:
     - "**/bin/**/*"
     - Rakefile
@@ -55,8 +56,24 @@ Layout/DefEndAlignment:
 Layout/DotPosition:
   Enabled: true
   EnforcedStyle: trailing
+Lint/AmbiguousAssignment:
+  Enabled: true
+Lint/DuplicateBranch:
+  Enabled: true
+Lint/DuplicateRegexpCharacterClassElement:
+  Enabled: true
 Layout/ElseAlignment:
   Enabled: true
+Lint/EmptyBlock:
+  Enabled: true
+Lint/EmptyClass:
+  Enabled: true
+Lint/NoReturnInBeginEndBlocks:
+  Enabled: true
+Lint/ToEnumArguments:
+  Enabled: true
+Lint/UnmodifiedReduceAccumulator:
+  Enabled: true
 Layout/EmptyComment:
   Enabled: true
   AllowBorderComment: true
@@ -125,6 +142,8 @@ Layout/HashAlignment:
   EnforcedHashRocketStyle: key
   EnforcedColonStyle: key
   EnforcedLastArgumentHashStyle: always_inspect
+Lint/HashCompareByIdentity:
+  Enabled: true
 Layout/HeredocArgumentClosingParenthesis:
   Enabled: true
 Layout/HeredocIndentation:
@@ -198,6 +217,8 @@ Layout/SpaceAroundOperators:
 Layout/SpaceBeforeBlockBraces:
   Enabled: true
   EnforcedStyle: space
+Layout/SpaceBeforeBrackets:
+  Enabled: true
 Layout/SpaceBeforeComma:
   Enabled: true
 Layout/SpaceBeforeComment:
@@ -360,6 +381,8 @@ Lint/PercentSymbolArray:
   Enabled: true
 Lint/RandOne:
   Enabled: true
+Lint/RedundantSafeNavigation:
+  Enabled: true
 Lint/RedundantStringCoercion:
   Enabled: true
 Lint/RedundantWithIndex:
@@ -398,6 +421,8 @@ Lint/ToJSON:
   Enabled: true
 Lint/UnderscorePrefixedVariableName:
   Enabled: true
+Lint/UnexpectedBlockArity:
+  Enabled: true
 Lint/UnifiedInteger:
   Enabled: true
 Lint/RaiseException:
@@ -550,8 +575,12 @@ Naming/VariableNumber:
 
 Performance/AncestorsInclude:
   Enabled: false
+Performance/ArraySemiInfiniteRangeSlice:
+  Enabled: false
 Performance/BigDecimalWithNumericArgument:
   Enabled: false
+Performance/BlockGivenWithExplicitBlock:
+  Enabled: true
 Performance/Caller:
   Enabled: false
 Performance/CaseWhenSplat:
@@ -562,6 +591,10 @@ Performance/CollectionLiteralInLoop:
   Enabled: true
 Performance/CompareWithBlock:
   Enabled: true
+Performance/ConstantRegexp:
+  Enabled: true
+Performance/ConcurrentMonotonicTime:
+  Enabled: true
 Performance/Count:
   Enabled: true
 Performance/Detect:
@@ -576,6 +609,10 @@ Performance/FlatMap:
   Enabled: true
 Performance/IoReadlines:
   Enabled: true
+Performance/MapCompact:
+  Enabled: true
+Performance/MethodObjectAsBlock:
+  Enabled: true
 Performance/OpenStruct:
   Enabled: true
   Exclude:
@@ -584,12 +621,16 @@ Performance/RangeInclude:
   Enabled: true
 Performance/RedundantBlockCall:
   Enabled: true
+Performance/RedundantEqualityComparisonBlock:
+  Enabled: true
 Performance/RedundantMatch:
   Enabled: true
 Performance/RedundantMerge:
   Enabled: true
 Performance/RedundantSortBlock:
   Enabled: true
+Performance/RedundantSplitRegexpArgument:
+  Enabled: true
 Performance/RedundantStringChars:
   Enabled: true
 Performance/RegexpMatch:
@@ -598,6 +639,8 @@ Performance/ReverseEach:
   Enabled: true
 Performance/ReverseFirst:
   Enabled: true
+Performance/SelectMap:
+  Enabled: true
 Performance/Size:
   Enabled: true
 Performance/SortReverse:
@@ -606,6 +649,8 @@ Performance/Squeeze:
   Enabled: true
 Performance/StartWith:
   Enabled: true
+Performance/StringIdentifierArgument:
+  Enabled: true
 Performance/StringInclude:
   Enabled: true
 Performance/StringReplacement:
@@ -630,6 +675,8 @@ Rails/ActiveRecordOverride:
   Enabled: true
 Rails/ActiveSupportAliases:
   Enabled: true
+Rails/AddColumnIndex:
+  Enabled: true
 Rails/ApplicationController:
   Enabled: true
 Rails/ApplicationMailer:
@@ -638,8 +685,12 @@ Rails/ApplicationJob:
   Enabled: true
 Rails/ApplicationRecord:
   Enabled: true
+Rails/ArelStar:
+  Enabled: true
 Rails/AfterCommitOverride:
   Enabled: true
+Rails/AttributeDefaultBlockValue:
+  Enabled: true
 Rails/BelongsTo:
   Enabled: true
 Rails/Blank:
@@ -665,8 +716,14 @@ Rails/EnumUniqueness:
   Enabled: true
 Rails/EnvironmentComparison:
   Enabled: true
+Rails/EnvironmentVariableAccess:
+  Enabled: true
+  AllowReads: true
+  AllowWrites: false
 Rails/Exit:
   Enabled: true
+Rails/ExpandedDateRange:
+  Enabled: true
 Rails/FilePath:
   Enabled: true
   EnforcedStyle: arguments
@@ -695,6 +752,8 @@ Rails/HttpPositionalArguments:
 Rails/HttpStatus:
   Enabled: true
   EnforcedStyle: symbolic
+Rails/I18nLocaleAssignment:
+  Enabled: true
 Rails/IndexBy:
   Enabled: true
 Rails/IndexWith:
@@ -780,6 +839,12 @@ Rails/ReversibleMigration:
   Enabled: true
   Include:
     - db/migrate/*.rb
+Rails/RequireDependency:
+  Enabled: false # Theoretically not all projects could use zeitwerk
+Rails/ReversibleMigrationMethodDefinition:
+  Enabled: true
+  Include:
+    - db/migrate/*.rb
 Rails/SafeNavigation:
   Enabled: true
 Rails/SafeNavigationWithBlank:
@@ -811,6 +876,8 @@ Rails/SquishedSQLHeredocs:
 Rails/TimeZone:
   Enabled: true
   EnforcedStyle: flexible
+Rails/TimeZoneAssignment:
+  Enabled: true
 Rails/UniqBeforePluck:
   Enabled: true
   EnforcedStyle: conservative
@@ -822,8 +889,14 @@ Rails/UnknownEnv:
     - development
     - test
     - production
+Rails/UnusedIgnoredColumns:
+  Enabled: true
+Rails/EagerEvaluationLogMessage:
+  Enabled: true
 Rails/WhereExists:
   Enabled: true
+Rails/WhereEquals:
+  Enabled: true
 Rails/WhereNot:
   Enabled: true
 Rails/Validation:
@@ -850,6 +923,8 @@ Style/Alias:
 Style/AndOr:
   Enabled: true
   EnforcedStyle: conditionals
+Style/ArgumentsForwarding:
+  Enabled: true
 Style/ArrayCoercion:
   Enabled: true
 Style/ArrayJoin:
@@ -884,6 +959,8 @@ Style/ClassAndModuleChildren:
 Style/ClassCheck:
   Enabled: true
   EnforcedStyle: is_a?
+Style/ClassEqualityComparison:
+  Enabled: true
 Style/ClassMethods:
   Enabled: true
 Style/ClassMethodsDefinitions:
@@ -891,6 +968,8 @@ Style/ClassMethodsDefinitions:
   EnforcedStyle: self_class
 Style/ClassVars:
   Enabled: true
+Style/CollectionCompact:
+  Enabled: true
 Style/CollectionMethods:
   Enabled: false
 Style/ColonMethodCall:
@@ -930,6 +1009,8 @@ Style/DisableCopsWithinSourceCodeDirective:
   Enabled: false
 Style/Documentation:
   Enabled: false
+Style/DocumentDynamicEvalDefinition:
+  Enabled: true
 Style/DocumentationMethod:
   Enabled: false
 Style/DoubleNegation:
@@ -996,6 +1077,8 @@ Style/HashAsLastArrayItem:
   EnforcedStyle: no_braces
 Style/HashEachMethods:
   Enabled: true
+Style/HashExcept:
+  Enabled: false # TODO: enable once ruby 3.0 is supported
 Style/HashLikeCase:
   Enabled: true
 Style/HashSyntax:
@@ -1078,6 +1161,8 @@ Style/MutableConstant:
 Style/NegatedIf:
   Enabled: true
   EnforcedStyle: both
+Style/NegatedIfElseCondition:
+  Enabled: true
 Style/NegatedUnless:
   Enabled: true
   EnforcedStyle: both
@@ -1112,6 +1197,8 @@ Style/Next:
   EnforcedStyle: skip_modifier_ifs
 Style/NilComparison:
   Enabled: true
+Style/NilLambda:
+  Enabled: true
 Style/NonNilCheck:
   Enabled: true
 Style/Not:
@@ -1165,6 +1252,8 @@ Style/RaiseArgs:
   EnforcedStyle: exploded
 Style/RandomWithOffset:
   Enabled: true
+Style/RedundantArgument:
+  Enabled: true
 Style/RedundantAssignment:
   Enabled: true
 Style/RedundantBegin:
@@ -1244,6 +1333,8 @@ Style/SpecialGlobalVars:
 Style/StabbyLambdaParentheses:
   Enabled: true
   EnforcedStyle: require_parentheses
+Style/StaticClass:
+  Enabled: false
 Style/StderrPuts:
   Enabled: true
 Style/StringConcatenation:
@@ -1330,6 +1421,8 @@ Style/RedundantPercentQ:
   Enabled: true
 Style/RedundantSort:
   Enabled: true
+Style/SwapValues:
+  Enabled: true
 Style/UnpackFirst:
   Enabled: true
 Style/VariableInterpolation:
@@ -1379,6 +1472,12 @@ RSpec/BeEql:
   Enabled: true
 RSpec/BeforeAfterAll:
   Enabled: true
+RSpec/Capybara/CurrentPathExpectation:
+  Enabled: true
+RSpec/Capybara/FeatureMethods:
+  Enabled: false
+RSpec/Capybara/VisibilityMatcher:
+  Enabled: true
 RSpec/ContextWording:
   Enabled: true
 RSpec/DescribeClass:
@@ -1424,6 +1523,13 @@ RSpec/ExpectInHook:
   Enabled: true
 RSpec/ExpectOutput:
   Enabled: true
+RSpec/FactoryBot/AttributeDefinedStatically:
+  Enabled: true
+RSpec/FactoryBot/CreateList:
+  Enabled: true
+  EnforcedStyle: create_list
+RSpec/FactoryBot/FactoryClassName:
+  Enabled: true
 RSpec/FilePath:
   Enabled: true
   IgnoreMethods: true
@@ -1434,6 +1540,8 @@ RSpec/HookArgument:
   EnforcedStyle: implicit
 RSpec/HooksBeforeExamples:
  Enabled: true
+RSpec/IdenticalEqualityAssertion:
+  Enabled: true
 RSpec/ImplicitBlockExpectation:
  Enabled: true
 RSpec/ImplicitExpect:
@@ -1444,8 +1552,6 @@ RSpec/InstanceSpy:
 RSpec/InstanceVariable:
   Enabled: true
   AssignmentOnly: false
-RSpec/InvalidPredicateMatcher:
-  Enabled: true
 RSpec/ItBehavesLike:
   Enabled: true
   EnforcedStyle: it_behaves_like
@@ -1490,6 +1596,8 @@ RSpec/PredicateMatcher:
   Enabled: true
   Strict: false
   EnforcedStyle: inflected
+RSpec/Rails/AvoidSetupHook:
+  Enabled: true
 RSpec/RepeatedDescription:
   Enabled: true
 RSpec/RepeatedExample:
@@ -1498,6 +1606,8 @@ RSpec/RepeatedExampleGroupBody:
     Enabled: true
 RSpec/RepeatedExampleGroupDescription:
     Enabled: true
+RSpec/RepeatedIncludeExample:
+  Enabled: true
 RSpec/ReturnFromStub:
   Enabled: true
   EnforcedStyle: and_return
@@ -1513,6 +1623,8 @@ RSpec/SingleArgumentMessageChain:
   Enabled: true
 RSpec/SubjectStub:
   Enabled: true
+RSpec/StubbedMock:
+  Enabled: true
 RSpec/VariableDefinition:
     Enabled: true
 RSpec/VariableName:
@@ -1524,18 +1636,3 @@ RSpec/VoidExpect:
   Enabled: true
 RSpec/Yield:
   Enabled: true
-
-FactoryBot/AttributeDefinedStatically:
-  Enabled: true
-FactoryBot/CreateList:
-  Enabled: true
-  EnforcedStyle: create_list
-FactoryBot/FactoryClassName:
-    Enabled: true
-
-Capybara/CurrentPathExpectation:
-  Enabled: true
-Capybara/FeatureMethods:
-  Enabled: false
-Capybara/VisibilityMatcher:
-  Enabled: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spicerack-styleguide
 version: !ruby/object:Gem::Version
-  version: 0.27.2
+  version: 0.29.1
 platform: ruby
 authors:
 - Allen Rettberg
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-08 00:00:00.000000000 Z
+date: 2022-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,56 +16,70 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.92.0
+        version: '1.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.92.0
+        version: '1.7'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.43.0
+        version: '2.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.43.0
+        version: '2.4'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: '1.13'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: '1.13'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.8.0
+        version: '2.11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.8.0
+        version: '2.11'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
 description: Wanna write code the Freshly way? Inherit this gem in your rubocop.yml
   and keep your code fresh
 email:
@@ -83,14 +97,14 @@ files:
 - lib/spicerack/styleguide.rb
 - lib/spicerack/styleguide/version.rb
 - rubocop.yml
-homepage: https://github.com/Freshly/spicerack/tree/main/spicerack-styleguide
+homepage: https://github.com/RubyAfterAll/spicerack/tree/main/spicerack-styleguide
 licenses:
 - MIT
 metadata:
-  homepage_uri: https://github.com/Freshly/spicerack/tree/main/spicerack-styleguide
-  source_code_uri: https://github.com/Freshly/spicerack/tree/main/spicerack-styleguide
-  changelog_uri: https://github.com/Freshly/spicerack/blob/main/spicerack-styleguide/CHANGELOG.md
-  documentation_uri: https://www.rubydoc.info/gems/spicerack-styleguide/0.27.2
+  homepage_uri: https://github.com/RubyAfterAll/spicerack/tree/main/spicerack-styleguide
+  source_code_uri: https://github.com/RubyAfterAll/spicerack/tree/main/spicerack-styleguide
+  changelog_uri: https://github.com/RubyAfterAll/spicerack/blob/main/spicerack-styleguide/CHANGELOG.md
+  documentation_uri: https://www.rubydoc.info/gems/spicerack-styleguide/0.29.1
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -106,7 +120,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.32
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Rubocop Styleguide for Rails and RSpec.