speednode 0.8.1 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ab3e330c3cd4bf4518c54e6666ff13ee722b553e4de7d8be2602b984811da9fc
-  data.tar.gz: '08218aa8e443770808a35de088c869bfc0d227493beba5f60b98ddcdfe35b51a'
+  metadata.gz: 3cb17f3391d9416c0a92291be8beaa42b25d8df70528e400d28a41984e3693bf
+  data.tar.gz: 463169b3ceb3d42703cbee80aa56c7edf2e1196a0114f8607eed173d0d6af583
 SHA512:
-  metadata.gz: 3f41ebd4a9b509dc81f815c7dff64ff3ce8ae15a57fa085038ce5cdb139ab37f0f0b26cded89f52450e4e39a0f69afd98238a7ed02d20db50e7d395872617f67
-  data.tar.gz: cb7d8667d95403426e7964e4e2be7d1608a3d2ad43fe1b36a694f125bd9595dfe3ba5b73d983d57215fdc637b2a141d8536f642435082005cbbdc5487af1b2e1
+  metadata.gz: fc644dbb0581167a2d03fe19b157cdd82fc2da2af2de29e80b4676e21097c2437e9da5acdb7bd6bdf0d6c52391bea5ad04b5a392e3717c2fb72cf0bc8004f1d5
+  data.tar.gz: 5e391001e4d7b42accf5c4b29ed424637fce9193871feb65a2c145ebc2ac082a94711031e70bf0221d9e70bc77cf40602f916f3571eb7a8d7624624deea52b06

data/README.md

@@ -48,7 +48,7 @@ ExecJS.permissive_eval('1+1')
 ```
 
 #### Stopping Contexts
-Contexts can be stopped programmatically. If all contexts of a VM are stopped, the VM itself will be shut down with Node exiting, freeing memory and resources.
+Contexts should be stopped programmatically when no longer needed.
 ```ruby
 context = ExecJS.compile('Test = "test"') # will start a node process
 ExecJS::Runtimes::Speednode.stop_context(context) # will kill the node process
@@ -80,7 +80,7 @@ context.await("foo('test')") # => 'test'
 
 ### Attaching ruby methods to Permissive Contexts
 
-Ruby methods can be attached to Permissive Contexts using Context#attach:
+Ruby methods can be attached to permissive contexts using Context#attach:
 ```ruby
   context = ExecJS.permissive_compile(SOURCE)
   context.attach('foo') { |v| v }

data/lib/speednode/runner.js

@@ -9,8 +9,8 @@ try {
   crypto_var = require('crypto');
 } catch (err) {}
 const crypto = crypto_var;
-let contexts = {};
-let scripts = {};
+let contexts = Object.create(null);
+let scripts = Object.create(null);
 let process_exit = false;
 
 /*** circular-json, originally taken from https://raw.githubusercontent.com/WebReflection/circular-json/
@@ -41,7 +41,7 @@ let process_exit = false;
 
  */
 
-const CircularJSON = {};
+const CircularJSON = Object.create(null);
 CircularJSON.specialChar = '~';
 CircularJSON.safeSpecialChar =  '\\x' + ('0' + CircularJSON.specialChar.charCodeAt(0).toString(16)).slice(-2);
 CircularJSON.escapedSafeSpecialChar = '\\' + CircularJSON.safeSpecialChar;
@@ -240,6 +240,8 @@ function getContext(uuid) {
 
 function getContextOptions(uuid) {
   let options = { filename: "(execjs)", displayErrors: true };
+  if (!contexts[uuid])
+    throw new Error(`Context ${uuid} not found`);
   if (contexts[uuid].options.timeout)
     options.timeout = contexts[uuid].options.timeout;
   return options;

data/lib/speednode/runtime/context.rb

@@ -1,12 +1,6 @@
 module Speednode
   class Runtime < ExecJS::Runtime
     class Context < ::ExecJS::Runtime::Context
-      def self.finalize(runtime, uuid)
-        proc do
-          runtime.unregister_context(uuid)
-        end
-      end
-
       def initialize(runtime, source = "", options = {})
         @runtime = runtime
         @uuid = SecureRandom.uuid
@@ -16,7 +10,7 @@ module Speednode
         @debug = false unless ENV['NODE_OPTIONS']&.include?('--inspect')
         @vm = @runtime.vm
         @timeout = options[:timeout] ? options[:timeout]/1000 : 600
-        
+
         filename = options.delete(:filename)
         source = File.read(filename) if filename
 
@@ -26,8 +20,6 @@ module Speednode
           source = source.force_encoding('UTF-8')
         end
 
-        ObjectSpace.define_finalizer(self, self.class.finalize(@runtime, @uuid))
-
         if @debug && @permissive
           raw_created(source, options)
         elsif @permissive
@@ -105,6 +97,10 @@ module Speednode
         raw_exec("(function(){#{source}})()")
       end
 
+      def available?
+        @runtime.context_registered?(@uuid)
+      end
+
       def stop
         @runtime.unregister_context(@uuid)
       end

data/lib/speednode/runtime/vm.rb

@@ -40,14 +40,17 @@ end
 module Speednode
   class Runtime < ExecJS::Runtime
     class VM
-      def self.finalize(socket, socket_dir, socket_path, pid)
+      def self.finalize(socket, socket_dir, socket_path, pid, spawner_pid)
         proc do
-          ::Speednode::Runtime.responders[socket_path].kill if ::Speednode::Runtime.responders[socket_path]
-          exit_node(socket, socket_dir, socket_path, pid)
+          if spawner_pid == Process.pid
+            ::Speednode::Runtime.responders[socket_path].kill if ::Speednode::Runtime.responders[socket_path]
+            exit_node(socket, socket_dir, socket_path, pid, spawner_pid)
+          end
         end
       end
 
-      def self.exit_node(socket, socket_dir, socket_path, pid)
+      def self.exit_node(socket, socket_dir, socket_path, pid, spawner_pid)
+        return if spawner_pid != Process.pid
         VMCommand.new(socket, "exit", 0).execute rescue nil
         socket.close
         File.unlink(socket_path) if File.exist?(socket_path)
@@ -135,8 +138,9 @@ module Speednode
 
       def stop
         return unless @started
+        return if @spawner_pid != Process.pid
         @mutex.synchronize do
-          self.class.exit_node(@socket, @socket_dir, @socket_path, @pid)
+          self.class.exit_node(@socket, @socket_dir, @socket_path, @pid, @spawner_pid)
           @socket_path = nil
           @started = false
           @socket = nil
@@ -151,10 +155,12 @@ module Speednode
           @socket_dir = nil
           @socket_path = SecureRandom.uuid
         else
-          @socket_dir = Dir.mktmpdir("iso-speednode-")
+          @socket_dir = Dir.mktmpdir("speednode-")
           @socket_path = File.join(@socket_dir, "socket")
         end
+        @spawner_pid = Process.pid
         @pid = Process.spawn({"SOCKET_PATH" => @socket_path}, @options[:binary], '--expose-gc', @options[:source_maps], @options[:runner_path])
+        Process.detach(@pid)
 
         retries = 500
 
@@ -183,7 +189,8 @@ module Speednode
 
         @started = true
 
-        Kernel.at_exit { self.class.finalize(@socket, @socket_dir, @socket_path, @pid).call }
+        exit_proc = self.class.finalize(@socket, @socket_dir, @socket_path, @pid, @spawner_pid)
+        Kernel.at_exit { exit_proc.call }
       end
 
       def create_responder(context)

data/lib/speednode/runtime.rb

@@ -24,7 +24,11 @@ module Speednode
       @popen_options = {}
       @popen_options[:external_encoding] = @encoding if @encoding
       @popen_options[:internal_encoding] = ::Encoding.default_internal || 'UTF-8'
-      @contexts = {} 
+      @contexts = {}
+    end
+
+    def context_registered?(uuid)
+      @contexts.key?(uuid)
     end
 
     def register_context(uuid, context)
@@ -33,8 +37,7 @@ module Speednode
 
     def unregister_context(uuid)
       context = @contexts.delete(uuid)
-      if context && @vm
-        ObjectSpace.undefine_finalizer(context)
+      if context
         @vm.delete_context(uuid) rescue nil # if delete_context fails, the vm exited before probably
       end
       @vm.stop if @contexts.size == 0 && @vm.started?

data/lib/speednode/version.rb

@@ -1,3 +1,3 @@
 module Speednode
-  VERSION = '0.8.1'
+  VERSION = '0.9.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: speednode
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.9.0
 platform: ruby
 authors:
 - Jan Biedermann
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-02-16 00:00:00.000000000 Z
+date: 2024-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: execjs
@@ -78,28 +78,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.20.0
+        version: 5.23.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.20.0
+        version: 5.23.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 13.1.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 13.1.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: uglifier
   requirement: !ruby/object:Gem::Requirement
@@ -114,8 +114,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: A fast ExecJS runtime based on nodejs. As fast as mini_racer, but without
-  the need to compile the js engine, because it uses the system provided nodejs.
+description: A fast ExecJS, almost as fast as mini_racer, but without the need to
+  compile the js engine, because it uses the system provided nodejs.
 email: jan@kursator.de
 executables: []
 extensions: []
@@ -156,7 +156,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.3
+rubygems_version: 3.5.9
 signing_key:
 specification_version: 4
 summary: A fast ExecJS runtime based on nodejs.