specwrk 0.19.2 → 0.19.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: befb2589fe879bbe901360402374acb906359ff133c877a9169bcb0f928d1833
-  data.tar.gz: 30c49a123a026d5a4af2da4fadf01cfc92637b095328c83c660d5a3ee7c26d43
+  metadata.gz: b2eb07bead54ad609b2d8fb821793a60b783485326daeccc092c14343ae96dc0
+  data.tar.gz: c41e008f026a61f2748cc8f5cd9c7dc2c257103518aa89fded4c84c9bd2ca976
 SHA512:
-  metadata.gz: 9e997305868b8cca5ce07ea2285462ed26b01079ccebe09617749ae76c42380787b68ed693af0df4aa6cf1e196b941c5449ae7034cf21614b16650c73de4fc6b
-  data.tar.gz: 21bb6a0af32806ed771f0e49ac0295e87ac6f57afb6259b5d74e09971adc5be23bdb1a5bcfb6762578f3f85b0387478d23767f1068e1fc53dd0dd2a63e84bbd3
+  metadata.gz: 1f9a7206df73023a2262d9775ff3b1983f403b4630ce54a04f7c4500ab77c51d30df6262604332b37e37fdf21cb98fe39952fcd0287f8b9ded7811a39ac97afe
+  data.tar.gz: ffbf1b2583044b4f3e4bdbc7cadb35278f93eb64274905c5869398f5ece9d2854ddad0c75463ac8172d025d8dcc7a92c8486d5d9ef581ad269c875aca5c22420

data/CHANGELOG.md

@@ -1,7 +1,18 @@
 # Changelog
 
 ## Unreleased  
-[Compare](https://github.com/danielwestendorf/specwrk/compare/v0.19.1...main)  
+[Compare](https://github.com/danielwestendorf/specwrk/compare/v0.19.3...main)  
+
+## v0.19.3 — 2026-07-26  
+[Compare](https://github.com/danielwestendorf/specwrk/compare/v0.19.2...v0.19.3)  
+- Retry transient file store read descriptor errors — [@danielwestendorf](https://github.com/danielwestendorf)  
+- Complete omitted worker processing examples as failures — [@danielwestendorf](https://github.com/danielwestendorf), [@benjaminwood](https://github.com/benjaminwood)  
+
+
+## v0.19.2 — 2025-12-09  
+[Compare](https://github.com/danielwestendorf/specwrk/compare/v0.19.1...v0.19.2)  
+- Optimize msgpack usage by using one packer/unpacker — [#180](https://github.com/danielwestendorf/specwrk/pull/180) by [@danielwestendorf](https://github.com/danielwestendorf)  
+- Standard style to v3.4 — [#179](https://github.com/danielwestendorf/specwrk/pull/179) by [@danielwestendorf](https://github.com/danielwestendorf)  
 - Add msgpack to the docker server — [#178](https://github.com/danielwestendorf/specwrk/pull/178) by [@danielwestendorf](https://github.com/danielwestendorf)  
 
 ## v0.19.1 — 2025-12-08  

data/lib/specwrk/store/file_adapter.rb

@@ -10,6 +10,9 @@ require "specwrk/store/base_adapter"
 module Specwrk
   class Store
     class FileAdapter < BaseAdapter
+      READ_ATTEMPTS = 3
+      READ_RETRY_DELAY = 0.01
+
       @work_queue = Queue.new
       @threads = []
 
@@ -91,18 +94,21 @@ module Specwrk
 
         read_keys.each do |key|
           self.class.schedule_work do
-            result_queue.push([key.to_s, read(key)])
+            result_queue.push([:ok, key.to_s, read(key)])
+          rescue => e
+            result_queue.push([:error, key.to_s, e])
           end
         end
 
-        Thread.pass until result_queue.length == read_keys.length
+        raw_results = read_keys.length.times.map { result_queue.pop }
+        error = raw_results.find { |status, _key, _result| status == :error }
+        raise error.last if error
 
         results = {}
-        until result_queue.empty?
-          result = result_queue.pop
-          next if result.last.nil?
+        raw_results.each do |_status, key, content|
+          next if content.nil?
 
-          results[result.first] = self.class.serializer.load(result.last)
+          results[key] = self.class.serializer.load(content)
         end
 
         read_keys.map { |key| [key.to_s, results[key.to_s]] if results.key?(key.to_s) }.compact.to_h # respect order requested in the returned hash
@@ -140,7 +146,17 @@ module Specwrk
 
       def read(key)
         filename = filename_for_key key
-        File.binread(filename)
+        attempts = 0
+
+        begin
+          attempts += 1
+          File.binread(filename)
+        rescue Errno::EBADF
+          raise if attempts >= READ_ATTEMPTS
+
+          sleep(READ_RETRY_DELAY * attempts)
+          retry
+        end
       rescue Errno::ENOENT
         nil
       end

data/lib/specwrk/store/serializer.rb

@@ -36,14 +36,14 @@ module Specwrk
 
         def dump(value)
           packer.tap(&:clear)
-            .tap { it.write(value) }
+            .tap { |msgpack| msgpack.write(value) }
             .then(&:to_s)
         end
 
         def load(payload)
           unpacker.tap(&:reset)
-            .tap { it.feed(payload) }
-            .then { it.read }
+            .tap { |msgpack| msgpack.feed(payload) }
+            .then { |msgpack| msgpack.read }
         end
 
         def packer

data/lib/specwrk/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Specwrk
-  VERSION = "0.19.2"
+  VERSION = "0.19.3"
 end

data/lib/specwrk/web/endpoints/complete_and_pop.rb

@@ -7,12 +7,14 @@ module Specwrk
     module Endpoints
       class CompleteAndPop < Popable
         EXAMPLE_STATUSES = %w[passed failed pending]
+        SYNTHETIC_FAILURE_CLASS = "Specwrk::WorkerExecutionError"
 
         def with_response
           retry_examples # pre-calculate before lock
+          omitted_processing_examples # pre-calculate before lock
 
           with_lock do
-            processing.delete(*(completed_examples.keys + retry_examples.keys))
+            processing.delete(*(completed_examples.keys + retry_examples.keys).map(&:to_s))
             pending.merge!(retry_examples)
           end
 
@@ -26,24 +28,30 @@ module Specwrk
 
         private
 
-        def all_examples
-          @all_examples ||= payload.map { |example| [example[:id], example] if processing_examples[example[:id]] }.compact.to_h
+        def reported_processing_examples
+          @reported_processing_examples ||= payload.map do |example|
+            [example[:id], example] if processing_examples_for_payload[example[:id]]
+          end.compact.to_h
         end
 
-        def processing_examples
-          @processing_examples ||= processing.multi_read(*payload.map { |example| example[:id] })
+        def processing_examples_for_payload
+          @processing_examples_for_payload ||= processing.multi_read(*payload.map { |example| example[:id] })
         end
 
         def completed_examples
-          @completed_examples ||= all_examples.map do |id, example|
-            next if retry_example?(example)
+          @completed_examples ||= begin
+            reported_completed_examples = reported_processing_examples.map do |id, example|
+              next if retry_example?(example)
 
-            [id, example]
-          end.compact.to_h
+              [id, example]
+            end.compact.to_h
+
+            reported_completed_examples.merge(unreported_completed_examples)
+          end
         end
 
         def retry_examples
-          @retry_examples ||= all_examples.map do |id, example|
+          @retry_examples ||= reported_processing_examples.map do |id, example|
             next unless retry_example?(example)
 
             [id, example]
@@ -66,7 +74,48 @@ module Specwrk
         end
 
         def all_example_failure_counts
-          @all_example_failure_counts ||= failure_counts.multi_read(*all_examples.keys)
+          @all_example_failure_counts ||= failure_counts.multi_read(*reported_processing_examples.keys)
+        end
+
+        def omitted_processing_examples
+          @omitted_processing_examples ||= processing.to_h.select do |_id, example|
+            example[:worker_id].to_s == worker_id && !payload_example_ids.include?(example[:id].to_s)
+          end
+        end
+
+        def unreported_completed_examples
+          @unreported_completed_examples ||= omitted_processing_examples.transform_values { |example| synthetic_failure_for(example) }
+        end
+
+        def payload_example_ids
+          @payload_example_ids ||= payload.map { |example| example[:id].to_s }.uniq
+        end
+
+        def synthetic_failure_for(example)
+          finished_at = Time.now
+
+          {
+            id: example[:id],
+            full_description: "Specwrk worker execution failed before completing #{example[:id]}",
+            status: "failed",
+            file_path: example[:file_path],
+            line_number: line_number_for(example),
+            started_at: finished_at.iso8601(6),
+            finished_at: finished_at.iso8601(6),
+            run_time: 0.0,
+            exception: {
+              class: SYNTHETIC_FAILURE_CLASS,
+              message: "Worker #{worker_id} claimed this example but did not submit a completion result. Check worker stderr/stdout for the underlying RSpec output.",
+              backtrace: []
+            }
+          }
+        end
+
+        def line_number_for(example)
+          return example[:line_number] if example[:line_number]
+
+          match = example[:id].to_s.match(/:(\d+)\z/)
+          match[1].to_i if match
         end
 
         def completed_examples_status_counts
@@ -87,7 +136,9 @@ module Specwrk
         end
 
         def run_time_data
-          @run_time_data ||= payload.map { |example| [example[:id], example[:run_time]] }.to_h
+          @run_time_data ||= payload.map { |example| [example[:id], example[:run_time]] }.to_h.merge(
+            unreported_completed_examples.transform_values { |example| example[:run_time] }
+          )
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: specwrk
 version: !ruby/object:Gem::Version
-  version: 0.19.2
+  version: 0.19.3
 platform: ruby
 authors:
 - Daniel Westendorf
@@ -274,7 +274,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.10
 specification_version: 4
 summary: Parallel rspec test runner from a queue of pending jobs.
 test_files: []