spectacles 0.5.1 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2e52e394df12083b7bf0f9c1a11d7bd0c289cf31
-  data.tar.gz: f9e492ffaf04763f7b0426a5f02e4bb3a411f3af
+  metadata.gz: 6bff68ef734659627597aa1deae49e6357b55a1a
+  data.tar.gz: 9562fb0f911b796007471e34520a8c29a960e943
 SHA512:
-  metadata.gz: 639f04580f920782af8dea089d4e2d174c23283c3c808813e0ed0950b1b86ac28483c398e22f07dd1030ac5b0342d4de13502fd0258d8bbd02df94ee0cd149e2
-  data.tar.gz: 54591a3d0620f44d364adcac8d21eac4075ba0382e9780acbaa5db30e2f4e5499b9673fa11420ddb4ff457951119883c071ff075d27e1358db7a4a59a55858b9
+  metadata.gz: 4195cc3601e942d02ef38564c16b7ac0bacfff12ea6559165b4b673b90cfb230679a9a88bc9db941260d4f8c28d422912ece536a97b71c760783d0f0f977cfc2
+  data.tar.gz: 51e088f02be3e2a436956339d340376fefb379e4a3164a7c07b24f94a484c39a1d89d9b09016e6ede1a853619bd7d8362d7388243bb49a4a6d0a1862a75c0589

data/lib/spectacles/schema_statements/postgresql_adapter.rb

@@ -4,7 +4,7 @@ module Spectacles
   module SchemaStatements
     module PostgreSQLAdapter
       include Spectacles::SchemaStatements::AbstractAdapter
-      
+
       def views(name = nil) #:nodoc:
         q = <<-SQL
         SELECT table_name, table_type
@@ -12,22 +12,23 @@ module Spectacles
          WHERE table_schema IN (#{schemas})
            AND table_type = 'VIEW'
         SQL
-        
+
         execute(q, name).map { |row| row['table_name'] }
       end
 
       def view_build_query(view, name = nil)
         q = <<-SQL
         SELECT view_definition
-          FROM information_schema.views 
+          FROM information_schema.views
          WHERE table_catalog = (SELECT catalog_name FROM information_schema.information_schema_catalog_name)
            AND table_schema IN (#{schemas})
            AND table_name = '#{view}'
         SQL
-        
-        select_value(q, name) or raise "No view called #{view} found"
+
+        view_sql = select_value(q, name) or raise "No view called #{view} found"
+        view_sql.gsub("\"", "\\\"")
       end
-      
+
     private
       def schemas
         schema_search_path.split(/,/).map { |p| quote(p) }.join(',')

data/lib/spectacles/version.rb

@@ -1,3 +1,3 @@
 module Spectacles
-  VERSION = "0.5.1"
+  VERSION = "0.5.2"
 end

data/specs/adapters/postgresql_adapter_spec.rb

@@ -14,4 +14,16 @@ describe "Spectacles::SchemaStatements::PostgreSQLAdapter" do
 
   it_behaves_like "an adapter", "PostgreSQLAdapter"
   it_behaves_like "a view model"
+
+  describe "#view_build_query" do
+    test_base = Class.new do
+      extend Spectacles::SchemaStatements::PostgreSQLAdapter
+      def self.schema_search_path; ""; end
+      def self.select_value(_, _); "\"products\""; end;
+    end
+
+    it "should escape double-quotes returned by Postgres" do
+      test_base.view_build_query(:new_product_users).must_match(/\\"/)
+    end
+  end
 end

metadata

@@ -1,69 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: spectacles
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors:
 - Adam Hutchison, Brandon Dewitt
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-07 00:00:00.000000000 Z
+date: 2014-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.0
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Spectacles adds database view functionality to ActiveRecord. Current
@@ -74,7 +74,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - LICENSE
 - Rakefile
@@ -117,17 +117,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.11
+rubygems_version: 2.4.3
 signing_key: 
 specification_version: 4
 summary: Spectacles (derived from RailsSQLViews) adds database view functionality