specific_install 0.2.7 → 0.2.8

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NTg5NmQ2ZTU3YTY5ZTYwYjE1ZjdjZTVlMjI2MmRiNzljMjMzOGZlNA==
+    MWNmNjQ1MTg3NDk1OWU0ZmFhYWMwYzE3ZGUyYmQxOTlmOTc1OGFhMQ==
   data.tar.gz: !binary |-
-    MDBiNDM4MmEyZTljMTljMWRiMjYwYmMwZTA4MjhlOTI1ZmRkZTRjYQ==
+    NzUxMTM1ZmZhNTM1YmI2OTU0YTIxNzczY2YyYWE5N2FkZDJmNjc5ZQ==
 SHA512:
   metadata.gz: !binary |-
-    MjlmNjFjZWY1YmIyYTMyZTcxN2ZiNDg1OWFiYTBhMTI2MDA1NDlmNzhlY2Ew
-    MzljM2JmNjRiZTQwMWExZDAyMmFiN2YxYWE1MmQ0MGVjNjg3NDY2NTAxMjJh
-    ZjM1M2JmNmNiMzFkYzViYjFkNDAyNzA2OWM2ZDI3YTQ0NDAxODY=
+    ODhlMDE5NjRhNTI1NmZmMmRkMzIwM2JlYzg0OTRmNTc5ZGFiN2Y4MmM0YTg1
+    YzVjYjAwNTI5ZDIxNzczNDU4YmUzMzE2YTM2MzhiNzE2OTM5ZGRiNzBmMDFl
+    NThkYjdjMjBhMTYwMjAzNzQyMjIzMTAzYWI1ZWMxOTY0MmI4ZTk=
   data.tar.gz: !binary |-
-    NGNjOTliMWNhNWVkNjJiNDY2MjZmNjBhZWFjMWIzNzIxM2RiZDhlYzkyMWM5
-    ZTA4MmNlZWE4YzJmYWJhNmI4ZTYxY2MxYzM2OTQ1YzQ3NGQ0NjZkYmMxNzI1
-    NmFmZTNmMjE4MTQxYmY4NGQzMTZhNDAyNGYyZjRhM2M1MTE4YTg=
+    MTI2MzEwYzkwYmNhZWU2ZjlmOGZhZWQyNTAwOTBlZTQ2ZjI0ZTJkMzc0NjM5
+    NzBlMzQ1NDMzNjMyMjQ3ZjljZjdlODJlMjJhMjRiYjQ0NzNkYWNkMjQwMGFj
+    Mjk1YmMzOTRkYTdiMjUyMDJkNzRjNDg5Mjc0ODE1N2RmYjJkNDQ=

data/Rakefile

@@ -1 +1,8 @@
 require "bundler/gem_tasks"
+
+desc "Uninstall specific_install and release, then reinstall"
+task :rubygems do
+  sh "gem uninstall specific_install --executables"
+  Rake::Task["release"].invoke
+  sh "gem install specific_install"
+end

data/lib/rubygems/commands/specific_install_command.rb

@@ -1,19 +1,20 @@
 require 'rubygems/command_manager'
 require 'rubygems/dependency_installer'
-require 'rubygems/builder'
 require 'tempfile'
 require 'backports'
 require 'fileutils'
 require 'open-uri'
 
 class Gem::Commands::SpecificInstallCommand < Gem::Command
+  attr_accessor :output
 
   def description
     "Allows you to install an 'edge' gem straight from its github repository or from a web site"
   end
 
-  def initialize
+  def initialize(output=STDOUT)
     super 'specific_install', description
+    @output = output
 
     add_option('-l', '--location LOCATION', arguments) do |location|
       options[:location] = location
@@ -26,7 +27,7 @@ class Gem::Commands::SpecificInstallCommand < Gem::Command
   end
 
   def arguments
-    "LOCATION like http://github.com/rdp/ruby_tutorials_core or git://github.com/rdp/ruby_tutorials_core.git or http://host/gem_name.gem"
+    "LOCATION like http://github.com/rdp/ruby_tutorials_core or git://github.com/rdp/ruby_tutorials_core.git or http://host/gem_name.gem\n" +
     "BRANCH (optional) like beta, or new-feature"
   end
 
@@ -35,64 +36,74 @@ class Gem::Commands::SpecificInstallCommand < Gem::Command
   end
 
   def execute
-    unless options[:location]
-      puts "No location received. Use `gem specific_install -l http://example.com/rdp/specific_install`"
-      exit 1
+    @loc ||= set_location
+    @branch ||= set_branch if set_branch
+    if @loc.nil?
+      raise ArgumentError, "No location received. Use `gem specific_install -l http://example.com/rdp/specific_install`"
     end
-      # options are
-      # http://github.com/githubsvnclone/rdoc.git
-      # git://github.com/githubsvnclone/rdoc.git
-      # git@github.com:rdp/install_from_git.git
-      # http://github.com/rdp/install_from_git [later]
-      # http://host/gem_name.gem
-      # rdp/specific_install
-    dir = Dir.mktmpdir
-    begin
-      loc = options[:location]
-      case loc
-      when /^http(.*)\.gem$/
-        Dir.chdir dir do
-          say "downloading #{loc}"
-          gem_name = loc.split("/").last
-          download(loc, gem_name)
-
-          if install_gemspec
-            success_message
-          else
-            puts "failed"
-          end
-        end
-      when /\.git$/
-       say 'git installing from ' + loc
+    Dir.mktmpdir do |dir|
+      @dir = dir
+      determine_source_and_install
+    end
+  end
 
-       system("git clone #{loc} #{dir}")
-       install_from_git(dir)
-      when %r(.*/.*)
-        puts "Installing from git@github.com:#{loc}.git"
+  def determine_source_and_install
+    case @loc
+    when /^https?(.*)\.gem$/
+      install_gem
+    when /\.git$/
+      install_git
+    when %r(.*/.*)
+      install_shorthand
+    else
+      warn 'Error: must end with .git to be a git repository' +
+        'or be in shorthand form: rdp/specific_install'
+    end
+  end
 
-        system("git clone git@github.com:#{loc}.git #{dir}")
-        install_from_git(dir)
+  def install_gem
+    Dir.chdir @dir do
+      output.puts "downloading #{@loc}"
+      download(@loc, gem_name)
+
+      if install_gemspec
+        success_message
       else
-        puts 'Error: must end with .git to be a git repository' +
-        'or be in shorthand form: rdp/specific_install'
+        output.puts "Failed"
       end
-    ensure
-      FileUtils.rm_rf dir
     end
+  end
 
+  def gem_name
+    @gem_name ||= @loc.split("/").last
   end
 
-  private
+  def install_git
+    output.puts 'git installing from ' + @loc
+
+    redirect_for_specs = ENV.fetch( "SPECIFIC_INSTALL_SPEC" ) { "" }
+    system("git clone #{@loc} #{@dir} #{redirect_for_specs}")
+    install_from_git(@dir)
+  end
+
+  def install_shorthand
+    output.puts "Installing from git@github.com:#{@loc}.git"
+
+    redirect_for_specs = ENV.fetch( "SPECIFIC_INSTALL_SPEC" ) { "" }
+    system("git clone git@github.com:#{@loc}.git #{@dir} #{redirect_for_specs}")
+    install_from_git(@dir)
+  end
 
   def download( full_url, output_name )
     File.open(output_name, "wb") do |output_file|
-      output_file.write(open(full_url).read)
+      uri = URI.parse(full_url)
+      output_file.write(uri.read)
     end
   end
 
   def install_from_git(dir)
     Dir.chdir dir do
-      change_to_branch(options[:branch]) if options[:branch]
+      change_to_branch(@branch) if @branch
       ['', 'rake gemspec', 'rake gem', 'rake build', 'rake package'].each do |command|
         system command
         if install_gemspec
@@ -103,21 +114,54 @@ class Gem::Commands::SpecificInstallCommand < Gem::Command
     end
   end
 
+  def set_location
+    options[:location] || options[:args][0]
+  end
+
+  def set_branch
+    options[:branch] || options[:args][1]
+  end
+
   def success_message
-    puts 'Successfully installed'
+    output.puts 'Successfully installed'
   end
 
   def install_gemspec
-    if gemspec_file = Dir['*.gemspec'][0]
+    gem = find_or_build_gem
+
+    inst = Gem::DependencyInstaller.new
+    inst.install gem
+  end
+
+  def find_or_build_gem
+    if gemspec_exists?
       gemspec = Gem::Specification.load(gemspec_file)
-      gem = Gem::Builder.new(gemspec).build
-    elsif gem = Dir['**/*.gem'][0]
+      Gem::Package.build gemspec
+    elsif gemfile
+      gemfile
+    else
+      raise ArgumentError, "Can't find gemspec or gem"
+    end
+  end
+
+  def gemspec_file(name = "*.gemspec")
+    Dir[name][0]
+  end
+
+  def gemspec_exists?(name = "*.gemspec")
+    if gemspec_file(name)
+      File.exists?(gemspec_file(name))
     else
       false
     end
+  end
 
-    inst = Gem::DependencyInstaller.new
-    inst.install gem
+  def gemfile(name = '**/*.gem')
+    if Dir[name].empty?
+      false
+    else
+      Dir[name][0]
+    end
   end
 
   def change_to_branch(branch)

data/lib/specific_install/version.rb

@@ -1,3 +1,3 @@
 module SpecificInstall
-  VERSION = "0.2.7"
+  VERSION = "0.2.8"
 end

data/spec/spec_helper.rb

@@ -0,0 +1,10 @@
+require 'simplecov'
+require 'simplecov-vim/formatter'
+require 'rspec'
+require 'rspec/mocks'
+
+SimpleCov.start do
+  formatter SimpleCov::Formatter::VimFormatter
+end
+
+require 'rubygems_plugin'

data/spec/specific_install_spec.rb

@@ -0,0 +1,209 @@
+require 'spec_helper'
+require 'stringio'
+require 'open3'
+
+describe Gem::Commands::SpecificInstallCommand do
+  before do
+    module Kernel
+      alias_method :real_system, :system
+
+      def system(cmd)
+        'system "#{cmd}"'
+      end
+
+      def puts(cmd)
+        cmd
+      end
+    end
+
+  end
+  after do
+    module Kernel
+      alias_method :system, :real_system
+    end
+  end
+
+  subject { Gem::Commands::SpecificInstallCommand.new(StringIO.new) }
+  describe "#gem_name" do
+    it "sets gem_name from location" do
+      subject.instance_variable_set(:@loc, "stuff/foo/bar")
+      expect(subject.gem_name).to eq("bar")
+    end
+  end
+
+  context "disable #install_from_git" do
+    before do
+      class Gem::Commands::SpecificInstallCommand
+        def install_from_git(dir)
+          dir
+        end
+      end
+      subject.instance_variable_set(:@dir, "foo")
+    end
+    describe "#install_git" do
+      before do
+        subject.instance_variable_set(:@loc, "bar")
+      end
+      it "sends correct command to system" do
+        subject.should_receive(:system).with(/git clone bar foo/)
+        subject.install_git
+      end
+    end
+
+    describe "#install_shorthand" do
+      it "formats the shorthand into a git repo" do
+        subject.instance_variable_set(:@loc, "bar/zoz")
+        subject.should_receive(:system).with(%r{git clone git@github.com:bar/zoz.git foo})
+        subject.install_shorthand
+      end
+    end
+  end
+
+  describe "#success_message" do
+    it "returns correct message" do
+      subject.output.should_receive(:puts).with('Successfully installed')
+      subject.success_message
+    end
+  end
+
+  describe "#install_gemspec" do
+    context "when no gemspec or gem" do
+      xit "returns false" do
+        expect( subject.install_gemspec ).to eq(false)
+      end
+    end
+  end
+
+  describe "#gemspec_exists?" do
+    it "response true to when exists" do
+      expect( subject.gemspec_exists? ).to be_true
+    end
+
+    it "responds false when not present" do
+      expect( subject.gemspec_exists?("*.gemNOTPRESENT") ).to be_false
+    end
+  end
+
+  describe "#gemfile" do
+    it "response false when not existing" do
+      expect( subject.gemfile("*.gemNOTPRESENT") ).to be_false
+    end
+    it "response true to when exists" do
+      expect( subject.gemfile("**/*.gem") ).to be_true
+    end
+  end
+
+  describe "#determine_source_and_install" do
+    it "executes http gem requests" do
+        subject.instance_variable_set(:@loc, "http://example.com/rad.gem")
+        subject.should_receive(:install_gem)
+        subject.determine_source_and_install
+    end
+    it "executes https gem requests" do
+        subject.instance_variable_set(:@loc, "https://example.com/rad.gem")
+        subject.should_receive(:install_gem)
+        subject.determine_source_and_install
+    end
+    it "executes https git install requests" do
+        subject.instance_variable_set(:@loc, "https://example.com/rad.git")
+        subject.should_receive(:install_git)
+        subject.determine_source_and_install
+    end
+    it "executes git url git install requests" do
+        subject.instance_variable_set(:@loc, "git@github.com:example/rad.git")
+        subject.should_receive(:install_git)
+        subject.determine_source_and_install
+    end
+    it "executes shorthand github install requests" do
+        subject.instance_variable_set(:@loc, "example/rad")
+        subject.should_receive(:install_shorthand)
+        subject.determine_source_and_install
+    end
+    it "executes shorthand github install requests" do
+        subject.instance_variable_set(:@loc, "example")
+        subject.should_receive(:warn)
+        subject.determine_source_and_install
+    end
+  end
+
+  describe "#set_location" do
+    it "sets from options[location]" do
+      subject.options[:location] = "example"
+      expect( subject.set_location ).to eq("example")
+    end
+    it "sets from options[args]" do
+      subject.options[:location] = nil
+      subject.options[:args] = ["args"]
+      expect( subject.set_location ).to eq("args")
+    end
+    it "sets neither and results in nil" do
+      subject.options[:location] = nil
+      subject.options[:args] = []
+      expect( subject.set_location ).to be_nil
+    end
+  end
+
+  describe "#execute" do
+    it "raises error when no location received" do
+      subject.options[:location] = nil
+      subject.options[:args] = []
+      expect{ subject.execute }.to raise_error(ArgumentError)
+    end
+  end
+
+end
+
+
+describe "Integration Tests" do
+
+  $STDOUT = StringIO.new
+  let(:output) { StringIO.new }
+  subject { Gem::Commands::SpecificInstallCommand.new(output) }
+  before(:all) do
+    # ENV.store( "SPECIFIC_INSTALL_SPEC", '2&> /dev/null' )
+  end
+  before(:each) do
+    `gem uninstall specific_install --executables 2&> /dev/null`
+    `rake install 2&> /dev/null`
+  end
+
+  after(:all) do
+    `gem uninstall specific_install --executables 2&> /dev/null`
+    `gem install specific_install`
+    ENV.delete( "SPECIFIC_INSTALL_SPEC" )
+  end
+
+  context "working URIs" do
+    it "installs from https" do
+      url = "https://github.com/rdp/specific_install.git"
+      subject.instance_variable_set(:@loc, url)
+      subject.options[:args] = []
+      stdout, status = Open3.capture2 "gem specific_install #{url}"
+      expect(stdout).to match(/Successfully installed/)
+    end
+    it "installs from http" do
+      url = "http://github.com/rdp/specific_install.git"
+      subject.instance_variable_set(:@loc, url)
+      subject.options[:args] = []
+      stdout, status = Open3.capture2 "gem specific_install #{url}"
+      expect(stdout).to match(/Successfully installed/)
+    end
+    it "installs from shorthand" do
+      url = "rdp/specific_install"
+      subject.instance_variable_set(:@loc, url)
+      subject.options[:args] = []
+      stdout, status = Open3.capture2 "gem specific_install #{url}"
+      expect(stdout).to match(/Successfully installed/)
+    end
+    it "installs from git" do
+      url = "git@github.com:zph/buff.git"
+      stdout, status = Open3.capture2 "gem specific_install #{url}"
+      expect(stdout).to match(/Successfully installed/)
+    end
+    it "installs from packaged gem" do
+      url = "https://rubygems.org/downloads/specific_install-0.2.7.gem"
+      stdout, status = Open3.capture2 "gem specific_install #{url}"
+      expect(stdout).to match(/Successfully installed/)
+    end
+  end
+end

data/specific_install.gemspec

@@ -26,4 +26,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'sane'
   s.add_development_dependency "bundler", "~> 1.3"
   s.add_development_dependency "rake"
+  s.add_development_dependency "rspec"
+  s.add_development_dependency "simplecov"
+  s.add_development_dependency "simplecov-vim"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: specific_install
 version: !ruby/object:Gem::Version
-  version: 0.2.7
+  version: 0.2.8
 platform: ruby
 authors:
 - Roger Pack
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-21 00:00:00.000000000 Z
+date: 2013-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backports
@@ -80,6 +80,48 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov-vim
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: rubygems plugin that allows you you to install a gem from from its github
   repository (like 'edge'), or from an arbitrary URL
 email: rogerdpack@gmail.com
@@ -95,6 +137,8 @@ files:
 - lib/rubygems/commands/specific_install_command.rb
 - lib/rubygems_plugin.rb
 - lib/specific_install/version.rb
+- spec/spec_helper.rb
+- spec/specific_install_spec.rb
 - specific_install.gemspec
 homepage: https://github.com/rdp/specific_install
 licenses:
@@ -121,5 +165,7 @@ signing_key:
 specification_version: 4
 summary: rubygems plugin that allows you you to install a gem from from its github
   repository (like 'edge'), or from an arbitrary URL
-test_files: []
+test_files:
+- spec/spec_helper.rb
+- spec/specific_install_spec.rb
 has_rdoc: