specguard-ruby 0.3.5 → 0.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9a82ff31aaa51455637e6500a2f4cebda11b50dad52947bd36ce535ada84bc1b
-  data.tar.gz: 658887600bd0fec337a1d7ddd372b3c481fa761c95ff3c92c25f12fc6e0fcf91
+  metadata.gz: a0b4156ddf8b2beed6ac009599c80e2be04d0ce213c44bd020bcf58c7bbb5bca
+  data.tar.gz: 21c4cad8aa165736d247e3092bb22480d3502525cb89d5e7e183f1bf69db69f2
 SHA512:
-  metadata.gz: 88589ddb1374aa792be0199049b7bb204b6479850831db80340344f4d624db96dc9b7c1c345d6c95c24bbb6728b4e711ab7a338899a7a815c09e6eb53f47c4b2
-  data.tar.gz: e11192524e6f248aa16d42c522664863a84894b85987f07ef5f54e5b9c2439bdb6146b0f3c693196d0fcc627f85923f24c5655ed330a9809926f1519802e1e0f
+  metadata.gz: 938b3a7dd2a6f20d75a1493346668ce07236a4db6e0d867d35166dc42c9efe1e76581550793ab475ca21c14ae0006cb5668f2755174f10c00c49de108a90ea63
+  data.tar.gz: 0b00056261a247ac2f3c31484a918fb371cc4abb05c2f0a2c2b932148633a1a57b3fa487a6d95d150e25066e23ca5952fcc575a6aaa03059224c3092b8b740e1

data/README.md

@@ -33,7 +33,9 @@ The plugin rides alongside Minitest's own reporters (the suite's output is uncha
 envelope per process with the same field names the RSpec formatter sends, and never fails the run:
 a refused or unreachable delivery costs one line on stderr and a line in the local sink. Without
 `SPECGUARD_API_KEY` nothing is sent — the run is appended to the local development record, exactly
-as the RSpec formatter behaves. For a deterministic CI attachment where plugin discovery must not
+as the RSpec formatter behaves. Parameterized tests — the `define_method("test_x_#{param}")` loop
+idiom — ship one row per instance, not one row per definition site, so each instance's outcome and
+duration are tracked on their own. For a deterministic CI attachment where plugin discovery must not
 be assumed, require it explicitly before the run:
 
 ```bash

data/lib/specguard/minitest/reporter.rb

@@ -69,6 +69,13 @@ module SpecGuard
         end
       end
 
+      # Internal, never on the wire: `record` stashes the result's own method
+      # name under this key so `uniquify_ids!` can re-identify colliding rows
+      # at delivery time, and `uniquify_ids!` strips it again before the
+      # payload is built. The underscore prefix exists so a leak onto the
+      # wire would be loud in any payload diff rather than plausible.
+      RESULT_NAME_KEY = "_specguard_result_name"
+
       def initialize(configuration: SpecGuard::RSpec.configuration,
                      transport: nil, output: $stderr,
                      annotations: SpecGuard::RSpec::AnnotationLookup.new,
@@ -104,7 +111,12 @@ module SpecGuard
       # exit code.
       def record(result)
         row = row_for(result)
-        @rows << row if row
+        return unless row
+
+        # Stashed for `uniquify_ids!` (and stripped there) — the one
+        # unique-per-result token a Minitest row has. See that method.
+        row[RESULT_NAME_KEY] = result.name.to_s
+        @rows << row
       rescue ScriptError, StandardError
         nil
       end
@@ -115,6 +127,7 @@ module SpecGuard
       def report
         return if @rows.empty?
 
+        uniquify_ids!
         deliver(payload)
       rescue ScriptError, StandardError => e
         warn_once("could not ship test telemetry (#{e.class}: #{e.message}). The test run is unaffected.")
@@ -129,6 +142,35 @@ module SpecGuard
 
       private
 
+      # The definition site is NOT unique per result for a generated test:
+      # `define_method("test_x_#{param}")` in a loop (or any
+      # generate_tests-style helper) stamps every instance with the SAME
+      # `source_location` — the define_method call site — so N results share
+      # one id, and the platform's ingest upserts
+      # `unique_by %i[test_run_id example_id]` silently drops every repeat
+      # but the first, taking each dropped row's outcome and duration with
+      # it. `@rows` is complete here — every `record` has returned, and
+      # parallel mode records from its worker threads through this one shared
+      # reporter — so the collision is detectable exactly once, at delivery.
+      # Every member of a colliding group is re-identified as
+      # `"#{file}:#{line}##{method_name}"`: a method name is unique per
+      # class and deterministic, so the suffixed ids are stable across runs.
+      # ALL members take the suffix, never just later arrivals — parallel
+      # mode's arrival order is fork scheduling, so "the first row keeps the
+      # bare id" would make identity depend on it. Rows whose id no other
+      # row claims — every plain `def test_` suite among them — keep the id
+      # they always had, byte for byte.
+      def uniquify_ids!
+        counts = Hash.new(0)
+        @rows.each { |row| counts[row["id"]] += 1 }
+        @rows.each do |row|
+          name = row.delete(RESULT_NAME_KEY)
+          next unless counts[row["id"]] > 1 && !name.to_s.empty?
+
+          row["id"] = "#{row["id"]}##{name}"
+        end
+      end
+
       # The envelope, in the platform's own field names (`Ingest::Payload`:
       # commit_sha / branch / ci_run_id / duration_seconds / specs) — the same
       # rule the RSpec formatter states at its `#payload`: this gem's settings
@@ -201,9 +243,14 @@ module SpecGuard
         intent = annotation_for(file, line_number)
         {
           # Minitest has no RSpec-style rerun path or nested ids, so the
-          # definition site is the identity: stable across runs (which is
-          # what the platform's per-test identity needs) and unique per
-          # definition (which is what a row needs).
+          # definition site is the row's id — the run-local primary key for
+          # this one delivered payload, never a cross-run stable identity
+          # (cross-run matching remains name + file, the platform's own
+          # rule). A definition site is NOT unique per result:
+          # `define_method`-generated tests stamp every instance with the
+          # same location, so rows can collide on this id within a run, and
+          # `uniquify_ids!` is what re-identifies those rows at delivery
+          # time. Nothing here promises uniqueness it does not have.
           "id" => "#{file}:#{line}",
           "spec_file_path" => file,
           "file_path" => file,

data/lib/specguard/version.rb

@@ -7,5 +7,5 @@
 # framework-scoped version constant a lie, so the number moved here and the
 # rspec module now points at it for back-compat.
 module SpecGuard
-  VERSION = "0.3.5"
+  VERSION = "0.3.6"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: specguard-ruby
 version: !ruby/object:Gem::Version
-  version: 0.3.5
+  version: 0.3.6
 platform: ruby
 authors:
 - specguard Agent
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-09-06 00:00:00.000000000 Z
+date: 2026-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json