specbandit 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 71f7dd0be00bb60fb8a8c09864f1f3a2545edea4e31efe8436065ef621bd0bac
-  data.tar.gz: ec658ea6137ada721f37e2a1d31acffc1eba290045e58c83ab3e6dc80afe251d
+  metadata.gz: dd0cef232a7dfa2dd4109d150bd63dbdaac27f65c87e9a9c4a8c495678fdc8f0
+  data.tar.gz: c0a7505268abdc305f6d095fd75788ee5180c4e911972af8f95397bb57241358
 SHA512:
-  metadata.gz: 0a9425785bbfb9a5fcad00c7cbd8c19c9050dbbd141d69c76e258fc0318105910378ef0bce4080a7af5963c8a3653ff6415666c6d920b56067acbd4f09ed4425
-  data.tar.gz: 685376873d376c2f7763859b9c5c4d55dd2194684668386bf2cb6b0749baa1f59d9e0c00224b686ba8721c5e71afb1fd2814c86cad297f90f3a711c7c1dd0207
+  metadata.gz: 93c598ec5a9e0a542c0f86159ba3a70f7d7712b4c7f1c0bdf264cd9316363b483470986af3f6b619d326a52ce6d14cbd4c3ffff91e681d8c7eb7ddb8f1a2e150
+  data.tar.gz: 7974be5fd63f662d6db8a3b99cf00aeb7a0f75b0742c74a585c8cb7388686673507e2b23e0eb836cf1ec5c6b698585ef5eba0ec106b9436f6927409cbc59c85e

data/lib/specbandit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Specbandit
-  VERSION = '0.4.0'
+  VERSION = '0.5.0'
 end

data/lib/specbandit/worker.rb

@@ -116,10 +116,7 @@ module Specbandit
     end
 
     def run_rspec_batch(files)
-      # Clear example state from previous batches so RSpec can run cleanly
-      # in the same process. This preserves configuration but resets
-      # the world (example groups, examples, shared groups, etc.).
-      RSpec.clear_examples
+      reset_rspec_state
 
       args = files + rspec_opts
       err = StringIO.new
@@ -134,5 +131,33 @@ module Specbandit
       rspec_err = err&.string
       output.print(rspec_err) unless rspec_err.nil? || rspec_err.empty?
     end
+
+    # Reset RSpec state between batches so each batch runs cleanly.
+    #
+    # RSpec.clear_examples resets example groups, the reporter, filters, and
+    # the start-time clock -- but it leaves three critical pieces of state
+    # that cause cascading failures when running multiple batches in the
+    # same process:
+    #
+    # 1. output_stream -- After batch #1, Runner#configure sets
+    #    output_stream to a StringIO. On batch #2+, the guard
+    #    `if output_stream == $stdout` is permanently false, so the new
+    #    `out` is never used. All RSpec output silently goes to the stale
+    #    batch-1 StringIO.
+    #
+    # 2. wants_to_quit -- If any batch triggers a load error or fail-fast,
+    #    this flag is set to true. On subsequent batches, Runner#setup
+    #    returns immediately and Runner#run does exit_early -- specs are
+    #    never loaded or run.
+    #
+    # 3. non_example_failure -- Once set, exit_code() unconditionally
+    #    returns the failure exit code, even if all examples passed.
+    #
+    def reset_rspec_state
+      RSpec.clear_examples
+      RSpec.world.wants_to_quit = false
+      RSpec.world.non_example_failure = false
+      RSpec.configuration.output_stream = $stdout
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: specbandit
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Ferran Basora