specbandit 0.13.0 → 0.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 95622117125136b9368557368697eb0b9663983289dc7a5c53692a230ac4d7ef
-  data.tar.gz: 5d74e976511d86b4c8da066cc782fc358af1c69e89ae02edcc3935b077ad473e
+  metadata.gz: 14a1d9a07eb3ab1b19c59c9e054aec4fb32e5da1ac3f33841feb1fb068085648
+  data.tar.gz: 756a15f2a9c7f9cce3db7fa06e499235fd18ec332a51d6db1900ee1a9a2d1fb8
 SHA512:
-  metadata.gz: 19a2cff1aab50ad0412e515a2081b85dcd8f94addf96232bfb2be3694b02980410df1a8788d3451907a985b26fc6cfecb1dd7d45750ba108b63f84975ea36996
-  data.tar.gz: 9af9ad631d684be5485a43620b76dcda02e7e223e50b6ecab47def52ee24fa4ab296dff43e5eea11c03acaea5146178da9cced4740ebb1036b41edef38ba0852
+  metadata.gz: 6bc49db9d7bd80540b17d19b15fb759a2ab0c1c867026f3234610074323237cf4cd5ee8d7e590c472b324dbc152b0db83d35fa05bbf443175efad1f5fc658c1c
+  data.tar.gz: '09cdd5433154bc6a35d13006beccdcba288d8538fc79585e79b8939edf1a0c2e1149d98d21cbdc8ee4eb7f756640d00575b4ebb3791217f5359c511a8ddea6a0'

data/README.md

@@ -318,6 +318,8 @@ Specbandit detects the mode automatically based on the state of `--key-rerun`:
 | Yes | Empty | Yes | **Fail** | Exit 1 with error. Prevents silent false pass on stale re-runs. |
 | No | -- | Yes | **Error** | Validation error: `--rerun` requires `--key-rerun`. |
 
+> **Empty key names count as "not provided".** A `--key-rerun` whose value is an empty string -- e.g. `--key-rerun "$VAR"` where `$VAR` is unset in CI -- is treated exactly like `--key-rerun` being absent (the **No** rows above), not as a configured-but-empty key. Combined with `--rerun`, that means an empty/unset name fails hard (exit 1) rather than silently steal-and-pass. The same applies to `--key-failed`: an empty/unset name is treated as "not configured" and no failed files are recorded.
+
 #### The `--rerun` safety flag
 
 Without `--rerun`, specbandit cannot distinguish a first run from a re-run when the rerun key is empty (e.g., TTL expired or Redis was flushed). In that case it silently falls back to Record mode, which may find an empty shared queue and exit 0 with zero tests -- a **silent false pass**.

data/lib/specbandit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Specbandit
-  VERSION = '0.13.0'
+  VERSION = '0.13.1'
 end

data/lib/specbandit/worker.rb

@@ -57,21 +57,7 @@ module Specbandit
       @run_start_time = Process.clock_gettime(Process::CLOCK_MONOTONIC)
       adapter.setup
 
-      exit_code = if key_rerun
-                    rerun_files = queue.read_all(key_rerun)
-                    if rerun_files.any?
-                      run_replay(rerun_files)
-                    elsif rerun
-                      output.puts "[specbandit] ERROR: --rerun flag is set but rerun key '#{key_rerun}' is empty."
-                      output.puts '[specbandit] The rerun key may have expired (TTL) or Redis was flushed.'
-                      output.puts '[specbandit] Cannot replay — failing to prevent silent false pass.'
-                      1
-                    else
-                      run_steal(record: true)
-                    end
-                  else
-                    run_steal(record: false)
-                  end
+      exit_code = determine_exit_code
 
       print_summary if @batch_results.any?
       merge_json_results
@@ -83,6 +69,43 @@ module Specbandit
 
     private
 
+    # Decide the operating mode and execute it, returning the exit code.
+    # - no usable rerun key → steal mode (or crash if --rerun was requested)
+    # - rerun key has data  → replay mode
+    # - rerun key but empty → record mode (or crash if --rerun was requested)
+    def determine_exit_code
+      unless key_present?(key_rerun)
+        return fail_stale_rerun if rerun
+
+        return run_steal(record: false)
+      end
+
+      rerun_files = queue.read_all(key_rerun)
+      return run_replay(rerun_files) if rerun_files.any?
+      return fail_stale_rerun if rerun
+
+      run_steal(record: true)
+    end
+
+    # A Redis key name is usable only when it is a non-nil, non-empty string.
+    # Guards the Ruby gotcha where "" is truthy (e.g. --key-rerun "$UNSET_VAR"),
+    # which would otherwise read/write against an empty key name.
+    def key_present?(value)
+      !value.nil? && !value.empty?
+    end
+
+    # Emit the stale/missing-rerun error and return exit code 1.
+    def fail_stale_rerun
+      if key_present?(key_rerun)
+        output.puts "[specbandit] ERROR: --rerun flag is set but rerun key '#{key_rerun}' is empty."
+      else
+        output.puts '[specbandit] ERROR: --rerun flag is set but no rerun key is configured.'
+      end
+      output.puts '[specbandit] The rerun key may have expired (TTL) or Redis was flushed.'
+      output.puts '[specbandit] Cannot replay — failing to prevent silent false pass.'
+      1
+    end
+
     # Replay mode: run a known list of files in local batches.
     # Used when re-running a failed CI job -- the rerun key already
     # contains the exact files this runner executed previously.
@@ -171,7 +194,7 @@ module Specbandit
     # paths are recorded (not the entire batch). For CLI adapter batches
     # (no per-file granularity), the whole batch is recorded as fallback.
     def record_failed_files(files, result)
-      return unless key_failed
+      return unless key_present?(key_failed)
       return if result.exit_code.zero?
 
       failed_files = extract_failed_files(result) || files

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: specbandit
 version: !ruby/object:Gem::Version
-  version: 0.13.0
+  version: 0.13.1
 platform: ruby
 authors:
 - Ferran Basora
@@ -109,7 +109,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.6
+rubygems_version: 4.0.10
 specification_version: 4
 summary: Distributed test runner using Redis as a work queue
 test_files: []