spec_views 0.1.1 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d044e56e8a631ad9236607bac60068c0f16cf2dedb4b50d0e620cdb791f41d47
-  data.tar.gz: e105a711a300354b0aa8e5fdb994a54b749e29133da40e07b7f6cc1546565d52
+  metadata.gz: 0c7f8a52383504378eddee951cba9a8fc6a47f255da78ed1a130eee0fa814ada
+  data.tar.gz: c8fabfb166786ccb35a9ecb3b195851b04c73bea7b6fe3a0a823a3e72b963469
 SHA512:
-  metadata.gz: 8c0f148c34253684f1a4ab2a4e4f879ffd89dc3a06fc1a050d3efd2b8462fd245da8060adc181dfa18d31ae6f7239d7a54a9615424fad570a6b2fb1b761ad271
-  data.tar.gz: aa83215d00e20dec8871b1a718dd2e5061c1c8675ef9a741ebad8108fa34d9ba24e0c5e598f4c62e37e19e54ebd72dab68d0353e7025241843f263c1fae49f51
+  metadata.gz: 838f2fc2cb3002b3e8b3d8274ba1f1e14ea0d3fcea5d54a6ff6bdf8e9919ab37f1c3f3b8a90594ff1911bb588230d513d78a444b838452f9115120eaf71d8dc8
+  data.tar.gz: f3fb138e0899c4a448fe2b8c3121420b6b86162a6ef3f4b5b9a81fed764e6ca3aad89c311f66381aff4d4b4a5024f87fa5c01010fb92e8621007f80fc2cb1c37

data/README.md

@@ -1,18 +1,5 @@
 # SpecViews
-Render views from controller specs for comparision
-
-## Usage
-Replace selected RSpec `it` methods with `render`:
-
-```ruby
-RSpec.describe HomeController, type: :controller do
-  describe 'GET #show' do
-    render 'homepage' do
-      get :show
-    end
-  end
-end
-```
+Render views from controller specs for comparision.
 
 ## Installation
 Add this line to your application's Gemfile:
@@ -21,15 +8,36 @@ Add this line to your application's Gemfile:
 gem 'spec_views'
 ```
 
+And this to RSpec's rails_helper.rb:
+```ruby
+require 'spec_views/support'
+```
+
 And then execute:
 ```bash
 $ bundle
 ```
 
-Or install it yourself as:
+Ignore some generated files in your .gitignore:
 ```bash
-$ gem install spec_views
+/spec/fixtures/views/*/challenger.*
+/spec/fixtures/views/*/last_run.txt
 ```
 
+## Usage
+Replace selected RSpec `it` methods with `render`:
+
+```ruby
+RSpec.describe HomeController, type: :controller do
+  describe 'GET #show' do
+    render 'homepage' do
+      get :show
+    end
+  end
+end
+```
+
+Run this spec to see it failing. Open SpecView UI [http://localhost:3000/spec_views](http://localhost:3000/spec_views) on Rails development server to accept the new view. When rerunning the spec it compares its rendering with the reference view. Use SpecView UI to review, accept or reject changed views.
+
 ## License
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/app/controllers/spec_views/views_controller.rb

@@ -96,15 +96,15 @@ module SpecViews
       end
 
       def controller_name
-        splitted_name.first.gsub(/Controller(_.*)$/, 'Controller').gsub('_', '::')
+        splitted_name.first.gsub(/Controller(_.*)$/, 'Controller').gsub(/Controller$/, '').gsub('_', '::')
       end
 
       def method
-        splitted_name.second
+        splitted_name.second[0, 3]
       end
 
       def description
-        splitted_name.third.humanize
+        splitted_name.third.gsub(/__pdf$/, '').humanize
       end
 
       def last_run

data/app/views/layouts/spec_views.html.haml

@@ -141,6 +141,7 @@
         margin: 5rem auto 0
         list-style-type: none
         padding: 0
+        padding-bottom: 2rem
 
         > div
           margin-top: 1rem
@@ -149,6 +150,7 @@
           display: flex
           flex: 1 0 auto
           align-items: stretch
+          line-height: 1.5
 
           &:hover, &:focus
             background-color: $dark-bg-light

data/app/views/spec_views/views/index.html.haml

@@ -1,23 +1,24 @@
 .iframes
-  .directories.w-100
-    - @directories.each do |dir|
-      - body = capture do
-        %div
-          %div= dir.controller_name
-          %div= dir.method
-          %div= dir.description
-      - if dir.challenger?
-        = link_to({ action: :compare, id: dir }, class: 'challenger') do
-          %div CHALLENGER
-          = body
-      - elsif dir.last_run < @latest_run
-        = link_to({ action: :preview, id: dir }, class: 'outdated') do
-          %div OUTDATED
-          = body
-      - else
-        = link_to(action: :preview, id: dir) do
+  %div.w-100
+    .directories
+      - @directories.each do |dir|
+        - body = capture do
           %div
-          = body
+            %div= dir.controller_name
+            %div= dir.method
+            %div= dir.description
+        - if dir.challenger?
+          = link_to({ action: :compare, id: dir }, class: 'challenger') do
+            %div CHALLENGER
+            = body
+        - elsif dir.last_run < @latest_run
+          = link_to({ action: :preview, id: dir }, class: 'outdated') do
+            %div OUTDATED
+            = body
+        - else
+          = link_to(action: :preview, id: dir) do
+            %div
+            = body
 
 .footer
   .info

data/lib/spec_views/engine.rb

@@ -3,15 +3,5 @@ require 'spec_views/configuration'
 module SpecViews
   class Engine < ::Rails::Engine
     config.spec_views = Configuration.default
-
-    initializer 'configure.rspec' do |app|
-      if Rails.env.test? && Object.const_defined?('RSpec')
-        require 'spec_views/support'
-        
-        RSpec.configure do |config|
-          config.include Support
-        end
-      end
-    end
   end
 end

data/lib/spec_views/support.rb

@@ -104,7 +104,7 @@ module SpecViews
       end
 
       def sanitized_body
-        return body if pdf?
+        return remove_headers_from_pdf(body) if pdf?
 
         remove_pack_digests_from_body(
           remove_digests_from_body(body),
@@ -112,13 +112,21 @@ module SpecViews
       end
 
       def remove_digests_from_body(body)
-        body.gsub(/(-[a-z0-9]{64})(\.css|\.js|\.png|\.jpg|\.jpeg|\.svg|\.gif)/, '\2')
+        body.gsub(/(-[a-z0-9]{64})(\.css|\.js|\.ico|\.png|\.jpg|\.jpeg|\.svg|\.gif)/, '\2')
       end
 
       def remove_pack_digests_from_body(body)
         body.gsub(%r{(packs.*/js/[a-z0-9_]+)(-[a-z0-9]{20})(\.js)}, '\1\3')
       end
 
+      def remove_headers_from_pdf(pdf)
+        pdf
+          .force_encoding("BINARY")
+          .gsub(/^\/CreationDate \(.*\)$/, '')
+          .gsub(/^\/ModDate \(.*\)$/, '')
+          .gsub(/^\/ID \[<.+><.+>\]$/, '')
+      end
+
       def put_write_instructions
         puts
         puts "\e[33mWarning:\e[0m Writing view fixture to #{champion_path.to_s.gsub(Rails.root.to_s, '')}"
@@ -179,4 +187,8 @@ module SpecViews
       end
     end
   end
-end
+end
+
+RSpec.configure do |rspec|
+  rspec.include SpecViews::Support, type: :controller
+end

data/lib/spec_views/version.rb

@@ -1,3 +1,3 @@
 module SpecViews
-  VERSION = '0.1.1'
+  VERSION = '1.1.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spec_views
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 1.1.1
 platform: ruby
 authors:
 - Sebastian Gaul
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-01-14 00:00:00.000000000 Z
+date: 2022-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: timecop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.0'
 description: Render views from controller specs for comparision
 email:
 - sebastian.gaul@lichtbit.com