speaky_csv 0.0.3 → 0.0.5

data/spec/base_spec.rb

@@ -13,14 +13,18 @@ describe SpeakyCsv::Base do
             d.has_many :reviews do |r|
               r.field :tomatoes
             end
+            d.has_one :publisher do |p|
+              p.field :id
+            end
           end
         end
       end
 
       it 'inherits it for child' do
-        expect(child_klass.csv_field_builder.fields).to eq [:name]
-        expect(child_klass.csv_field_builder.has_manys.keys).to eq [:reviews]
-        expect(child_klass.csv_field_builder.has_manys[:reviews].fields).to eq [:tomatoes]
+        expect(child_klass.speaky_csv_config.fields).to eq [:name]
+        expect(child_klass.speaky_csv_config.has_manys.keys).to eq [:reviews]
+        expect(child_klass.speaky_csv_config.has_manys[:reviews].fields).to eq [:tomatoes]
+        expect(child_klass.speaky_csv_config.has_ones[:publisher].fields).to eq [:id]
       end
 
       context 'and child adds to it' do
@@ -34,23 +38,42 @@ describe SpeakyCsv::Base do
               d.has_many :reviews do |r|
                 r.field :publication
               end
+              d.has_one :publisher do |p|
+                p.field :name
+              end
             end
           end
         end
 
         it 'adds it to child' do
-          expect(child_klass.csv_field_builder.fields).to eq [:name, :author]
-          expect(child_klass.csv_field_builder.has_manys.keys.sort).to eq [:reviews, :sales].sort
-          expect(child_klass.csv_field_builder.has_manys[:reviews].fields).to eq [:tomatoes, :publication]
-          expect(child_klass.csv_field_builder.has_manys[:sales].fields).to eq [:period]
+          expect(child_klass.speaky_csv_config.fields).to eq [:name, :author]
+          expect(child_klass.speaky_csv_config.has_manys.keys.sort).to eq [:reviews, :sales].sort
+          expect(child_klass.speaky_csv_config.has_manys[:reviews].fields).to eq [:tomatoes, :publication]
+          expect(child_klass.speaky_csv_config.has_manys[:sales].fields).to eq [:period]
+          expect(child_klass.speaky_csv_config.has_ones[:publisher].fields).to eq [:id, :name]
         end
 
         it 'doesnt change parents config' do
-          expect(parent_klass.csv_field_builder.fields).to_not include :author
-          expect(parent_klass.csv_field_builder.has_manys.keys).to_not include :sales
-          expect(parent_klass.csv_field_builder.has_manys[:reviews].fields).to_not include :publication
+          expect(parent_klass.speaky_csv_config.fields).to_not include :author
+          expect(parent_klass.speaky_csv_config.has_manys.keys).to_not include :sales
+          expect(parent_klass.speaky_csv_config.has_manys[:reviews].fields).to_not include :publication
+          expect(parent_klass.speaky_csv_config.has_ones[:publisher].fields).to_not include :name
         end
       end
     end
+
+    it 'raises if association nesting is attempted' do
+      expect do
+        parent_klass.class_eval do
+          define_csv_fields do |d|
+            d.has_one :foo do |f|
+              f.has_many :bars do |b|
+                b.field 'name'
+              end
+            end
+          end
+        end
+      end.to raise_error(NotImplementedError)
+    end
   end
 end

data/spec/export_spec.rb

@@ -36,6 +36,36 @@ True story,Honest Abe
     end
   end
 
+  context 'with _destroy field' do
+    before do
+      presenter_klass.class_eval do
+        define_csv_fields do |d|
+          d.field 'id', 'name', '_destroy'
+        end
+      end
+    end
+
+    let(:records) do
+      [
+        double('book1', id: 4, name: 'Big Fiction', author: 'Sneed'),
+        double('book2', id: 8, name: 'True story', author: 'Honest Abe')
+      ]
+    end
+
+    it 'should write to io' do
+      expect(output).to eq <<-CSV
+id,name,_destroy
+4,Big Fiction,
+8,True story,
+      CSV
+    end
+
+    it 'doesnt log that _destroy is an unknown field' do
+      subject.to_a
+      expect(subject.log).to_not match(/_destroy is not a method/)
+    end
+  end
+
   context 'with export_only fields' do
     before do
       presenter_klass.class_eval do
@@ -171,4 +201,118 @@ id
       expect(subject.log).to match(/unknowns is not a method/)
     end
   end
+
+  context 'with has_one fields' do
+    before do
+      presenter_klass.class_eval do
+        define_csv_fields do |d|
+          d.field 'name', 'author'
+          d.has_one 'publisher' do |r|
+            r.field :id, :name
+          end
+        end
+      end
+    end
+
+    let(:records) do
+      [
+        double('book1',
+               name: 'Big Fiction',
+               author: 'Sneed',
+               publisher: double(id: 99, name: 'Post')),
+        double('book2',
+               name: 'True story',
+               author: 'Honest Abe',
+               publisher: double(id: 50, name: 'Daily'))
+      ]
+    end
+    it 'should return csv' do
+      expect(output).to eq <<-CSV
+name,author,publisher_id,publisher_name
+Big Fiction,Sneed,99,Post
+True story,Honest Abe,50,Daily
+      CSV
+    end
+  end
+
+  context 'with export_only has_one field' do
+    before do
+      presenter_klass.class_eval do
+        define_csv_fields do |d|
+          d.field 'id'
+          d.has_one 'publisher' do |r|
+            r.field :id
+            r.field :name, export_only: true
+          end
+        end
+      end
+    end
+
+    let(:records) do
+      [
+        double('book1',
+               id: 22,
+               publisher: double(id: 99, name: 'Post')),
+      ]
+    end
+
+    it 'should write field' do
+      expect(output).to eq <<-CSV
+id,publisher_id,publisher_name
+22,99,Post
+      CSV
+    end
+  end
+
+  context 'with unknown has_many field' do
+    before do
+      presenter_klass.class_eval do
+        define_csv_fields do |d|
+          d.field 'id'
+          d.has_one 'publisher' do |r|
+            r.field :unknown
+          end
+        end
+      end
+    end
+
+    let(:records) do
+      [
+        double('book1',
+               id: 22,
+               publisher: double(id: 99, name: 'Post')),
+      ]
+    end
+
+    it 'adds an error' do
+      subject.to_a
+      expect(subject.log).to match(/publisher_unknown is not a method/)
+    end
+  end
+
+  context 'with unknown has_many association' do
+    before do
+      presenter_klass.class_eval do
+        define_csv_fields do |d|
+          d.field 'id'
+          d.has_one 'unknown' do |r|
+            r.field :name
+          end
+        end
+      end
+    end
+
+    let(:records) do
+      [
+        double('book1',
+               id: 22,
+               publisher: double(id: 99, name: 'Post')),
+      ]
+    end
+
+    it 'adds an error' do
+      subject.to_a
+      expect(subject.log).to match(/unknown is not a method/)
+    end
+  end
 end

data/spec/readme_spec.rb

@@ -0,0 +1,95 @@
+require 'spec_helper'
+require 'support/active_record'
+
+describe "Examples in README.md", :db do
+  it "has working examples" do
+    # For example ...
+
+    # in app/models/book.rb
+    class Book < ActiveRecord::Base
+      # ...
+    end
+
+    # in app/csvs/book_csv.rb
+    class BookCsv < SpeakyCsv::Base
+      define_csv_fields do |config|
+        config.field :id, :author
+      end
+    end
+
+    # Importing - create
+
+    csv_io = StringIO.new <<-CSV
+id,author
+,Sneed
+    CSV
+
+    importer = BookCsv.active_record_importer csv_io, Book
+    importer.each { |book| book.save }
+
+    expect(Book.last.author).to eq 'Sneed'
+
+    # Importing - update
+
+    csv_io = StringIO.new <<-CSV
+id,author
+1,Simon Sneed
+    CSV
+
+    importer = BookCsv.active_record_importer csv_io, Book
+    importer.each { |book| book.save }
+    expect(Book.last.author).to eq 'Simon Sneed'
+
+    # Importing - record not found
+
+    csv_io = StringIO.new <<-CSV
+id,author
+234,I dont exist
+    CSV
+
+    importer = BookCsv.active_record_importer csv_io, Book
+    expect(importer.to_a).to eq [nil]
+    expect(importer.log).to include '[row 1] record not found with primary key: "234"'
+
+    # Importing - destroy
+
+    # in app/csvs/book_csv.rb
+    class BookCsv < SpeakyCsv::Base
+      define_csv_fields do |config|
+        config.field :id, :author, :_destroy
+      end
+    end
+
+    csv_io = StringIO.new <<-CSV
+id,_destroy
+1,true
+    CSV
+
+    importer = BookCsv.active_record_importer csv_io, Book
+    book = importer.to_a.first
+    expect(book).to be_marked_for_destruction
+    if book.marked_for_destruction?
+      book.destroy
+    end
+
+    # Exporting
+
+    books = [
+      Book.create!(author: 'Stevenson'),
+      Book.create!(author: 'Melville'),
+      Book.create!(author: 'Macaulay'),
+    ]
+    exporter = BookCsv.exporter books
+
+    io = StringIO.new
+    exporter.each { |row| io.write row }
+    io.rewind
+    expect(io.read).to eq <<-OUTPUT
+id,author,_destroy
+2,Stevenson,false
+3,Melville,false
+4,Macaulay,false
+    OUTPUT
+  end
+end
+

data/spec/support/active_record.rb

@@ -30,6 +30,7 @@ class Book < ActiveRecord::Base
   has_many :reviews, inverse_of: :book
   belongs_to :publisher, inverse_of: :books
   accepts_nested_attributes_for :reviews, allow_destroy: true
+  accepts_nested_attributes_for :publisher, allow_destroy: true
 end
 
 class Review < ActiveRecord::Base

metadata

@@ -1,209 +1,209 @@
 --- !ruby/object:Gem::Specification
 name: speaky_csv
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.5
 platform: ruby
 authors:
 - Andy Hartford
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-04 00:00:00.000000000 Z
+date: 2016-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.2'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.2'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.10'
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.5'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3'
 - !ruby/object:Gem::Dependency
   name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.35'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.35'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.6'
 - !ruby/object:Gem::Dependency
   name: rb-fsevent
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.9'
 - !ruby/object:Gem::Dependency
   name: rb-inotify
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.9'
 - !ruby/object:Gem::Dependency
   name: ruby_gntp
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.3'
 description: CSV importing and exporting for ActiveRecord and ActiveModel with a Enumerator
@@ -216,9 +216,9 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rubocop.yml"
-- ".travis.yml"
+- .gitignore
+- .rubocop.yml
+- .travis.yml
 - Gemfile
 - Guardfile
 - LICENSE.txt
@@ -230,6 +230,8 @@ files:
 - lib/speaky_csv/active_record_import.rb
 - lib/speaky_csv/attr_import.rb
 - lib/speaky_csv/base.rb
+- lib/speaky_csv/config.rb
+- lib/speaky_csv/config_builder.rb
 - lib/speaky_csv/export.rb
 - lib/speaky_csv/version.rb
 - log/.gitkeep
@@ -238,6 +240,7 @@ files:
 - spec/attr_import_spec.rb
 - spec/base_spec.rb
 - spec/export_spec.rb
+- spec/readme_spec.rb
 - spec/spec_helper.rb
 - spec/support/active_record.rb
 homepage: https://github.com/ajh/speaky_csv
@@ -250,17 +253,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.0.14.1
 signing_key: 
 specification_version: 4
 summary: CSV importing and exporting for ActiveRecord and ActiveModel
@@ -269,5 +272,6 @@ test_files:
 - spec/attr_import_spec.rb
 - spec/base_spec.rb
 - spec/export_spec.rb
+- spec/readme_spec.rb
 - spec/spec_helper.rb
 - spec/support/active_record.rb