sparkql 1.3.3 → 1.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1fb6060ec97e59958c12e0ed3338540afa180bf28eab0224af3ffef568dbf469
-  data.tar.gz: 982d3956830686faeb210e6abf52125d18d4d68fa0d231b00a251a4876e1bd14
+  metadata.gz: 995514ae40305cedb2116dafc6c98b8efb534ae3d2f31c9d48e86421e3f5c10c
+  data.tar.gz: 6162d29fb4520941edb2b53742d966fdf373418b2745f6fd1d8c1fa79432b896
 SHA512:
-  metadata.gz: 6754d10ca449bbd3467127a8470bb4233dd00b5162984ca636bcd93aff41743b25ace78fdd30ba77cbb6a79bef55d36118f67f2102b676ca9184db04c2437c01
-  data.tar.gz: d337d7169ceb202c6f4d8a066196c472404cccf5e1b6f0fc13bf07a4fba62fa6d135c04bfc017544c73fb84ca1834f5d06c78bbf5ee2848ac16b06372b09b711
+  metadata.gz: c39c06894d6a7b298d4fafb3c578e6d203543c77c68ad0cf8acb9ec943c00c656e38529a7e6b2afe4cc3177b5a59b078c7ce4c193a08dea0f575bd62ee0495d7
+  data.tar.gz: fbbba23b099146c85f3c15fb82ea3bbc93fe989b156752a80137a2212b2ed64f4cf50ecb99bf06b59914f1e1f8996a65155c9cde11c025702e6b8504b083cc93

data/CHANGELOG.md

@@ -1,3 +1,5 @@
+v1.3.4, 20265-01-20
+  * [BUGFIX] Validate limit for days and weekdays
 
 v1.3.3, 2025-08-12
 -------------------

data/VERSION

@@ -1 +1 @@
-1.3.3
+1.3.4

data/lib/sparkql/function_resolver.rb

@@ -21,6 +21,7 @@ module Sparkql
     VALID_REGEX_FLAGS = ['', 'i'].freeze
     MIN_DATE_TIME = Time.new(1970, 1, 1, 0, 0, 0, '+00:00').iso8601
     MAX_DATE_TIME = Time.new(9999, 12, 31, 23, 59, 59, '+00:00').iso8601
+    MAX_DAYS = (365 * 1000).freeze # 1000 years ought to cover most cases
     VALID_CAST_TYPES = %i[field character decimal integer].freeze
 
     SUPPORTED_FUNCTIONS = {
@@ -43,16 +44,16 @@ module Sparkql
       regex: {
         args: [:character],
         opt_args: [{
-          type: :character,
-          default: ''
-        }],
+                     type: :character,
+                     default: ''
+                   }],
         return_type: :character
       },
       substring: {
         args: [%i[field character], :integer],
         opt_args: [{
-          type: :integer
-        }],
+                     type: :integer
+                   }],
         resolve_for_type: true,
         return_type: :character
       },
@@ -526,6 +527,15 @@ module Sparkql
 
     # Offset the current timestamp by a number of days
     def days(number_of_days)
+      if number_of_days.abs > MAX_DAYS
+        @errors << Sparkql::ParserError.new(token: number_of_days,
+                                            message: "Function call 'days' max offset #{MAX_DAYS} days",
+                                            status: :fatal,
+                                            syntax: false,
+                                            constraint: true)
+        return
+      end
+
       # date calculated as the offset from midnight tommorrow. Zero will provide values for all times
       # today.
       d = current_date + number_of_days
@@ -536,6 +546,15 @@ module Sparkql
     end
 
     def weekdays(number_of_days)
+      if number_of_days.abs > MAX_DAYS
+        @errors << Sparkql::ParserError.new(token: number_of_days,
+                                            message: "Function call 'weekdays' max offset #{MAX_DAYS} days",
+                                            status: :fatal,
+                                            syntax: false,
+                                            constraint: true)
+        return
+      end
+
       today = current_date
       weekend_start = today.saturday? || today.sunday?
       direction = number_of_days.positive? ? 1 : -1

data/test/unit/function_resolver_test.rb

@@ -445,6 +445,24 @@ class FunctionResolverTest < Test::Unit::TestCase
     end
   end
 
+  test 'days - exceed max' do
+    f = FunctionResolver.new('days',
+                             [{ type: :integer, value: 365_001 }],
+                             current_timestamp: EXAMPLE_DATE)
+    f.validate
+    assert !f.errors?
+    assert_nil f.call
+    assert f.errors?, "function 'days' limit 365000"
+
+    f = FunctionResolver.new('days',
+                             [{ type: :integer, value: -365_001 }],
+                             current_timestamp: EXAMPLE_DATE)
+    f.validate
+    assert !f.errors?
+    assert_nil f.call
+    assert f.errors?, "function 'days' limit 365000"
+  end
+
   test 'weekdays()' do
     friday = Date.new(2012, 10, 19)
     saturday = Date.new(2012, 10, 20)
@@ -514,6 +532,24 @@ class FunctionResolverTest < Test::Unit::TestCase
     end
   end
 
+  test 'weekdays - exceed max' do
+    f = FunctionResolver.new('weekdays',
+                             [{ type: :integer, value: 365_001 }],
+                             current_timestamp: EXAMPLE_DATE)
+    f.validate
+    assert !f.errors?
+    assert_nil f.call
+    assert f.errors?, "function 'weekdays' limit 365000"
+
+    f = FunctionResolver.new('weekdays',
+                             [{ type: :integer, value: -365_001 }],
+                             current_timestamp: EXAMPLE_DATE)
+    f.validate
+    assert !f.errors?
+    assert_nil f.call
+    assert f.errors?, "function 'weekdays' limit 365000"
+  end
+
   test 'months()' do
     f = FunctionResolver.new('months',
                              [{ type: :integer, value: 3 }],

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sparkql
 version: !ruby/object:Gem::Version
-  version: 1.3.3
+  version: 1.3.4
 platform: ruby
 authors:
 - Wade McEwen
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-08-19 00:00:00.000000000 Z
+date: 2026-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: georuby