sparkql 1.3.1 → 1.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0f8f460c07a1a833cd0a80040f686b12a9579db3bc0ae60d1cc7aa1c73fe644d
-  data.tar.gz: 66a6701ad74dc5454d9e4dd2a14c0ea133715e10ba5babb676c90aed62e917bd
+  metadata.gz: 1fb6060ec97e59958c12e0ed3338540afa180bf28eab0224af3ffef568dbf469
+  data.tar.gz: 982d3956830686faeb210e6abf52125d18d4d68fa0d231b00a251a4876e1bd14
 SHA512:
-  metadata.gz: 661e847ae1aa0f336706d94129c0afdc7d0ba040c0c8f62b7a6e9248dcc990d8f0179ef153355e050bae2b8a2f676c7e358081280418986c6c0bbf27393ac572
-  data.tar.gz: 4b64da6af2453236ec0b9c0e240238241609c79e0d4b8cca2c126ecc9b5e3b7e9c585836cc0dceb9a5136cb9decb993bffdef0145720de8dd734b2b2f291f340
+  metadata.gz: 6754d10ca449bbd3467127a8470bb4233dd00b5162984ca636bcd93aff41743b25ace78fdd30ba77cbb6a79bef55d36118f67f2102b676ca9184db04c2437c01
+  data.tar.gz: d337d7169ceb202c6f4d8a066196c472404cccf5e1b6f0fc13bf07a4fba62fa6d135c04bfc017544c73fb84ca1834f5d06c78bbf5ee2848ac16b06372b09b711

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+
+v1.3.3, 2025-08-12
+-------------------
+  * [BUGFIX] Evaluator fix for Not regression
+
+v1.3.2, 2025-08-06
+-------------------
+  * [BUGFIX] More Evaluator fixes
+  * [BUGFIX] fixed the build.
+
 v1.3.1, 2025-08-06
 -------------------
   * [BUGFIX] Evaluator fix for Not expressions

data/VERSION

@@ -1 +1 @@
-1.3.1
+1.3.3

data/lib/sparkql/evaluator.rb

@@ -1,9 +1,12 @@
+
 # Using an instance of ExpressionResolver to resolve the individual expressions,
 # this class will evaluate the rest of a parsed sparkql string to true or false.
 # Namely, this class will handle all the nesting, boolean algebra, and dropped
 # fields. Plus, it has some optimizations built in to skip the processing for
 # any expressions that don't contribute to the net result of the filter.
 class Sparkql::Evaluator
+  include Sparkql::Token
+
   attr_reader :processed_count
 
   def initialize(expression_resolver)
@@ -40,6 +43,11 @@ class Sparkql::Evaluator
       block = expression[:block_group]
       block_group = block_groups[block]
 
+      if expression[:conjunction] == NOT && expression[:conjunction_level] == level
+        expression[:conjunction] = AND
+        expression[:unary] = NOT
+      end
+
       unless block_group
         block_groups[block] ||= block_builder(expression, level)
         block_group = block_groups[block]
@@ -48,9 +56,9 @@ class Sparkql::Evaluator
 
         # When dealing with Not expression conjunctions at the block level,
         # it's far simpler to convert it into the equivalent "And Not"
-        if block_group[:conjunction] == "Not"
-          block_group[:unary] = "Not"
-          block_group[:conjunction] = "And"
+        if block_group[:conjunction] == NOT
+          block_group[:unary] = NOT
+          block_group[:conjunction] = AND
         end
 
         # Every block group _must_ be seen as an expression in another block
@@ -60,20 +68,22 @@ class Sparkql::Evaluator
         # with a level -1 here to turn the top level expressions into a block
         # group for processing.
         current_level = level
+        last_block_group = block_group
         while current_level >= 0
           current_level -= 1
           levels[current_level] ||= []
           last_block_group_id = levels[current_level].last
           if last_block_group_id
-            block_groups[last_block_group_id][:expressions] << block_group
+            block_groups[last_block_group_id][:expressions] << last_block_group
             break
           else
             block_id = "placeholder_for_#{block}_#{current_level}"
-            placeholder_block = block_builder(block_group, current_level)
-            placeholder_block[:expressions] << block_group
+            placeholder_block = block_builder(last_block_group, current_level)
+            placeholder_block[:expressions] << last_block_group
 
             levels[current_level] << block_id
             block_groups[block_id] = placeholder_block
+            last_block_group = placeholder_block
           end
         end
       end
@@ -98,7 +108,7 @@ class Sparkql::Evaluator
         block_group[:expressions].each do |expression|
           # If we encounter any or's in the same block group, we can cheat at
           # resolving the rest, if we are at a true
-          if block_result && expression[:conjunction] == 'Or'
+          if block_result && expression[:conjunction] == OR
             break
           end
 
@@ -112,7 +122,7 @@ class Sparkql::Evaluator
                               end
           next if expression_result == :drop
 
-          if expression[:unary] == "Not"
+          if expression[:unary] == NOT
             expression_result = !expression_result
           end
 
@@ -122,11 +132,11 @@ class Sparkql::Evaluator
           end
 
           case expression[:conjunction]
-          when 'Not'
+          when NOT
             block_result &= !expression_result
-          when 'And'
+          when AND
             block_result &= expression_result
-          when 'Or'
+          when OR
             block_result |= expression_result
           else
             # Not a supported conjunction. We skip over this for backwards
@@ -134,7 +144,7 @@ class Sparkql::Evaluator
           end
         end
 
-        # block_group.delete(:expressions)
+        block_group.delete(:expressions)
         block_group[:result] = block_result
         final_result = block_result
       end

data/lib/sparkql/token.rb

@@ -24,8 +24,15 @@ module Sparkql::Token
   NULL = /NULL|null|Null/.freeze
   # Reserved words
   RANGE_OPERATOR = 'Bt'.freeze
-  EQUALITY_OPERATORS = %w[Eq Ne].freeze
+  EQUAL = 'Eq'.freeze
+  NOT_EQUAL = 'Ne'.freeze
+  EQUALITY_OPERATORS = [EQUAL, NOT_EQUAL].freeze
+
   OPERATORS = %w[Gt Ge Lt Le] + EQUALITY_OPERATORS
-  UNARY_CONJUNCTIONS = ['Not'].freeze
-  CONJUNCTIONS = %w[And Or].freeze
+
+  NOT = 'Not'.freeze
+  AND = 'And'.freeze
+  OR = 'Or'.freeze
+  UNARY_CONJUNCTIONS = [NOT].freeze
+  CONJUNCTIONS = [AND, OR].freeze
 end

data/test/unit/evaluator_test.rb

@@ -64,35 +64,93 @@ class EvaluatorTest < Test::Unit::TestCase
   def test_dropped_field_handling
     assert sample("Test Eq 'Drop' And Test Eq true")
     assert !sample("Test Eq 'Drop' And Test Eq false")
-    assert !sample("Test Eq 'Drop' Or Test Eq false")
+
     assert sample("Test Eq 'Drop' Or Test Eq true")
+    assert !sample("Test Eq 'Drop' Or Test Eq false")
+
     assert sample("Test Eq false And Test Eq 'Drop' Or Test Eq true")
+    assert !sample("Test Eq false And Test Eq 'Drop' Or Test Eq false")
+
     assert sample("Test Eq false Or (Test Eq 'Drop' And Test Eq true)")
+    assert !sample("Test Eq false Or (Test Eq 'Drop' And Test Eq false)")
+
+    assert sample("Test Eq false Or (Not Test Eq 'Drop' And Test Eq true)")
+    assert !sample("Test Eq false Or (Not Test Eq 'Drop' And Test Eq false)")
+
+    assert sample("Test Eq true Not Test Eq 'Drop' And Test Eq true")
+    assert !sample("Test Eq true Not Test Eq 'Drop' And Test Eq false")
+    assert !sample("Test Eq false Not Test Eq 'Drop' And Test Eq false")
+
+    assert sample("Test Eq true And Test Eq 'Drop' Not Test Eq false")
+    assert !sample("Test Eq true And Test Eq 'Drop' Not Test Eq true")
+    assert !sample("Test Eq true And Test Eq 'Drop' Not Test Eq true")
+
+    assert sample("Test Eq true Not (Test Eq 'Drop' And Test Eq false)")
+    assert !sample("Test Eq true Not (Test Eq 'Drop' And Test Eq true)")
+    assert !sample("Test Eq true Not (Test Eq 'Drop' And Test Eq true)")
   end
 
   def test_nesting
     assert sample("Test Eq true Or (Test Eq true) And Test Eq false And (Test Eq true)")
+    assert sample("Test Eq true Or (Test Eq false) And Test Eq false And (Test Eq false)")
+    assert sample("Test Eq false Or (Test Eq true) And Test Eq true And (Test Eq true)")
+    assert !sample("Test Eq false Or (Test Eq false) And Test Eq false And (Test Eq false)")
+    assert !sample("Test Eq false Or (Test Eq true) And Test Eq false And (Test Eq false)")
+    assert !sample("Test Eq false Or (Test Eq false) And Test Eq true And (Test Eq false)")
+    assert !sample("Test Eq false Or (Test Eq false) And Test Eq false And (Test Eq true)")
+
     assert sample("Test Eq true Or ((Test Eq false) And Test Eq false) And (Test Eq false)")
     assert sample("(Test Eq false Or Test Eq true) Or (Test Eq false Or Test Eq false)")
     assert sample("(Test Eq true And Test Eq true) Or (Test Eq false)")
     assert sample("(Test Eq true And Test Eq true) Or (Test Eq false And Test Eq true)")
     assert !sample("(Test Eq false And Test Eq true) Or (Test Eq false)")
+
     assert sample("Test Eq true And ((Test Eq true And Test Eq false) Or Test Eq true)")
     assert !sample("Test Eq true And ((Test Eq true And Test Eq false) Or Test Eq false) And Test Eq true")
     assert !sample("Test Eq true And ((Test Eq true And Test Eq false) Or Test Eq false) Or Test Eq false")
     assert sample("Test Eq true And ((Test Eq true And Test Eq false) Or Test Eq false) Or Test Eq true")
+    assert !sample("(Test Eq true Or Test Eq true) And Test Eq false")
+    assert !sample("(Test Eq true Or Test Eq true) And (Test Eq false)")
+
+    assert sample("(Test Eq true Or Test Eq true) And (Test Eq false Or Test Eq true)")
+    assert !sample("(Test Eq true Or Test Eq true) And (Test Eq false Or Test Eq false)")
+
+    assert sample("(Test Eq true) Not Test Eq false And (Test Eq true)")
+    assert !sample("(Test Eq true) Not Test Eq true And (Test Eq true)")
+    assert !sample("(Test Eq false) Not Test Eq false And (Test Eq true)")
+    assert !sample("(Test1 Eq true) Not Test2 Eq false And (Test3 Eq false)")
   end
 
   def test_nots
     assert sample("Test Eq true Not Test Eq false")
     assert !sample("Test Eq true Not Test Eq true")
+    assert !sample("Test Eq false Not Test Eq true")
+    assert !sample("Test Eq false Not Test Eq false")
+
+    assert sample("Test Eq true And Test Eq true Not Test Eq false")
+    assert !sample("Test Eq false And Test Eq true Not Test Eq false")
+    assert !sample("Test Eq true And Test Eq true Not Test Eq true")
+    assert !sample("Test Eq true And Test Eq false Not Test Eq false")
+
     assert sample("Test Eq true Not (Test Eq false Or Test Eq false)")
-    assert sample("Test Eq true Not (Test Eq false And Test Eq false)")
     assert !sample("Test Eq true Not (Test Eq false Or Test Eq true)")
     assert !sample("Test Eq true Not (Test Eq true Or Test Eq false)")
-    assert !sample("Test Eq true Not (Not Test Eq false)")
-    assert !sample("Test Eq false And Test Eq true Not Test Eq false")
+    assert !sample("Test Eq true Not (Test Eq true Or Test Eq true)")
+    assert !sample("Test Eq false Not (Test Eq false Or Test Eq false)")
+
+    assert sample("Test Eq true Not (Test Eq false And Test Eq false)")
+    assert sample("Test Eq true Not (Test Eq true And Test Eq false)")
+    assert sample("Test Eq true Not (Test Eq false And Test Eq true)")
+    assert !sample("Test Eq true Not (Test Eq true And Test Eq true)")
+    assert !sample("Test Eq false Not (Test Eq false And Test Eq false)")
+
+    assert sample("Test Eq true Not (Test Eq false Or Test Eq false) And (Test Eq true Or Test Eq false)")
+    assert sample("Test Eq true Not (Test Eq false Or Test Eq false) And (Test Eq false Or Test Eq true)")
+    assert sample("Test Eq true Not (Test Eq false Or Test Eq false) And (Test Eq true Or Test Eq true)")
     assert !sample("Test Eq true Not (Test Eq false Or Test Eq false) And (Test Eq false Or Test Eq false)")
+    assert !sample("Test Eq true Not (Test Eq false Or Test Eq true) And (Test Eq true Or Test Eq false)")
+    assert !sample("Test Eq true Not (Test Eq true Or Test Eq false) And (Test Eq true Or Test Eq false)")
+    assert !sample("Test Eq false Not (Test Eq false Or Test Eq false) And (Test Eq true Or Test Eq false)")
   end
 
   def test_unary_nots
@@ -105,17 +163,14 @@ class EvaluatorTest < Test::Unit::TestCase
 
   def test_unary_double_nots
     assert sample("Not (Not(Not Test Eq true))")
+    assert !sample("Not (Not(Not Test Eq false))")
+
+    assert sample("Test Eq true Not (Not Test Eq true)")
+    assert !sample("Test Eq true Not (Not Test Eq false)")
+    assert !sample("Test Eq false Not (Not Test Eq true)")
   end
 
   def test_examples
-    # This one is based on a real life example that had problems.
-    #
-    # CurrentPrice Bt 130000.00,180000.00 And PropertySubType Eq 'Single Family Residence' And
-    # SchoolDistrict Eq 'Byron Center','Grandville','Jenison' And MlsStatus Eq 'Active' And
-    # BathsTotal Bt 1.50,9999.00 And BedsTotal Bt 3,99 And PropertyType Eq 'A'
-    # Not "Garage"."Garage2" Eq 'No' And "Pool"."OutdoorAbove" Eq true
-    # And "Pool"."OutdoorInground" Eq true Not "Substructure"."Michigan Basement" Eq true
-
     assert !sample("Test Eq false And Test Eq true And " \
       "Test Eq false And Test Eq true And " \
       "Test Eq true And Test Eq true And Test Eq true " \

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sparkql
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.3.3
 platform: ruby
 authors:
 - Wade McEwen
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-08-07 00:00:00.000000000 Z
+date: 2025-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: georuby