sparkle_formation 3.0.30 → 3.0.32

data/lib/sparkle_formation/provider/azure.rb

@@ -1,4 +1,4 @@
-require 'sparkle_formation'
+require "sparkle_formation"
 
 class SparkleFormation
   module Provider
@@ -7,7 +7,7 @@ class SparkleFormation
 
       # @return [String] Type string for Azure Resource Manager stack resource
       def stack_resource_type
-        'Microsoft.Resources/deployments'
+        "Microsoft.Resources/deployments"
       end
 
       # Generate policy for stack
@@ -24,7 +24,7 @@ class SparkleFormation
       # @return [AttributeStruct]
       def set_compiled_state(compiled)
         super
-        compiled.outputs.compile_state.type 'String'
+        compiled.outputs.compile_state.type "String"
         compiled
       end
 
@@ -112,9 +112,9 @@ class SparkleFormation
             end
           end
           raise ArgumentError.new "Failed to detect available bubbling path for output `#{output_name}`. " <<
-                                    'This may be due to a circular dependency! ' <<
-                                    "(Output Path: #{outputs[output_name].root_path.map(&:name).join(' > ')} " <<
-                                    "Requester Path: #{root_path.map(&:name).join(' > ')})"
+                                    "This may be due to a circular dependency! " <<
+                                    "(Output Path: #{outputs[output_name].root_path.map(&:name).join(" > ")} " <<
+                                    "Requester Path: #{root_path.map(&:name).join(" > ")})"
         end
         result = compile._stack_output(bubble_path.first.name, output_name)
         if drip_path.size > 1
@@ -123,7 +123,7 @@ class SparkleFormation
           drip_path.each_slice(2) do |base_sparkle, ref_sparkle|
             next unless ref_sparkle
             base_sparkle.compile.resources[ref_sparkle.name].properties.parameters.value._set(output_name, result)
-            ref_sparkle.compile.parameters._set(output_name).type 'string' # TODO: <<<<------ type check and prop
+            ref_sparkle.compile.parameters._set(output_name).type "string" # TODO: <<<<------ type check and prop
             result = compile._parameter(output_name)
           end
         end

data/lib/sparkle_formation/provider/google.rb

@@ -1,4 +1,4 @@
-require 'sparkle_formation'
+require "sparkle_formation"
 
 class SparkleFormation
   module Provider
@@ -17,16 +17,16 @@ class SparkleFormation
       # @param parent_names [Array<String>] name of parent resources
       # @return [Smash] dump_copy
       def google_template_extractor(template_hash, dump_copy, parent_names = [])
-        template_hash.fetch('resources', []).each do |t_resource|
-          if t_resource['type'] == stack_resource_type
-            full_names = parent_names + [t_resource['name']]
-            stack = t_resource['properties'].delete('stack')
-            if t_resource['properties'].empty?
-              t_resource.delete('properties')
+        template_hash.fetch("resources", []).each do |t_resource|
+          if t_resource["type"] == stack_resource_type
+            full_names = parent_names + [t_resource["name"]]
+            stack = t_resource["properties"].delete("stack")
+            if t_resource["properties"].empty?
+              t_resource.delete("properties")
             end
             google_template_extractor(stack, dump_copy, full_names)
-            new_type = generate_template_files(full_names.join('-'), stack, dump_copy)
-            t_resource['type'] = new_type
+            new_type = generate_template_files(full_names.join("-"), stack, dump_copy)
+            t_resource["type"] = new_type
           end
         end
         dump_copy
@@ -41,7 +41,7 @@ class SparkleFormation
       # @return [String] new type for stack
       def generate_template_files(r_name, r_stack, dump_copy)
         f_name = "#{r_name}.jinja"
-        r_parameters = r_stack.delete('parameters')
+        r_parameters = r_stack.delete("parameters")
         dump_copy[:imports].push(
           Smash.new(
             :name => f_name,
@@ -101,7 +101,7 @@ class SparkleFormation
       # @note Nested templates aren't defined as a specific type thus no "real"
       #   type exists. So we'll create a custom one!
       def stack_resource_type
-        'sparkleformation.stack'
+        "sparkleformation.stack"
       end
 
       # Generate policy for stack
@@ -147,7 +147,7 @@ class SparkleFormation
       # Forcibly disable shallow nesting as support for it with Google templates doesn't
       # really make much sense.
       def apply_shallow_nesting(*args, &block)
-        raise NotImplementedError.new 'Shallow nesting is not supported for this provider!'
+        raise NotImplementedError.new "Shallow nesting is not supported for this provider!"
       end
 
       # Extract output to make available for stack parameter usage at the
@@ -176,9 +176,9 @@ class SparkleFormation
             end
           end
           raise ArgumentError.new "Failed to detect available bubbling path for output `#{output_name}`. " <<
-                                    'This may be due to a circular dependency! ' <<
-                                    "(Output Path: #{outputs[output_name].root_path.map(&:name).join(' > ')} " <<
-                                    "Requester Path: #{root_path.map(&:name).join(' > ')})"
+                                    "This may be due to a circular dependency! " <<
+                                    "(Output Path: #{outputs[output_name].root_path.map(&:name).join(" > ")} " <<
+                                    "Requester Path: #{root_path.map(&:name).join(" > ")})"
         end
         result = source_stack.compile._stack_output(bubble_path.first.name, output_name)
         if drip_path.size > 1
@@ -187,7 +187,7 @@ class SparkleFormation
           drip_path.each_slice(2) do |base_sparkle, ref_sparkle|
             next unless ref_sparkle
             base_sparkle.compile.resources[ref_sparkle.name].properties.parameters.value._set(output_name, result)
-            ref_sparkle.compile.parameters._set(output_name).type 'string' # TODO: <<<<------ type check and prop
+            ref_sparkle.compile.parameters._set(output_name).type "string" # TODO: <<<<------ type check and prop
             result = compile._parameter(output_name)
           end
         end

data/lib/sparkle_formation/provider/heat.rb

@@ -1,4 +1,4 @@
-require 'sparkle_formation'
+require "sparkle_formation"
 
 class SparkleFormation
   module Provider
@@ -7,7 +7,7 @@ class SparkleFormation
 
       # @return [String] Type string for OpenStack HEAT stack resource
       def stack_resource_type
-        'OS::Heat::Stack'
+        "OS::Heat::Stack"
       end
 
       # Generate policy for stack
@@ -96,9 +96,9 @@ class SparkleFormation
             end
           end
           raise ArgumentError.new "Failed to detect available bubbling path for output `#{output_name}`. " <<
-                                    'This may be due to a circular dependency! ' <<
-                                    "(Output Path: #{outputs[output_name].root_path.map(&:name).join(' > ')} " <<
-                                    "Requester Path: #{root_path.map(&:name).join(' > ')})"
+                                    "This may be due to a circular dependency! " <<
+                                    "(Output Path: #{outputs[output_name].root_path.map(&:name).join(" > ")} " <<
+                                    "Requester Path: #{root_path.map(&:name).join(" > ")})"
         end
         result = compile._stack_output(bubble_path.first.name, output_name)
         if drip_path.size > 1
@@ -107,7 +107,7 @@ class SparkleFormation
           drip_path.each_slice(2) do |base_sparkle, ref_sparkle|
             next unless ref_sparkle
             base_sparkle.compile.resources[ref_sparkle.name].properties.parameters._set(output_name, result)
-            ref_sparkle.compile.parameters._set(output_name).type 'string' # TODO: <<<<------ type check and prop
+            ref_sparkle.compile.parameters._set(output_name).type "string" # TODO: <<<<------ type check and prop
             result = compile._parameter(output_name)
           end
         end

data/lib/sparkle_formation/provider/terraform.rb

@@ -1,4 +1,4 @@
-require 'sparkle_formation'
+require "sparkle_formation"
 
 class SparkleFormation
   module Provider
@@ -49,7 +49,7 @@ class SparkleFormation
       # @note Nested templates aren't defined as a specific type thus no "real"
       #   type exists. So we'll create a custom one!
       def stack_resource_type
-        'module'
+        "module"
       end
 
       # Generate policy for stack
@@ -94,7 +94,7 @@ class SparkleFormation
 
       # Forcibly disable shallow nesting
       def apply_shallow_nesting(*args, &block)
-        raise NotImplementedError.new 'Shallow nesting is not supported for this provider!'
+        raise NotImplementedError.new "Shallow nesting is not supported for this provider!"
       end
 
       # Extract output to make available for stack parameter usage at the
@@ -123,9 +123,9 @@ class SparkleFormation
             end
           end
           raise ArgumentError.new "Failed to detect available bubbling path for output `#{output_name}`. " <<
-                                    'This may be due to a circular dependency! ' <<
-                                    "(Output Path: #{outputs[output_name].root_path.map(&:name).join(' > ')} " <<
-                                    "Requester Path: #{root_path.map(&:name).join(' > ')})"
+                                    "This may be due to a circular dependency! " <<
+                                    "(Output Path: #{outputs[output_name].root_path.map(&:name).join(" > ")} " <<
+                                    "Requester Path: #{root_path.map(&:name).join(" > ")})"
         end
         result = source_stack.compile._stack_output(bubble_path.first.name, output_name)
         if drip_path.size > 1
@@ -134,7 +134,7 @@ class SparkleFormation
           drip_path.each_slice(2) do |base_sparkle, ref_sparkle|
             next unless ref_sparkle
             base_sparkle.compile.resources[ref_sparkle.name].properties.parameters.value._set(output_name, result)
-            ref_sparkle.compile.parameters._set(output_name).type 'string' # TODO: <<<<------ type check and prop
+            ref_sparkle.compile.parameters._set(output_name).type "string" # TODO: <<<<------ type check and prop
             result = compile._parameter(output_name)
           end
         end

data/lib/sparkle_formation/resources.rb

@@ -1,19 +1,19 @@
-require 'sparkle_formation'
+require "sparkle_formation"
 
 class SparkleFormation
   # Resources helper
   class Resources
-    autoload :Aws, 'sparkle_formation/resources/aws'
-    autoload :Azure, 'sparkle_formation/resources/azure'
-    autoload :Google, 'sparkle_formation/resources/google'
-    autoload :Heat, 'sparkle_formation/resources/heat'
-    autoload :Rackspace, 'sparkle_formation/resources/rackspace'
-    autoload :Terraform, 'sparkle_formation/resources/terraform'
+    autoload :Aws, "sparkle_formation/resources/aws"
+    autoload :Azure, "sparkle_formation/resources/azure"
+    autoload :Google, "sparkle_formation/resources/google"
+    autoload :Heat, "sparkle_formation/resources/heat"
+    autoload :Rackspace, "sparkle_formation/resources/rackspace"
+    autoload :Terraform, "sparkle_formation/resources/terraform"
 
     # Characters to be removed from supplied key on matching
-    RESOURCE_TYPE_TR = '_:'
+    RESOURCE_TYPE_TR = "_:"
     # String to split for resource namespacing
-    RESOURCE_TYPE_NAMESPACE_SPLITTER = '::'
+    RESOURCE_TYPE_NAMESPACE_SPLITTER = "::"
     # Property update conditionals
     # Format: Smash.new(RESOURCE_TYPE => {PROPERTY_NAME => [PropertyConditional]})
     PROPERTY_UPDATE_CONDITIONALS = Smash.new
@@ -65,7 +65,7 @@ class SparkleFormation
           if result
             result.update_causes
           else
-            'unknown'
+            "unknown"
           end
         else
           self[:update_causes]
@@ -79,7 +79,7 @@ class SparkleFormation
 
       # @return [String] base registry key
       def base_key
-        Bogo::Utility.snake(self.name.split('::').last) # rubocop:disable Style/RedundantSelf
+        Bogo::Utility.snake(self.name.split("::").last) # rubocop:disable Style/RedundantSelf
       end
 
       # Register resource
@@ -148,13 +148,13 @@ class SparkleFormation
           result = key
         else
           o_key = key
-          key = key.to_s.downcase.tr(self.const_get(:RESOURCE_TYPE_TR), '') # rubocop:disable Style/RedundantSelf
+          key = key.to_s.downcase.tr(self.const_get(:RESOURCE_TYPE_TR), "") # rubocop:disable Style/RedundantSelf
           snake_parts = nil
           result = @@registry[base_key].keys.detect do |ref|
             ref = ref.downcase
             snake_parts = ref.split(resource_type_splitter)
             until snake_parts.empty?
-              break if snake_parts.join('') == key
+              break if snake_parts.join("") == key
               snake_parts.shift
             end
             !snake_parts.empty?
@@ -162,12 +162,12 @@ class SparkleFormation
           if result
             collisions = @@registry[base_key].keys.find_all do |ref|
               split_ref = ref.downcase.split(resource_type_splitter)
-              ref = Array(split_ref.slice(split_ref.size - snake_parts.size, split_ref.size)).join('')
+              ref = Array(split_ref.slice(split_ref.size - snake_parts.size, split_ref.size)).join("")
               key == ref
             end
             if collisions.size > 1
-              raise ArgumentError.new 'Ambiguous dynamic name returned multiple matches! ' \
-                                      "`#{o_key.inspect}` -> #{collisions.sort.join(', ')}"
+              raise ArgumentError.new "Ambiguous dynamic name returned multiple matches! " \
+                                      "`#{o_key.inspect}` -> #{collisions.sort.join(", ")}"
             end
           end
         end
@@ -180,7 +180,7 @@ class SparkleFormation
         Regexp.new(
           [self.const_get(:RESOURCE_TYPE_NAMESPACE_SPLITTER)].flatten.compact.map { |value|
             Regexp.escape(value)
-          }.join('|')
+          }.join("|")
         )
       end
 
@@ -217,7 +217,7 @@ class SparkleFormation
       def resource_lookup(type)
         result = registry[type]
         if result
-          properties = result.fetch('full_properties', {}).map do |p_name, p_info|
+          properties = result.fetch("full_properties", {}).map do |p_name, p_info|
             Property.new(p_name,
                          p_info[:description],
                          p_info[:type],

data/lib/sparkle_formation/resources/aws.rb

@@ -1,4 +1,4 @@
-require 'sparkle_formation'
+require "sparkle_formation"
 
 class SparkleFormation
 
@@ -10,236 +10,326 @@ class SparkleFormation
 
       # Conditionals for property updates
       PROPERTY_UPDATE_CONDITIONALS = Smash.new(
-        'AWS::DynamoDB::Table' => {
-          'GlobalSecondaryIndexes' => [
+        "AWS::DynamoDB::Table" => {
+          "GlobalSecondaryIndexes" => [
             # Updates not really supported here. Set as unknown to
             # prompt user to investigate
-            UpdateCausesConditional.new('unknown', true),
+            UpdateCausesConditional.new("unknown", true),
           ],
         },
-        'AWS::EC2::EIPAssociation' => {
-          'AllocationId' => [
-            UpdateCausesConditional.new('replacement',
+        "AWS::EC2::EIPAssociation" => {
+          "AllocationId" => [
+            UpdateCausesConditional.new("replacement",
                                         lambda { |final, original|
-              original.get('Properties', 'InstanceId') != final.get('Properties', 'InstanceId') ||
-                original.get('Properties', 'NetworkInterfaceId') != final.get('Properties', 'NewtorkInterfaceId')
+              original.get("Properties", "InstanceId") != final.get("Properties", "InstanceId") ||
+                original.get("Properties", "NetworkInterfaceId") != final.get("Properties", "NewtorkInterfaceId")
             }),
-            UpdateCausesConditional.new('none', true),
+            UpdateCausesConditional.new("none", true),
           ],
-          'EIP' => [
-            UpdateCausesConditional.new('replacement',
+          "EIP" => [
+            UpdateCausesConditional.new("replacement",
                                         lambda { |final, original|
-              original.get('Properties', 'InstanceId') != final.get('Properties', 'InstanceId') ||
-                original.get('Properties', 'NetworkInterfaceId') != final.get('Properties', 'NewtorkInterfaceId')
+              original.get("Properties", "InstanceId") != final.get("Properties", "InstanceId") ||
+                original.get("Properties", "NetworkInterfaceId") != final.get("Properties", "NewtorkInterfaceId")
             }),
-            UpdateCausesConditional.new('none', true),
+            UpdateCausesConditional.new("none", true),
           ],
-          'InstanceId' => [
-            UpdateCausesConditional.new('replacement',
+          "InstanceId" => [
+            UpdateCausesConditional.new("replacement",
                                         lambda { |final, original|
-              original.get('Properties', 'AllocationId') != final.get('Properties', 'AllocationId') ||
-                original.get('Properties', 'EIP') != final.get('Properties', 'EIP')
+              original.get("Properties", "AllocationId") != final.get("Properties", "AllocationId") ||
+                original.get("Properties", "EIP") != final.get("Properties", "EIP")
             }),
-            UpdateCausesConditional.new('none', true),
+            UpdateCausesConditional.new("none", true),
           ],
-          'NetworkInterfaceId' => [
-            UpdateCausesConditional.new('replacement',
+          "NetworkInterfaceId" => [
+            UpdateCausesConditional.new("replacement",
                                         lambda { |final, original|
-              original.get('Properties', 'AllocationId') != final.get('Properties', 'AllocationId') ||
-                original.get('Properties', 'EIP') != final.get('Properties', 'EIP')
+              original.get("Properties", "AllocationId") != final.get("Properties", "AllocationId") ||
+                original.get("Properties", "EIP") != final.get("Properties", "EIP")
             }),
-            UpdateCausesConditional.new('none', true),
+            UpdateCausesConditional.new("none", true),
           ],
         },
-        'AWS::EC2::Instance' => {
-          'AdditionalInfo' => [
-            UpdateCausesConditional.new('unknown', true), # EBS AMI dependent
+        "AWS::EC2::Instance" => {
+          "AdditionalInfo" => [
+            UpdateCausesConditional.new("unknown", true), # EBS AMI dependent
           ],
-          'BlockDeviceMappings' => [
-            UpdateCausesConditional.new('replacement',
+          "BlockDeviceMappings" => [
+            UpdateCausesConditional.new("replacement",
                                         lambda { |final, original|
-              f_maps = final.fetch('Properties', 'BlockDeviceMappings', [])
-              o_maps = original.fetch('Properties', 'BlockDeviceMappings', [])
+              f_maps = final.fetch("Properties", "BlockDeviceMappings", [])
+              o_maps = original.fetch("Properties", "BlockDeviceMappings", [])
               f_maps.map! do |m|
-                m.delete('DeleteOnTermination')
+                m.delete("DeleteOnTermination")
                 m.to_smash(:sorted)
               end
               o_maps.map! do |m|
-                m.delete('DeleteOnTermination')
+                m.delete("DeleteOnTermination")
                 m.to_smash(:sorted)
               end
               f_maps.size != o_maps.size ||
                 !f_maps.all? { |m| o_maps.include?(m) }
             }),
-            UpdateCausesConditional.new('none', true),
+            UpdateCausesConditional.new("none", true),
           ],
-          'EbsOptimized' => [
-            UpdateCausesConditional.new('unknown', true), # EBS AMI dependent
+          "EbsOptimized" => [
+            UpdateCausesConditional.new("unknown", true), # EBS AMI dependent
           ],
-          'InstanceType' => [
-            UpdateCausesConditional.new('unknown', true), # EBS AMI dependent
+          "InstanceType" => [
+            UpdateCausesConditional.new("unknown", true), # EBS AMI dependent
           ],
-          'KernelId' => [
-            UpdateCausesConditional.new('unknown', true), # EBS AMI dependent
+          "KernelId" => [
+            UpdateCausesConditional.new("unknown", true), # EBS AMI dependent
           ],
-          'RamdiskId' => [
-            UpdateCausesConditional.new('unknown', true), # EBS AMI dependent
+          "RamdiskId" => [
+            UpdateCausesConditional.new("unknown", true), # EBS AMI dependent
           ],
-          'SecurityGroupIds' => [
-            UpdateCausesConditional.new('none',
+          "SecurityGroupIds" => [
+            UpdateCausesConditional.new("none",
                                         lambda { |final, _orig|
-              final.get('Properties', 'SubnetId') ||
-                final.fetch('Properties', 'NetworkInterface', {}).values.include?('SubnetId')
+              final.get("Properties", "SubnetId") ||
+                final.fetch("Properties", "NetworkInterface", {}).values.include?("SubnetId")
             }),
-            UpdateCausesConditional.new('replacement', true),
+            UpdateCausesConditional.new("replacement", true),
           ],
-          'UserData' => [
-            UpdateCausesConditional.new('unknown', true), # EBS AMI dependent
+          "Tenancy" => [
+            UpdateCausesConditional.new("none", lambda { |final, original|
+                ["host", "dedicated"].any?{ |val| final.get("Properties", "Tenancy") == val } &&
+                  ["host", "dedicated"].any?{ |val| original.get("Properties", "Tenancy") == val }
+              }
+            ),
+            UpdateCausesConditional.new("replacement", true),
+          ],
+          "UserData" => [
+            UpdateCausesConditional.new("unknown", true), # EBS AMI dependent
           ],
         },
-        'AWS::EC2::NetworkInterface' => {
-          'PrivateIpAddresses' => [
-            UpdateCausesConditional.new('replacement',
+        "AWS::EC2::NetworkInterface" => {
+          "PrivateIpAddresses" => [
+            UpdateCausesConditional.new("replacement",
                                         lambda { |final, original|
-              f_primary = final.fetch('Properties', 'PrivateIpAddresses', []).detect do |addr|
-                addr['Primary']
+              f_primary = final.fetch("Properties", "PrivateIpAddresses", []).detect do |addr|
+                addr["Primary"]
               end || Smash.new
-              o_primary = original.fetch('Properties', 'PrivateIpAddresses', []).detect do |addr|
-                addr['Primary']
+              o_primary = original.fetch("Properties", "PrivateIpAddresses", []).detect do |addr|
+                addr["Primary"]
               end || Smash.new
               f_primary.to_smash(:sorted) != o_primary.to_smash(:sorted)
             }),
-            UpdateCausesConditional.new('none', true),
+            UpdateCausesConditional.new("none", true),
           ],
         },
-        'AWS::ElastiCache::CacheCluster' => {
-          'NumCacheNodes' => [
-            UpdateCausesConditional.new('replacement',
+        "AWS::ElastiCache::CacheCluster" => {
+          "NumCacheNodes" => [
+            UpdateCausesConditional.new("replacement",
                                         lambda { |final, original|
               [
-                final.get('Properties', 'PreferredAvailabilityZone'),
-                final.get('Properties', 'PreferredAvailabilityZones'),
-                original.get('Properties', 'PreferredAvailabilityZone'),
-                original.get('Properties', 'PreferredAvailabilityZones'),
+                final.get("Properties", "PreferredAvailabilityZone"),
+                final.get("Properties", "PreferredAvailabilityZones"),
+                original.get("Properties", "PreferredAvailabilityZone"),
+                original.get("Properties", "PreferredAvailabilityZones"),
               ].all? { |i| i.nil? || i.empty? }
             }),
-            UpdateCausesConditional.new('none', true),
+            UpdateCausesConditional.new("none", true),
           ],
-          'PreferredAvailabilityZones' => [
-            UpdateCausesConditional.new('interrupt',
+          "PreferredAvailabilityZones" => [
+            UpdateCausesConditional.new("interrupt",
                                         lambda { |final, original|
-              original.get('Properties', 'PreferredAvailabilityZones') ||
-                final.fetch('Properties', 'PreferredAvailabilityZones', []).include?(
-                  original.get('Properties', 'PreferredAvailabilityZone')
+              original.get("Properties", "PreferredAvailabilityZones") ||
+                final.fetch("Properties", "PreferredAvailabilityZones", []).include?(
+                  original.get("Properties", "PreferredAvailabilityZone")
                 )
             }),
-            UpdateCausesConditional.new('replacement', true),
+            UpdateCausesConditional.new("replacement", true),
           ],
         },
-        'AWS::ElasticLoadBalancing::LoadBalancer' => {
-          'AvailabilityZones' => [
-            UpdateCausesConditional.new('replacement',
+        "AWS::ElasticLoadBalancing::LoadBalancer" => {
+          "AvailabilityZones" => [
+            UpdateCausesConditional.new("replacement",
                                         lambda { |final, original|
-              original.fetch('Properties', 'AvailabilityZones', []).empty? ||
-                final.fetch('Properties', 'AvailabilityZones', []).empty?
+              original.fetch("Properties", "AvailabilityZones", []).empty? ||
+                final.fetch("Properties", "AvailabilityZones", []).empty?
             }),
-            UpdateCausesConditional.new('none', true),
+            UpdateCausesConditional.new("none", true),
           ],
-          'HealthCheck' => [
-            UpdateCausesConditional.new('replacement',
+          "HealthCheck" => [
+            UpdateCausesConditional.new("replacement",
                                         lambda { |final, original|
-              original.fetch('Properties', 'HealthCheck', {}).empty? ||
-                final.fetch('Properties', 'HealthCheck', {}).empty?
+              original.fetch("Properties", "HealthCheck", {}).empty? ||
+                final.fetch("Properties", "HealthCheck", {}).empty?
             }),
-            UpdateCausesConditional.new('none', true),
+            UpdateCausesConditional.new("none", true),
           ],
-          'Subnets' => [
-            UpdateCausesConditional.new('replacement',
+          "Subnets" => [
+            UpdateCausesConditional.new("replacement",
                                         lambda { |final, original|
-              original.fetch('Properties', 'Subnets', []).empty? ||
-                final.fetch('Properties', 'Subnets', []).empty?
+              original.fetch("Properties", "Subnets", []).empty? ||
+                final.fetch("Properties", "Subnets", []).empty?
             }),
-            UpdateCausesConditional.new('none', true),
+            UpdateCausesConditional.new("none", true),
+          ],
+        },
+        "AWS::KinesisFirehose::DeliveryStream" => {
+          "ElasticsearchDestinationConfiguration" => [
+            UpdateCausesConditional.new("interrupt", lambda { |final, original|
+                !!original.get("Properties", "ElasticsearchDestinationConfiguration")
+              }
+            ),
+            UpdateCausesConditional.new("none", true),
+          ],
+          "ExtendedS3DestinationConfiguration" => [
+            UpdateCausesConditional.new("interrupt", lambda { |final, original|
+                !!original.get("Properties", "ExtendedS3DestinationConfiguration")
+              }
+            ),
+            UpdateCausesConditional.new("none", true),
+          ],
+          "RedshiftDestinationConfiguration" => [
+            UpdateCausesConditional.new("interrupt", lambda { |final, original|
+                !!original.get("Properties", "RedshiftDestinationConfiguration")
+              }
+            ),
+            UpdateCausesConditional.new("none", true),
+          ],
+          "S3DestinationConfiguration" => [
+            UpdateCausesConditional.new("interrupt", lambda { |final, original|
+                !!original.get("Properties", "S3DestinationConfiguration")
+              }
+            ),
+            UpdateCausesConditional.new("none", true),
+          ],
+        },
+        "AWS::Neptune::DBCluster" => {
+          "BackupRetentionPeriod" => [
+            # Not clear within documentation
+            UpdateCausesConditional.new("unknown", true),
+          ],
+          "PreferredMaintenanceWindow" => [
+            # Not clear within documentation
+            UpdateCausesConditional.new("unknown", true),
+          ],
+        },
+        "AWS::Neptune::DBClusterParameterGroup" => {
+          "Parameters" => [
+            # dependent on what parameters have been changed. doesn't
+            # look like parameter modifications are applied immediately?
+            # set as unknown for safety
+            UpdateCausesConditional.new("unknown", true),
+          ],
+        },
+        "AWS::Neptune::DBInstance" => {
+          "AutoMinorVersionUpgrade" => [
+            # Documentation does not indicate condition when no
+            # interruption occurs, so set as interrupt for safety
+            UpdateCausesConditional.new("interrupt", true),
+          ],
+          "DBParameterGroupName" => [
+            UpdateCausesConditional.new("interrupt", true),
+          ],
+          "PreferredMaintenanceWindow" => [
+            UpdateCausesConditional.new("interrupt", true),
           ],
         },
-        'AWS::RDS::DBCluster' => {
-          'BackupRetentionPeriod' => [
-            UpdateCausesConditional.new('interrupt',
+        "AWS::Neptune::DBParameterGroup" => {
+          # Interrupt is only caused when parameters are static
+          # values. Dynamic values are applied immediately
+          "Parameters" => [
+            UpdateCausesConditional.new("interrupt", lambda { |final, original|
+                o_params = original.fetch("Properties", "Parameters", {})
+                f_params = final.fetch("Properties", "Parameters", {})
+                f_params.any? { |key, value|
+                  o_params[key].nil? ||
+                    o_params[key].is_a?(Hash)
+                }
+              }
+            ),
+            UpdateCausesConditional.new("none", true),
+          ]
+        },
+        "AWS::RDS::DBCluster" => {
+          "BackupRetentionPeriod" => [
+            UpdateCausesConditional.new("interrupt",
                                         lambda { |final, original|
-              fp = final.get('Properties', 'BackupRetentionPeriod').to_i
-              op = original.get('Properties', 'BackupRetentionPeriod').to_i
+              fp = final.get("Properties", "BackupRetentionPeriod").to_i
+              op = original.get("Properties", "BackupRetentionPeriod").to_i
               (fp == 0 && op != 0) ||
                 (op == 0 && fp != 0)
             }),
-            UpdateCausesConditional.new('none', true),
+            UpdateCausesConditional.new("none", true),
           ],
-          'PreferredMaintenanceWindow' => [
+          "PreferredMaintenanceWindow" => [
             # can interrupt if apply immediately is set on api call but
             # no way to know
-            UpdateCausesConditional.new('unknown', true),
+            UpdateCausesConditional.new("unknown", true),
           ],
         },
-        'AWS::RDS::DBClusterParameterGroup' => {
-          'Parameters' => [
+        "AWS::RDS::DBClusterParameterGroup" => {
+          "Parameters" => [
             # dependent on what parameters have been changed. doesn't
             # look like parameter modifications are applied immediately?
             # set as unknown for safety
-            UpdateCausesConditional.new('unknown', true),
+            UpdateCausesConditional.new("unknown", true),
           ],
         },
-        'AWS::RDS::DBInstance' => {
-          'AutoMinorVersionUpgrade' => [
+        "AWS::RDS::DBInstance" => {
+          "AutoMinorVersionUpgrade" => [
             # can cause interrupts based on future actions (enables
             # auto patching) so leave as unknown for safety
-            UpdateCausesConditional.new('unknown', true),
+            UpdateCausesConditional.new("unknown", true),
           ],
-          'BackupRetentionPeriod' => [
-            UpdateCausesConditional.new('interrupt',
+          "BackupRetentionPeriod" => [
+            UpdateCausesConditional.new("interrupt",
                                         lambda { |final, original|
-              fp = final.get('Properties', 'BackupRetentionPeriod').to_i
-              op = original.get('Properties', 'BackupRetentionPeriod').to_i
+              fp = final.get("Properties", "BackupRetentionPeriod").to_i
+              op = original.get("Properties", "BackupRetentionPeriod").to_i
               (fp == 0 && op != 0) ||
                 (op == 0 && fp != 0)
             }),
-            UpdateCausesConditional.new('none', true),
+            UpdateCausesConditional.new("none", true),
           ],
-          'DBParameterGroupName' => [
+          "DBParameterGroupName" => [
             # changes are not applied until reboot, but it could
             # still be considered an interrupt? setting as unknown
             # for safety
-            UpdateCausesConditional.new('unknown', true),
+            UpdateCausesConditional.new("unknown", true),
+          ],
+          "MonitoringInterval" => [
+            # There can be an interruption or nothing. No clear distinction
+            # on when an interrupt so just default to interrupt for safety
+            UpdateCausesConditional.new("interrupt", true),
           ],
-          'PreferredMaintenanceWindow' => [
+          "PreferredMaintenanceWindow" => [
             # can interrupt if apply immediately is set on api call but
             # no way to know
-            UpdateCausesConditional.new('unknown', true),
+            UpdateCausesConditional.new("unknown", true),
           ],
         },
-        'AWS::RDS::DBParameterGroup' => {
-          'Parameters' => [
+        "AWS::RDS::DBParameterGroup" => {
+          "Parameters" => [
             # dependent on what parameters have been changed. doesn't
             # look like parameter modifications are applied immediately?
             # set as unknown for safety
-            UpdateCausesConditional.new('unknown', true),
+            UpdateCausesConditional.new("unknown", true),
           ],
         },
-        'AWS::RDS::EventSubscription' => {
-          'SourceType' => [
-            UpdateCausesConditional.new('replacement',
+        "AWS::RDS::EventSubscription" => {
+          "SourceType" => [
+            UpdateCausesConditional.new("replacement",
                                         lambda { |final, original|
-              !final.get('Properties', 'SourceType')
+              !final.get("Properties", "SourceType")
             }),
-            UpdateCausesConditional.new('none', true),
+            UpdateCausesConditional.new("none", true),
           ],
         },
-        'AWS::Route53::HostedZone' => {
-          'VPCs' => [
-            UpdateCausesConditional.new('replacement',
+        "AWS::Route53::HostedZone" => {
+          "VPCs" => [
+            UpdateCausesConditional.new("replacement",
                                         lambda { |final, original|
-              !final.get('Properties', 'VPCs') ||
-                !original.get('Properties', 'VPCs')
+              !final.get("Properties", "VPCs") ||
+                !original.get("Properties", "VPCs")
             }),
-            UpdateCausesConditional.new('none', true),
+            UpdateCausesConditional.new("none", true),
           ],
         },
       )
@@ -255,7 +345,7 @@ class SparkleFormation
             load(
               File.join(
                 File.dirname(__FILE__),
-                'aws_resources.json'
+                "aws_resources.json"
               )
             )
             true